[edk2-devel] Extend TianoCore Bug Triage - APAC / NAMO Meeting from 0.5 hour to 1 hour

2020-03-12 Thread Liming Gao
Hi, all Recently, regular TianoCore Bug Triage meeting has no enough time to review and discuss the existing bugzillas. I would propose to extend this meeting from 0.5 hour to 1 hour. Now, Bug Triage, Tiano Design and Community meeting are all in one day. I have met some conflict to those

Re: [edk2-devel] [edk2/master PATCH RISC-V CI Code Changes v1 01/11] FatPkg: Add RISC-V architecture for EDK2 CI.

2020-03-12 Thread Liming Gao
Edk2 spec are listed in https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Specifications This change requires to update INF/DEC/DSC/FDF/Build spec. You can find their github repo in the above link. Then, create git patch for the change. Thanks Liming -Original Message-

[edk2-devel] [patch v2] OvmfPkg: Fix build failure with VS2015 tool chain

2020-03-11 Thread Liming Gao
warning C4244: '=': conversion from 'UINTN' to 'UINT32', possible loss of data With this fix, OvmfIa32, OvmfX64 and OvmfIa32X64 can pass build. Cc: Laszlo Ersek Cc: Ard Biesheuvel Signed-off-by: Liming Gao --- OvmfPkg/Library/X86QemuLoadImageLib/X86QemuLoadImageLib.c | 2 +- 1 file changed, 1

Re: [edk2-devel] [PATCH v2 0/2] Use submodule way to access brotli

2020-03-11 Thread Liming Gao
Reviewed-by: Liming Gao -Original Message- From: Zhang, Shenglei Sent: 2020年3月9日 14:32 To: devel@edk2.groups.io Cc: Gao, Liming ; Wang, Jian J ; Wu, Hao A ; Feng, Bob C Subject: [PATCH v2 0/2] Use submodule way to access brotli Currently brotli is used and customized by edk2

[edk2-devel] [Patch] OvmfPkg: Fix build failure with VS2015 tool chain

2020-03-11 Thread Liming Gao
warning C4244: '=': conversion from 'UINT64' to 'UINTN', possible loss of data With this fix, OvmfIa32, OvmfX64 and OvmfIa32X64 can pass build. Cc: Laszlo Ersek Cc: Ard Biesheuvel Signed-off-by: Liming Gao --- OvmfPkg/Library/X86QemuLoadImageLib/X86QemuLoadImageLib.c | 2

Re: [edk2-devel] [PATCH V4] BaseTools:copy the common PcdValueCommon.c to output directory

2020-03-11 Thread Liming Gao
Reviewed-by: Liming Gao > -Original Message- > From: devel@edk2.groups.io On Behalf Of Fan, ZhijuX > Sent: Wednesday, March 11, 2020 5:51 PM > To: devel@edk2.groups.io > Cc: Gao, Liming ; Feng, Bob C ; > Fan, ZhijuX > Subject: [edk2-devel] [PATCH V4] Base

Re: [edk2-devel] Adding Bhyve support into upstream EDK2

2020-03-10 Thread Liming Gao
Sean: We mostly use Emulator to verify and debug the code change in the common module, such as BDS, HII, DxeCore, PeiCore. Compared to the real platform, Emulator and OVMF are more easier to be built and verified. So, I request to add Open CI build test for Ovmf and Emulator (BZ 2570). Later,

Re: [edk2-devel] [PATCH V2] BaseTools:GuidedSectionTools.txt is not generated correctly

2020-03-10 Thread Liming Gao
. > Then, specify it in platform.dsc [BuildOptions] to override the default one > in tools_def.txt. > > *_*_*_LZMA_PATH = LzmaCompressPlatform > > This override tool will be used. But, its name is not specified in the > generated GuidedSectionTools.txt. > > Signed-o

Re: [edk2-devel] [PATCH 1/1] BaseTools:copy the common PcdValueCommon.obj to output directory

2020-03-09 Thread Liming Gao
the conflict, it should copy this file to its output directory, > If so, PcdValueCommon.obj file will be private for PcdValueInit > > Cc: Liming Gao > Cc: Bob Feng > Signed-off-by: Zhiju.Fan > --- > BaseTools/Source/Python/Workspace/DscBuildData.py | 9 +++-- >

Re: [edk2-devel] [PATCH 0/2] Use submodule way to access brotli

2020-03-08 Thread Liming Gao
ttps://bugzilla.tianocore.org/show_bug.cgi?id=2559 > > Cc: Liming Gao > Cc: Jian J Wang > Cc: Hao A Wu > Cc: Bob Feng > Shenglei Zhang (2): > MdeModulePkg/BrotliCustomDecompressLib: Make brotli a submodule > BaseTools: Make brotli a submodule > > .../C/B

Re: [edk2-announce] [edk2-devel] EDK II Stable Tag release edk2-stable202002 completed

2020-03-04 Thread Liming Gao
> annou...@edk2.groups.io > Cc: Guptha, Soumya K ; Kinney, Michael D > ; af...@apple.com; > l...@nuviainc.com; Ard Biesheuvel ; Liran Alon > ; Nikita Leshenko > > Subject: Re: [edk2-announce] [edk2-devel] EDK II Stable Tag release > edk2-stable202002 completed > > Hi Lim

Re: [edk2-devel] [PATCH] IntelSiliconPkg: Issue reported by ECC in edk2-platforms.

2020-03-04 Thread Liming Gao
This patch is for [edk2-platform]. So, please generate the patch with it. Below command can be used. git format-patch -1 --subject-prefix="edk2-platform][patch" > -Original Message- > From: devel@edk2.groups.io On Behalf Of Zhang, Shenglei > Sent: Thursday, March 5, 2020 1:05 PM > To:

[edk2-devel] EDK II Stable Tag release edk2-stable202002 completed

2020-03-04 Thread Liming Gao
Hi, all The tag edk2-stable202002 has been created. https://github.com/tianocore/edk2/releases/tag/edk2-stable202002 git clone -b edk2-stable202002 https://github.com/tianocore/edk2.git The tag edk2-stable202002 has been added into the main EDK II Wiki page.

[edk2-devel] EDK II Stable Tag edk2-stable202002 will be created based on commit 4c0f6e349d32cf27a7104ddd3e729d6ebc88ea70

2020-03-03 Thread Liming Gao
Hi, all edk2-stable202002 tag will be created on Mar 4th (UTC-8 00:00:00). It will base on current edk2 trunk (the latest commit https://github.com/tianocore/edk2/commit/4c0f6e349d32cf27a7104ddd3e729d6ebc88ea70 UefiCpuPkg/MpInitLib: Skip reading PlatformId on AMD processors). If you have any

Re: [edk2-devel] [PATCH v3 0/1] Add PCD to disable safe string constraint assertions

2020-03-03 Thread Liming Gao
; vit9696 ; Gao, Liming ; Gao, Zhichao ; Laszlo Ersek Subject: Re: [edk2-devel] [PATCH v3 0/1] Add PCD to disable safe string constraint assertions Good day, Unfortunately, this discussion has died again. This is fine by me, I'm also fine with the already proposed patch and mostly shared different

Re: [edk2-devel] Patch List for 202002 stable tag

2020-03-03 Thread Liming Gao
Hi, Stewards and all: Below three patches status are updated. If you have no other comments, I will create edk2-stable202002 tomorrow and send the announcement. https://edk2.groups.io/g/devel/message/55105 [PATCH 0/2] UefiCpuPkg/Library: Fix bug in MpInitLib (BZ: 2556) [Liming 2020-02-28]

Re: [edk2-devel] Extend Hard Feature Freeze by a few days for edk2-stable202002

2020-03-02 Thread Liming Gao
.groups.io On Behalf Of Liming Gao Sent: 2020年2月28日 16:23 To: annou...@edk2.groups.io; devel@edk2.groups.io Cc: Guptha, Soumya K ; Kinney, Michael D ; af...@apple.com; Laszlo Ersek ; l...@nuviainc.com Subject: [edk2-announce] Extend Hard Feature Freeze by a few days for edk2-stable202002 Hi, all

Re: [edk2-devel] [PATCH v1] ShellPkg: Fix 'ping' command Ip4 receive flow.

2020-03-02 Thread Liming Gao
w. > >> > >> Laszlo, > >> > >> Thanks for the detailed response on the patch. Always happy to learn > >> about stuff from the past. > >> > >> Liming, > >> > >> I am currently the maintainer of NetworkPkg :) If you require add

Re: [edk2-devel] [PATCH v2 3/3] MdeModulePkg: Use CopyMem instead of GUID assignment

2020-03-02 Thread Liming Gao
Daniel: I agree this fix. But, I don't meet with this failure with GCC on IA32/X64 arch. So, I don't fix it early. Reviewed-by: Liming Gao Thanks Liming > -Original Message- > From: devel@edk2.groups.io On Behalf Of Daniel Schaefer > Sent: Monday, March 2, 2020 6:33 PM &g

Re: [edk2-devel] [PATCH v2 2/3] MdeModulePkg: Set PcdDxeIplSwitchToLongMode false on non-x86

2020-03-02 Thread Liming Gao
her architectures. > > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2548 > > Signed-off-by: Daniel Schaefer > Cc: Abner Chang > Cc: Gilbert Chen > Cc: Leif Lindholm > Cc: Dandan Bi > Cc: Liming Gao > --- > MdeModulePkg/MdeModulePkg.dec | 3 +++

Re: [edk2-devel] [PATCH v2 1/3] MdeModulePkg: Restrict libraries using SMM to x86

2020-03-02 Thread Liming Gao
6. > > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2549 > > Signed-off-by: Daniel Schaefer > Cc: Abner Chang > Cc: Gilbert Chen > Cc: Leif Lindholm > Cc: Eric Dong > Cc: Ray Ni > Cc: Hao A Wu > Cc: Dandan Bi > Cc: Liming Gao > --- > >

Re: [edk2-devel] [PATCH v2 01/16] MdeModulePkg/PiSmmCore: log SMM image start failure

2020-03-02 Thread Liming Gao
Laszlo: The change refers to the same logic in DxeMain logic. So, it makes sense. Reviewed-by: Liming Gao Thanks Liming > -Original Message- > From: devel@edk2.groups.io On Behalf Of Laszlo Ersek > Sent: Monday, March 2, 2020 8:47 PM > To: Dong, Eric ; Wu, Hao A ; Wan

Re: [edk2-devel] [PATCH v3 5/6] MdeModulePkg/DxeCore: defer PE/COFF emulator registration to StartImage

2020-02-28 Thread Liming Gao
Ard: I think this change is OK. Ack-by: Liming Gao Thanks Liming > -Original Message- > From: devel@edk2.groups.io On Behalf Of Ard Biesheuvel > Sent: Friday, February 28, 2020 1:11 AM > To: edk2-devel-groups-io ; Wu, Hao A > ; Wang, Jian J ; Gao, > Zhichao ; Ni,

Re: [edk2-devel] [PATCH v1] ShellPkg: Fix 'ping' command Ip4 receive flow.

2020-02-28 Thread Liming Gao
ently the maintainer of NetworkPkg :) If you require additional > feedback from Siyuan or/and Jiaxin, that's ok. > Please let me know if any corrections to the patch (like CVE note) are > required from your point of view. > > Thanks, > Maciej > > On 28-Feb-20 03:59, Liming

[edk2-devel] Extend Hard Feature Freeze by a few days for edk2-stable202002

2020-02-28 Thread Liming Gao
Hi, all Yesterday, one critical issue was reported. Its fix required more time to be reviewed and verified. Here is the discussion https://edk2.groups.io/g/devel/message/55047. So, two stewards suggested to extend Hard Feature Freeze by a few days. Now, we are still in Hard Feature Freeze

Re: [edk2-devel] Patch List for 202002 stable tag

2020-02-27 Thread Liming Gao
olm wrote: > > Hi Liming, > > > > On Thu, Feb 27, 2020 at 16:06:22 +, Liming Gao wrote: > >> Stewards: > >> I update the patch lists and status. Based on current information, > >> only one patch (item 5) needs catch this stable tag. Its fix is > >

Re: [edk2-devel] [PATCH v1] ShellPkg: Fix 'ping' command Ip4 receive flow.

2020-02-27 Thread Liming Gao
Also include NetworkPkg reviewer to collect the feedback for this change. Thanks Liming > -Original Message- > From: Laszlo Ersek > Sent: Friday, February 28, 2020 1:40 AM > To: devel@edk2.groups.io; maciej.rab...@linux.intel.com; Gao, Liming > ; Kinney, Michael D > ; Andrew Fish ;

Re: [edk2-devel] Patch List for 202002 stable tag

2020-02-27 Thread Liming Gao
Of Liming Gao Sent: Friday, February 21, 2020 4:23 PM To: devel@edk2.groups.io; Gao, Liming ; Ni, Ray ; vit9696 ; gaurav.j...@nxp.com Cc: Kinney, Michael D ; Laszlo Ersek ; Guptha, Soumya K ; l...@nuviainc.com; af...@apple.com; Marvin Häuser ; Gao, Zhichao ; 'ard.biesheu...@linaro.org' ; Wu, Hao

Re: [edk2-devel] [Patch] BaseTools: Remove invalid leading space before !INCLUDE in Makefile

2020-02-27 Thread Liming Gao
Reviewed-by: Liming Gao Tested-by: Liming Gao -Original Message- > From: devel@edk2.groups.io On Behalf Of Bob Feng > Sent: Thursday, February 27, 2020 10:25 PM > To: devel@edk2.groups.io > Cc: Andrew Fish ; Laszlo Ersek ; Leif > Lindholm ; Kinney, Michael D >

Re: [edk2-devel] [Patch 1/1][edk2-stable202002]BaseTools: Fixed a regression issue in Makefile for incremental build

2020-02-27 Thread Liming Gao
g the incremental build with this > > fix. > > There is no impact on the clean build. > > > > Cc: Andrew Fish > > Cc: Laszlo Ersek > > Cc: Leif Lindholm > > Cc: Michael D Kinney > > Cc: Pierre Gondois > > Signed-off-by: Bob Feng >

Re: [edk2-devel] [Patch] IntelSiliconPkg/ShadowMicrocodePei: Fix GCC build error.

2020-02-26 Thread Liming Gao
elSiliconPkg/ShadowMicrocodePei: Fix GCC build > > > > error. > > > > > > > > > > What compiler does not like the flexible array > > > > > member syntax []. > > > > > > > > > > Mike > > > > > &

Re: [edk2-devel] [Patch] IntelSiliconPkg/ShadowMicrocodePei: Fix GCC build error.

2020-02-26 Thread Liming Gao
k2.groups.io > > > > Cc: Ni, Ray ; Chaganty, Rangasai > > V > > > > ; Gao, Liming > > > > > > > > Subject: [edk2-devel] [Patch] > > > > IntelSiliconPkg/ShadowMicrocodePei: Fix GCC build > > > > error. > > > > > >

Re: [edk2-devel] [Patch] IntelSiliconPkg/ShadowMicrocodePei: Fix GCC build error.

2020-02-26 Thread Liming Gao
> error. > > > > This patch fixes compiler error introduced by commit > > b0099a39bd. > > > > BZ: > > https://tianocore.acgmultimedia.com/show_bug.cgi?id=244 > > 9 > > Cc: Ray Ni > > Cc: Rangasai V Chaganty > > Cc: Liming Gao > > Signed-off-b

Re: [edk2-devel] [Patch] IntelSiliconPkg/ShadowMicrocodePei: Fix GCC build error.

2020-02-26 Thread Liming Gao
Reviewed-by: Liming Gao > -Original Message- > From: Fu, Siyuan > Sent: Thursday, February 27, 2020 9:58 AM > To: devel@edk2.groups.io > Cc: Ni, Ray ; Chaganty, Rangasai V > ; Gao, Liming > Subject: [Patch] IntelSiliconPkg/ShadowMicrocodePei: Fix GCC build error.

Re: [edk2-devel] [PATCH 0/2] UefiCpuPkg/Library: Fix bug in MpInitLib

2020-02-26 Thread Liming Gao
Leo: Now, we enter into Hard Feature Freeze phase until edk2-stable202002 tag is created at 2020-02-28. Only critical bug fix is still allowed. Do you request to catch this fix into this stable tag? If yes, please work closely with UefiCpuPkg maintainers to catch the stable tag release

Re: [edk2-devel] [Patch] IntelSiliconPkg: Declare zero array explicitly to avoid compiler error.

2020-02-25 Thread Liming Gao
Reviewed-by: Liming Gao > -Original Message- > From: devel@edk2.groups.io On Behalf Of Siyuan, Fu > Sent: Wednesday, February 26, 2020 9:08 AM > To: devel@edk2.groups.io > Cc: Ni, Ray ; Chaganty, Rangasai V > > Subject: [edk2-devel] [Patch] IntelSiliconPk

Re: [edk2-devel] [PATCH edk2-stable202002] OvmfPkg/QemuVideoDxe: unbreak "secondary-vga" and "bochs-display" support

2020-02-25 Thread Liming Gao
Laszlo: Seemly, this is a regression issue. I am ok to catch it into stable tag edk2-stable202002. Thanks Liming > -Original Message- > From: devel@edk2.groups.io On Behalf Of Ard Biesheuvel > Sent: Tuesday, February 25, 2020 1:21 AM > To: Laszlo Ersek > Cc: edk2-devel-groups-io ;

Re: [edk2-devel] Patch List for 202002 stable tag

2020-02-21 Thread Liming Gao
support for input with separately reported modifiers [Liming] There is no agreement now. The discussion is in BZ https://bugzilla.tianocore.org/show_bug.cgi?id=2510. So, it may not catch this table tag. Thanks Liming From: devel@edk2.groups.io On Behalf Of Liming Gao Sent: Thursday, February 20

[edk2-devel] Hard Feature Freeze starts now for edk2-stable202002

2020-02-21 Thread Liming Gao
Hi, all Today, we enter into Hard Feature Freeze phase until edk2-stable202002 tag is created at 2020-02-28. In this phase, there is no feature to be pushed. The critical bug fix is still allowed. If the patch is sent after Hard Feature Freeze, and plans to catch this stable tag, please

Re: [edk2-devel] [PATCH] MdeModulePkg/SetupBrowserDxe: Fix IsZeroGuid() ASSERT.

2020-02-20 Thread Liming Gao
Do you request to catch this fix into this edk2 stable tag 202002? > -Original Message- > From: Wang, Nickle (HPS SW) > Sent: Friday, February 21, 2020 10:21 AM > To: Gao, Liming ; devel@edk2.groups.io; Bi, Dandan > > Subject: RE: [edk2-devel] [PATCH] MdeModulePkg/SetupBrowserDxe: Fix

Re: [edk2-devel] Patch List for 202002 stable tag

2020-02-19 Thread Liming Gao
Ray, Zhichao and Vitaly: Thanks. BZ is the good place to catch all discussion. Because we are close to edk2 stable tag 202002, can you make the agreement soon for BZ 2510? Thanks Liming From: Ni, Ray Sent: Thursday, February 20, 2020 11:13 AM To: Gao, Liming ; vit9696 Cc: Kinney, Michael D ;

Re: [edk2-devel] [PATCH v4 1/1] NetworkPkg/ArpDxe: Recycle invalid ARP packets (CVE-2019-14559)

2020-02-19 Thread Liming Gao
This patch is for BZ https://bugzilla.tianocore.org/show_bug.cgi?id=2031 So, please add this line into the commit message. This can be done when submit this patch. Don't need to send the patch again. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2031 Thanks Liming > -Original

Re: [EXT] RE: [edk2-devel] [PATCH v2 1/1] EmbeddedPkg: Fixed Asserts in SCT Runtime Services test.

2020-02-19 Thread Liming Gao
Gaurav: Got it. Lefi and Ard: Can you review this patch for stable tag 202002? Thanks Liming > -Original Message- > From: devel@edk2.groups.io On Behalf Of Gaurav Jain > Sent: Thursday, February 20, 2020 1:19 PM > To: Gao, Liming ; devel@edk2.groups.io > Cc: Leif Lindholm ; Ard

Re: [edk2-devel] Patch List for 202002 stable tag

2020-02-19 Thread Liming Gao
Vitaly: I add my comments. Zhichao and Ray: Can you give your opinion for BZ https://bugzilla.tianocore.org/show_bug.cgi?id=2510? Is it a bug fix or feature enhancement? Thanks Liming From: vit9696 Sent: Thursday, February 20, 2020 2:09 AM To: Gao, Liming Cc: Kinney, Michael D ; Laszlo

Re: [edk2-devel] Patch List for 202002 stable tag

2020-02-19 Thread Liming Gao
Mike and Laszlo: Thanks for your comments. Vitaly: You request below two patches to catch 202002 stable tag. I agree with Mike and Laszlo comments. They are not ready to catch this stable tag. The first one is under discussion. The second one is like the enhancement or feature instead of

Re: [edk2-devel] [edk2-staging/FceFmmt][PATCH] BaseTools/FCE: Fix multiple FVs with SEC module issue

2020-02-19 Thread Liming Gao
Reviewed-by: Liming Gao > -Original Message- > From: Feng, YunhuaX > Sent: Friday, February 14, 2020 5:15 PM > To: devel@edk2.groups.io > Cc: Gao, Liming ; Feng, Bob C ; > Zhang, Hongbin1 > Subject: [edk2-staging/FceFmmt][PATCH] BaseTools/FCE: Fix multiple FVs wit

Re: [edk2-devel] [PATCH] [edk2-staging/FceFmmt]BaseTools: Support no UI section FFS

2020-02-19 Thread Liming Gao
Reviewed-by: Liming Gao > -Original Message- > From: Feng, YunhuaX > Sent: Wednesday, February 12, 2020 2:24 PM > To: devel@edk2.groups.io > Cc: Gao, Liming ; Feng, Bob C > Subject: [PATCH] [edk2-staging/FceFmmt]BaseTools: Support no UI section F

Re: [edk2-devel] [PATCH] Tools/FitGen: Check the input file path before open it

2020-02-19 Thread Liming Gao
Reviewed-by: Liming Gao > -Original Message- > From: Feng, YunhuaX > Sent: Wednesday, February 19, 2020 8:13 PM > To: devel@edk2.groups.io > Cc: Gao, Liming ; Feng, Bob C > Subject: [PATCH] Tools/FitGen: Check the input file path before open it > > REF: https:

Re: [edk2-devel] [PATCH v2 1/1] EmbeddedPkg: Fixed Asserts in SCT Runtime Services test.

2020-02-19 Thread Liming Gao
Gaurav: Does this patch catch to edk2 stable tag 202002? Thanks Liming > -Original Message- > From: devel@edk2.groups.io On Behalf Of Gaurav Jain > Sent: Tuesday, February 18, 2020 8:24 PM > To: devel@edk2.groups.io > Cc: Leif Lindholm ; Ard Biesheuvel > ; Pankaj Bansal ; Gaurav >

Re: [edk2-devel] [PATCH v3] NetworkPkg/Ip4Dxe: Check the received package length (CVE-2019-14559).

2020-02-18 Thread Liming Gao
Siyuan and Maciej: Can you help review this patch? I would like to make CVE fix catch this stable tag edk2 202002. Thanks Liming > -Original Message- > From: devel@edk2.groups.io On Behalf Of Wu, Jiaxin > Sent: Tuesday, February 18, 2020 1:52 PM > To: devel@edk2.groups.io > Cc: Fu,

[edk2-devel] Patch List for 202002 stable tag

2020-02-18 Thread Liming Gao
Hi Stewards and all: I collect current patch lists in devel mail list. Those patch contributors request to add them for 201902 stable tag. Because we have enter into Soft Feature Freeze, I want to collect your feedback for them. If any patches are missing, please reply this mail to add them.

Re: [edk2-devel] [PATCH v1 1/1] ShellPkg: acpiview: Prevent infinite loop if structure length is 0

2020-02-17 Thread Liming Gao
tag. > > Over the last few months I added some security features to acpiview. They > make this debug tool less sensitive to exploits from ACPI > tables. This patch completes my efforts in making the tool more reliable. > > Kind regards, > Krzysztof > > -Original M

Re: [edk2-devel] [PATCH v1 1/1] ShellPkg: acpiview: Prevent infinite loop if structure length is 0

2020-02-17 Thread Liming Gao
Krzysztof: Is there one BZ for this issue? Does this patch catch to this edk2 stable tag 202002? Thanks Liming > -Original Message- > From: devel@edk2.groups.io On Behalf Of Krzysztof Koch > Sent: Friday, February 14, 2020 9:59 PM > To: devel@edk2.groups.io > Cc: Ni, Ray ; Gao,

Re: [edk2-devel] [PATCH v1] MdeModulePkg/Ip4Dxe: Check the received package length (CVE-2019-14559).

2020-02-17 Thread Liming Gao
Another minor comment. Ip4Dxe is moved into NetworkPkg. So, the patch title should be NetworkPkg/Ip4Dxe. Thanks Liming > -Original Message- > From: devel@edk2.groups.io On Behalf Of Laszlo Ersek > Sent: Monday, February 17, 2020 6:40 PM > To: devel@edk2.groups.io; Wu, Jiaxin > Cc: Fu,

Re: [edk2-devel] [PATCH 1/1] MdeModulePkg/Pci: Fixed Asserts in SCT PCIIO Protocol Test.

2020-02-17 Thread Liming Gao
Gaurav: Does this patch catch to edk2 stable tag 202002? Thanks Liming > -Original Message- > From: devel@edk2.groups.io On Behalf Of Gaurav Jain > Sent: Monday, February 17, 2020 3:18 PM > To: devel@edk2.groups.io > Cc: Wang, Jian J ; Wu, Hao A ; Ni, > Ray ; Pankaj Bansal > >

Re: [edk2-devel] [edk2-announce] Soft Feature Freeze starts now for edk2-stable202002

2020-02-16 Thread Liming Gao
> have listed the Boot Guard one. > > Thanks, > Tim Lewis > CTO, Insyde Software > www.insyde.com > > -Original Message- > From: annou...@edk2.groups.io On Behalf Of Liming > Gao > Sent: Friday, February 14, 2020 12:19 AM > To: devel@edk2.groups.io; an

Re: [edk2-devel] [PATCH v3 0/2] CryptoPkg/OpensslLib: Remove "no-autoalginit" flag from OpenSSL build

2020-02-14 Thread Liming Gao
Zurcher: Seemly, this is like an enhancement in OpensslLib. Please submit one BZ (https://bugzilla.tianocore.org/) for this change. And today, edk2 enters into the soft feature freeze for edk2-stable202002 stable tag. So, this change may not catch this stable tag. Thanks Liming >

[edk2-devel] Soft Feature Freeze starts now for edk2-stable202002

2020-02-14 Thread Liming Gao
Hi, all We will enter into Soft Feature Freeze phase. In this phase, the feature under review will not be allowed to be pushed. The patch review can continue without break in edk2 community. If the patch is sent before Soft Feature Freeze, and plans to catch this stable tag, the patch

[edk2-devel] [edk2-platform][patch] FitGen: Add FIT spec revision in FitGen tool help message

2020-02-13 Thread Liming Gao
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2483 Signed-off-by: Liming Gao Cc: Bob Feng Cc: Paul Lohr --- Silicon/Intel/Tools/FitGen/FitGen.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Silicon/Intel/Tools/FitGen/FitGen.c b/Silicon/Intel/Tools/FitGen/FitGen.c

Re: [edk2-devel] [edk2-platforms] Building a platform: which edk2 revision to choose?

2020-02-13 Thread Liming Gao
Felix: I always pull the latest edk2 and edk2-platform, then build it. Thanks Liming From: devel@edk2.groups.io On Behalf Of Felix Polyudov Sent: Friday, February 14, 2020 7:11 AM To: devel@edk2.groups.io Cc: Kubacki, Michael A Subject: [edk2-devel] [edk2-platforms] Building a platform: which

Re: [edk2-devel] [PATCH 2/3] MdeModulePkg: Issues reported by ECC in EDK2.

2020-02-13 Thread Liming Gao
Reviewed-by: Liming Gao > -Original Message- > From: devel@edk2.groups.io On Behalf Of GuoMinJ > Sent: Thursday, February 13, 2020 4:34 PM > To: devel@edk2.groups.io > Cc: GuoMinJ > Subject: [edk2-devel] [PATCH 2/3] MdeModulePkg: Issues reported by ECC in

Re: [edk2-devel] [PATCH v2 1/1] MdePkg: Add PCCT table signature definition

2020-02-13 Thread Liming Gao
Push @a67efa3b22113cc9b52f8e56e50466d6da0ab11e > -Original Message- > From: devel@edk2.groups.io On Behalf Of Liming Gao > Sent: Thursday, February 13, 2020 8:59 AM > To: Krzysztof Koch ; devel@edk2.groups.io > Cc: Kinney, Michael D ; matteo.carl...@arm.com; > sami.

Re: [edk2-devel] [PATCH 1/3] FmpDevicePkg/FmpDxe: Issues reported by ECC in EDK2.

2020-02-13 Thread Liming Gao
Reviewed-by: Liming Gao > -Original Message- > From: devel@edk2.groups.io On Behalf Of GuoMinJ > Sent: Thursday, February 13, 2020 4:34 PM > To: devel@edk2.groups.io > Cc: GuoMinJ > Subject: [edk2-devel] [PATCH 1/3] FmpDevicePkg/FmpDxe: Issues reported by ECC >

Re: [edk2-devel] [PATCH 0/9] Fix false negative issue in DxeImageVerificationHandler

2020-02-12 Thread Liming Gao
Jian, Jiewen and Chao: Does this patch catch to edk2 Q1 stable tag? If yes, can this patch be reviewed this week, because Q1 stable tag soft feature freeze is 2020-02-14. Thanks Liming > -Original Message- > From: devel@edk2.groups.io On Behalf Of Wang, Jian J > Sent: Thursday,

Re: [edk2-devel] [PATCH v2 1/1] MdePkg: Add PCCT table signature definition

2020-02-12 Thread Liming Gao
Reviewed-by: Liming Gao > -Original Message- > From: Krzysztof Koch > Sent: Thursday, February 13, 2020 1:28 AM > To: devel@edk2.groups.io > Cc: Kinney, Michael D ; Gao, Liming > ; matteo.carl...@arm.com; > sami.muja...@arm.com; n...@arm.com > Subject: [PATCH

Re: [edk2-devel] [Patch] MdePkg/BaseSafeIntLib: Fix VS20xx IA32 link failures

2020-02-12 Thread Liming Gao
Reviewed-by: Liming Gao > -Original Message- > From: Kinney, Michael D > Sent: Thursday, February 13, 2020 6:45 AM > To: devel@edk2.groups.io > Cc: Gao, Liming ; Sean Brogan > ; Bret Barkelew > Subject: [Patch] MdePkg/BaseSafeIntLib: Fix VS20xx IA32 lin

Re: [edk2-devel] PCD Migration issue

2020-02-12 Thread Liming Gao
o freeze Dynamic PCD usage in > your common core? > > Thanks, > > Andrew Fish > > > On Feb 11, 2020, at 7:54 PM, Liming Gao wrote: > > > > Andrew: > > Current implementation requires PEI PcdDB and DXE PcdDB match. This is > > like a n

Re: [edk2-devel] [PATCH 1/1] BaseTools: Switch to GNU mode for CLANGPDB

2020-02-12 Thread Liming Gao
ing From: devel@edk2.groups.io<mailto:devel@edk2.groups.io> mailto:devel@edk2.groups.io>> On Behalf Of Liming Gao Sent: Tuesday, February 11, 2020 1:34 PM To: vit9696 mailto:vit9...@protonmail.com>>; devel@edk2.groups.io<mailto:devel@edk2.groups.io> Subject: Re: [edk2-devel] [PA

Re: [edk2-devel] [PATCH v1 1/1] MdePkg: Add PCCT table signature definition

2020-02-12 Thread Liming Gao
Krzysztof: Sorry to miss this patch. I see PCCT table is added since ACPI 5.0. So, I think its table signature definition should also be added into Acpi50.h, Acpi51.h, Acpi60.h, Acpi61.h and Acpi62.h. Thanks Liming > -Original Message- > From: Krzysztof Koch > Sent: Wednesday,

Re: [edk2-devel] PCD Migration issue

2020-02-11 Thread Liming Gao
Andrew: Current implementation requires PEI PcdDB and DXE PcdDB match. This is like a new request for PCD DataBase. It requests PCD DB binary format and Dynamic PCD token assignment be compatible in the different version. Thanks Liming > -Original Message- > From: devel@edk2.groups.io

Re: [edk2-devel] [PATCH] BaseTools: remove -DNO_MSABI_VA_FUNCS option in CLANGPDB tool chain

2020-02-11 Thread Liming Gao
Reviewed-by: Liming Gao > -Original Message- > From: Liu, Zhiguang > Sent: Wednesday, February 12, 2020 9:40 AM > To: devel@edk2.groups.io > Cc: Feng, Bob C ; Gao, Liming > Subject: [PATCH] BaseTools: remove -DNO_MSABI_VA_FUNCS option in CLANGPDB > tool

Re: [edk2-devel] [PATCH] MdePkg: Add PCI Express 5.0 Header File

2020-02-11 Thread Liming Gao
Reviewed-by: Liming Gao PR https://github.com/tianocore/edk2/pull/366 > -Original Message- > From: Felix Polyudov > Sent: Wednesday, February 12, 2020 6:35 AM > To: Gao, Liming ; 'devel@edk2.groups.io' > > Subject: RE: [PATCH] MdePkg: Add PCI Express 5.0 Heade

Re: [edk2-devel] [PATCH v2 2/2] MdePkg: Remove FIT table industry standard header file.

2020-02-11 Thread Liming Gao
Reviewed-by: Liming Gao > -Original Message- > From: Fu, Siyuan > Sent: Tuesday, February 11, 2020 9:37 PM > To: devel@edk2.groups.io > Cc: Kinney, Michael D ; Gao, Liming > > Subject: [PATCH v2 2/2] MdePkg: Remove FIT table industry standard header > f

Re: [edk2-devel] [PATCH V2 1/1] BaseTools: Switch to GNU mode for CLANGPDB

2020-02-11 Thread Liming Gao
Reviewed-by: Liming Gao > -Original Message- > From: devel@edk2.groups.io On Behalf Of Vitaly > Cheptsov via Groups.Io > Sent: Tuesday, February 11, 2020 2:53 PM > To: devel@edk2.groups.io > Subject: [edk2-devel] [PATCH V2 1/1] BaseTools: Switch to GNU mode for &

Re: [edk2-devel] [PATCH 1/1] BaseTools: Switch to GNU mode for CLANGPDB

2020-02-10 Thread Liming Gao
Vitaly: Can you update this patch based on the latest edk2 trunk? I will catch it for edk2 Q1 stable tag. Thanks Liming From: devel@edk2.groups.io On Behalf Of Liming Gao Sent: Tuesday, February 11, 2020 1:34 PM To: vit9696 ; devel@edk2.groups.io Subject: Re: [edk2-devel] [PATCH 1/1

Re: [edk2-devel] [PATCH v2] Add support for Diagnostics ACM in FitGen tool

2020-02-10 Thread Liming Gao
Push @ 8864a1ad2f090e8f71bb4a5da873baf903f5e053 > -Original Message- > From: devel@edk2.groups.io On Behalf Of Liming Gao > Sent: Monday, February 10, 2020 10:10 PM > To: Agrawal, Sachin ; devel@edk2.groups.io > Cc: Feng, Bob C > Subject: Re: [edk2-devel] [PAT

Re: [edk2-devel] [PATCH 1/1] BaseTools: Switch to GNU mode for CLANGPDB

2020-02-10 Thread Liming Gao
Reviewed-by: Liming Gao From: vit9696 Sent: Tuesday, February 11, 2020 3:23 AM To: Gao, Liming ; devel@edk2.groups.io Subject: RE: [edk2-devel] [PATCH 1/1] BaseTools: Switch to GNU mode for CLANGPDB Liming, We did run several of our projects based on EDK II in X64 mode, DEBUG, RELEASE, NOOPT

[edk2-devel] [edk2 wiki][patch] Move TOCTOU feature from Q1 stable tag to Q2 stable tag

2020-02-10 Thread Liming Gao
Its solution is changed. This feature is moving to Q2 Stable tag. Signed-off-by: Liming Gao --- EDK-II-Release-Planning.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/EDK-II-Release-Planning.md b/EDK-II-Release-Planning.md index a1866d2..32488de 100644 --- a/EDK-II

Re: [edk2-devel] [PATCH v2] Add support for Diagnostics ACM in FitGen tool

2020-02-10 Thread Liming Gao
Reviewed-by: Liming Gao > -Original Message- > From: Agrawal, Sachin > Sent: Saturday, February 8, 2020 6:32 AM > To: devel@edk2.groups.io > Cc: Feng, Bob C ; Gao, Liming > Subject: [PATCH v2] Add support for Diagnostics ACM in FitGen tool > > From: "Agr

Re: [edk2-devel] [PATCH 1/1] BaseTools: Switch to GNU mode for CLANGPDB

2020-02-10 Thread Liming Gao
Vitaly: This change is good. Can you your test for it? I verify this patch for Ovmf platform on Windows. It can make ovmf pass build with CLANGPDB. Thanks Liming > -Original Message- > From: devel@edk2.groups.io On Behalf Of Vitaly > Cheptsov via Groups.Io > Sent: Monday, February

Re: [edk2-devel] [Patch 1/1] BaseTools: Fixed a Incremental build issue

2020-02-07 Thread Liming Gao
Reviewed-by: Liming Gao > -Original Message- > From: Feng, Bob C > Sent: Friday, February 7, 2020 4:42 PM > To: edk2-de...@lists.01.org; devel@edk2.groups.io > Cc: Feng, Bob C ; Dong, Guo ; Gao, > Liming > Subject: [Patch 1/1] BaseTools: Fixed a Incremental build

Re: [edk2-devel] [edk2-staging/UEFI_PCI_ENHANCE-2 PATCH] MdePkg/Protocols: Code correction - removal of reserved member

2020-02-06 Thread Liming Gao
Reviewed-by: Liming Gao > -Original Message- > From: Javeed, Ashraf > Sent: Thursday, February 6, 2020 6:38 PM > To: devel@edk2.groups.io > Cc: Kinney, Michael D ; Gao, Liming > ; Ni, Ray > Subject: [edk2-staging/UEFI_PCI_ENHANCE-2 PATCH] MdePkg/Protocols: Code &

Re: [edk2-devel] [PATCH v2] MdeModulePkg/Capsule: Remove RT restriction in UpdateCapsule service.

2020-02-06 Thread Liming Gao
Reviewed-by: Liming Gao > -Original Message- > From: devel@edk2.groups.io On Behalf Of Siyuan, Fu > Sent: Friday, February 7, 2020 2:39 PM > To: devel@edk2.groups.io > Cc: Wu, Hao A ; Gao, Liming > Subject: [edk2-devel] [PATCH v2] MdeModulePkg/Capsule: Rem

Re: [edk2-devel] [PATCH] MdePkg/SmBios.h: Add two additional DWORD for smbios 3.3.0 type17

2020-02-06 Thread Liming Gao
gt; Configured Memory Speed". The lack of these field may cause strange > error i some operating systems. Seemly, this is typo. It should be in some operating systems > > Cc: Michael D Kinney > Cc: Liming Gao > Signed-off-by: Zhichao Gao > --- > MdePkg/Include/Industry

Re: [edk2-devel] [PATCH] MdePkg: Add PCI Express 5.0 Header File

2020-02-06 Thread Liming Gao
Felix: The patch is good. Is any test for the header file, such as build? Thanks Liming > -Original Message- > From: Felix Polyudov > Sent: Wednesday, February 5, 2020 5:30 AM > To: devel@edk2.groups.io > Cc: Kinney, Michael D ; Gao, Liming > ; manickavasak...@ami.com > Subject:

Re: [edk2-devel] [Patch] MdeModulePkg/Capsule: Remove RT restriction in UpdateCapsule service.

2020-02-06 Thread Liming Gao
k a > platform CapsuleLib from implementing ProcessCapsuleImage() with runtime > capsule processing capability. This patch removes this restriction. > > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2501 > > Cc: Hao A Wu > Cc: Liming Gao > Signed-off-by: Siyuan Fu > --- >

Re: [edk2-devel] [PATCH] BaseTools: Enhance call stack unwindability for CLANGPDB x64 binary

2020-02-06 Thread Liming Gao
Reviewed-by: Liming Gao > -Original Message- > From: Shi, Steven > Sent: Tuesday, February 4, 2020 3:49 PM > To: Gao, Liming ; devel@edk2.groups.io > Cc: Feng, Bob C > Subject: RE: [PATCH] BaseTools: Enhance call stack unwindability for CLANGPDB > x64 b

Re: [edk2-devel] [PATCH 0/1] Use _MSC_VER to determine MSVC compiler

2020-02-06 Thread Liming Gao
Vitaly: We also find _MSC_VER is defined in Windows, but not in Linux. Your analysis explains it. When use i686-unknown-windows-gnu option, __GNUC__ macro will be defined. If so, we don’t need to append the check for defined (__clang__) in Base.h. And, this change can remove

[edk2-devel] [edk2-platform] FitGen: Support FV with the extension header

2020-02-05 Thread Liming Gao
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2086 To find Microcode FILE in FV image, need to skip FV header and FV extension header, then find the first RAW FFS file. Cc: Bob Feng Signed-off-by: Liming Gao --- Silicon/Intel/Tools/FitGen/FitGen.c | 40

[edk2-devel] [edk2-platform][patch v3] FitGen: Fix the issue to run in X64 linux machine

2020-02-05 Thread Liming Gao
: Bob Feng Cc: Isaac Oram Signed-off-by: Liming Gao --- In v2: update the commit message. In v3: correct Index to access OptionalModule field Silicon/Intel/Tools/FitGen/FitGen.c | 31 --- Silicon/Intel/Tools/FitGen/FitGen.h | 2 +- 2 files changed, 21 insertions

Re: [edk2-devel] [Patch] BaseTools tools_def.template: Add back -fno-pie option in GCC49 tool chain

2020-02-05 Thread Liming Gao
d > host libs when building the POSIX host application. > > [BuildOptions] > GCC:*_*_*_CC_FLAGS = -fno-pie > > I think with the proposed change below, I could remove > this. Do you agree? > > Thanks, > > Mike > > > > -Original Message- >

Re: [edk2-devel] [PATCH v2 1/1] BaseTools: Build ASL files before C files

2020-02-04 Thread Liming Gao
Pierre: I see you use ':' to describe the dependency between the different source file. This is makefile syntax for the dependency. If one file depends on more than one files, other files will list after this file with the separator space ' '. So, I think the example should be like below. >

Re: [edk2-devel] [PATCH v2 1/1] BaseTools: Rationalise makefile generation

2020-02-04 Thread Liming Gao
Pierre: I think below three configurations are common. With this patch, they can work fine, right? And, do you mean Windows - GCC- GNUmake is still blocked by the change "0c3e8e9947a6c13b4327dd11b20acb95441701cf BaseTools: Enhance Basetool for incremental build"? > Windows - GCC-

Re: [edk2-devel] [Patch] BaseTools tools_def.template: Add back -fno-pie option in GCC49 tool chain

2020-02-04 Thread Liming Gao
tion in GCC49 tool chain > > (+Ard) > > On 02/04/20 05:54, Liming Gao wrote: > > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2502 > > This option is required to make GCC49 tool chain work with the high > > version GCC compiler. > > > > Cc: Bo

[edk2-devel] [edk2-platform][patch v2] FitGen: Fix the issue to run in X64 linux machine

2020-02-04 Thread Liming Gao
: Bob Feng Cc: Isaac Oram Signed-off-by: Liming Gao --- In V2, add the detail commit message. Silicon/Intel/Tools/FitGen/FitGen.c | 31 --- Silicon/Intel/Tools/FitGen/FitGen.h | 2 +- 2 files changed, 21 insertions(+), 12 deletions(-) diff --git a/Silicon/Intel/Tools

Re: [edk2-devel] [PATCH] BaseTools: Enhance call stack unwindability for CLANGPDB x64 binary

2020-02-03 Thread Liming Gao
me. > Enhance the build options to force emit the unwind tables and > keep the data of pdata and xdata sections correct in the binary. > > Signed-off-by: Steven Shi > Cc: Liming Gao > Cc: Bob Feng > --- > BaseTools/Conf/tools_def.template | 16 +

Re: [edk2-devel] [PATCH 0/1] Use _MSC_VER to determine MSVC compiler

2020-02-03 Thread Liming Gao
Vitaly: Yes. I think we should have better solution in OpenSSL to support EDK2 usage. But, this is a long term solution. For now, I will try the solution to remove -fms-compatibility option in CLANGPDB tool chain. Thanks Liming From: vit9696 Sent: Monday, February 3, 2020 7:29 PM To: Gao,

Re: [edk2-devel] [Patch V2 1/2] BaseTools: append -DNO_MSABI_VA_FUNCS option in CLANGPDB tool chain

2020-02-03 Thread Liming Gao
Reviewed-by: Liming Gao > -Original Message- > From: Liu, Zhiguang > Sent: Tuesday, February 4, 2020 10:21 AM > To: devel@edk2.groups.io > Cc: Feng, Bob C ; Gao, Liming > Subject: [Patch V2 1/2] BaseTools: append -DNO_MSABI_VA_FUNCS option in > CLANGPDB tool

Re: [edk2-devel] [Patch V2 2/2] MdePkg: Avoid using __clang__ to specify CLANGPDB

2020-02-03 Thread Liming Gao
Reviewed-by: Liming Gao > -Original Message- > From: Liu, Zhiguang > Sent: Tuesday, February 4, 2020 10:21 AM > To: devel@edk2.groups.io > Cc: Kinney, Michael D ; Gao, Liming > > Subject: [Patch V2 2/2] MdePkg: Avoid using __clang__ to specify CL

Re: [edk2-devel] [PATCH 2/5] MdePkg: Allow PcdFSBClock to by Dynamic

2020-02-03 Thread Liming Gao
Thanks for your data. Seemly, those data is acceptable on OvmfXen. For this patch, Reviewed-by: Liming Gao Thanks Liming > -Original Message- > From: devel@edk2.groups.io On Behalf Of Anthony PERARD > Sent: Tuesday, February 4, 2020 1:26 AM > To: Gao, Liming > Cc: Laszl

<    1   2   3   4   5   6   7   8   9   10   >