Cc: Ray Ni
Cc: Zhichao Gao
Cc: Liming Gao
Signed-off-by: Mike Maslenkin
---
MdeModulePkg/Universal/Disk/RamDiskDxe/RamDiskImpl.c | 9 +++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/MdeModulePkg/Universal/Disk/RamDiskDxe/RamDiskImpl.c
b/MdeModulePkg/Universal/Disk
l]
> >
> > Caution: This message originated from an External Source. Use proper caution
> > when opening attachments, clicking links, or responding.
> >
> >
> > [AMD Official Use Only - General]
> >
> > Hi @Mike Maslenkin, would you like to review this
d
> I don't see any issue.
>
>
>
> Hi @Mike Maslenkin, please add Abner and my reviewed-by to the commit
> messages. And we can merge the pull request.
>
>
>
> Thanks,
>
> Nickle
>
>
>
> > -Original Message-
>
> > From: Chang,
GetRedpathNodeByIndex[4]:Bios/Settings
GetRedpathNodeByIndex[5]:Settings
Cc: Abner Chang
Cc: Igor Kulchytskyy
Cc: Nickle Wang
Signed-off-by: Mike Maslenkin
---
.../Library/RedfishFeatureUtilityLib/RedfishFeatureUtilityLib.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
a/RedfishClientPkg
correctly.
Cc: Abner Chang
Cc: Igor Kulchytskyy
Cc: Nickle Wang
Signed-off-by: Mike Maslenkin
---
.../RedfishFeatureUtilityLib/RedfishFeatureUtilityLib.c | 5 +
1 file changed, 5 insertions(+)
diff --git
a/RedfishClientPkg/Library/RedfishFeatureUtilityLib/RedfishFeatureUtilityLib.c
.
Cc: Abner Chang
Cc: Igor Kulchytskyy
Cc: Nickle Wang
Signed-off-by: Mike Maslenkin
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#117065): https://edk2.groups.io/g/devel/message/117065
Mute This Topic: https://groups.io/mt/105101990
-off-by: Mike Maslenkin
---
.../Library/RedfishFeatureUtilityLib/RedfishFeatureUtilityLib.c | 1 +
1 file changed, 1 insertion(+)
diff --git
a/RedfishClientPkg/Library/RedfishFeatureUtilityLib/RedfishFeatureUtilityLib.c
b/RedfishClientPkg/Library/RedfishFeatureUtilityLib
Hi Abner,
Sorry if I wasn't clear.
I meant in this function including the success path.
RedfishSetRedfishUri->..->NewConfigLangMapRecord() creates a copy of
this string, so it should be freed in this function.
Regards,
Mike.
On Fri, Mar 22, 2024 at 12:58 PM Chang, Abner wrote:
>
> [AMD
Hi Abner,
> On 22. 3. 2024., at 12:09, Chang, Abner via groups.io
> wrote:
>
> From: Abner Chang
>
> Set SettingsObject URI in @Redfish.Settings resource as the config
> language which is the same as the config language of parent URI
> that mandates @Redfish.Settings.
> With this, we can
On Sun, Mar 10, 2024 at 1:41 PM Mike Maslenkin wrote:
>
> This set contains fixes for proper deallocation of the structures
> returned by JsonStructProtocol->ToStructure().
>
> PR: https://github.com/tianocore/edk2-redfish-client/pull/82
>
> Cc: Abner Chang
> Cc: Igo
The structure instance retunred by ToStructure() must be deallocated
properly.
Cc: Abner Chang
Cc: Igor Kulchytskyy
Cc: Nickle Wang
Signed-off-by: Mike Maslenkin
---
.../v1_13_0/Common/ComputerSystemCommon.c | 25 +--
.../v1_5_0/Common/ComputerSystemCommon.c | 25
The structure instance retunred by ToStructure() must be deallocated
properly.
Cc: Abner Chang
Cc: Igor Kulchytskyy
Cc: Nickle Wang
Signed-off-by: Mike Maslenkin
---
.../v1_5_0/RedfishResourceIdentifyLibComputerSystem.c| 9 ++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff
The structure instance retunred by ToStructure() must be deallocated
properly.
Cc: Abner Chang
Cc: Igor Kulchytskyy
Cc: Nickle Wang
Signed-off-by: Mike Maslenkin
---
RedfishClientPkg/Features/Bios/v1_0_9/Common/BiosCommon.c| 5 -
.../Features/BootOption/v1_0_4/Common
This set contains fixes for proper deallocation of the structures
returned by JsonStructProtocol->ToStructure().
PR: https://github.com/tianocore/edk2-redfish-client/pull/82
Cc: Abner Chang
Cc: Igor Kulchytskyy
Cc: Nickle Wang
Signed-off-by: Mike Maslen
This patch fixes leak of EFI_REDFISH_COMPUTERSYSTEMCOLLECTION instance
on error path.
Cc: Abner Chang
Cc: Igor Kulchytskyy
Cc: Nickle Wang
Signed-off-by: Mike Maslenkin
---
.../ComputerSystemCollectionDxe.c| 12 +---
.../MemoryCollectionDxe/MemoryCollectionDxe.c
Good work, Nickle!
On Thu, Feb 29, 2024 at 11:53 AM Nickle Wang via groups.io
wrote:
>
> Redfish HTTP protocol is introduced to edk2 RedfishPkg. Update
> RedfishClientPkg to use RedfishHttpLib. And remove the use of
> RedfishHttpCacheLib.
>
> I also replace several functions from RedfishLib with
Reviewed-by: Mike Maslenkin
Regards,
Mike.
On Mon, Feb 26, 2024 at 7:55 AM wrote:
>
> From: Abner Chang
>
> Clarify the HTTP method that is used to provision BIOS
> managed Redfish resource.
>
> Signed-off-by: Abner Chang
> Cc: Nickle Wang
> Cc: Igor Kulchy
On Wed, Feb 28, 2024 at 2:47 PM Nickle Wang wrote:
>
> Hi @Mike Maslenkin,
>
>
>
> May I have your reviewed-by if version 3 patch set look good to you?
>
Sure!
Reviewed-by: Mike Maslenkin
BTW I'm just curious, there is a mention in patch 2 "We currently only
sup
Hii Nickle,
On Mon, Feb 26, 2024 at 4:44 PM Nickle Wang wrote:
>
> Hi Mike,
>
> > So finally we have
> > HttpFreeHeaderFields (Response->Headers, Response->HeaderCount);
> > but Response->HeaderCount does not count partially allocated elements.
> > Right?
> >
> > To fix this, it is required to
Right?
To fix this, it is required to set
*DstHeaderCount = SrcHeaderCount unconditionally right after
DstHeaders allocation, and HttpFreeHeaderFields() will do the work
then.
Regards,
Mike.
>
> Regards,
> Nickle
>
> > -Original Message-
> > From: Mike Maslenkin
&g
Hi Nickle,
I've updated commit message with your R-b and pushed it to PR.
Regards,
Mike.
> On 23. 2. 2024., at 12:38, Nickle Wang wrote:
>
> Hi @Mike Maslenkin <mailto:mike.maslen...@gmail.com>,
>
> Can you please help me to add my reviewed-by to this commit message?
Hi Nickle,
%s/Resrouce/Resource/ this comes from RedfishClient autogenerated files...
there are thousands of "Resrouce" typos.
please, find my minor notes below:
On Thu, Feb 22, 2024 at 12:11 PM Nickle Wang via groups.io
wrote:
>
> implement Redfish HTTP protocol driver.
>
>
Common Json actually is the same
value as Private->Json. Let's make code a bit cleaner.
Cc: Abner Chang
Cc: Nickle Wang
Cc: Igor Kulchytskyy
Signed-off-by: Mike Maslenkin
Reviewed-by: Abner Chang
Reviewed-by: Nickle Wang
---
RedfishClientPkg/Features/Bios/v1_0_9/Common/BiosCommon.c
Cc: Abner Chang
Cc: Nickle Wang
Cc: Igor Kulchytskyy
Signed-off-by: Mike Maslenkin
Reviewed-by: Abner Chang
Reviewed-by: Nickle Wang
---
.../Features/Bios/v1_0_9/Dxe/BiosDxe.c | 17 +++--
1 file changed, 11 insertions(+), 6 deletions(-)
diff --git a/RedfishClientPkg
Cc: Abner Chang
Cc: Igor Kulchytskyy
Cc: Nickle Wang
Signed-off-by: Mike Maslenkin
Reviewed-by: Abner Chang
Reviewed-by: Nickle Wang
---
.../Library/RedfishFeatureUtilityLib/RedfishFeatureUtilityLib.c | 1 +
1 file changed, 1 insertion(+)
diff --git
a/RedfishClientPkg/Library
Use local variable for BiosUri passed to HandleResource() to avoid
problems in case of Private->Uri is overriden down the call stack.
Suggested-by: Nickle Wang
Cc: Abner Chang
Cc: Nickle Wang
Cc: Igor Kulchytskyy
Signed-off-by: Mike Maslenkin
---
RedfishClientPkg/Features/Bios/v1_0_9/
back for the ones had given R-b
collected R-b
renamed CollectionUri to BiosUri
Signed-off-by: Mike Maslenkin
Cc: Abner Chang
Cc: Nickle Wang
Cc: Igor Kulchytskyy
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#115734): https://edk2
On Wed, Feb 21, 2024 at 5:34 AM Chang, Abner wrote:
>
> [AMD Official Use Only - General]
>
> > -Original Message-
> > From: Mike Maslenkin
> > Sent: Wednesday, February 21, 2024 8:13 AM
> > To: devel@edk2.groups.io
> > Cc: Mike Maslenkin
Common Json actually is the same
value as Private->Json. Let's make code a bit cleaner.
Cc: Abner Chang
Cc: Nickle Wang
Cc: Igor Kulchytskyy
Signed-off-by: Mike Maslenkin
---
RedfishClientPkg/Features/Bios/v1_0_9/Common/BiosCommon.c | 2 +-
.../Features/BootOption/v1_0
Cc: Abner Chang
Cc: Nickle Wang
Cc: Igor Kulchytskyy
Signed-off-by: Mike Maslenkin
---
RedfishClientPkg/Features/Bios/v1_0_9/Dxe/BiosDxe.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/RedfishClientPkg/Features/Bios/v1_0_9/Dxe/BiosDxe.c
b/RedfishClientPkg/Features/Bios/v1_0_9/Dxe
Cc: Igor Kulchytskyy
Cc: Nickle Wang
Signed-off-by: Mike Maslenkin
Reviewed-by: Abner Chang
---
.../Library/RedfishFeatureUtilityLib/RedfishFeatureUtilityLib.c | 1 +
1 file changed, 1 insertion(+)
diff --git
a/RedfishClientPkg/Library/RedfishFeatureUtilityLib/RedfishFeatureUtilityLib.c
b
Use local variable for CollectionUri passed to HandleResource() to avoid
problems in case of Private->Uri is overriden down the call stack.
Suggested-by: Nickle Wang
Cc: Abner Chang
Cc: Nickle Wang
Cc: Igor Kulchytskyy
Signed-off-by: Mike Maslenkin
---
RedfishClientPkg/Features/Bios/v1_
This set contains a trivial fix for a leak reviewed on Feb 1 [1]
and a fix for а leak discussed in [2].
PR: https://github.com/tianocore/edk2-redfish-client/pull/76
[1] https://edk2.groups.io/g/devel/message/114925
[2] https://edk2.groups.io/g/devel/message/114765
Signed-off-by: Mike Maslenkin
Signed-off-by: Mike Maslenkin
Cc: Ray Ni
---
MdeModulePkg/Bus/Pci/NvmExpressDxe/NvmExpress.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/MdeModulePkg/Bus/Pci/NvmExpressDxe/NvmExpress.c
b/MdeModulePkg/Bus/Pci/NvmExpressDxe/NvmExpress.c
index dfa3653d6a5e
This set contains a simple fixes for UINT64 values passed to functions
producing strings.
Patch 1/2 is a real fix for NVMe drive label creation logic.
For example: Opal driver from SecurityPkg uses gEfiComponentNameProtocolGuid
family for obtaining disk name.
Signed-off-by: Mike Maslenkin
Cc
Eui64 is a 64 bit value, so the "L" or "l" is required for
format specifier, otherwise only lower 32 bit will be converted.
Signed-off-by: Mike Maslenkin
Cc: Ray Ni
---
MdeModulePkg/Bus/Pci/NvmExpressDxe/NvmExpress.c | 2 +-
1 file changed, 1 insertion(+), 1 del
The memory returned by json_dumps() must be freed.
Signed-off-by: Mike Maslenkin
Cc: Abner Chang
Cc: Nickle Wang
Cc: Igor Kulchytskyy
---
RedfishClientPkg/ConverterLib/src/RedfishCsCommon.c | 7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/RedfishClientPkg
Variable 'Status' may be used uninitialized in this function
[-Werror=maybe-uninitialized]
Signed-off-by: Mike Maslenkin
Cc: Abner Chang
Cc: Igor Kulchytskyy
Reviewed-by: Nickle Wang
---
RedfishClientPkg/RedfishFeatureCoreDxe/RedfishFeatureCoreDxe.c | 1 +
1 file changed, 1 insertion
This patchset contains a trivial fix for memory leak in ConverterLib
Also patch 1 is a resend of the same patch sent to list on 4th Jan with
added Rb (https://edk2.groups.io/g/devel/message/113162).
PR: https://github.com/tianocore/edk2-redfish-client/pull/74
Signed-off-by: Mike Maslenkin
Cc
BTW did you consider to remove this Private->Uri someday at all ?
I tried to remove it, but since it declared in a common header for all redfish
client feature drivers
those changes was huge comparing to a small memory leak I tried to fix.
And now such pattern spreads into new feature drivers.
You are right.
Sorry for the noise!
No problems here.
I mixed up with tags in my editor while looked into patch.
Regards,
Mike
> On 26. 1. 2024., at 17:03, Chang, Abner wrote:
>
> [AMD Official Use Only - General]
>
> Hi Mike,
> I can't identify the issue on %s as Private->Uri is defined as
Hi Abner,
> On 26. 1. 2024., at 05:20, Nickle Wang via groups.io
> wrote:
>
> Hi Abner,
>
> Same minor issue as 1_5_0. Please add "%a:" to below DEBUG call.
>
>> + DEBUG ((DEBUG_MANAGEABILITY, " No platform Redfish ConfigureLang
>> found for %s\n", __func__, Private->Uri));
>
>
tion?
>
> Thanks
> Abner
>
> > -Original Message-
> > From: Mike Maslenkin
> > Sent: Friday, January 5, 2024 8:20 AM
> > To: devel@edk2.groups.io; Chang, Abner
> > Cc: Nickle Wang ; Igor Kulchytskyy
> > Subject: Re: [edk2-devel] [edk2-redfish-cl
r Chang
>
> Add PCD to disable ETag capability for the case Redfish
> service doesn't support ETag.
>
> Signed-off-by: Abner Chang
> Cc: Nickle Wang
> Cc: Igor Kulchytskyy
> Cc: Mike Maslenkin
> ---
> RedfishClientPkg/RedfishClientPkg.dec | 2 +
>
Variable 'Status' may be used uninitialized in this function
[-Werror=maybe-uninitialized]
Signed-off-by: Mike Maslenkin
Cc: Abner Chang
Cc: Nickle Wang
Cc: Igor Kulchytskyy
---
RedfishClientPkg/RedfishFeatureCoreDxe/RedfishFeatureCoreDxe.c | 1 +
1 file changed, 1 insertion(+)
diff --git
set it.
>
> Thanks
> Abner
>
> > -Original Message-
> > From: Mike Maslenkin
> > Sent: Monday, December 25, 2023 6:59 AM
> > To: devel@edk2.groups.io
> > Cc: Chang, Abner ; nick...@nvidia.com;
> > ig...@ami.com; Mike Maslenkin
&
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=4625
Cc: Abner Chang
Cc: Nickle Wang
Cc: Igor Kulchytskyy
Signed-off-by: Mike Maslenkin
---
.../RedfishDiscoverDxe/RedfishDiscoverDxe.c | 89 ---
1 file changed, 78 insertions(+), 11 deletions(-)
diff --git a/RedfishPkg
Cache size of ASCII string in local variable.
Cc: Nickle Wang
Cc: Igor Kulchytskyy
Signed-off-by: Mike Maslenkin
Reviewed-by: Abner Chang
---
.../RedfishDiscoverDxe/RedfishDiscoverDxe.c | 34 ---
1 file changed, 21 insertions(+), 13 deletions(-)
diff --git a/RedfishPkg
es, the IP address must be specified
in brackets, i.e. the resulting string should look like:
"http{,s}://[X::X:X:X:X]/".
Cc: Abner Chang
Cc: Nickle Wang
Cc: Igor Kulchytskyy
Signed-off-by: Mike Maslenkin
---
.../RedfishDiscoverDxe/RedfishDiscoverDxe.c | 17 +++--
This patch adds a handy helper function deallocating resources from the
EFI_REDFISH_DISCOVERED_INFORMATION structure instance.
Cc: Abner Chang
Cc: Nickle Wang
Cc: Igor Kulchytskyy
Signed-off-by: Mike Maslenkin
---
.../RedfishDiscoverDxe/RedfishDiscoverDxe.c | 68 ---
1 file
It is required to free previously allocated strings stored in
DiscoveredInstance->Information structure.
Cc: Abner Chang
Cc: Nickle Wang
Cc: Igor Kulchytskyy
Signed-off-by: Mike Maslenkin
---
RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c | 2 ++
1 file changed, 2 insertions(+)
d
Cc: Abner Chang
Cc: Nickle Wang
Cc: Igor Kulchytskyy
Signed-off-by: Mike Maslenkin
---
.../RedfishDiscoverDxe/RedfishDiscoverDxe.c | 108 --
1 file changed, 74 insertions(+), 34 deletions(-)
diff --git a/RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c
b/RedfishPkg
Cc: Nickle Wang
Cc: Igor Kulchytskyy
Cc: Pedro Falcato
Signed-off-by: Mike Maslenkin
Reviewed-by: Abner Chang
---
.../RedfishDiscoverDxe/RedfishDiscoverDxe.c | 36 +--
1 file changed, 18 insertions(+), 18 deletions(-)
diff --git a/RedfishPkg/RedfishDiscoverDxe
Cc: Nickle Wang
Signed-off-by: Mike Maslenkin
Reviewed-by: Abner Chang
---
.../RedfishPlatformHostInterfaceLib.c | 2 --
1 file changed, 2 deletions(-)
diff --git
a/EmulatorPkg/Library/RedfishPlatformHostInterfaceLib/RedfishPlatformHostInterfaceLib.c
b/EmulatorPkg
All fields of IPMI_CHANNEL_INFO_CHANNEL_NUMBER union must be
initialized to avoid error condition on BMC side.
Cc: Nickle Wang
Cc: Igor Kulchytskyy
Signed-off-by: Mike Maslenkin
Reviewed-by: Abner Chang
---
.../PlatformHostInterfaceBmcUsbNicLib.c | 8 +---
1 file
Cc: Nickle Wang
Signed-off-by: Mike Maslenkin
Reviewed-by: Abner Chang
---
EmulatorPkg/EmulatorPkg.dec | 8
.../RedfishPlatformCredentialLib.c | 12 ++--
.../RedfishPlatformCredentialLib.inf | 8
3 files
Currently there is no description for RedfishConfigHandler driver.
This leads to in the "DRIVER NAME" column of a `drivers`
command for example.
Cc: Abner Chang
Cc: Nickle Wang
Cc: Igor Kulchytskyy
Signed-off-by: Mike Maslenkin
---
.../RedfishConfigHandler/ComponentName.c
It's unclear why the new string is allocated as copy of the original
string if its pointer is stored in an array and the original string
is released immediately after the copy is created. All data allocated
in the same pool.
Cc: Nickle Wang
Cc: Igor Kulchytskyy
Signed-off-by: Mike Maslenkin
Cc: Nickle Wang
Cc: Igor Kulchytskyy
Signed-off-by: Mike Maslenkin
Reviewed-by: Abner Chang
---
RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c
b/RedfishPkg
hat also seems based on a header mentioned above.
Cc: Nickle Wang
Cc: Igor Kulchytskyy
Signed-off-by: Mike Maslenkin
Reviewed-by: Abner Chang
---
RedfishPkg/Include/Library/RedfishCrtLib.h | 45 ++
1 file changed, 11 insertions(+), 34 deletions(-)
diff --git a/Redfis
RedfishPlatformCredentialIpmiLib is the library instance name not the
class name.
Cc: Nickle Wang
Cc: Igor Kulchytskyy
Signed-off-by: Mike Maslenkin
Reviewed-by: Abner Chang
---
.../RedfishPlatformCredentialIpmiLib.inf| 2 +-
1 file changed, 1 insertion(+), 1 deletion
in the last patch
diff from v1:
fixed typo double "that that"
removed variable declaration in block scope
added patches 10-13
removed unnecessary casts
added checks for memory allocation result
Cc: Abner Chang
Cc: Nickle Wang
Cc: Igor Kulchytskyy
Signed-off-by: Mike
PlatformHostInterfaceBmcUsbNicLib is the library instance name not
the class name.
Cc: Nickle Wang
Cc: Igor Kulchytskyy
Signed-off-by: Mike Maslenkin
Reviewed-by: Abner Chang
---
.../PlatformHostInterfaceBmcUsbNicLib.inf | 2 +-
1 file changed, 1 insertion(+), 1
=maybe-uninitialized]
*Location = StrAsciiToUnicode (AsciiLocation);
Cc: Igor Kulchytskyy
Signed-off-by: Mike Maslenkin
Reviewed-by: Nickle Wang
Reviewed-by: Abner Chang
---
.../RedfishFeatureUtilityLib/RedfishFeatureUtilityLib.c| 3 ++-
1 file changed, 2 insertions(+), 1 deletion
Cc: Igor Kulchytskyy
Signed-off-by: Mike Maslenkin
Reviewed-by: Nickle Wang
Reviewed-by: Abner Chang
---
RedfishClientPkg/Features/Bios/v1_0_9/Dxe/BiosDxe.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/RedfishClientPkg/Features/Bios/v1_0_9/Dxe/BiosDxe.c
b
/64
Cc: Abner Chang
Cc: Igor Kulchytskyy
Cc: Nickle Wang
Signed-off-by: Mike Maslenkin
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#112848): https://edk2.groups.io/g/devel/message/112848
Mute This Topic: https://groups.io/mt
Kulchytskyy
Signed-off-by: Mike Maslenkin
Reviewed-by: Nickle Wang
Reviewed-by: Abner Chang
---
.../RedfishFeatureUtilityLib/RedfishFeatureUtilityLib.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git
a/RedfishClientPkg/Library/RedfishFeatureUtilityLib
Hi Abner,
On Mon, Dec 18, 2023 at 7:58 AM Chang, Abner wrote:
>
> [AMD Official Use Only - General]
>
> > -Original Message-
> > From: Mike Maslenkin
> > Sent: Friday, December 15, 2023 7:25 AM
> > To: devel@edk2.groups.io
> > Cc: Chang, Abner
that follow below format on the later patches you send; as you use the
> individual contributor copyright.
>
> Copyright (c) FIRST - LAST, Contributor
>
> Thanks
> Abner
>
> > -Original Message-
> > From: Mike Maslenkin
> > Sent: Tuesday, Dece
Hi Abner,
On Mon, Dec 18, 2023 at 7:47 AM Chang, Abner wrote:
>
> [AMD Official Use Only - General]
>
> > -Original Message-
> > From: Mike Maslenkin
> > Sent: Friday, December 15, 2023 7:25 AM
> > To: devel@edk2.groups.io
> > Cc: Chang, Abner
=maybe-uninitialized]
*Location = StrAsciiToUnicode (AsciiLocation);
Cc: Abner Chang
Cc: Igor Kulchytskyy
Signed-off-by: Mike Maslenkin
Reviewed-by: Nickle Wang
---
.../RedfishFeatureUtilityLib/RedfishFeatureUtilityLib.c| 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff
Cc: Abner Chang
Cc: Igor Kulchytskyy
Signed-off-by: Mike Maslenkin
Reviewed-by: Nickle Wang
---
RedfishClientPkg/Features/Bios/v1_0_9/Dxe/BiosDxe.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/RedfishClientPkg/Features/Bios/v1_0_9/Dxe/BiosDxe.c
b/RedfishClientPkg
This patch set contains minor fixes.
diff from v1:
original patch 4/4 with change related to BIOS resources provisioning removed.
PR: https://github.com/tianocore/edk2-redfish-client/pull/64
Cc: Abner Chang
Cc: Igor Kulchytskyy
Cc: Nickle Wang
Signed-off-by: Mike Maslenkin
Chang
Cc: Igor Kulchytskyy
Signed-off-by: Mike Maslenkin
Reviewed-by: Nickle Wang
---
.../RedfishFeatureUtilityLib/RedfishFeatureUtilityLib.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git
a/RedfishClientPkg/Library/RedfishFeatureUtilityLib/RedfishFeatureUtilityLib.c
> On 18. 12. 2023., at 03:33, Mike Maslenkin via groups.io
> wrote:
>
>
> Hi Nickle,
>
>> On 15. 12. 2023., at 04:53, Nickle Wang > <mailto:nick...@nvidia.com>> wrote:
>>
>> Hi Mike,
>>
>> Per Redfish specification 7.9 POST(c
hod is not used anywhere in RedfishClientPkg/Features/Bios
and "PUT back to instance" actually performs the PATCH.
I will drop this patch from the current PR until it becomes clear how this can
be improved.
Regards,
Mike.
>
>> -----Original Message-
>> From: Mike Maslenkin
Cc: Abner Chang
Cc: Igor Kulchytskyy
Cc: Nickle Wang
Signed-off-by: Mike Maslenkin
---
RedfishClientPkg/Features/Bios/v1_0_9/Dxe/BiosDxe.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/RedfishClientPkg/Features/Bios/v1_0_9/Dxe/BiosDxe.c
b/RedfishClientPkg/Features
=maybe-uninitialized]
*Location = StrAsciiToUnicode (AsciiLocation);
Cc: Abner Chang
Cc: Igor Kulchytskyy
Cc: Nickle Wang
Signed-off-by: Mike Maslenkin
---
.../RedfishFeatureUtilityLib/RedfishFeatureUtilityLib.c| 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git
: Nickle Wang
Signed-off-by: Mike Maslenkin
---
RedfishClientPkg/Features/Bios/v1_0_9/Common/BiosCommon.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/RedfishClientPkg/Features/Bios/v1_0_9/Common/BiosCommon.c
b/RedfishClientPkg/Features/Bios/v1_0_9/Common/BiosCommon.c
Chang
Cc: Igor Kulchytskyy
Cc: Nickle Wang
Signed-off-by: Mike Maslenkin
---
.../RedfishFeatureUtilityLib/RedfishFeatureUtilityLib.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git
a/RedfishClientPkg/Library/RedfishFeatureUtilityLib/RedfishFeatureUtilityLib.c
b
This patch set contains minor fixes and the one major change related
to BIOS resources provisioning.
PR: https://github.com/tianocore/edk2-redfish-client/pull/64
Cc: Abner Chang
Cc: Igor Kulchytskyy
Cc: Nickle Wang
Signed-off-by: Mike Maslenkin
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links
Cc: Abner Chang
Cc: Nickle Wang
Cc: Igor Kulchytskyy
Signed-off-by: Mike Maslenkin
---
.../RedfishDiscoverDxe/RedfishDiscoverDxe.c | 85 ---
1 file changed, 75 insertions(+), 10 deletions(-)
diff --git a/RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c
b/RedfishPkg
es, the IP address must be specified
in brackets, i.e. the resulting string should look like:
"http{,s}://[X::X:X:X:X]/".
Cc: Abner Chang
Cc: Nickle Wang
Cc: Igor Kulchytskyy
Signed-off-by: Mike Maslenkin
---
.../RedfishDiscoverDxe/RedfishDiscoverDxe.c | 21 ---
Cache size of ASCII string in local variable.
Cc: Abner Chang
Cc: Nickle Wang
Cc: Igor Kulchytskyy
Signed-off-by: Mike Maslenkin
---
.../RedfishDiscoverDxe/RedfishDiscoverDxe.c | 34 ---
1 file changed, 21 insertions(+), 13 deletions(-)
diff --git a/RedfishPkg
Cc: Abner Chang
Cc: Nickle Wang
Cc: Igor Kulchytskyy
Signed-off-by: Mike Maslenkin
---
.../RedfishDiscoverDxe/RedfishDiscoverDxe.c | 108 --
1 file changed, 74 insertions(+), 34 deletions(-)
diff --git a/RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c
b/RedfishPkg
Cc: Abner Chang
Cc: Nickle Wang
Cc: Igor Kulchytskyy
Cc: Pedro Falcato
Signed-off-by: Mike Maslenkin
---
.../RedfishDiscoverDxe/RedfishDiscoverDxe.c | 36 +--
1 file changed, 18 insertions(+), 18 deletions(-)
diff --git a/RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c
Cc: Abner Chang
Cc: Nickle Wang
Signed-off-by: Mike Maslenkin
---
.../RedfishPlatformHostInterfaceLib.c | 2 --
1 file changed, 2 deletions(-)
diff --git
a/EmulatorPkg/Library/RedfishPlatformHostInterfaceLib/RedfishPlatformHostInterfaceLib.c
b/EmulatorPkg/Library
Cc: Abner Chang
Cc: Nickle Wang
Signed-off-by: Mike Maslenkin
---
EmulatorPkg/EmulatorPkg.dec | 8
.../RedfishPlatformCredentialLib.c | 12 ++--
.../RedfishPlatformCredentialLib.inf | 8
3 files changed, 14
All fields of IPMI_CHANNEL_INFO_CHANNEL_NUMBER union must be
initialized to avoid error condition on BMC side.
Cc: Abner Chang
Cc: Nickle Wang
Cc: Igor Kulchytskyy
Signed-off-by: Mike Maslenkin
---
.../PlatformHostInterfaceBmcUsbNicLib.c | 8 +---
1 file changed, 5
Currently there is no description for RedfishConfigHandler driver.
This leads to in the "DRIVER NAME" column of a `drivers`
command for example.
Cc: Abner Chang
Cc: Nickle Wang
Cc: Igor Kulchytskyy
Signed-off-by: Mike Maslenkin
---
.../RedfishConfigHandler/ComponentName.c
Cc: Abner Chang
Cc: Nickle Wang
Cc: Igor Kulchytskyy
Signed-off-by: Mike Maslenkin
---
RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c
b/RedfishPkg
-by: Mike Maslenkin
---
.../RedfishPlatformConfigDxe/RedfishPlatformConfigDxe.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/RedfishPkg/RedfishPlatformConfigDxe/RedfishPlatformConfigDxe.c
b/RedfishPkg/RedfishPlatformConfigDxe/RedfishPlatformConfigDxe.c
index cbc65ba59408
PlatformHostInterfaceBmcUsbNicLib is the library instance name not
the class name.
Cc: Abner Chang
Cc: Nickle Wang
Cc: Igor Kulchytskyy
Signed-off-by: Mike Maslenkin
---
.../PlatformHostInterfaceBmcUsbNicLib.inf | 2 +-
1 file changed, 1 insertion(+), 1 deletion
RedfishPlatformCredentialIpmiLib is the library instance name not the
class name.
Cc: Abner Chang
Cc: Nickle Wang
Cc: Igor Kulchytskyy
Signed-off-by: Mike Maslenkin
---
.../RedfishPlatformCredentialIpmiLib.inf| 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff
hat also seems based on a header mentioned above.
Cc: Abner Chang
Cc: Nickle Wang
Cc: Igor Kulchytskyy
Signed-off-by: Mike Maslenkin
---
RedfishPkg/Include/Library/RedfishCrtLib.h | 45 ++
1 file changed, 11 insertions(+), 34 deletions(-)
diff --git a/RedfishPkg/Include/Librar
"that that"
removed variable declaration in block scope
added patches 10-13
removed unnecessary casts
added checks for memory allocation result
Cc: Abner Chang
Cc: Nickle Wang
Cc: Igor Kulchytskyy
Signed-off-by: Mike Maslenkin
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You r
Fair.
I'll try to make some cleanups before applying this patch after
committing Abner's remedy patch
https://github.com/tianocore/edk2/pull/5139.
Regards,
Mike..
On Wed, Dec 13, 2023 at 4:15 PM Pedro Falcato wrote:
>
> On Thu, Dec 7, 2023 at 1:24 PM Mike Maslenkin
> wrote:
&g
now the network domain the NIC is
> connected. There may have multiple subnets in the corporation
> network environment. So the subnet information provides client
> an idea when they choose the network interface, so does VLAN ID.
>
> Change-Id: Ibb38ddcd17459ad4b23fcb4fcd
Cc: Abner Chang
Cc: Nickle Wang
Signed-off-by: Mike Maslenkin
---
.../RedfishPlatformHostInterfaceLib.c | 2 --
1 file changed, 2 deletions(-)
diff --git
a/EmulatorPkg/Library/RedfishPlatformHostInterfaceLib/RedfishPlatformHostInterfaceLib.c
b/EmulatorPkg/Library
Cc: Abner Chang
Cc: Nickle Wang
Signed-off-by: Mike Maslenkin
---
EmulatorPkg/EmulatorPkg.dec | 8
.../RedfishPlatformCredentialLib.c | 12 ++--
.../RedfishPlatformCredentialLib.inf | 8
3 files changed, 14
1 - 100 of 233 matches
Mail list logo
