[edk2-devel] [edk2-platforms][PATCH v1] PurleyOpenBoardPkg: Fix Build

Adds SmmLockBox driver which is needed to build with the newest version of MinPlatformPkg Cc: Chasel Chiu Signed-off-by: Nate DeSimone --- .../Intel/PurleyOpenBoardPkg/BoardMtOlympus/OpenBoardPkg.dsc | 3 ++- .../Intel/PurleyOpenBoardPkg/BoardTiogaPass/OpenBoardPkg.dsc | 3 ++- 2 files

[edk2-devel] [edk2-platforms][PATCH v1] PurleyOpenBoardPkg: Replace Python Interpreter Name

Removes the assumption that the python interpreter will have the name python. Cc: Chasel Chiu Signed-off-by: Nate DeSimone --- .../PurleyOpenBoardPkg/BoardMtOlympus/build_board.py | 8 .../PurleyOpenBoardPkg/BoardTiogaPass/build_board.py | 10 +- 2 files changed, 9

[edk2-devel] [edk2-platforms][PATCH v1] WhitleyOpenBoardPkg: Replace Python Interpreter Name

Removes the assumption that the python interpreter will have the name python. Cc: Chasel Chiu Signed-off-by: Nate DeSimone +# Copyright (c) 2021 - 2023, Intel Corporation. All rights reserved. # Copyright (c) 2022, American Megatrends International LLC. # SPDX-License-Identifier: BSD-2

[edk2-devel] [edk2-platforms][PATCH v1] MinPlatformPkg: Remove usage of PYTHON_HOME

Removes usage PYTHON_HOME from RebaseFspBinBaseAddress.py Cc: Chasel Chiu Cc: Liming Gao Cc: Eric Dong Signed-off-by: Nate DeSimone --- .../MinPlatformPkg/Tools/Fsp/RebaseFspBinBaseAddress.py | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/Platform/Intel

Re: [edk2-devel] [PATCH v1] MinPlatformPkg: If BaseTools doesn't build, try a clean build

Pushed as 787154b -Original Message- From: devel@edk2.groups.io On Behalf Of Nate DeSimone Sent: Monday, September 25, 2023 5:47 PM To: devel@edk2.groups.io Cc: Chiu, Chasel ; Isaac Oram ; Gao, Liming ; Dong, Eric Subject: [edk2-devel] [PATCH v1] MinPlatformPkg: If BaseTools doesn't

Re: [edk2-devel] [PATCH edk2-platforms 1/1] IpmiFeaturePkg/IpmiRedirFru: Switch to AfterConsole event for callback

Use AfterConsole event instead of ReadyToBoot for callback so the driver can update SMBIOS table before booting to setup menu. Cc: Nate DeSimone Cc: Liming Gao Change-Id: Ife697f4c78449b90f17ffa7b7bc5a6a5f77d9436 Signed-off-by: Zhen Gong --- .../IpmiFeaturePkg/IpmiRedirFru/IpmiRedirFru.inf

Re: [edk2-devel] [PATCH] IntelFsp2Pkg/FspMultiPhaseLib: Remove EFIAPI for local function

Reviewed-by: Nate DeSimone -Original Message- From: Ni, Ray Sent: Sunday, November 12, 2023 11:39 PM To: devel@edk2.groups.io Cc: Chiu, Chasel ; Desimone, Nathaniel L ; Duggapu, Chinni B ; Ng, Ray Han Lim ; Zeng, Star ; Kuo, Ted ; S, Ashraf Ali ; Mohapatra, Susovan Subject: [PATCH

Re: [edk2-devel] [PATCH edk2-platforms 1/1] IpmiFeaturePkg/IpmiRedirFru: Switch to AfterConsole event for callback

Reviewed-by: Nate DeSimone -Original Message- From: Gong, Zhen Sent: Thursday, November 16, 2023 3:42 PM To: devel@edk2.groups.io Cc: Gong, Zhen ; Desimone, Nathaniel L ; Gao, Liming Subject: [PATCH edk2-platforms 1/1] IpmiFeaturePkg/IpmiRedirFru: Switch to AfterConsole event

Re: [edk2-devel] edk2-platforms: developing Whitley Lake package

Hi Alireza, The GPIO table for Wilson City is stored in this file: edk2-platforms/Platform/Intel/WhitleyOpenBoardPkg/Uba/UbaMain/TypeWilsonCityRP/Pei/GpioTable.c Note that IceLake-SP (ICX) pairs with the Lewisburg (LBG) PCH. The pin definitions for LBG come from this file:

Re: [edk2-devel] [PATCH v4 1/1] IpmiFeaturePkg/GenericIpmi: Support Standalone MM

Add Standalone Mm Generic Impi driver. And add type 'PcdsFixedAtBuild' > for PcdIpmiSmmIoBaseAddress to access in StandaloneMm driver > > Cc: Abner Chang > Cc: Nate DeSimone > Signed-off-by: Lixia Huang > --- > > Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Generic

Re: [edk2-devel] [PATCH v4 1/1] IpmiFeaturePkg/GenericIpmi: Support Standalone MM

Reviewed-by: Nate DeSimone > -Original Message- > From: Huang, Li-Xia > Sent: Monday, October 30, 2023 11:24 PM > To: devel@edk2.groups.io > Cc: Abner Chang ; Desimone, Nathaniel L > > Subject: [PATCH v4 1/1] IpmiFeaturePkg/GenericIpmi: Support Standalone > M

Re: [edk2-devel] [PATCH edk2-platforms 1/1] IpmiFeaturePkg/SmmIpmiBaseLib: Support Standalone MM.

e > Smst with Mmst. Remove unused UefiBootServicesTableLib reference. > > Cc: Abner Chang > Cc: Nate DeSimone > Cc: Liming Gao > Signed-off-by: Wei6 Xu > --- > .../Library/SmmIpmiBaseLib/SmmIpmiBaseLib.c | 17 - > .../Library/SmmIpmiBaseLib/SmmIpmiBaseLib.inf |

Re: [edk2-devel] [PATCH] IntelFsp2Pkg/PatchFv: Fix syntax issue in markdown manual

Reviewed-by: Nate DeSimone -Original Message- From: Ni, Ray Sent: Wednesday, November 1, 2023 2:30 AM To: devel@edk2.groups.io Cc: Chiu, Chasel ; Desimone, Nathaniel L ; Duggapu, Chinni B ; Ng, Ray Han Lim ; Zeng, Star ; Kuo, Ted ; S, Ashraf Ali ; Mohapatra, Susovan Subject

Re: [edk2-devel] [PATCH] IntelFsp2Pkg/SwitchStack: Reserve 32B when calling C function in 64bit

ow space" which is not reserved by the assembly caller. That causes the IDTR saved on the stack is corrupted by the C routine. The patch fixes so by reserving the 32 bytes before calling C routine. Signed-off-by: Ray Ni Cc: Chasel Chiu M: Nate DeSimone M: Duggapu Chinni B M: Ray Han Lim Ng R: Star

Re: [edk2-devel] [PATCH] IntelFsp2Pkg/SwitchStack: Reserve 32B when calling C function in 64bit

Good catch! Reviewed-by: Nate DeSimone -Original Message- From: devel@edk2.groups.io On Behalf Of Ni, Ray Sent: Tuesday, October 31, 2023 1:22 AM To: devel@edk2.groups.io Cc: Chiu, Chasel Subject: [edk2-devel] [PATCH] IntelFsp2Pkg/SwitchStack: Reserve 32B when calling C function

Re: [edk2-devel] [PATCH edk2-platforms v2 0/4] IpmiFeaturePkg: Add server management features

The series has been pushed as 0cedeab~..6d60278 -Original Message- From: devel@edk2.groups.io On Behalf Of Zhen Gong Sent: Sunday, October 29, 2023 1:28 PM To: devel@edk2.groups.io Cc: Gong, Zhen Subject: [edk2-devel] [PATCH edk2-platforms v2 0/4] IpmiFeaturePkg: Add server management

Re: [edk2-devel] [PATCH edk2-platforms v2 0/4] IpmiFeaturePkg: Add server management features

Good work Zhen! Reviewed-by: Nate DeSimone -Original Message- From: devel@edk2.groups.io On Behalf Of Zhen Gong Sent: Sunday, October 29, 2023 1:28 PM To: devel@edk2.groups.io Cc: Gong, Zhen Subject: [edk2-devel] [PATCH edk2-platforms v2 0/4] IpmiFeaturePkg: Add server management

[edk2-devel] [PATCH v1] EmulatorPkg: Update MMTimerThread() signature

the last three parameters, this issue has not been caught until now. Cc: Andrew Fish Cc: Ray Ni Cc: Michael D Kinney Signed-off-by: Nate DeSimone --- EmulatorPkg/Win/Host/WinThunk.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/EmulatorPkg/Win/Host/WinThunk.c b

[edk2-devel] [PATCH v1] EmulatorPkg: Improve comments in WinThunk.c

File description has not been updated since Nt32Pkg was merged with EmulatorPkg, and several details were no longer technically accurate. Cc: Andrew Fish Cc: Ray Ni Cc: Michael D Kinney Cc: Chasel Chiu Signed-off-by: Nate DeSimone --- EmulatorPkg/Win/Host/WinThunk.c | 19

[edk2-devel] [PATCH v2] EmulatorPkg: Add EFI_STATUS return to EMU_THUNK_PROTOCOL.SetTime()

add the EFI_STATUS return type to the protocol definition. Cc: Andrew Fish Cc: Ray Ni Cc: Michael D Kinney Cc: Chasel Chiu Signed-off-by: Nate DeSimone --- EmulatorPkg/Include/Protocol/EmuThunk.h | 5 +++-- EmulatorPkg/Unix/Host/EmuThunk.c| 4 ++-- 2 files changed, 5 insertions(+), 4 deleti

[edk2-devel] [PATCH v1] Add EFI_STATUS return to EMU_THUNK_PROTOCOL.SetTime()

add the EFI_STATUS return type to the protocol definition. Cc: Andrew Fish Cc: Ray Ni Cc: Michael D Kinney Cc: Chasel Chiu Signed-off-by: Nate DeSimone --- EmulatorPkg/Include/Protocol/EmuThunk.h | 5 +++-- EmulatorPkg/Unix/Host/EmuThunk.c| 4 ++-- 2 files changed, 5 insertions(+), 4 deleti

Re: [edk2-devel] [PATCH v1] EmulatorPkg: Fix Source Level Debug on Windows

  "cwd": > "${workspaceFolder}//Build/EmulatorX64/DEBUG_ in>/X64/", >   "environment": [], >   "console": false, >     } >   ] > } > > Make modifications to the above template as nessesary and build > Emu

Re: [edk2-devel] [PATCH v1] EmulatorPkg: Fix Terminal Issues

, Chasel > > > > Subject: [PATCH v1] EmulatorPkg: Fix Terminal Issues > > > > After running EmulatorPkg, one will notice that their terminal acts > > strangely. This is caused by the EmulatorPkg Host changing the > > terminal mode and not restoring the ori

Re: [edk2-devel] [PATCH v1] EmulatorPkg: Fix Source Level Debug on Windows

"launch", > > "program": > > > "${workspaceFolder}//Build/EmulatorX64/DEBUG_ > n>/X64/WinHost", > > "args": [], > > "stopAtEntry": false, > > "cwd": > > > &qu

Re: [edk2-devel] [PATCH v1] EmulatorPkg: Fix Terminal Issues

estoring the original mode, which is now fixed. > > Cc: Andrew Fish > Cc: Ray Ni > Cc: Michael D Kinney > Cc: Chasel Chiu > Signed-off-by: Nate DeSimone > --- > EmulatorPkg/Unix/Host/EmuThunk.c | 16 - > EmulatorPkg/Win/Host/WinThunk.c | 40 > ++

Re: [edk2-devel] [PATCH v1] EmulatorPkg: Fix Terminal Issues

ely. This is caused by the EmulatorPkg Host changing the > terminal mode and not restoring the original mode, which is now fixed. > > Cc: Andrew Fish > Cc: Ray Ni > Cc: Michael D Kinney > Cc: Chasel Chiu > Signed-off-by: Nate DeSimone > --- > EmulatorPkg/Unix/Host/

Re: [edk2-devel] [PATCH v1] EmulatorPkg: Fix Terminal Issues

ixed. > > Cc: Andrew Fish > Cc: Ray Ni > Cc: Michael D Kinney > Cc: Chasel Chiu > Signed-off-by: Nate DeSimone > --- > EmulatorPkg/Unix/Host/EmuThunk.c | 16 - > EmulatorPkg/Win/Host/WinThunk.c | 40 > +++- > 2 files ch

Re: [edk2-devel] [PATCH v1] EmulatorPkg: Fix Source Level Debug on Windows

paceFolder}//Build/EmulatorX64/DEBUG_ n>/X64/", > "environment": [], > "console": false, > } > ] > } > > Make modifications to the above template as nessesary and build > EmulatorPkg. > Now, just add breakpoints directly i

[edk2-devel] [PATCH v1] EmulatorPkg: Fix Terminal Issues

After running EmulatorPkg, one will notice that their terminal acts strangely. This is caused by the EmulatorPkg Host changing the terminal mode and not restoring the original mode, which is now fixed. Cc: Andrew Fish Cc: Ray Ni Cc: Michael D Kinney Cc: Chasel Chiu Signed-off-by: Nate

[edk2-devel] [PATCH v1] MinPlatformPkg: If BaseTools doesn't build, try a clean build

Cc: Chasel Chiu Cc: Isaac Oram Cc: Liming Gao Cc: Eric Dong Signed-off-by: Nate DeSimone --- Platform/Intel/build_bios.py | 17 - 1 file changed, 16 insertions(+), 1 deletion(-) diff --git a/Platform/Intel/build_bios.py b/Platform/Intel/build_bios.py index 9c95cfff76

[edk2-devel] [PATCH v1 1/1] Maintainers.txt: Remove Isaac Oram

Removing Isaac Oram from Maintainers.txt as he is no longer working on EDK II. Cc: Isaac Oram Cc: Chasel Chiu Cc: Michael D Kinney Signed-off-by: Nate DeSimone --- Maintainers.txt | 27 ++- 1 file changed, 14 insertions(+), 13 deletions(-) diff --git

[edk2-devel] [PATCH v1 0/1] Maintainers.txt: Remove Isaac Oram

Kinney Signed-off-by: Nate DeSimone Nathaniel L DeSimone (1): Maintainers.txt: Remove Isaac Oram Maintainers.txt | 27 ++- 1 file changed, 14 insertions(+), 13 deletions(-) -- 2.34.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group

[edk2-devel] [PATCH v1] EmulatorPkg: Fix Source Level Debug on Windows

ectly in Visual Studio Code the way you would with any other software project. When you start the debugger, it will halt at the breakpoint automatically without any extra configuration required. Cc: Andrew Fish Cc: Ray Ni Cc: Michael D Kinney Cc: Chasel Chiu Signed-off-by: Nate DeSimone ---

Re: [edk2-devel] [PATCH v2] IpmiFeaturePkg: Refine code to avoid warning report

code to avoid warning report REF:https://bugzilla.tianocore.org/show_bug.cgi?id=4522 "if (FixedPcdGet8 (PcdKcsInterfaceSupport) == 1) {" will not be executed in current code, put it within "case SysInterfaceKcs:" to avoid this issue. Cc: Isaac Oram Cc: Nate DeSimone Cc: Lim

Re: [edk2-devel] [PATCH v2] IpmiFeaturePkg: Refine code to avoid warning report

Reviewed-by: Nate DeSimone -Original Message- From: Huang, Yanbo Sent: Tuesday, September 5, 2023 7:19 PM To: devel@edk2.groups.io Cc: Huang, Yanbo ; Isaac Oram ; Desimone, Nathaniel L ; Gao, Liming Subject: [PATCH v2] IpmiFeaturePkg: Refine code to avoid warning report REF:https

Re: [edk2-devel] [PATCH 1/4] AlderlakeOpenBoardPkg/AlderlakePRvp: Add DSC and build files

for other PCD customization. * OpenBoardPkg.fdf - The AlderlakePRvp board flash file. * OpenBoardPkgBuildOption.dsc - Sets build options Based on PCD values. * FlashMapInclude.fdf - AlderlakePRvp flash map file. Cc: Sai Chaganty Cc: Nate DeSimone Cc: Rosen Chuang Signed-off-by: Saloni

Re: [edk2-devel] [PATCH v2 01/10] AlderlakeSiliconPkg/IpBlock: Add CpuPcieRp, Espi, Gpio components

] AlderlakeSiliconPkg/IpBlock: Add CpuPcieRp, Espi, Gpio components Adds the following modules: - IpBlock/CpuPcieRp/Include - IpBlock/Espi/Library - IpBlock/Gpio/IncludePrivate - IpBlock/Gpio/Library - IpBlock/Gpio/LibraryPrivate Cc: Sai Chaganty Cc: Nate DeSimone Cc: Rosen Chuang Signed-off

Re: [edk2-devel] [PATCH v2 10/10] AlderlakeSiliconPkg: Add Alderlake Product and SiPkg.dec

Acked-by: Nate DeSimone -Original Message- From: Kasbekar, Saloni Sent: Thursday, September 14, 2023 9:46 PM To: devel@edk2.groups.io Cc: Kasbekar, Saloni ; Chaganty, Rangasai V ; Desimone, Nathaniel L ; Chuang, Rosen Subject: [PATCH v2 10/10] AlderlakeSiliconPkg: Add Alderlake

Re: [edk2-devel] [PATCH v2 07/10] AlderlakeSiliconPkg/Include: Add Protocol, Register, Other Includes

Acked-by: Nate DeSimone -Original Message- From: Kasbekar, Saloni Sent: Thursday, September 14, 2023 9:46 PM To: devel@edk2.groups.io Cc: Kasbekar, Saloni ; Chaganty, Rangasai V ; Desimone, Nathaniel L ; Chuang, Rosen Subject: [PATCH v2 07/10] AlderlakeSiliconPkg/Include: Add

Re: [edk2-devel] [PATCH v2 09/10] AlderlakeSiliconPkg: Add AdlPch Fru and IncludePrivate modules

Acked-by: Nate DeSimone -Original Message- From: Kasbekar, Saloni Sent: Thursday, September 14, 2023 9:46 PM To: devel@edk2.groups.io Cc: Kasbekar, Saloni ; Chaganty, Rangasai V ; Desimone, Nathaniel L ; Chuang, Rosen Subject: [PATCH v2 09/10] AlderlakeSiliconPkg: Add AdlPch Fru

Re: [edk2-devel] [PATCH v2 08/10] AlderlakeSiliconPkg/Fru: Add AdlCpu Fru

Acked-by: Nate DeSimone -Original Message- From: Kasbekar, Saloni Sent: Thursday, September 14, 2023 9:46 PM To: devel@edk2.groups.io Cc: Kasbekar, Saloni ; Chaganty, Rangasai V ; Desimone, Nathaniel L ; Chuang, Rosen Subject: [PATCH v2 08/10] AlderlakeSiliconPkg/Fru: Add AdlCpu Fru

Re: [edk2-devel] [PATCH v2 06/10] AlderlakeSiliconPkg/Include: Add Library, Pins, Ppi Includes

Acked-by: Nate DeSimone -Original Message- From: Kasbekar, Saloni Sent: Thursday, September 14, 2023 9:46 PM To: devel@edk2.groups.io Cc: Kasbekar, Saloni ; Chaganty, Rangasai V ; Desimone, Nathaniel L ; Chuang, Rosen Subject: [PATCH v2 06/10] AlderlakeSiliconPkg/Include: Add

Re: [edk2-devel] [PATCH v2 04/10] AlderlakeSiliconPkg/IpBlock: Add Pmc, Spi components

Acked-by: Nate DeSimone -Original Message- From: Kasbekar, Saloni Sent: Thursday, September 14, 2023 9:46 PM To: devel@edk2.groups.io Cc: Kasbekar, Saloni ; Chaganty, Rangasai V ; Desimone, Nathaniel L ; Chuang, Rosen Subject: [PATCH v2 04/10] AlderlakeSiliconPkg/IpBlock: Add Pmc

Re: [edk2-devel] [PATCH v2 02/10] AlderlakeSiliconPkg/IpBlock: Add Graphics, HostBridge, PcieRp components

Acked-by: Nate DeSimone -Original Message- From: Kasbekar, Saloni Sent: Thursday, September 14, 2023 9:46 PM To: devel@edk2.groups.io Cc: Kasbekar, Saloni ; Chaganty, Rangasai V ; Desimone, Nathaniel L ; Chuang, Rosen Subject: [PATCH v2 02/10] AlderlakeSiliconPkg/IpBlock: Add

Re: [edk2-devel] [PATCH v2 03/10] AlderlakeSiliconPkg/IpBlock: Add P2sb, PchDmi components

Acked-by: Nate DeSimone -Original Message- From: Kasbekar, Saloni Sent: Thursday, September 14, 2023 9:46 PM To: devel@edk2.groups.io Cc: Kasbekar, Saloni ; Chaganty, Rangasai V ; Desimone, Nathaniel L ; Chuang, Rosen Subject: [PATCH v2 03/10] AlderlakeSiliconPkg/IpBlock: Add P2sb

Re: [edk2-devel] [PATCH v2 01/10] AlderlakeSiliconPkg/IpBlock: Add CpuPcieRp, Espi, Gpio components

Hi Saloni, For a patch series this large, please send a cover letter for it in the future. Acked-by: Nate DeSimone -Original Message- From: Kasbekar, Saloni Sent: Thursday, September 14, 2023 9:46 PM To: devel@edk2.groups.io Cc: Kasbekar, Saloni ; Chaganty, Rangasai V ; Desimone

Re: [edk2-devel] [PATCH 1/4] AlderlakeOpenBoardPkg/AlderlakePRvp: Add DSC and build files

Acked-by: Nate DeSimone -Original Message- From: Kasbekar, Saloni Sent: Wednesday, September 13, 2023 3:05 PM To: devel@edk2.groups.io Cc: Kasbekar, Saloni ; Chaganty, Rangasai V ; Desimone, Nathaniel L ; Chuang, Rosen Subject: [PATCH 1/4] AlderlakeOpenBoardPkg/AlderlakePRvp: Add

Re: [edk2-devel] [PATCH 2/4] Enable build for AlderlakeOpenBoardPkg

Acked-by: Nate DeSimone -Original Message- From: Kasbekar, Saloni Sent: Wednesday, September 13, 2023 3:06 PM To: devel@edk2.groups.io Cc: Kasbekar, Saloni ; Chaganty, Rangasai V ; Desimone, Nathaniel L ; Chuang, Rosen Subject: [PATCH 2/4] Enable build for AlderlakeOpenBoardPkg

Re: [edk2-devel] [PATCH 3/4] Readme.md: Add AlderlakeOpenBoardPkg

Acked-by: Nate DeSimone -Original Message- From: Kasbekar, Saloni Sent: Wednesday, September 13, 2023 3:06 PM To: devel@edk2.groups.io Cc: Kasbekar, Saloni ; Chaganty, Rangasai V ; Desimone, Nathaniel L ; Chuang, Rosen Subject: [PATCH 3/4] Readme.md: Add AlderlakeOpenBoardPkg Add

Re: [edk2-devel] [PATCH 4/4] Maintainers.txt: Add maintainers

Reviewed-by: Nate DeSimone -Original Message- From: Kasbekar, Saloni Sent: Wednesday, September 13, 2023 3:06 PM To: devel@edk2.groups.io Cc: Kasbekar, Saloni ; Chaganty, Rangasai V ; Desimone, Nathaniel L ; Chuang, Rosen Subject: [PATCH 4/4] Maintainers.txt: Add maintainers Add

Re: [edk2-devel] [edk2-platfoms][PATCH V1] WhitleyOpenBoardPkg :Updated PcdFlashFvSecuritySize for JunctionCity and Aowanda platform

Cc: Ramkumar Krishnamoorthi Cc: Isaac Oram Cc: Nate DeSimone Signed-off-by: Ramkumar Krishnamoorthi --- Platform/Intel/WhitleyOpenBoardPkg/Aowanda/PlatformPkg.fdf | 2 +- Platform/Intel/WhitleyOpenBoardPkg/JunctionCity/PlatformPkg.fdf | 2 +- 2 files changed, 2 insertions(+), 2

Re: [edk2-devel] [edk2-platfoms][PATCH V1] WhitleyOpenBoardPkg :Updated PcdFlashFvSecuritySize for JunctionCity and Aowanda platform

Reviewed-by: Nate DeSimone -Original Message- From: Ramkumar Krishnamoorthi Sent: Thursday, August 31, 2023 10:53 AM To: devel@edk2.groups.io Cc: DOPPALAPUDI, HARIKRISHNA ; Ponnusamy, Suresh ; KARPAGAVINAYAGAM, MANICKAVASAKAM ; Venkatesan, Selvaraj ; Ramkumar Krishnamoorthi ; Isaac

Re: [edk2-devel] [PATCH v1] MdeModulePkg: Fix memory leak in LocateHandleBuffer()

o > alignment with the original intentions of the UEFI specification > authors. > > Cc: Liming Gao > Cc: Jian J Wang > Cc: Michael D Kinney > Cc: Dandan Bi > Signed-off-by: Nate DeSimone > --- > MdeModulePkg/Core/Dxe/Hand/Locate.c | 6 +- > 1 file chang

[edk2-devel] [PATCH v1] MdeModulePkg: Fix memory leak in LocateHandleBuffer()

ion, this boils down to a fix for a memory leak that also brings the behavior of our LocateHandleBuffer() implementation into alignment with the original intentions of the UEFI specification authors. Cc: Liming Gao Cc: Jian J Wang Cc: Michael D Kinney Cc: Dandan Bi Signed-off-by: Nate DeSim

Re: [edk2-devel] Visual Studio Code extension for EDK2

Thanks Willy! I have added your extensions to my recommended list of vscode extensions: Nate's Recommended VSCode Extensions and Settings * tianocore/tianocore.github.io Wiki Best Regards,

Re: [edk2-devel] [edk2-platforms: PATCH] MinPlatformPkg: Add FSP 2.4 MultiPhase library.

io > Sent: Wednesday, August 31, 2022 11:19 AM > To: devel@edk2.groups.io > Cc: Chasel Chiu ; Nate DeSimone > ; Isaac Oram ; > Liming Gao ; Eric Dong > Subject: [edk2-devel] [edk2-platforms: PATCH] MinPlatformPkg: Add FSP 2.4 > MultiPhase library. > > FSP Wrapper has impl

Re: [edk2-devel] [PATCH] ASpeed/ASpeedGopBinPkg: Update X64/AArch Gop UEFI Driver

Reviewed-by: Nate DeSimone > -Original Message- > From: Tommy Huang > Sent: Monday, August 7, 2023 11:12 PM > To: devel@edk2.groups.io > Cc: a...@kernel.org; Oram, Isaac W ; Desimone, > Nathaniel L ; quic_llind...@quicinc.com; > Kinney, Michael D ; Chen, Ryan >

Re: [edk2-devel] [PATCH] Intel/MinPlatformPkg:Add MmSaveStateLib required by PiSmmCpuDxe

Reviewed-by: Nate DeSimone > -Original Message- > From: Tan, Dun > Sent: Wednesday, July 26, 2023 7:22 PM > To: devel@edk2.groups.io > Cc: Ni, Ray ; Chiu, Chasel ; > Desimone, Nathaniel L ; Oram, Isaac W > ; Gao, Liming ; Dong, > Eric > Subject: [PATC

Re: [edk2-devel] [PATCH v1 0/2] MdePkg: Add missing status codes

The series as been pushed as ~107ddf1..3c274c0 -Original Message- From: devel@edk2.groups.io On Behalf Of Nate DeSimone Sent: Monday, July 31, 2023 11:43 AM To: devel@edk2.groups.io Cc: Kinney, Michael D ; Gao, Liming ; Liu, Zhiguang Subject: [edk2-devel] [PATCH v1 0/2] MdePkg: Add

Re: [edk2-devel] [PATCH v1 24/24] IntelFsp2WrapperPkg: CI: Add PrEval entry

Reviewed-by: Nate DeSimone > -Original Message- > From: Joey Vagedes > Sent: Monday, June 26, 2023 2:35 PM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Desimone, Nathaniel L > ; Duggapu, Chinni B > ; Chen, Gang C ; > Zeng, Star ; Kuo, Ted ; S, Ashraf &g

Re: [edk2-devel] [PATCH v1 12/24] IntelFsp2Pkg: CI: Add PrEval entry

Reviewed-by: Nate DeSimone > -Original Message- > From: Joey Vagedes > Sent: Monday, June 26, 2023 2:34 PM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Desimone, Nathaniel L > ; Duggapu, Chinni B > ; Ng, Ray Han Lim ; > Zeng, Star ; Kuo, Ted ; S, Ashraf &g

Re: [edk2-devel] [PATCH v1 19/24] PrmPkg: CI: Add PrEval entry

Reviewed-by: Nate DeSimone > -Original Message- > From: Joey Vagedes > Sent: Monday, June 26, 2023 2:34 PM > To: devel@edk2.groups.io > Cc: Michael Kubacki ; Desimone, Nathaniel L > > Subject: [PATCH v1 19/24] PrmPkg: CI: Add PrEval entry > > Adds a Pr

Re: [edk2-devel] [PATCH] SimicsOpenBoardPkg: Set PcdDxeIplSwitchToLongMode to FALSE

Reviewed-by: Nate DeSimone -Original Message- From: Tan, Dun Sent: Wednesday, July 26, 2023 7:23 PM To: devel@edk2.groups.io Cc: Ni, Ray ; Desimone, Nathaniel L ; Zhiguang Liu Subject: [PATCH] SimicsOpenBoardPkg: Set PcdDxeIplSwitchToLongMode to FALSE Set PcdDxeIplSwitchToLongMode

Re: [edk2-devel] [PATCH] MinPlatformPkg: Remove IA32 in PeiFspWrapperPlatformLib

Reviewed-by: Nate DeSimone -Original Message- From: Hsueh, DoraX Sent: Monday, July 24, 2023 3:07 AM To: devel@edk2.groups.io Cc: Hsueh, DoraX ; Chiu, Chasel ; Desimone, Nathaniel L ; Oram, Isaac W ; Gao, Liming ; Dong, Eric ; Chaganty, Rangasai V ; Chuang, Rosen ; Kuo, Ted

[edk2-devel] [PATCH 2/2] MdePkg: Add new status codes to PrintLib

Gao Cc: Zhiguang Liu Signed-off-by: Nate DeSimone --- MdePkg/Library/BasePrintLib/PrintLibInternal.c | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/MdePkg/Library/BasePrintLib/PrintLibInternal.c b/MdePkg/Library/BasePrintLib/PrintLibInternal.c index 42b598a432

[edk2-devel] [PATCH v1 0/2] MdePkg: Add missing status codes

the follow status codes: 1. EFI_IP_ADDRESS_CONFLICT 2. EFI_HTTP_ERROR 3. EFI_WARN_FILE_SYSTEM 4. EFI_WARN_RESET_REQUIRED These missing status codes and the missing decodings have been added. Cc: Michael D Kinney Cc: Liming Gao Cc: Zhiguang Liu Signed-off-by: Nate DeSimone Nate DeSimone (2

[edk2-devel] [PATCH 1/2] MdePkg: Add missing status codes

: Michael D Kinney Cc: Liming Gao Cc: Zhiguang Liu Signed-off-by: Nate DeSimone --- MdePkg/Include/Base.h | 10 ++ MdePkg/Include/Uefi/UefiBaseType.h | 2 ++ 2 files changed, 12 insertions(+) diff --git a/MdePkg/Include/Base.h b/MdePkg/Include/Base.h index d209e6de28

Re: [edk2-devel] [edk2-platforms:PATCH v2] MinPlatformPkg: Fix SetLargeVariable fail issue

Thank you, Miki, and Xiaoqiang! Reviewed-by: Nate DeSimone From: Shindo, Miki Date: Tuesday, May 23, 2023 at 5:44 PM To: devel@edk2.groups.io Cc: Chiu, Chasel , Desimone, Nathaniel L , Gao, Liming , Dong, Eric , Zhang, Xiaoqiang Subject: [edk2-platforms:PATCH v2] MinPlatformPkg: Fix

Re: [edk2-devel] [PATCH v1] MinPlatformPkg: Fix SetLargeVariable fail issue

e new data to the remaining space before we decide that there is not enough space to store the large variable. Cc: Chasel Chiu Cc: Nate DeSimone Cc: Liming Gao Cc: Eric Dong Signed-off-by: Xiaoqiang Zhang --- Platform/Intel/MinPlatformPkg/Library/BaseLargeVariableLib/LargeVariableWriteLib.c

Re: [edk2-devel] [PATCH v4] IntelFsp2Pkg: LoadMicrocodeDefault() causing unnecessary delay.

Reviewed-by: Nate DeSimone -Original Message- From: Chiu, Chasel Sent: Monday, April 3, 2023 11:34 AM To: devel@edk2.groups.io Cc: Chiu, Chasel ; Desimone, Nathaniel L ; Zeng, Star ; Ni, Ray ; Kuo, Ted Subject: [PATCH v4] IntelFsp2Pkg: LoadMicrocodeDefault() causing unnecessary

Re: [edk2-devel] [PATCH] IntelFsp2Pkg: TempRamInit API should preserve EBX/RBX register.

Reviewed-by: Nate DeSimone -Original Message- From: Chiu, Chasel Sent: Friday, March 31, 2023 4:16 PM To: devel@edk2.groups.io Cc: Chiu, Chasel ; Desimone, Nathaniel L ; Zeng, Star Subject: [PATCH] IntelFsp2Pkg: TempRamInit API should preserve EBX/RBX register. REF: https

Re: [edk2-devel] [PATCH v3] IntelFsp2Pkg: Fix NASM X64 build warnings.

Reviewed-by: Nate DeSimone -Original Message- From: Chiu, Chasel Sent: Tuesday, March 21, 2023 5:14 PM To: devel@edk2.groups.io Cc: Chiu, Chasel ; Desimone, Nathaniel L ; Zeng, Star Subject: [PATCH v3] IntelFsp2Pkg: Fix NASM X64 build warnings. REF: https://bugzilla.tianocore.org

Re: [edk2-devel] [PATCH v2] IntelFsp2Pkg: Fix NASM X64 build warnings.

Reviewing this code in more detail... I think clearing the upper 32-bits is a bug. These functions are supposed to return pointers, and since this is X64 code those pointers could be anywhere in address space. The fact that the FSP is in XIP NEM, which on current Intel platforms just happens to

Re: [edk2-devel] [PATCH] [IntelFsp2Pkg]: Fix GCC Compiler warning

Reviewed-by: Nate DeSimone -Original Message- From: S, Ashraf Ali Sent: Thursday, March 9, 2023 8:06 AM To: devel@edk2.groups.io Cc: S, Ashraf Ali ; Chiu, Chasel ; Desimone, Nathaniel L ; Chaganty, Rangasai V ; Zeng, Star Subject: [PATCH] [IntelFsp2Pkg]: Fix GCC Compiler warning

[edk2-devel] [PATCH v1 4/6] EmulatorPkg: Add ARM support to UNIX Host App

Adds ARM implementation of the EFIAPI to UNIX ABI gasket. Adds ARM implementation of SecCore stack switch and invocation. Adds ARM compiler flags. Cc: Andrew Fish Cc: Ray Ni Cc: Michael D Kinney Cc: Chasel Chiu Signed-off-by: Nate DeSimone --- EmulatorPkg/EmulatorPkg.dsc

[edk2-devel] [PATCH v1 6/6] EmulatorPkg: Add EmuCacheMaintenanceLib

-by: Nate DeSimone --- EmulatorPkg/EmulatorPkg.dec | 4 +- EmulatorPkg/EmulatorPkg.dsc | 7 + EmulatorPkg/Include/Protocol/EmuCache.h | 217 +++ .../DxeEmuCacheMaintenanceLib.c | 337 + .../DxeEmuCacheMaintenanceLib.inf

[edk2-devel] [PATCH v1 1/6] ArmPkg: Add ArmMmuNullLib

Adds a NULL implementation of the ArmMmuLib. This is nessesary for ARM support in EmulatorPkg due to DxeIplPeim requiring an implementation of ArmMmuLib. Cc: Leif Lindholm Cc: Ard Biesheuvel Cc: Sami Mujawar Cc: Michael D Kinney Cc: Chasel Chiu Signed-off-by: Nate DeSimone --- ArmPkg

[edk2-devel] [PATCH v1 3/6] EmulatorPkg: Fix PosixFileSystem function misspellings

PosixFileSystemThunkClose Cc: Andrew Fish Cc: Ray Ni Cc: Michael D Kinney Cc: Chasel Chiu Signed-off-by: Nate DeSimone --- EmulatorPkg/Unix/Host/Gasket.h | 12 +- EmulatorPkg/Unix/Host/Ia32/Gasket.S | 31 + EmulatorPkg/Un

[edk2-devel] [PATCH v1 2/6] EmulatorPkg: Add ARM Build Target

since EbcDxe does not support the ARM architecture. Cc: Andrew Fish Cc: Ray Ni Cc: Michael D Kinney Cc: Chasel Chiu Signed-off-by: Nate DeSimone --- EmulatorPkg/EmulatorPkg.dsc | 17 ++--- EmulatorPkg/EmulatorPkg.fdf | 6 -- EmulatorPkg/build.sh| 13 - 3

[edk2-devel] [PATCH v1 5/6] EmulatorPkg: Add ARM support to EmuSec

Adds ARM implementation of EFI_PEI_TEMPORARY_RAM_SUPPORT_PPI. Cc: Andrew Fish Cc: Ray Ni Cc: Michael D Kinney Cc: Chasel Chiu Signed-off-by: Nate DeSimone --- EmulatorPkg/Sec/Arm/SwitchRam.S | 32 ++ EmulatorPkg/Sec/Arm/TempRam.c | 58

[edk2-devel] [PATCH v1 0/6] Add Raspberry Pi Support to EmulatorPkg

Cc: Ard Biesheuvel Cc: Sami Mujawar Cc: Michael D Kinney Cc: Chasel Chiu Signed-off-by: Nate DeSimone Nate DeSimone (6): ArmPkg: Add ArmMmuNullLib EmulatorPkg: Add ARM Build Target EmulatorPkg: Fix PosixFileSystem function misspellings EmulatorPkg: Add ARM support to UNIX Host App

Re: [edk2-devel] DSC nightmare

Hi Ben, On the x86 side we developed the MinPlatformPkg to help mitigate this problem. As Andrew points out the edk2 build system is extremely flexible… to the point that it can become unwieldy and difficult to get started. For that reason, our Minimum Platform

[edk2-devel] [PATCH v1] MdeModulePkg: Fix misspelling

From: Nate DeSimone confroms should be conforms. Signed-off-by: Nate DeSimone Cc: Jian J Wang Cc: Liming Gao Cc: Michael D Kinney Cc: Dandan Bi --- MdeModulePkg/Core/DxeIplPeim/Ia32/DxeLoadFunc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/MdeModulePkg/Core

[edk2-devel] [PATCH v1] EmulatorPkg: Rename Variable

From: Nate DeSimone Rename PeiCorePe32File to SecCorePe32File, because the variable actually contains the SEC core... not PEI core. Cc: Andrew Fish Cc: Ray Ni Cc: Michael D Kinney Cc: Chasel Chiu Signed-off-by: Nate DeSimone --- EmulatorPkg/Unix/Host/Host.c | 12 ++-- EmulatorPkg

[edk2-devel] [PATCH v1] EmulatorPkg: Remove Duplicate gEmuIoThunkProtocolGuid

From: Nate DeSimone Host.inf contains two redundant references to gEmuIoThunkProtocolGuid. Removing one of them as it is superfluous. Cc: Andrew Fish Cc: Ray Ni Cc: Michael D Kinney Cc: Chasel Chiu Signed-off-by: Nate DeSimone --- EmulatorPkg/Unix/Host/Host.inf | 3 +-- 1 file changed, 1

[edk2-devel] [PATCH v1] EmulatorPkg: Fix SecInterruptEnabled misspelling

From: Nate DeSimone SecInterruptEanbled should be SecInterruptEnabled Cc: Andrew Fish Cc: Ray Ni Cc: Michael D Kinney Cc: Chasel Chiu Signed-off-by: Nate DeSimone --- EmulatorPkg/Unix/Host/EmuThunk.c | 4 ++-- EmulatorPkg/Unix/Host/Host.h | 4 ++-- EmulatorPkg/Unix/Host/Pthreads.c | 4

[edk2-devel] [PATCH v1] EmulatorPkg: Fix misspelling

From: Nate DeSimone pased should be passed. Cc: Andrew Fish Cc: Ray Ni Cc: Michael D Kinney Cc: Chasel Chiu Signed-off-by: Nate DeSimone --- EmulatorPkg/Unix/Host/Host.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/EmulatorPkg/Unix/Host/Host.c b/EmulatorPkg/Unix

[edk2-devel] [PATCH v1] EmulatorPkg: Delete EMU_IO_THUNK_PROTOCO_GUID

From: Nate DeSimone Delete this macro because: 1. Nothing uses it. 2. It is misspelled. 3. It is a EDK I style GUID definition which is redundant with an existing EDK II style GUID definition. Cc: Andrew Fish Cc: Ray Ni Cc: Michael D Kinney Cc: Chasel Chiu Signed-off-by: Nate DeSimone

[edk2-devel] [PATCH v1] EmulatorPkg: Correct Comment

From: Nate DeSimone EFI_EMU_UGA_IO_PROTOCOL has been replaced by EMU_GRAPHICS_WINDOW_PROTOCOL. Cc: Andrew Fish Cc: Ray Ni Cc: Michael D Kinney Cc: Chasel Chiu Signed-off-by: Nate DeSimone --- EmulatorPkg/Unix/Host/Gasket.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff

Re: [edk2-devel][edk2-platforms][PATCH V1 0/2] Update Si support

Good work Isaac! For the series... Reviewed-by: Nate DeSimone -Original Message- From: Oram, Isaac W Sent: Thursday, January 12, 2023 3:57 PM To: devel@edk2.groups.io Cc: Oram, Isaac W ; Desimone, Nathaniel L ; Chiu, Chasel Subject: [edk2-devel][edk2-platforms][PATCH V1 0/2] Update

Re: [edk2-devel][edk2-platforms][PATCH v2] KabylakeOpenBoardPkg/I2cHdmiDebugSerialPortLib: Configurable timings

Reviewed-by: Nate DeSimone -Original Message- From: Benjamin Doron Sent: Friday, January 13, 2023 9:56 AM To: devel@edk2.groups.io Cc: Chaganty, Rangasai V ; Oram, Isaac W ; Desimone, Nathaniel L ; Chiu, Chasel Subject: [edk2-devel][edk2-platforms][PATCH v2] KabylakeOpenBoardPkg

Re: [edk2-devel][PATCH v1] IntelFsp2Pkg: Improvement of supporting null UPD pointer in FSP-T

Reviewed-by: Nate DeSimone -Original Message- From: devel@edk2.groups.io On Behalf Of Kuo, Ted Sent: Wednesday, November 9, 2022 3:31 AM To: devel@edk2.groups.io Cc: Chiu, Chasel ; Desimone, Nathaniel L ; Zeng, Star ; S, Ashraf Ali ; Duggapu, Chinni B Subject: [edk2-devel][PATCH v1

Re: [edk2-devel] [PATCH V4] MdeModulePkg: Memory Corruption Error in CapsuleRuntimeDxe

> CapsuleRuntimeDxe > > > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4112 > > > > In AllocateReservedMemoryBelow4G(), if gBS->AllocatePages() > > returns an error, and ASSERTs are disabled, then the > > function will overwrite memory fr

Re: [edk2-devel] [PATCH v2] IntelFsp2Pkg: FSP should support input UPD as NULL.

Reviewed-by: Nate DeSimone -Original Message- From: Chiu, Chasel Sent: Tuesday, November 1, 2022 10:46 PM To: devel@edk2.groups.io Cc: Chiu, Chasel ; Desimone, Nathaniel L ; Zeng, Star Subject: [PATCH v2] IntelFsp2Pkg: FSP should support input UPD as NULL. REF: https

Re: [edk2-devel] [PATCH] IntelFsp2Pkg: Update Function header to support IA32/X64.

Reviewed-by: Nate DeSimone > -Original Message- > From: Chiu, Chasel > Sent: Thursday, October 27, 2022 7:58 PM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Desimone, Nathaniel L > ; Zeng, Star > Subject: [PATCH] IntelFsp2Pkg: Update Function header to suppo

Re: [edk2-devel] [PATCH V3] MdeModulePkg: Memory Corruption Error in CapsuleRuntimeDxe

Thanks for the review Michael, I've sent a V4 patch with the added @return > From: Michael Kubacki > Sent: Tuesday, October 25, 2022 3:03 PM > To: Desimone, Nathaniel L ; > devel@edk2.groups.io > Subject: Re: [edk2-devel] [PATCH V3] MdeModulePkg: Memory Corruption Error in >

Re: [edk2-devel] [PATCH V1] MdeModulePkg: Fix spelling error in PciSioSerialDxe

Pushed: https://github.com/tianocore/edk2/commit/7464db4 > -Original Message- > From: devel@edk2.groups.io On Behalf Of Nate > DeSimone > Sent: Tuesday, October 25, 2022 2:42 PM > To: devel@edk2.groups.io > Cc: Ni, Ray ; Gao, Zhichao ; > Wang, Jian J ; Gao, Liming

[edk2-devel] [PATCH V4] MdeModulePkg: Memory Corruption Error in CapsuleRuntimeDxe

ng Cc: Michael D Kinney Signed-off-by: Nate DeSimone --- .../X64/SaveLongModeContext.c | 25 --- 1 file changed, 22 insertions(+), 3 deletions(-) diff --git a/MdeModulePkg/Universal/CapsuleRuntimeDxe/X64/SaveLongModeContext.c b/MdeModulePkg/Universal/CapsuleRunt

Re: [edk2-devel] [PATCH] IntelFsp2WrapprPkg: Check header revision for MultiPhase support.

Hi Chasel, There is a spelling error in your commit message. IntelFsp2WrapprPkg should be IntelFsp2WrapperPkg. Please fix this during the push. No need to send a 2nd review. With that change... Reviewed-by: Nate DeSimone > -Original Message- > From: Chiu, Chasel > Sent

[edk2-devel] [PATCH V1] MdeModulePkg: Fix spelling error in PciSioSerialDxe

gSerialDevTempate should be gSerialDevTemplate Cc: Ray Ni Cc: Zhichao Gao Cc: Jian J Wang Cc: Liming Gao Cc: Michael D Kinney Signed-off-by: Nate DeSimone --- MdeModulePkg/Bus/Pci/PciSioSerialDxe/Serial.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MdeModulePkg/Bus

<    1   2   3   4   5   6   7   8   9   10   >