Hi Igor,
Thanks for your idea. This sounds feasible to me. Let me try to test it on my
system.
Regards,
Nickle
> -Original Message-
> From: Igor Kulchytskyy
> Sent: Thursday, May 16, 2024 7:34 PM
> To: Nickle Wang ; Chang, Abner
> ; devel@edk2.groups.io
> Cc: Nick
Redfish design in system.
Regards,
Nickle
> -Original Message-
> From: Chang, Abner
> Sent: Thursday, May 16, 2024 10:41 AM
> To: Nickle Wang ; Igor Kulchytskyy ;
> devel@edk2.groups.io
> Cc: Nick Ramirez
> Subject: RE: [EXTERNAL] RE: [edk2-devel] [edk2-redfish-client][
nt as the signal to do the notification, since
there is not supposed to have Redfish driver running jobs after this event...
Regards,
Nickle
> -Original Message-
> From: Chang, Abner
> Sent: Thursday, May 16, 2024 9:06 AM
> To: Igor Kulchytskyy ; Nickle Wang ;
> de
Yes, this is pull request: https://github.com/tianocore/edk2/pull/5660
Thanks,
Nickle
> -Original Message-
> From: Chang, Abner
> Sent: Thursday, May 16, 2024 9:01 AM
> To: devel@edk2.groups.io; Nickle Wang
> Cc: Attar, AbdulLateef (Abdul Lateef) ; Nick
> Ramirez
&g
10:26 AM
> To: Nickle Wang ; devel@edk2.groups.io;
> abner.ch...@amd.com; Rebecca Cran
> Cc: Isaac Oram ; Attar, AbdulLateef (Abdul Lateef)
> ; Tinh Nguyen
>
> Subject: Re: [edk2-devel] [edk2-platforms][PATCH] ManageabilityPkg: add
> support for the phosphor ipmi blob transfer pro
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=4773
This change implements the blob transfer protocol used in OpenBmc
documented here: https://github.com/openbmc/phosphor-ipmi-blobs
Signed-off-by: Nick Ramirez
Co-authored-by: Nickle Wang
Cc: Abner Chang
Cc: Abdul Lateef Attar
Cc: Tinh
Add net function definitions for OEM/Non-IPMI group
request and response
Signed-off-by: Nickle Wang
Cc: Abner Chang
Cc: Abdul Lateef Attar
Cc: Nick Ramirez
---
MdePkg/Include/IndustryStandard/IpmiNetFnOem.h | 18 ++
1 file changed, 18 insertions(+)
create mode 100644 MdePkg
Of Chang, Abner
> via groups.io
> Sent: Tuesday, April 23, 2024 3:42 PM
> To: Nickle Wang ; Igor Kulchytskyy ;
> devel@edk2.groups.io
> Cc: Nick Ramirez
> Subject: Re: [edk2-devel] [edk2-redfish-client][PATCH] RedfishClientPkg:
> introduce RedfishBootstrapAccountDxe
>
is deleted at BMC, the Redfish service
instance is no longer usable. Close Redfish service instance to
release the HTTP connection between BIOS and BMC.
Signed-off-by: Nickle Wang
Cc: Abner Chang
Cc: Igor Kulchytskyy
Cc: Nick Ramirez
---
.../RedfishClientComponents.dsc.inc | 1
Hi Nhi,
This task is on my list but with lower priority. I will try to provide version
2 patch for review here by the end of this week.
Thanks,
Nickle
> -Original Message-
> From: Nhi Pham
> Sent: Monday, May 13, 2024 5:02 PM
> To: devel@edk2.groups.io; abner.ch...@amd
Upgrade Werkzeug to version 3.0.3 to address CVE-2024-34069
Signed-off-by: Nickle Wang
Cc: Abner Chang
Cc: Igor Kulchytskyy
Cc: Nick Ramirez
---
Tools/Redfish-Profile-Simulator/redfishProfileSimulator.py | 7 ---
Tools/Redfish-Profile-Simulator/requirements.txt | 6 ++
2
Rename x-uefi-redfish to x-UEFI-redfish to match the format of
UEFI configuration namespace prefix.
RFC: https://edk2.groups.io/g/rfc/message/849
Signed-off-by: Jeff Brasen
Co-authored-by: Nickle Wang
Cc: Abner Chang
Cc: Igor Kulchytskyy
Cc: Nick Ramirez
---
.../Features/Bios/v1_0_9/Common
Rename x-uefi-redfish to x-UEFI-redfish to match the format of
UEFI configuration namespace prefix.
RFC: https://edk2.groups.io/g/rfc/message/849
Signed-off-by: Jeff Brasen
Co-authored-by: Nickle Wang
Cc: Abner Chang
Cc: Igor Kulchytskyy
Cc: Nick Ramirez
---
RedfishPkg/RedfishPkg.dec
p account at BMC after
we finish Redfish jobs. And this also release the BMC account resource since
this account won't be used for a long period of time.
Regards,
Nickle
> -Original Message-
> From: Igor Kulchytskyy
> Sent: Monday, April 22, 2024 11:03 PM
> To: Chang, Ab
is deleted at BMC, the Redfish service
instance is no longer usable. Close Redfish service instance to
release the HTTP connection between BIOS and BMC.
Signed-off-by: Nickle Wang
Cc: Abner Chang
Cc: Igor Kulchytskyy
Cc: Nick Ramirez
---
.../RedfishClientComponents.dsc.inc | 1
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Chang, Abner
> via groups.io
> Sent: Wednesday, April 10, 2024 9:43 AM
> To: Nickle Wang ; devel@edk2.groups.io
> Cc: Igor Kulchytskyy ; Nick Ramirez
> Subject: Re: [edk2-devel] [edk2-redfish
Thanks for your review, Abner! I merged this change.
Regards,
Nickle
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Chang, Abner
> via groups.io
> Sent: Tuesday, April 2, 2024 1:04 PM
> To: Nickle Wang ; devel@edk2.groups.io
> Cc: Igor Kulchytskyy
&g
Private->Uri is initialized after calling SetRedfishSettingsObjectsUri()
but it is used in SetRedfishSettingsObjectsUri function. Use input
parameter "Uri" instead.
Signed-off-by: Nickle Wang
Cc: Abner Chang
Cc: Igor Kulchytskyy
---
RedfishClientPkg/Features/Bios/v1_0_9/
-Release Etag and PendingSettingUri resources.
-Update function header for GetHttpResponseEtag() and
GetHttpResponseLocation(). Caller has to release returned
memory buffer from these two functions.
-Fix typo.
Signed-off-by: Nickle Wang
Cc: Abner Chang
Cc: Igor Kulchytskyy
Cc: Nick Ramirez
Introduce SecureBoot driver to support
/redfish/v1/Systems/SYS/SecureBoot resource.
Signed-off-by: Nickle Wang
Cc: Abner Chang
Cc: Igor Kulchytskyy
Cc: Nick Ramirez
---
.../RedfishClientComponents.dsc.inc | 2 +
RedfishClientPkg/RedfishClientLibs.dsc.inc| 4
Thanks, Mike!
I merged this pull request.
Regards,
Nickle
> -Original Message-
> From: Mike Maslenkin
> Sent: Wednesday, March 27, 2024 5:19 AM
> To: Nickle Wang
> Cc: Chang, Abner ; devel@edk2.groups.io; Igor
> Kulchytskyy
> Subject: Re: [edk2-redfish-
I have tested this patch series on my system and got a lot of performance
improvements too.
Great work, Abner!
Regards,
Nickle
> -Original Message-
> From: abner.ch...@amd.com
> Sent: Tuesday, March 26, 2024 11:15 PM
> To: devel@edk2.groups.io
> Cc: Nickle Wang ; I
Reviewed-by: Nickle Wang
Regards,
Nickle
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Chang, Abner
> via groups.io
> Sent: Tuesday, March 26, 2024 11:15 PM
> To: devel@edk2.groups.io
> Cc: Abner Chang ; Igor Kulchytskyy
> Subject: [edk2
Reviewed-by: Nickle Wang
Regards,
Nickle
> -Original Message-
> From: abner.ch...@amd.com
> Sent: Tuesday, March 26, 2024 11:15 PM
> To: devel@edk2.groups.io
> Cc: Nickle Wang
> Subject: [PATCH V2 5/6] EmulatorPkg/Redfish: Use edk2 Redfish debug PCDs
>
Thanks for addressing this issue.
Reviewed-by: Nickle Wang
Regards,
Nickle
> -Original Message-
> From: abner.ch...@amd.com
> Sent: Tuesday, March 26, 2024 11:15 PM
> To: devel@edk2.groups.io
> Cc: Nickle Wang ; Igor Kulchytskyy
> Subject: [PATCH
Reviewed-by: Nickle Wang
Regards,
Nickle
> -Original Message-
> From: abner.ch...@amd.com
> Sent: Tuesday, March 26, 2024 11:15 PM
> To: devel@edk2.groups.io
> Cc: Nickle Wang ; Igor Kulchytskyy
> Subject: [PATCH V2 3/6] RedfishPkg/RedfishPlatformConfigDxe:Ad
Reviewed-by: Nickle Wang
Regards,
Nickle
> -Original Message-
> From: abner.ch...@amd.com
> Sent: Tuesday, March 26, 2024 11:15 PM
> To: devel@edk2.groups.io
> Cc: Nickle Wang ; Igor Kulchytskyy
> Subject: [PATCH V2 2/6] RedfishPkg/RedfishDebugLib: Introduce Red
Per offline discussion with Abner, this will be addressed by separated patch
since there is no function impact to performance improvements.
Reviewed-by: Nickle Wang
Regards,
Nickle
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Nickle Wang
> via groups.
ch 26, 2024 11:15 PM
> To: devel@edk2.groups.io
> Cc: Nickle Wang ; Igor Kulchytskyy
> Subject: [PATCH V2 1/6] RedfishPkg/RedfishPlatformConfigDxe: Config language
> searching optimization
>
> External email: Use caution opening links or attachments
>
>
> From: abncha
-Original Message-
> From: Chang, Abner
> Sent: Monday, March 25, 2024 10:13 AM
> To: Mike Maslenkin ; devel@edk2.groups.io
> Cc: Igor Kulchytskyy ; Nickle Wang
> Subject: RE: [edk2-redfish-client][RFC PATCH 0/3] RedfishClientPkg: fix
> GetRedpathNodeByIndex()
>
> Ex
Reviewed-by: Nickle Wang
Regards,
Nickle
> -Original Message-
> From: Mike Maslenkin
> Sent: Saturday, March 23, 2024 8:01 PM
> To: devel@edk2.groups.io
> Cc: Mike Maslenkin ; Abner Chang
> ; Igor Kulchytskyy ; Nickle Wang
>
> Subject: [edk2-redfi
Reviewed-by: Nickle Wang
Regards,
Nickle
> -Original Message-
> From: Mike Maslenkin
> Sent: Saturday, March 23, 2024 8:01 PM
> To: devel@edk2.groups.io
> Cc: Mike Maslenkin ; Abner Chang
> ; Igor Kulchytskyy ; Nickle Wang
>
> Subject: [edk2-redfi
Reviewed-by: Nickle Wang
Regards,
Nickle
> -Original Message-
> From: Mike Maslenkin
> Sent: Saturday, March 23, 2024 8:01 PM
> To: devel@edk2.groups.io
> Cc: Mike Maslenkin ; Abner Chang
> ; Igor Kulchytskyy ; Nickle Wang
>
> Subject: [edk2-redfi
Reviewed-by: Nickle Wang
Regards,
Nickle
> -Original Message-
> From: abner.ch...@amd.com
> Sent: Friday, March 22, 2024 10:41 PM
> To: devel@edk2.groups.io
> Cc: Nickle Wang ; Igor Kulchytskyy
> Subject: [edk2-redfish-client][PATCH V5 2/2] RedfishClientPkg/Fe
Thanks for working on this, Abner.
Reviewed-by: Nickle Wang
Regards,
Nickle
> -Original Message-
> From: abner.ch...@amd.com
> Sent: Friday, March 22, 2024 10:41 PM
> To: devel@edk2.groups.io
> Cc: Igor Kulchytskyy ; Nickle Wang
> Subject: [edk2-redfish-cl
age-
> From: abner.ch...@amd.com
> Sent: Friday, March 22, 2024 5:43 PM
> To: devel@edk2.groups.io
> Cc: Nickle Wang ; Igor Kulchytskyy
> Subject: [PATCH 0/5] [PATCH 0/5] Config language searching algorithm
> enhancement and the bug fixes
>
> External email: Use caution o
Introduce SecureBoot driver to support
/redfish/v1/Systems/SYS/SecureBoot resource.
Signed-off-by: Nickle Wang
Cc: Abner Chang
Cc: Igor Kulchytskyy
Cc: Nick Ramirez
---
.../RedfishClientComponents.dsc.inc | 2 +
RedfishClientPkg/RedfishClientLibs.dsc.inc| 4
-Release Etag and PendingSettingUri resources.
-Update function header for GetHttpResponseEtag() and
GetHttpResponseLocation(). Caller has to release returned
memory buffer from these two functions.
Signed-off-by: Nickle Wang
Cc: Abner Chang
Cc: Igor Kulchytskyy
Cc: Nick Ramirez
Reviewed-by: Nickle Wang
Regards,
Nickle
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Mike
> Maslenkin via groups.io
> Sent: Sunday, March 10, 2024 6:42 PM
> To: devel@edk2.groups.io
> Cc: Mike Maslenkin ; Abner Chang
> ; Igor Kulchytskyy ; Nic
Reviewed-by: Nickle Wang
Regards,
Nickle
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Mike
> Maslenkin via groups.io
> Sent: Sunday, March 10, 2024 6:42 PM
> To: devel@edk2.groups.io
> Cc: Mike Maslenkin ; Abner Chang
> ; Igor Kulchytskyy ; Nic
Reviewed-by: Nickle Wang
Regards,
Nickle
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Mike
> Maslenkin via groups.io
> Sent: Sunday, March 10, 2024 6:42 PM
> To: devel@edk2.groups.io
> Cc: Mike Maslenkin ; Abner Chang
> ; Igor Kulchytskyy ; Nic
Reviewed-by: Nickle Wang
Regards,
Nickle
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Mike
> Maslenkin via groups.io
> Sent: Sunday, March 10, 2024 6:42 PM
> To: devel@edk2.groups.io
> Cc: Mike Maslenkin ; Abner Chang
> ; Igor Kulchytskyy ; Nic
resource config2 protocol, update corresponding functions in feature
drivers.
Signed-off-by: Nickle Wang
Cc: Abner Chang
Cc: Igor Kulchytskyy
Cc: Nick Ramirez
---
.../EdkIIRedfishResourceConfigLib.inf | 4 +-
.../Library/EdkIIRedfishResourceConfigLib.h | 33
vice again. This is useful when Redfish service supports
"expand" query parameter. "Version" is added to this protocol too so
we don't create new protocol to add new parameter in the future.
Signed-off-by: Nickle Wang
Cc: Abner Chang
Cc: Igor Kulchytskyy
Cc: Nick Ramirez
---
Redfish
no Config2 protocol supported,
library will use config protocol automatically.
Pull request is created:
https://github.com/tianocore/edk2-redfish-client/pull/80
Signed-off-by: Nickle Wang
Cc: Abner Chang
Cc: Igor Kulchytskyy
Cc: Nick Ramirez
Nickle Wang (2):
RedfishClientPkg: introd
o the following functions.
>
Thanks for your comment, Abner! I update the description of "JsonText" in
version 2 patch set.
Regards,
Nickle
> -Original Message-
> From: Chang, Abner
> Sent: Wednesday, March 6, 2024 1:16 PM
> To: Nickle Wang ; devel@edk2.groups.io
&g
Because EdkIIRedfishResourceConfigLib is updated to support
Redfish resource config2 protocol, update corresponding
functions in feature drivers.
Signed-off-by: Nickle Wang
Cc: Abner Chang
Cc: Igor Kulchytskyy
Cc: Nick Ramirez
---
.../Features/Bios/v1_0_9/Common/BiosCommon.c | 14
Support Redfish resource config2 protocol in Edk2RedfishResourceConfigLib.
This library will try Redfish resource config2 protocol first. And if
there is no matching protocol found, Redfish resource config protocol will
be used.
Signed-off-by: Nickle Wang
Cc: Abner Chang
Cc: Igor Kulchytskyy
vice again. This is useful when Redfish service supports
"expand" query parameter. "Version" is added to this protocol too so
we don't create new protocol to add new parameter in the future.
Signed-off-by: Nickle Wang
Cc: Abner Chang
Cc: Igor Kulchytskyy
Cc: Nick Ramirez
---
Redfish
automatically.
Pull request is created:
https://github.com/tianocore/edk2-redfish-client/pull/80
Signed-off-by: Nickle Wang
Cc: Abner Chang
Cc: Igor Kulchytskyy
Cc: Nick Ramirez
Nickle Wang (3):
RedfishClientPkg: introduce Redfish resource config2 protocol.
RedfishClientPkg/Edk2Redf
stdarg.h and stdio.h are not used in RedfishClientPkg.
Signed-off-by: Nickle Wang
Cc: Abner Chang
Cc: Igor Kulchytskyy
---
RedfishClientPkg/PrivateInclude/Crt/stdarg.h | 14 --
RedfishClientPkg/PrivateInclude/Crt/stdio.h | 14 --
2 files changed, 28 deletions
Yes that is correct.
Regards,
Nickle
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Chang, Abner
> via groups.io
> Sent: Wednesday, March 6, 2024 1:51 PM
> To: Nickle Wang ; devel@edk2.groups.io
> Cc: Igor Kulchytskyy ; Nick Ramirez
> Subject: R
Thanks for your feedback, Igor!
I will create a patch and remove RedfishLib in RedfishClientPkg.
Regards,
Nickle
From: Igor Kulchytskyy
Sent: Wednesday, March 6, 2024 1:50 AM
To: Nickle Wang ; Mike Maslenkin
; devel@edk2.groups.io
Cc: Abner Chang
Subject: RE: [EXTERNAL] RE: [edk2-devel
.io
> Sent: Tuesday, March 5, 2024 10:27 AM
> To: Nickle Wang ; devel@edk2.groups.io
> Cc: Igor Kulchytskyy ; Nick Ramirez
> Subject: Re: [edk2-devel] [edk2-redfish-client][PATCH 0/3] introduce Redfish
> Resource Config2 protocol.
>
> External email: Use caution opening links
Because EdkIIRedfishResourceConfigLib is updated to support
Redfish resource config2 protocol, update corresponding
functions in feature drivers.
Signed-off-by: Nickle Wang
Cc: Abner Chang
Cc: Igor Kulchytskyy
Cc: Nick Ramirez
---
.../Features/Bios/v1_0_9/Common/BiosCommon.c | 14
Support Redfish resource config2 protocol in Edk2RedfishResourceConfigLib.
This library will try Redfish resource config2 protocol first. And if
there is no matching protocol found, Redfish resource config protocol will
be used.
Signed-off-by: Nickle Wang
Cc: Abner Chang
Cc: Igor Kulchytskyy
vice again. This is useful when Redfish service supports
"expand" query parameter. "Version" is added to this protocol too so
we don't create new protocol to add new parameter in the future.
Signed-off-by: Nickle Wang
Cc: Abner Chang
Cc: Igor Kulchytskyy
Cc: Nick Ramirez
---
Redfish
lient/pull/80
Signed-off-by: Nickle Wang
Cc: Abner Chang
Cc: Igor Kulchytskyy
Cc: Nick Ramirez
Nickle Wang (3):
RedfishClientPkg: introduce Redfish resource config2 protocol.
RedfishClientPkg/Edk2RedfishResourceConfigLib: support config2
protocol
RedfishClientPkg/Features: suppo
-
> From: Mike Maslenkin
> Sent: Friday, March 1, 2024 8:08 AM
> To: devel@edk2.groups.io; Nickle Wang
> Cc: Abner Chang ; Igor Kulchytskyy
> Subject: Re: [edk2-devel] [edk2-redfish-client][PATCH 00/13] use Redfish HTTP
> protocol
>
> External email: Use caution opening
Hi Laszlo,
Thanks for your reminder. I enable sendemail.thread now.
Regards,
Nickle
> -Original Message-
> From: Laszlo Ersek
> Sent: Thursday, February 29, 2024 5:04 PM
> To: devel@edk2.groups.io; Nickle Wang
> Cc: Abner Chang ; Igor Kulchytskyy
> Subject: Re:
Use EDK2 RedfishHttpLib to replace RedfishHttpCacheLib and RedfishLib
Signed-off-by: Nickle Wang
Cc: Abner Chang
Cc: Igor Kulchytskyy
---
.../MemoryCollectionDxe/MemoryCollectionDxe.inf | 3 +--
.../MemoryCollectionDxe/MemoryCollectionDxe.c | 15 ++-
2 files changed, 3
Use EDK2 RedfishHttpLib to replace RedfishHttpCacheLib and RedfishLib
Signed-off-by: Nickle Wang
Cc: Abner Chang
Cc: Igor Kulchytskyy
---
.../Features/Memory/V1_7_1/Dxe/MemoryDxe.inf | 3 +-
.../Memory/V1_7_1/Common/MemoryCommon.c | 86 ++
.../Features/Memory/V1_7_1/Dxe
Use EDK2 RedfishHttpLib to replace RedfishHttpCacheLib and RedfishLib
Signed-off-by: Nickle Wang
Cc: Abner Chang
Cc: Igor Kulchytskyy
---
.../ComputerSystemCollectionDxe.inf | 3 +--
.../ComputerSystemCollectionDxe.c | 15 ++-
2 files changed, 3
Use EDK2 RedfishHttpLib to replace RedfishHttpCacheLib and RedfishLib
Signed-off-by: Nickle Wang
Cc: Abner Chang
Cc: Igor Kulchytskyy
---
.../v1_13_0/Dxe/ComputerSystemDxe.inf | 3 +-
.../v1_5_0/Dxe/ComputerSystemDxe.inf | 3 +-
.../v1_13_0/Common/ComputerSystemCommon.c
Use EDK2 RedfishHttpLib to replace RedfishHttpCacheLib and RedfishLib
Signed-off-by: Nickle Wang
Cc: Abner Chang
Cc: Igor Kulchytskyy
---
.../BootOption/v1_0_4/Dxe/BootOptionDxe.inf | 5 +-
.../v1_0_4/Common/BootOptionCommon.c | 45 ++
.../BootOption/v1_0_4/Dxe
Use EDK2 RedfishHttpLib to replace RedfishHttpCacheLib and RedfishLib
Signed-off-by: Nickle Wang
Cc: Abner Chang
Cc: Igor Kulchytskyy
---
.../BootOptionCollectionDxe.inf | 5 ++--
.../BootOptionCollectionDxe.c | 26 ---
2 files changed, 7
Use EDK2 RedfishHttpLib to replace RedfishHttpCacheLib and RedfishLib
Signed-off-by: Nickle Wang
Cc: Abner Chang
Cc: Igor Kulchytskyy
---
.../Features/Bios/v1_0_9/Dxe/BiosDxe.inf | 3 +-
.../Features/Bios/v1_0_9/Common/BiosCommon.c | 92 +++---
.../Features/Bios/v1_0_9/Dxe
Use EDK2 RedfishHttpLib to replace RedfishHttpCacheLib and RedfishLib
Signed-off-by: Nickle Wang
Cc: Abner Chang
Cc: Igor Kulchytskyy
---
.../RedfishVersionLib/RedfishVersionLib.inf | 3 +--
.../RedfishVersionLib/RedfishVersionLib.c | 24 +++
2 files changed, 4
- Remove RedfishHttpCacheLib and use EDK2 RedfishHttpLib.
- Remove RedfishLib.
- Remove CreatePayloadToPostResource and CreatePayloadToPatchResource
because we no longer need them.
Signed-off-by: Nickle Wang
Cc: Abner Chang
Cc: Igor Kulchytskyy
---
.../RedfishFeatureUtilityLib.inf
Remove RedfishHttpCacheLib and use EDK2 RedfishHttpLib.
Signed-off-by: Nickle Wang
Cc: Abner Chang
Cc: Igor Kulchytskyy
---
.../EdkIIRedfishResourceConfigLib.inf | 2 +-
.../Include/Library/EdkIIRedfishResourceConfigLib.h | 4
Use EDK2 RedfishHttpLib to replace RedfishHttpCacheLib and RedfishLib
Signed-off-by: Nickle Wang
Cc: Abner Chang
Cc: Igor Kulchytskyy
---
RedfishClientPkg/Include/RedfishCollectionCommon.h | 3 +--
RedfishClientPkg/Include/RedfishResourceCommon.h | 3 +--
2 files changed, 2 insertions(+), 4
Remove RedfishHttpCacheLib and use EDK2 RedfishHttpLib.
Signed-off-by: Nickle Wang
Cc: Abner Chang
Cc: Igor Kulchytskyy
---
RedfishClientPkg/RedfishClientPkg.dec | 1 -
RedfishClientPkg/RedfishClientLibs.dsc.inc| 2 +-
RedfishClientPkg/RedfishClientPkg.dsc | 1
Check to see if file exists or not before running uncrustify.
The file in change list may be a deleted file.
Signed-off-by: Nickle Wang
Cc: Abner Chang
Cc: Igor Kulchytskyy
---
.github/workflows/uncrustify-check.sh | 17 +++--
1 file changed, 11 insertions(+), 6 deletions(-)
diff
in RedfishClientPkg.
I noticed that there is false alarm in uncrustify check. When there
are deleted files, uncrustiry cannot check them and trigger uncrustify
failure.
Pull request is created here for testing CI:
https://github.com/tianocore/edk2-redfish-client/pull/79
Signed-off-by: Nickle Wang
riginal Message-
> From: Mike Maslenkin
> Sent: Thursday, February 29, 2024 1:56 AM
> To: Nickle Wang
> Cc: devel@edk2.groups.io; Igor Kulchytskyy ; Abner Chang
> ; Nick Ramirez
> Subject: Re: [edk2-devel] [PATCH v2 2/6] RedfishPkg: implement Redfish HTTP
> protocol
>
&
Hi @Mike Maslenkin<mailto:mike.maslen...@gmail.com>,
May I have your reviewed-by if version 3 patch set look good to you?
Thanks,
Nickle
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Nickle Wang
> via groups.io
> Sent: Tuesday, Februar
Check and see if JSON object type is desired type before
getting its value. According to the Redfish schema, attribute
value can be null value. Add this error handling to avoid
system assertion while getting attribute value.
Signed-off-by: Nickle Wang
Cc: Abner Chang
Cc: Igor Kulchytskyy
Cc
Thanks for your confirmation, Mike!
Version 3 patch set is here: https://edk2.groups.io/g/devel/message/115985
Regards,
Nickle
> -Original Message-
> From: Mike Maslenkin
> Sent: Tuesday, February 27, 2024 8:13 AM
> To: Nickle Wang
> Cc: devel@edk2.groups.io; Igor Kulc
Thanks for your explanation, Abner.
Reviewed-by: Nickle Wang mailto:nick...@nvidia.com>>
Regards,
Nickle
From: Chang, Abner
Sent: Tuesday, February 27, 2024 8:40 AM
To: Nickle Wang ; devel@edk2.groups.io
Cc: Igor Kulchytskyy
Subject: RE: [PATCH] RedfishPkg/RestJsonStructureDxe: Refin
-Fix below compiler error reported in edk2 CI.
ERROR - Linker #2001 from JsonLib.lib(load.obj) : unresolved external
symbol __ftol2
-The file MathFtol.c is copied from IntrinsicLib in CryptoPkg.
-Add MathFtol.c to EccCheck IgnoreFiles.
Signed-off-by: Nickle Wang
Cc: Abner Chang
Cc: Igor
Remove RedfishLib and use RedfishHttpLib for debug printing
Redfish response data.
Signed-off-by: Nickle Wang
Cc: Abner Chang
Cc: Igor Kulchytskyy
Cc: Nick Ramirez
Reviewed-by: Abner Chang
Reviewed-by: Igor Kulchytskyy
---
RedfishPkg/Library/RedfishDebugLib/RedfishDebugLib.inf | 4
Redfish common structures are moved to RedfishServiceData.h. Remove
them from RedfishLib.h
Signed-off-by: Nickle Wang
Cc: Abner Chang
Cc: Igor Kulchytskyy
Cc: Nick Ramirez
Reviewed-by: Abner Chang
Reviewed-by: Igor Kulchytskyy
---
RedfishPkg/Include/Library/RedfishLib.h | 17
RedfishHttpLib is a wrapper library for Redfish feature drivers to
call Redfish HTTP Protocol easily.
Signed-off-by: Nickle Wang
Cc: Abner Chang
Cc: Igor Kulchytskyy
Cc: Nick Ramirez
Reviewed-by: Abner Chang
Reviewed-by: Igor Kulchytskyy
---
RedfishPkg/RedfishPkg.dec
implement Redfish HTTP protocol driver.
Signed-off-by: Nickle Wang
Co-authored-by: Igor Kulchytskyy
Cc: Abner Chang
Cc: Igor Kulchytskyy
Cc: Nick Ramirez
Reviewed-by: Abner Chang
Reviewed-by: Igor Kulchytskyy
---
RedfishPkg/RedfishPkg.dec |7 +-
RedfishPkg
helps BIOS Redfish to finish its job as much as possible.
- PCDs are defined to control how many times BIOS will retry the
request and how many time BIOS will wait between retries.
Signed-off-by: Nickle Wang
Co-authored-by: Igor Kulchytskyy
Cc: Abner Chang
Cc: Igor Kulchytskyy
Cc: Nick Ramirez
.
Several libraries are updated to fix build issues. Pull request is created:
https://github.com/tianocore/edk2/pull/5348
Signed-off-by: Nickle Wang
Cc: Abner Chang
Cc: Igor Kulchytskyy
Cc: Nick Ramirez
Nickle Wang (6):
RedfishPkg: introduce Redfish HTTP protocol
RedfishPkg: implement Redfish
Reviewed-by: Nickle Wang
Regards,
Nickle
> -Original Message-
> From: abner.ch...@amd.com
> Sent: Monday, February 26, 2024 12:55 PM
> To: devel@edk2.groups.io
> Cc: Nickle Wang ; Igor Kulchytskyy ;
> Mike Maslenkin
> Subject: [edk2-redfish-client][PATCH
l Message-
> From: abner.ch...@amd.com
> Sent: Monday, February 26, 2024 10:44 AM
> To: devel@edk2.groups.io
> Cc: Nickle Wang ; Igor Kulchytskyy
> Subject: [PATCH] RedfishPkg/RestJsonStructureDxe: Refine REST JSON C Structure
> DXE driver
>
> External
Thanks Mike! I merged the pull request.
Regards,
Nickle
From: M M
Sent: Friday, February 23, 2024 7:32 PM
To: Nickle Wang
Cc: devel@edk2.groups.io; Abner Chang ; Igor Kulchytskyy
Subject: Re: [edk2-devel] [edk2-redfish-client][PATCH v2 2/4] RedfishClientPkg:
refine
Nickle
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Nickle Wang
> via groups.io
> Sent: Thursday, February 22, 2024 10:14 AM
> To: Mike Maslenkin ; devel@edk2.groups.io
> Cc: Abner Chang ; Igor Kulchytskyy
> Subject: Re: [edk2-devel] [edk2-r
Thanks for catching this typo, Abner. Version 2 patch is sent.
Regards,
Nickle
> -Original Message-
> From: Chang, Abner
> Sent: Wednesday, February 21, 2024 9:52 AM
> To: Nickle Wang ; devel@edk2.groups.io
> Cc: Igor Kulchytskyy ; Nick Ramirez
> Subject: RE: [PAT
Hi Abner,
Please check v2 patch. I add the source location of MathFtol.c
Thanks,
Nickle
> -Original Message-
> From: Chang, Abner
> Sent: Wednesday, February 21, 2024 10:10 AM
> To: Nickle Wang ; devel@edk2.groups.io
> Cc: Igor Kulchytskyy ; Nick Ramirez
> Subje
Remove RedfishLib and use RedfishHttpLib for debug printing
Redfish response data.
Signed-off-by: Nickle Wang
Cc: Abner Chang
Cc: Igor Kulchytskyy
Cc: Nick Ramirez
Reviewed-by: Abner Chang
---
RedfishPkg/Library/RedfishDebugLib/RedfishDebugLib.inf | 4 ++--
RedfishPkg/Include/Library
-Fix below compiler error reported in edk2 CI.
ERROR - Linker #2001 from JsonLib.lib(load.obj) : unresolved external
symbol __ftol2
-The file MathFtol.c is copied from IntrinsicLib in CryptoPkg.
-Add MathFtol.c to EccCheck IgnoreFiles.
Signed-off-by: Nickle Wang
Cc: Abner Chang
Cc: Igor
RedfishHttpLib is a wrapper library for Redfish feature drivers to
call Redfish HTTP Protocol easily.
Signed-off-by: Nickle Wang
Cc: Abner Chang
Cc: Igor Kulchytskyy
Cc: Nick Ramirez
Reviewed-by: Abner Chang
---
RedfishPkg/RedfishPkg.dec | 5 +
RedfishPkg
implement Redfish HTTP protocol driver.
Signed-off-by: Nickle Wang
Co-authored-by: Igor Kulchytskyy
Cc: Abner Chang
Cc: Igor Kulchytskyy
Cc: Nick Ramirez
---
RedfishPkg/RedfishPkg.dec |7 +-
RedfishPkg/RedfishComponents.dsc.inc |3 +-
RedfishPkg
Redfish common structures are moved to RedfishServiceData.h. Remove
them from RedfishLib.h
Signed-off-by: Nickle Wang
Cc: Abner Chang
Cc: Igor Kulchytskyy
Cc: Nick Ramirez
Reviewed-by: Abner Chang
---
RedfishPkg/Include/Library/RedfishLib.h | 17 +
1 file changed, 1
helps BIOS Redfish to finish its job as much as possible.
- PCDs are defined to control how many times BIOS will retry the
request and how many time BIOS will wait between retries.
Signed-off-by: Nickle Wang
Co-authored-by: Igor Kulchytskyy
Cc: Abner Chang
Cc: Igor Kulchytskyy
Cc: Nick Ramirez
as best as possible.
Several libraries are updated to fix build issues. Pull request is created:
https://github.com/tianocore/edk2/pull/5348
Signed-off-by: Nickle Wang
Cc: Abner Chang
Cc: Igor Kulchytskyy
Cc: Nick Ramirez
Nickle Wang (6):
RedfishPkg: introduce Redfish HTTP protocol
Thanks for addressing my comment.
Reviewed-by: Nickle Wang
Regards,
Nickle
> -Original Message-
> From: Mike Maslenkin
> Sent: Thursday, February 22, 2024 4:06 AM
> To: devel@edk2.groups.io
> Cc: Mike Maslenkin ; Nickle Wang
> ; Abner Chang ; Igor Kulchytskyy
&
1 - 100 of 659 matches
Mail list logo
