Re: [edk2-devel] [edk2-redfish-client][PATCH] RedfishClientPkg: introduce RedfishBootstrapAccountDxe

Hi Igor, Thanks for your idea. This sounds feasible to me. Let me try to test it on my system. Regards, Nickle > -Original Message- > From: Igor Kulchytskyy > Sent: Thursday, May 16, 2024 7:34 PM > To: Nickle Wang ; Chang, Abner > ; devel@edk2.groups.io > Cc: Nick Ramirez > Subject:

Re: [edk2-devel] [edk2-redfish-client][PATCH] RedfishClientPkg: introduce RedfishBootstrapAccountDxe

> RedfishFeatureCore could be one of the Redfish clients, delete the credential > from > Redfish account service in RedfishFeatureCore lifecycle may impact other > Redfish > clients that still need the communication with Redfish service, right? When all Redfish clients are managed by

Re: [edk2-devel] [edk2-redfish-client][PATCH] RedfishClientPkg: introduce RedfishBootstrapAccountDxe

Hi Igor, Abner, > Maybe we should consider moving RedfishBootstrapAccountDxe driver to > RedfishPkg and have some register mechanism which will be used by interested > drivers to notify that they finished their job and after that > RedfishBootstrapAccountDxe driver would delete an account.

Re: [edk2-devel] [PATCH] MdePkg: Add Ipmi definitions header file for OEM net function

kle, > Do you have the corresponding PR for this? I will merge it after hard freeze. > Thanks > Abner > > > -----Original Message----- > > From: devel@edk2.groups.io On Behalf Of Nickle > > Wang via groups.io > > Sent: Wednesday, May 15, 2024 4:50 PM > >

Re: [edk2-devel] [edk2-platforms][PATCH] ManageabilityPkg: add support for the phosphor ipmi blob transfer protocol

Hi Nhi, Version 2 patch files are sent for review here: https://edk2.groups.io/g/devel/message/118914 and https://edk2.groups.io/g/devel/message/118922 For your convenience, below are two pull requests if you would like to test them. 1) https://github.com/tianocore/edk2/pull/5660 2)

[edk2-devel] [edk2-platforms][PATCH v2] ManageabilityPkg: add support for the phosphor ipmi blob transfer protocol

REF:https://bugzilla.tianocore.org/show_bug.cgi?id=4773 This change implements the blob transfer protocol used in OpenBmc documented here: https://github.com/openbmc/phosphor-ipmi-blobs Signed-off-by: Nick Ramirez Co-authored-by: Nickle Wang Cc: Abner Chang Cc: Abdul Lateef Attar Cc: Tinh

[edk2-devel] [PATCH] MdePkg: Add Ipmi definitions header file for OEM net function

Add net function definitions for OEM/Non-IPMI group request and response Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Abdul Lateef Attar Cc: Nick Ramirez --- MdePkg/Include/IndustryStandard/IpmiNetFnOem.h | 18 ++ 1 file changed, 18 insertions(+) create mode 100644

Re: [edk2-devel] [edk2-redfish-client][PATCH] RedfishClientPkg: introduce RedfishBootstrapAccountDxe

Hi Abner, > Ok, then I don't have the problem with invoking GetAuthInfo again. However, I > will suggest to add more description in GetAuthInfo function header, mention > that > we will keep the auth info in EFI variable until exist boot service. > Also, give some more descriptions on the code

[edk2-devel] [edk2-redfish-client][PATCH v2] RedfishClientPkg: introduce RedfishBootstrapAccountDxe

-Introduce RedfishBootstrapAccountDxe to delete bootstrap account from /redfish/v1/AccountService/Accounts after BIOS finished all Redfish jobs. The bootstrap account won't be available to other application. So deleting bootstrap account helps to release resource at BMC. - After bootstrap account

Re: [edk2-devel] [edk2-platforms][PATCH] ManageabilityPkg: add support for the phosphor ipmi blob transfer protocol

Hi Nhi, This task is on my list but with lower priority. I will try to provide version 2 patch for review here by the end of this week. Thanks, Nickle > -Original Message- > From: Nhi Pham > Sent: Monday, May 13, 2024 5:02 PM > To: devel@edk2.groups.io; abner.ch...@amd.com; Nickle

[edk2-devel] [edk2-redfish-client][PATCH] Tool/Redfish-Profile-Simulator: fix Werkzeug security issue

Upgrade Werkzeug to version 3.0.3 to address CVE-2024-34069 Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy Cc: Nick Ramirez --- Tools/Redfish-Profile-Simulator/redfishProfileSimulator.py | 7 --- Tools/Redfish-Profile-Simulator/requirements.txt | 6 ++ 2

[edk2-devel] [edk2-redfish-client][PATCH] RedfishClientPkg: rename x-uefi-redfish to x-UEFI-redfish

Rename x-uefi-redfish to x-UEFI-redfish to match the format of UEFI configuration namespace prefix. RFC: https://edk2.groups.io/g/rfc/message/849 Signed-off-by: Jeff Brasen Co-authored-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy Cc: Nick Ramirez ---

[edk2-devel] [PATCH] RedfishPkg: Rename x-uefi-redfish to x-UEFI-redfish

Rename x-uefi-redfish to x-UEFI-redfish to match the format of UEFI configuration namespace prefix. RFC: https://edk2.groups.io/g/rfc/message/849 Signed-off-by: Jeff Brasen Co-authored-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy Cc: Nick Ramirez --- RedfishPkg/RedfishPkg.dec

Re: [edk2-devel] [edk2-redfish-client][PATCH] RedfishClientPkg: introduce RedfishBootstrapAccountDxe

Hi Igor, Abner, Thanks for your review. Please allow me to answer your questions together. > 1. We suppose acquire the credential before we start to communicate with > Redfish. Will Redfish credential driver create another bootstrap account here > after provisioning? No, according to the

[edk2-devel] [edk2-redfish-client][PATCH] RedfishClientPkg: introduce RedfishBootstrapAccountDxe

-Introduce RedfishBootstrapAccountDxe to delete bootstrap account from /redfish/v1/AccountService/Accounts after BIOS finished all Redfish jobs. The bootstrap account won't be available to other application. So deleting bootstrap account helps to release resource at BMC. - After bootstrap account

Re: [edk2-devel] [edk2-redfish-client][PATCH v2 1/2] RedfishClientPkg/Features: support Redfish Secure Boot

Thanks for your review, Abner! The reason why I keep HPE copyright statement is because I create this feature driver by copying existing one and modifying it. Since I still leverage some functions contributed by HPE, I think I am supposed to keep HPE copyright statement. Regards, Nickle >

Re: [edk2-devel] [edk2-redfish-client][PATCH] RedfishClientPkg/Features: Variable used before being initialized

Thanks for your review, Abner! I merged this change. Regards, Nickle > -Original Message- > From: devel@edk2.groups.io On Behalf Of Chang, Abner > via groups.io > Sent: Tuesday, April 2, 2024 1:04 PM > To: Nickle Wang ; devel@edk2.groups.io > Cc: Igor Kulchytskyy > Subject: Re:

[edk2-devel] [edk2-redfish-client][PATCH] RedfishClientPkg/Features: Variable used before being initialized

Private->Uri is initialized after calling SetRedfishSettingsObjectsUri() but it is used in SetRedfishSettingsObjectsUri function. Use input parameter "Uri" instead. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy --- RedfishClientPkg/Features/Bios/v1_0_9/Dxe/BiosDxe.c

[edk2-devel] [edk2-redfish-client][PATCH v2 2/2] RedfishClientPkg/Features: release resources

-Release Etag and PendingSettingUri resources. -Update function header for GetHttpResponseEtag() and GetHttpResponseLocation(). Caller has to release returned memory buffer from these two functions. -Fix typo. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy Cc: Nick Ramirez

[edk2-devel] [edk2-redfish-client][PATCH v2 1/2] RedfishClientPkg/Features: support Redfish Secure Boot

Introduce SecureBoot driver to support /redfish/v1/Systems/SYS/SecureBoot resource. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy Cc: Nick Ramirez --- .../RedfishClientComponents.dsc.inc | 2 + RedfishClientPkg/RedfishClientLibs.dsc.inc| 4 +

Re: [edk2-devel] [edk2-redfish-client][RFC PATCH 0/3] RedfishClientPkg: fix GetRedpathNodeByIndex()

Thanks, Mike! I merged this pull request. Regards, Nickle > -Original Message- > From: Mike Maslenkin > Sent: Wednesday, March 27, 2024 5:19 AM > To: Nickle Wang > Cc: Chang, Abner ; devel@edk2.groups.io; Igor > Kulchytskyy > Subject: Re: [edk2-redfish-client][RFC PATCH 0/3]

Re: [edk2-devel] [PATCH V2 0/6] [PATCH V2 0/5] Config language searching algorithm enhancement and the bug fixes

I have tested this patch series on my system and got a lot of performance improvements too. Great work, Abner! Regards, Nickle > -Original Message- > From: abner.ch...@amd.com > Sent: Tuesday, March 26, 2024 11:15 PM > To: devel@edk2.groups.io > Cc: Nickle Wang ; Igor Kulchytskyy >

Re: [edk2-devel] [PATCH V2 6/6] RedfishPkg/RedfishPlatformConfigDxe: support menu path report

Reviewed-by: Nickle Wang Regards, Nickle > -Original Message- > From: devel@edk2.groups.io On Behalf Of Chang, Abner > via groups.io > Sent: Tuesday, March 26, 2024 11:15 PM > To: devel@edk2.groups.io > Cc: Abner Chang ; Igor Kulchytskyy > Subject: [edk2-devel] [PATCH V2 6/6]

Re: [edk2-devel] [PATCH V2 5/6] EmulatorPkg/Redfish: Use edk2 Redfish debug PCDs

Reviewed-by: Nickle Wang Regards, Nickle > -Original Message- > From: abner.ch...@amd.com > Sent: Tuesday, March 26, 2024 11:15 PM > To: devel@edk2.groups.io > Cc: Nickle Wang > Subject: [PATCH V2 5/6] EmulatorPkg/Redfish: Use edk2 Redfish debug PCDs > > External email: Use

Re: [edk2-devel] [PATCH V2 4/6] RedfishPkg/RedfishPlatformConfigDxe: HII string is deleted unexpectedly

Thanks for addressing this issue. Reviewed-by: Nickle Wang Regards, Nickle > -Original Message- > From: abner.ch...@amd.com > Sent: Tuesday, March 26, 2024 11:15 PM > To: devel@edk2.groups.io > Cc: Nickle Wang ; Igor Kulchytskyy > Subject: [PATCH V2 4/6]

Re: [edk2-devel] [PATCH V2 3/6] RedfishPkg/RedfishPlatformConfigDxe:Add RefishDebugLib support

Reviewed-by: Nickle Wang Regards, Nickle > -Original Message- > From: abner.ch...@amd.com > Sent: Tuesday, March 26, 2024 11:15 PM > To: devel@edk2.groups.io > Cc: Nickle Wang ; Igor Kulchytskyy > Subject: [PATCH V2 3/6] RedfishPkg/RedfishPlatformConfigDxe:Add > RefishDebugLib

Re: [edk2-devel] [PATCH V2 2/6] RedfishPkg/RedfishDebugLib: Introduce Redfish DEBUG macro

Reviewed-by: Nickle Wang Regards, Nickle > -Original Message- > From: abner.ch...@amd.com > Sent: Tuesday, March 26, 2024 11:15 PM > To: devel@edk2.groups.io > Cc: Nickle Wang ; Igor Kulchytskyy > Subject: [PATCH V2 2/6] RedfishPkg/RedfishDebugLib: Introduce Redfish DEBUG > macro >

Re: [edk2-devel] [PATCH V2 1/6] RedfishPkg/RedfishPlatformConfigDxe: Config language searching optimization

Per offline discussion with Abner, this will be addressed by separated patch since there is no function impact to performance improvements. Reviewed-by: Nickle Wang Regards, Nickle > -Original Message- > From: devel@edk2.groups.io On Behalf Of Nickle Wang > via groups.

Re: [edk2-devel] [PATCH V2 1/6] RedfishPkg/RedfishPlatformConfigDxe: Config language searching optimization

Hi Abner, Could we change "DescriptionStr" below to something like "XuefiString", so people don't think it is a regular English string of HII statement? > + EFI_STRING_ID Description; // String > token of this question. > + CHAR16

Re: [edk2-devel] [edk2-redfish-client][RFC PATCH 0/3] RedfishClientPkg: fix GetRedpathNodeByIndex()

Thanks for your reminder, Abner. I verify this patch series on my system, and I don't see any issue. Hi @Mike Maslenkin, please add Abner and my reviewed-by to the commit messages. And we can merge the pull request. Thanks, Nickle > -Original

Re: [edk2-devel] [edk2-redfish-client][RFC PATCH 3/3] RedfishClientPkg: fix the first node processing in GetRedpathNodeByIndex()

Reviewed-by: Nickle Wang Regards, Nickle > -Original Message- > From: Mike Maslenkin > Sent: Saturday, March 23, 2024 8:01 PM > To: devel@edk2.groups.io > Cc: Mike Maslenkin ; Abner Chang > ; Igor Kulchytskyy ; Nickle Wang > > Subject: [edk2-redfish-client][RFC PATCH 3/3]

Re: [edk2-devel] [edk2-redfish-client][RFC PATCH 2/3] RedfishClientPkg: fix the last field processing in GetRedpathNodeByIndex()

Reviewed-by: Nickle Wang Regards, Nickle > -Original Message- > From: Mike Maslenkin > Sent: Saturday, March 23, 2024 8:01 PM > To: devel@edk2.groups.io > Cc: Mike Maslenkin ; Abner Chang > ; Igor Kulchytskyy ; Nickle Wang > > Subject: [edk2-redfish-client][RFC PATCH 2/3]

Re: [edk2-devel] [edk2-redfish-client][RFC PATCH 1/3] RedfishClientPkg: fix nodes count in GetRedpathNodeByIndex()

Reviewed-by: Nickle Wang Regards, Nickle > -Original Message- > From: Mike Maslenkin > Sent: Saturday, March 23, 2024 8:01 PM > To: devel@edk2.groups.io > Cc: Mike Maslenkin ; Abner Chang > ; Igor Kulchytskyy ; Nickle Wang > > Subject: [edk2-redfish-client][RFC PATCH 1/3]

Re: [edk2-devel] [edk2-redfish-client][PATCH V5 2/2] RedfishClientPkg/FeatureDriver: Use SetRedfishSettingsObjectsUri

Reviewed-by: Nickle Wang Regards, Nickle > -Original Message- > From: abner.ch...@amd.com > Sent: Friday, March 22, 2024 10:41 PM > To: devel@edk2.groups.io > Cc: Nickle Wang ; Igor Kulchytskyy > Subject: [edk2-redfish-client][PATCH V5 2/2] RedfishClientPkg/FeatureDriver: > Use

Re: [edk2-devel] [edk2-redfish-client][PATCH V5 1/2] RedfishClientPkg: Set SettingsObject URI as the config language

Thanks for working on this, Abner. Reviewed-by: Nickle Wang Regards, Nickle > -Original Message- > From: abner.ch...@amd.com > Sent: Friday, March 22, 2024 10:41 PM > To: devel@edk2.groups.io > Cc: Igor Kulchytskyy ; Nickle Wang > Subject: [edk2-redfish-client][PATCH V5 1/2]

Re: [edk2-devel] [PATCH 0/5] [PATCH 0/5] Config language searching algorithm enhancement and the bug fixes

Thanks for working on Redfish performance improvements, Abner. Per offline discussion, I have updated this patch series to support menu path reporting for BIOS attribute registry. Please send version 2 patch series if you are ok with my modifications. Thanks, Nickle > -Original

[edk2-devel] [edk2-redfish-client][PATCH 1/2] RedfishClientPkg/Features: support Redfish Secure Boot

Introduce SecureBoot driver to support /redfish/v1/Systems/SYS/SecureBoot resource. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy Cc: Nick Ramirez --- .../RedfishClientComponents.dsc.inc | 2 + RedfishClientPkg/RedfishClientLibs.dsc.inc| 4 +

[edk2-devel] [edk2-redfish-client][PATCH 2/2] RedfishClientPkg/Features: release resources

-Release Etag and PendingSettingUri resources. -Update function header for GetHttpResponseEtag() and GetHttpResponseLocation(). Caller has to release returned memory buffer from these two functions. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy Cc: Nick Ramirez ---

Re: [edk2-devel] [PATCH 4/4][edk2-redfish-client] RedfishClientPkg: fix memory leak

Reviewed-by: Nickle Wang Regards, Nickle > -Original Message- > From: devel@edk2.groups.io On Behalf Of Mike > Maslenkin via groups.io > Sent: Sunday, March 10, 2024 6:42 PM > To: devel@edk2.groups.io > Cc: Mike Maslenkin ; Abner Chang > ; Igor Kulchytskyy ; Nickle Wang > >

Re: [edk2-devel] [PATCH 3/4][edk2-redfish-client] RedfishClientPkg: fix leak in provisioning properties functions

Reviewed-by: Nickle Wang Regards, Nickle > -Original Message- > From: devel@edk2.groups.io On Behalf Of Mike > Maslenkin via groups.io > Sent: Sunday, March 10, 2024 6:42 PM > To: devel@edk2.groups.io > Cc: Mike Maslenkin ; Abner Chang > ; Igor Kulchytskyy ; Nickle Wang > >

Re: [edk2-devel] [PATCH 2/4][edk2-redfish-client] RedfishClientPkg: fix leak in provisioning properties functions

Reviewed-by: Nickle Wang Regards, Nickle > -Original Message- > From: devel@edk2.groups.io On Behalf Of Mike > Maslenkin via groups.io > Sent: Sunday, March 10, 2024 6:42 PM > To: devel@edk2.groups.io > Cc: Mike Maslenkin ; Abner Chang > ; Igor Kulchytskyy ; Nickle Wang > >

Re: [edk2-devel] [PATCH 1/4][edk2-redfish-client] RedfishClientPkg: fix memory leak

Reviewed-by: Nickle Wang Regards, Nickle > -Original Message- > From: devel@edk2.groups.io On Behalf Of Mike > Maslenkin via groups.io > Sent: Sunday, March 10, 2024 6:42 PM > To: devel@edk2.groups.io > Cc: Mike Maslenkin ; Abner Chang > ; Igor Kulchytskyy ; Nickle Wang > >

[edk2-devel] [edk2-redfish-client][PATCH v3 2/2] RedfishClientPkg/Edk2RedfishResourceConfigLib: support config2 protocol

-Support Redfish resource config2 protocol in Edk2RedfishResourceConfigLib. This library will try Redfish resource config2 protocol first. And if there is no matching protocol found, Redfish resource config protocol will be used. -Because EdkIIRedfishResourceConfigLib is updated to support Redfish

[edk2-devel] [edk2-redfish-client][PATCH v3 1/2] RedfishClientPkg: introduce Redfish resource config2 protocol.

Introduce EDKII Redfish Resource Config2 Protocol. Comparing to Redfish Resource Config Protocol, this protocol adds new parameter called "JsonText". This allows Redfish caller driver to pass JSON context to callee. Callee save the effort of getting same data from Redfish service again. This is

[edk2-devel] [edk2-redfish-client][PATCH v3 0/2] introduce Redfish Resource Config2 protocol.

v3: merge 2/3 and 3/3 in v2 together so we don't break the build. v2: address review comment about the description of "JsonText" parameter. Introduce EDKII Redfish Resource Config2 Protocol so that caller can pass Redfish data to callee when caller uses "expand" query parameter to get multiple

Re: [edk2-devel] [edk2-redfish-client][PATCH 1/3] RedfishClientPkg: introduce Redfish resource config2 protocol.

> Can we say "The additional JSON data in ASCII string format passed to callee. > The > usage is defined between the Redfish feature driver and subordinate Redfish > resource feature driver."? Seems to me more clear about the usage. > Also apply this description to the following functions. >

[edk2-devel] [edk2-redfish-client][PATCH v2 3/3] RedfishClientPkg/Features: support config2 protocol

Because EdkIIRedfishResourceConfigLib is updated to support Redfish resource config2 protocol, update corresponding functions in feature drivers. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy Cc: Nick Ramirez --- .../Features/Bios/v1_0_9/Common/BiosCommon.c | 14

[edk2-devel] [edk2-redfish-client][PATCH v2 2/3] RedfishClientPkg/Edk2RedfishResourceConfigLib: support config2 protocol

Support Redfish resource config2 protocol in Edk2RedfishResourceConfigLib. This library will try Redfish resource config2 protocol first. And if there is no matching protocol found, Redfish resource config protocol will be used. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy

[edk2-devel] [edk2-redfish-client][PATCH v2 1/3] RedfishClientPkg: introduce Redfish resource config2 protocol.

Introduce EDKII Redfish Resource Config2 Protocol. Comparing to Redfish Resource Config Protocol, this protocol adds new parameter called "JsonText". This allows Redfish caller driver to pass JSON context to callee. Callee save the effort of getting same data from Redfish service again. This is

[edk2-devel] [edk2-redfish-client][PATCH v2 0/3] introduce Redfish Resource Config2 protocol.

v2: address review comment about the description of "JsonText" parameter. Introduce EDKII Redfish Resource Config2 Protocol so that caller can pass Redfish data to callee when caller uses "expand" query parameter to get multiple Redfish resources all together. Then, callee does not get Redfish

[edk2-devel] [edk2-redfish-client][PATCH 2/2] RedfishClientPkg: Remove unused header files.

stdarg.h and stdio.h are not used in RedfishClientPkg. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy --- RedfishClientPkg/PrivateInclude/Crt/stdarg.h | 14 -- RedfishClientPkg/PrivateInclude/Crt/stdio.h | 14 -- 2 files changed, 28 deletions(-)

Re: [edk2-devel] [edk2-redfish-client][PATCH 3/3] RedfishClientPkg/Features: support config2 protocol

Yes that is correct. Regards, Nickle > -Original Message- > From: devel@edk2.groups.io On Behalf Of Chang, Abner > via groups.io > Sent: Wednesday, March 6, 2024 1:51 PM > To: Nickle Wang ; devel@edk2.groups.io > Cc: Igor Kulchytskyy ; Nick Ramirez > Subject: Re: [edk2-devel]

Re: [edk2-devel] [edk2-redfish-client][PATCH 00/13] use Redfish HTTP protocol

h-client][PATCH 00/13] use Redfish HTTP > protocol > > External email: Use caution opening links or attachments > > > Good work, Nickle! > > On Thu, Feb 29, 2024 at 11:53 AM Nickle Wang via groups.io > mailto:nicklew=nvidia@groups.io>> wrote: >

Re: [edk2-devel] [edk2-redfish-client][PATCH 0/3] introduce Redfish Resource Config2 protocol.

Hi Abner, Per offline discussion, Redfish collection driver may use query parameter "expand" to get members data all together. And then Redfish collection driver can send these data to non-collection driver. Non-collection driver does not need to get data from BMC again and this saves time of

[edk2-devel] [edk2-redfish-client][PATCH 3/3] RedfishClientPkg/Features: support config2 protocol

Because EdkIIRedfishResourceConfigLib is updated to support Redfish resource config2 protocol, update corresponding functions in feature drivers. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy Cc: Nick Ramirez --- .../Features/Bios/v1_0_9/Common/BiosCommon.c | 14

[edk2-devel] [edk2-redfish-client][PATCH 2/3] RedfishClientPkg/Edk2RedfishResourceConfigLib: support config2 protocol

Support Redfish resource config2 protocol in Edk2RedfishResourceConfigLib. This library will try Redfish resource config2 protocol first. And if there is no matching protocol found, Redfish resource config protocol will be used. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy

[edk2-devel] [edk2-redfish-client][PATCH 1/3] RedfishClientPkg: introduce Redfish resource config2 protocol.

Introduce EDKII Redfish Resource Config2 Protocol. Comparing to Redfish Resource Config Protocol, this protocol adds new parameter called "JsonText". This allows Redfish caller driver to pass JSON context to callee. Callee save the effort of getting same data from Redfish service again. This is

[edk2-devel] [edk2-redfish-client][PATCH 0/3] introduce Redfish Resource Config2 protocol.

Introduce EDKII Redfish Resource Config2 Protocol so that caller can pass Redfish data to callee when caller uses "expand" query parameter to get multiple Redfish resources all together. Then, callee does not get Redfish resource from Redfish service again and save the communication effort

Re: [edk2-devel] [edk2-redfish-client][PATCH 00/13] use Redfish HTTP protocol

links or attachments > > > Good work, Nickle! > > On Thu, Feb 29, 2024 at 11:53 AM Nickle Wang via groups.io > mailto:nicklew=nvidia@groups.io>> wrote: > > > > Redfish HTTP protocol is introduced to edk2 RedfishPkg. Update > > RedfishClientPkg t

Re: [edk2-devel] [edk2-redfish-client][PATCH 00/13] use Redfish HTTP protocol

[edk2-devel] [edk2-redfish-client][PATCH 00/13] use Redfish HTTP > protocol > > External email: Use caution opening links or attachments > > > Hi Nickle, > > On 2/29/24 09:52, Nickle Wang via groups.io wrote: > > Redfish HTTP protocol is introduced to edk2 RedfishPkg. U

[edk2-devel] [edk2-redfish-client][PATCH 13/13] RedfishClientPkg/MemoryCollectionDxe: ues RedfishHttpLib

Use EDK2 RedfishHttpLib to replace RedfishHttpCacheLib and RedfishLib Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy --- .../MemoryCollectionDxe/MemoryCollectionDxe.inf | 3 +-- .../MemoryCollectionDxe/MemoryCollectionDxe.c | 15 ++- 2 files changed, 3

[edk2-devel] [edk2-redfish-client][PATCH 12/13] RedfishClientPkg/MemoryDxe: ues RedfishHttpLib

Use EDK2 RedfishHttpLib to replace RedfishHttpCacheLib and RedfishLib Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy --- .../Features/Memory/V1_7_1/Dxe/MemoryDxe.inf | 3 +- .../Memory/V1_7_1/Common/MemoryCommon.c | 86 ++

[edk2-devel] [edk2-redfish-client][PATCH 11/13] RedfishClientPkg/ComputerSystemCollectionDxe: ues RedfishHttpLib

Use EDK2 RedfishHttpLib to replace RedfishHttpCacheLib and RedfishLib Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy --- .../ComputerSystemCollectionDxe.inf | 3 +-- .../ComputerSystemCollectionDxe.c | 15 ++- 2 files changed, 3

[edk2-devel] [edk2-redfish-client][PATCH 10/13] RedfishClientPkg/ComputerSystemDxe: ues RedfishHttpLib

Use EDK2 RedfishHttpLib to replace RedfishHttpCacheLib and RedfishLib Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy --- .../v1_13_0/Dxe/ComputerSystemDxe.inf | 3 +- .../v1_5_0/Dxe/ComputerSystemDxe.inf | 3 +- .../v1_13_0/Common/ComputerSystemCommon.c

[edk2-devel] [edk2-redfish-client][PATCH 08/13] RedfishClientPkg/BootOptionDxe: ues RedfishHttpLib

Use EDK2 RedfishHttpLib to replace RedfishHttpCacheLib and RedfishLib Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy --- .../BootOption/v1_0_4/Dxe/BootOptionDxe.inf | 5 +- .../v1_0_4/Common/BootOptionCommon.c | 45 ++

[edk2-devel] [edk2-redfish-client][PATCH 09/13] RedfishClientPkg/BootOptionCollectionDxe: ues RedfishHttpLib

Use EDK2 RedfishHttpLib to replace RedfishHttpCacheLib and RedfishLib Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy --- .../BootOptionCollectionDxe.inf | 5 ++-- .../BootOptionCollectionDxe.c | 26 --- 2 files changed, 7

[edk2-devel] [edk2-redfish-client][PATCH 07/13] RedfishClientPkg/BiosDxe: ues RedfishHttpLib

Use EDK2 RedfishHttpLib to replace RedfishHttpCacheLib and RedfishLib Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy --- .../Features/Bios/v1_0_9/Dxe/BiosDxe.inf | 3 +- .../Features/Bios/v1_0_9/Common/BiosCommon.c | 92 +++---

[edk2-devel] [edk2-redfish-client][PATCH 06/13] RedfishClientPkg/RedfishVersionLib: ues RedfishHttpLib

Use EDK2 RedfishHttpLib to replace RedfishHttpCacheLib and RedfishLib Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy --- .../RedfishVersionLib/RedfishVersionLib.inf | 3 +-- .../RedfishVersionLib/RedfishVersionLib.c | 24 +++ 2 files changed, 4

[edk2-devel] [edk2-redfish-client][PATCH 05/13] RedfishClientPkg/RedfishFeatureUtilityLib: ues RedfishHttpLib

- Remove RedfishHttpCacheLib and use EDK2 RedfishHttpLib. - Remove RedfishLib. - Remove CreatePayloadToPostResource and CreatePayloadToPatchResource because we no longer need them. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy --- .../RedfishFeatureUtilityLib.inf

[edk2-devel] [edk2-redfish-client][PATCH 04/13] RedfishClientPkg/RedfishResourceConfigLib: ues RedfishHttpLib

Remove RedfishHttpCacheLib and use EDK2 RedfishHttpLib. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy --- .../EdkIIRedfishResourceConfigLib.inf | 2 +- .../Include/Library/EdkIIRedfishResourceConfigLib.h | 4 ++--

[edk2-devel] [edk2-redfish-client][PATCH 03/13] RedfishClientPkg: ues RedfishHttpLib

Use EDK2 RedfishHttpLib to replace RedfishHttpCacheLib and RedfishLib Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy --- RedfishClientPkg/Include/RedfishCollectionCommon.h | 3 +-- RedfishClientPkg/Include/RedfishResourceCommon.h | 3 +-- 2 files changed, 2 insertions(+), 4

[edk2-devel] [edk2-redfish-client][PATCH 02/13] RedfishClientPkg: remove RedfishHttpCacheLib

Remove RedfishHttpCacheLib and use EDK2 RedfishHttpLib. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy --- RedfishClientPkg/RedfishClientPkg.dec | 1 - RedfishClientPkg/RedfishClientLibs.dsc.inc| 2 +- RedfishClientPkg/RedfishClientPkg.dsc | 1 -

[edk2-devel] [edk2-redfish-client][PATCH 01/13] RedfishClientPkg/.github: do not run uncrustify to deleted file.

Check to see if file exists or not before running uncrustify. The file in change list may be a deleted file. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy --- .github/workflows/uncrustify-check.sh | 17 +++-- 1 file changed, 11 insertions(+), 6 deletions(-) diff

[edk2-devel] [edk2-redfish-client][PATCH 00/13] use Redfish HTTP protocol

Redfish HTTP protocol is introduced to edk2 RedfishPkg. Update RedfishClientPkg to use RedfishHttpLib. And remove the use of RedfishHttpCacheLib. I also replace several functions from RedfishLib with the function provided in RedfishHttpLib. In this way, there is no dependency on RedfishLib

Re: [edk2-devel] [PATCH v2 2/6] RedfishPkg: implement Redfish HTTP protocol

you know that patch 5 breaks edk2-redfish-client compilation (Instance > of > library class [RedfishHttpLib] is not found) But I understand these changes > are not > atomic for edk2 and edk2-redfish-client. > > Regards, > Mike. > > > > > > > > Thanks, >

Re: [edk2-devel] [PATCH v2 2/6] RedfishPkg: implement Redfish HTTP protocol

Hi @Mike Maslenkin<mailto:mike.maslen...@gmail.com>, May I have your reviewed-by if version 3 patch set look good to you? Thanks, Nickle > -Original Message- > From: devel@edk2.groups.io On Behalf Of Nickle Wang > via groups.io > Sent: Tuesday, Februar

[edk2-devel] [edk2-redfish-client][PATCH] RedfishClientPkg/ConverterLib: check JSON value type

Check and see if JSON object type is desired type before getting its value. According to the Redfish schema, attribute value can be null value. Add this error handling to avoid system assertion while getting attribute value. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy Cc:

Re: [edk2-devel] [PATCH v2 2/6] RedfishPkg: implement Redfish HTTP protocol

Thanks for your confirmation, Mike! Version 3 patch set is here: https://edk2.groups.io/g/devel/message/115985 Regards, Nickle > -Original Message- > From: Mike Maslenkin > Sent: Tuesday, February 27, 2024 8:13 AM > To: Nickle Wang > Cc: devel@edk2.groups.io; Igor Kulchytskyy ; Abner

Re: [edk2-devel] [PATCH] RedfishPkg/RestJsonStructureDxe: Refine REST JSON C Structure DXE driver

Thanks for your explanation, Abner. Reviewed-by: Nickle Wang mailto:nick...@nvidia.com>> Regards, Nickle From: Chang, Abner Sent: Tuesday, February 27, 2024 8:40 AM To: Nickle Wang ; devel@edk2.groups.io Cc: Igor Kulchytskyy Subject: RE: [PATCH] RedfishPkg/RestJsonStructureDxe: Refine REST

[edk2-devel] [PATCH v3 6/6] RedfishPkg/RedfishCrtLib: fix unresolved external symbol issue

-Fix below compiler error reported in edk2 CI. ERROR - Linker #2001 from JsonLib.lib(load.obj) : unresolved external symbol __ftol2 -The file MathFtol.c is copied from IntrinsicLib in CryptoPkg. -Add MathFtol.c to EccCheck IgnoreFiles. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor

[edk2-devel] [PATCH v3 5/6] RedfishPkg/RedfishDebugLib: use RedfishHttpLib

Remove RedfishLib and use RedfishHttpLib for debug printing Redfish response data. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy Cc: Nick Ramirez Reviewed-by: Abner Chang Reviewed-by: Igor Kulchytskyy --- RedfishPkg/Library/RedfishDebugLib/RedfishDebugLib.inf | 4 ++--

[edk2-devel] [PATCH v3 4/6] RedfishPkg/RedfishLib: include RedfishServiceData.h

Redfish common structures are moved to RedfishServiceData.h. Remove them from RedfishLib.h Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy Cc: Nick Ramirez Reviewed-by: Abner Chang Reviewed-by: Igor Kulchytskyy --- RedfishPkg/Include/Library/RedfishLib.h | 17

[edk2-devel] [PATCH v3 3/6] RedfishPkg: introduce RedfishHttpLib

RedfishHttpLib is a wrapper library for Redfish feature drivers to call Redfish HTTP Protocol easily. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy Cc: Nick Ramirez Reviewed-by: Abner Chang Reviewed-by: Igor Kulchytskyy --- RedfishPkg/RedfishPkg.dec |

[edk2-devel] [PATCH v3 2/6] RedfishPkg: implement Redfish HTTP protocol

implement Redfish HTTP protocol driver. Signed-off-by: Nickle Wang Co-authored-by: Igor Kulchytskyy Cc: Abner Chang Cc: Igor Kulchytskyy Cc: Nick Ramirez Reviewed-by: Abner Chang Reviewed-by: Igor Kulchytskyy --- RedfishPkg/RedfishPkg.dec |7 +-

[edk2-devel] [PATCH v3 1/6] RedfishPkg: introduce Redfish HTTP protocol

Introduce Redfish HTTP protocol to improve Redfish performance and communication stability between BIOS and Redfish service. - Feature drivers often query same Redfish resource multiple times for different purpose. Implement HTTP cache mechanism to improve HTTP GET performance. "UseCache"

[edk2-devel] [PATCH v3 0/6] Introduce Redfish http protocol

v3: address review comments. 1) handle the condition while memory allocation failure happens to HTTP headers. Make sure that HTTP headers can be released properly while calling HttpFreeHeaderFields(). 2) Create macro ASCII_STR_DUPLICATE() to copy ASCII string. 3) Fix typos. v2: address review

Re: [edk2-devel] [edk2-redfish-client][PATCH] edk2-Redfish-client: Clarify HTTP method used for provisioning

Reviewed-by: Nickle Wang Regards, Nickle > -Original Message- > From: abner.ch...@amd.com > Sent: Monday, February 26, 2024 12:55 PM > To: devel@edk2.groups.io > Cc: Nickle Wang ; Igor Kulchytskyy ; > Mike Maslenkin > Subject: [edk2-redfish-client][PATCH] edk2-Redfish-client:

Re: [edk2-devel] [PATCH] RedfishPkg/RestJsonStructureDxe: Refine REST JSON C Structure DXE driver

Hi @abner.ch...@amd.com, RestJsonStructureDxe is a driver in RedfishPkg. May I know why we can not have dependency to RedfishPkg? Do we need to move it to MdeModulePkg for this goal (removing dependency to RedfishPkg)? Regards, Nickle > -Original

Re: [edk2-devel] [edk2-redfish-client][PATCH v2 2/4] RedfishClientPkg: refine RedfishExternalResourceResourceFeatureCallback

vel@edk2.groups.io<mailto:devel@edk2.groups.io> > mailto:devel@edk2.groups.io>> On Behalf Of Nickle Wang > via groups.io<http://groups.io/> > Sent: Thursday, February 22, 2024 10:14 AM > To: Mike Maslenkin > mailto:mike.maslen...@gmail.com>>; > devel@e

Re: [edk2-devel] [edk2-redfish-client][PATCH v2 2/4] RedfishClientPkg: refine RedfishExternalResourceResourceFeatureCallback

Nickle > -Original Message- > From: devel@edk2.groups.io On Behalf Of Nickle Wang > via groups.io > Sent: Thursday, February 22, 2024 10:14 AM > To: Mike Maslenkin ; devel@edk2.groups.io > Cc: Abner Chang ; Igor Kulchytskyy > Subject: Re: [edk2-devel] [edk2-r

Re: [edk2-devel] [PATCH 2/6] RedfishPkg: implement Redfish HTTP protocol

Thanks for catching this typo, Abner. Version 2 patch is sent. Regards, Nickle > -Original Message- > From: Chang, Abner > Sent: Wednesday, February 21, 2024 9:52 AM > To: Nickle Wang ; devel@edk2.groups.io > Cc: Igor Kulchytskyy ; Nick Ramirez > Subject: RE: [PATCH 2/6] RedfishPkg:

Re: [edk2-devel] [PATCH 6/6] RedfishPkg/RedfishCrtLib: fix unresolved external symbol issue

Hi Abner, Please check v2 patch. I add the source location of MathFtol.c Thanks, Nickle > -Original Message- > From: Chang, Abner > Sent: Wednesday, February 21, 2024 10:10 AM > To: Nickle Wang ; devel@edk2.groups.io > Cc: Igor Kulchytskyy ; Nick Ramirez > Subject: RE: [PATCH 6/6]

[edk2-devel] [PATCH v2 5/6] RedfishPkg/RedfishDebugLib: use RedfishHttpLib

Remove RedfishLib and use RedfishHttpLib for debug printing Redfish response data. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy Cc: Nick Ramirez Reviewed-by: Abner Chang --- RedfishPkg/Library/RedfishDebugLib/RedfishDebugLib.inf | 4 ++--

[edk2-devel] [PATCH v2 6/6] RedfishPkg/RedfishCrtLib: fix unresolved external symbol issue

-Fix below compiler error reported in edk2 CI. ERROR - Linker #2001 from JsonLib.lib(load.obj) : unresolved external symbol __ftol2 -The file MathFtol.c is copied from IntrinsicLib in CryptoPkg. -Add MathFtol.c to EccCheck IgnoreFiles. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor

[edk2-devel] [PATCH v2 3/6] RedfishPkg: introduce RedfishHttpLib

RedfishHttpLib is a wrapper library for Redfish feature drivers to call Redfish HTTP Protocol easily. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy Cc: Nick Ramirez Reviewed-by: Abner Chang --- RedfishPkg/RedfishPkg.dec | 5 +

[edk2-devel] [PATCH v2 2/6] RedfishPkg: implement Redfish HTTP protocol

implement Redfish HTTP protocol driver. Signed-off-by: Nickle Wang Co-authored-by: Igor Kulchytskyy Cc: Abner Chang Cc: Igor Kulchytskyy Cc: Nick Ramirez --- RedfishPkg/RedfishPkg.dec |7 +- RedfishPkg/RedfishComponents.dsc.inc |3 +-

[edk2-devel] [PATCH v2 4/6] RedfishPkg/RedfishLib: include RedfishServiceData.h

Redfish common structures are moved to RedfishServiceData.h. Remove them from RedfishLib.h Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy Cc: Nick Ramirez Reviewed-by: Abner Chang --- RedfishPkg/Include/Library/RedfishLib.h | 17 + 1 file changed, 1

[edk2-devel] [PATCH v2 1/6] RedfishPkg: introduce Redfish HTTP protocol

Introduce Redfish HTTP protocol to improve Redfish performance and communication stability between BIOS and Redfish service. - Feature drivers often query same Redfish resource multiple times for different purpose. Implement HTTP cache mechanism to improve HTTP GET performance. "UseCache"

[edk2-devel] [PATCH v2 0/6] Introduce Redfish http protocol

v2: address review comments. 1) add comment to show the source file of MathFtol.c 2) update macro to follow file name in RedfishHttpOperation.h This patch series introduce Redfish HTTP protocol to RedfishPkg. This is to improve Redfish performance and communication stability between BIOS and

Re: [edk2-devel] [edk2-redfish-client][PATCH v2 2/4] RedfishClientPkg: refine RedfishExternalResourceResourceFeatureCallback

Thanks for addressing my comment. Reviewed-by: Nickle Wang Regards, Nickle > -Original Message- > From: Mike Maslenkin > Sent: Thursday, February 22, 2024 4:06 AM > To: devel@edk2.groups.io > Cc: Mike Maslenkin ; Nickle Wang > ; Abner Chang ; Igor Kulchytskyy > > Subject:

  1   2   3   4   5   6   >