[edk2-devel] [PATCH v2 1/1] MdeModulePkg: Warn if out of space when writing variables

2024-05-10 Thread Oliver Steffen
: Liming Gao Cc: Michael D Kinney Cc: Zhiguang Liu Signed-off-by: Oliver Steffen Reviewed-by: Laszlo Ersek Reviewed-by: Gerd Hoffmann --- MdeModulePkg/Universal/Variable/RuntimeDxe/Variable.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/MdeModulePkg/Universal/Variable/RuntimeDxe/Variable.c

[edk2-devel] [PATCH v2 0/1] MdeModulePkg: Warn if out of space when writing variables

2024-05-10 Thread Oliver Steffen
ull/5435 Changes since v1: - Mention "variable space" instead of "flash space" - Emit DEBUG_ERROR instead of DEBUG_WARN Cc: Liming Gao Cc: Michael D Kinney Cc: Zhiguang Liu Oliver Steffen (1): MdeModulePkg: Warn if out of space when writing variables MdeModulePkg/Univer

[edk2-devel] [PATCH v2 0/1] MdeModulePkg: Warn if out of space when writing variables

2024-05-10 Thread Oliver Steffen
ull/5435 Changes since v1: - Mention "variable space" instead of "flash space" - Emit DEBUG_ERROR instead of DEBUG_WARN Cc: Liming Gao Cc: Michael D Kinney Cc: Zhiguang Liu Oliver Steffen (1): MdeModulePkg: Warn if out of space when writing variables MdeModulePkg/Univer

[edk2-devel] [PATCH v2 1/1] MdeModulePkg: Warn if out of space when writing variables

2024-04-15 Thread Oliver Steffen
Feng Cc: Gerd Hoffmann Cc: Jiewen Yao Cc: Laszlo Ersek Cc: Liming Gao Cc: Rahul Kumar Cc: Rebecca Cran Cc: Yuwei Chen Signed-off-by: Oliver Steffen Reviewed-by: Laszlo Ersek --- MdeModulePkg/Universal/Variable/RuntimeDxe/Variable.c | 2 ++ 1 file changed, 2 insertions(+) diff --git

[edk2-devel] [PATCH v2 0/1] MdeModulePkg: Warn if out of space when writing variables

2024-04-15 Thread Oliver Steffen
ull/5435 Changes since v1: - Mention "variable space" instead of "flash space" - Emit DEBUG_ERROR instead of DEBUG_WARN Cc: Bob Feng Cc: Gerd Hoffmann Cc: Jiewen Yao Cc: Laszlo Ersek Cc: Liming Gao Cc: Rahul Kumar Cc: Rebecca Cran Cc: Yuwei Chen Oliver Steffen (1): Md

Re: 回复: [edk2-devel] [PATCH v1 1/1] MdeModulePkg: Warn if out of flash space when writing variables

2024-03-05 Thread Oliver Steffen
s, Oliver > > Thanks > > Liming > >> -\u90ae\u4ef6\u539f\u4ef6- > >> \u53d1\u4ef6\u4eba: devel@edk2.groups.io > >> \u4ee3\u8868 Oliver Steffen > >> \u53d1\u9001\u65f6\u95f4: 2024\u5e743\u67084\u65e5 23:18 > >> \u6536\u4ef6\u4eba: de

[edk2-devel] [PATCH v1 0/1] MdeModulePkg: Warn if out of flash space when writing variables

2024-03-04 Thread Oliver Steffen
; 0) PR: https://github.com/tianocore/edk2/pull/5435 Cc: Bob Feng Cc: Gerd Hoffmann Cc: Laszlo Ersek Cc: Liming Gao Cc: Rebecca Cran Cc: Yuwei Chen Oliver Steffen (1): MdeModulePkg: Warn if out of flash space when writing variables MdeModulePkg/Universal/Variable/RuntimeDxe/Variable.c

[edk2-devel] [PATCH v1 1/1] MdeModulePkg: Warn if out of flash space when writing variables

2024-03-04 Thread Oliver Steffen
Cc: Gerd Hoffmann Cc: Laszlo Ersek Cc: Liming Gao Cc: Rebecca Cran Cc: Yuwei Chen Signed-off-by: Oliver Steffen --- MdeModulePkg/Universal/Variable/RuntimeDxe/Variable.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/MdeModulePkg/Universal/Variable/RuntimeDxe/Variable.c b

[edk2-devel] CI: GCC13 and lcov problem

2024-02-28 Thread Oliver Steffen
Hi, I am working on switching the Linux CI jobs over to the Fedora 39 image which comes with gcc 13. Unfortunately, some jobs fail due to some error related to lcov / geninfo, see below. Does anybody know from the top of the head what this is about / what to do? PR:

Re: [edk2-devel] [PATCH v2 1/1] OvmfPkg:Add variable store is full debug info

2023-09-07 Thread Oliver Steffen
bleSpace = 0x3FF9C - CommonVariableTotalSize = 0x3FF98 > > > > Synchronous Exception at 0x00023CA60374 > > .. > > ASSERT_EFI_ERROR (Status = Out of Resources) > > ASSERT /builddir/build/BUILD/edk2-ba91d0292e59/OvmfPkg/Library/ > > PlatformBootManage

Re: [edk2-devel] [PATCH v1 0/4] Use Qemu 8 in CI and enable SMP in tests

2023-08-04 Thread Oliver Steffen
On Fri, Aug 4, 2023 at 3:17 PM Ard Biesheuvel wrote: > > On Thu, 3 Aug 2023 at 23:25, Ard Biesheuvel wrote: > > > > On Thu, 3 Aug 2023 at 21:21, Kinney, Michael D > > wrote: > > > > > > Hi Ard, > > > > > > This is the email with the analysis and the flag > > > setting required for SMP to work

Re: [edk2-devel] [PATCH v1 0/4] Use Qemu 8 in CI and enable SMP in tests

2023-08-03 Thread Oliver Steffen
On Thu, Aug 3, 2023 at 3:51 PM Laszlo Ersek wrote: > > On 8/3/23 15:03, Ard Biesheuvel wrote: > > On Thu, 3 Aug 2023 at 13:44, Oliver Steffen wrote: > >> > >> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4324 > >> PR: https://github.com/tianoco

[edk2-devel] [PATCH v1 4/4] CI: Increase time limit of "Run to shell" task to 4 minutes

2023-08-03 Thread Oliver Steffen
The current job time limit of 2 minutes is just a little bit too short for running Qemu in SMP mode. Signed-off-by: Oliver Steffen --- .azurepipelines/templates/platform-build-run-steps.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.azurepipelines/templates/platform

[edk2-devel] [PATCH v1 3/4] OvmfPkg/PlatformCI: Boot OVMF in SMP mode.

2023-08-03 Thread Oliver Steffen
://bugzilla.tianocore.org/show_bug.cgi?id=4324 Signed-off-by: Oliver Steffen --- OvmfPkg/PlatformCI/PlatformBuildLib.py | 1 + 1 file changed, 1 insertion(+) diff --git a/OvmfPkg/PlatformCI/PlatformBuildLib.py b/OvmfPkg/PlatformCI/PlatformBuildLib.py index c8e805c56616..bca36d0bd758 100644 --- a/OvmfPkg/PlatformCI

[edk2-devel] [PATCH v1 2/4] OvmfPkg/PlatformCI VS2019: Disable workaround for cpuhp bugfix

2023-08-03 Thread Oliver Steffen
This reverts commit 3beb8c965455f4c1cc3184e36c627ef1d9bfe5f9. Both Windows and Linux CI jobs are now using Qemu 8, this workaround is no longer needed. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4324 Signed-off-by: Oliver Steffen --- .../PlatformCI/.azurepipelines/Windows-VS2019.yml

[edk2-devel] [PATCH v1 1/4] OvmfPkg/PlatformCI: Use recent Qemu on Windows

2023-08-03 Thread Oliver Steffen
Bump the version of the Qemu chocolatey package up to 2023.7.25. The Linux CI is already using Qemu 8. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4324 Signed-off-by: Oliver Steffen --- OvmfPkg/PlatformCI/.azurepipelines/Windows-VS2019.yml | 2 +- 1 file changed, 1 insertion(+), 1

[edk2-devel] [PATCH v1 0/4] Use Qemu 8 in CI and enable SMP in tests

2023-08-03 Thread Oliver Steffen
n SMP mode and sometimes hit the time limit of 2 minutes, thus this limit is increased to 4 minutes. Together with 81cb0371f9db ("CI: Use latest image for Linux jobs (Qemu 8, gcc 12)" this series is sufficient to close Bug 4324. Gerd Hoffmann (1): OvmfPkg/PlatformCI: Boot OVMF in SMP mode

Re: [edk2-devel] [PATCH v2 0/1] CI: Use latest image for Linux jobs (Qemu 8, gcc 12)

2023-06-26 Thread Oliver Steffen
ichael > > On 6/22/2023 7:37 AM, Oliver Steffen wrote: > > Use the latest Linux container image (from 2023-05-30). > > It uses Qemu 8.0.0 and gcc 12. > > > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4324 > > PR: https://github.com/tianocore/edk2/pull/4460

[edk2-devel] [PATCH v2 1/1] CI: Use latest image for Linux jobs (Qemu 8, gcc 12)

2023-06-22 Thread Oliver Steffen
Use the latest Linux container image (from 2023-05-30). It uses Qemu 8.0.0 and gcc 12. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4324 Signed-off-by: Oliver Steffen Acked-by: Ard Biesheuvel Reviewed-by: Michael Kubacki --- .azurepipelines/templates/defaults.yml | 2 +- 1 file

[edk2-devel] [PATCH v2 0/1] CI: Use latest image for Linux jobs (Qemu 8, gcc 12)

2023-06-22 Thread Oliver Steffen
Use the latest Linux container image (from 2023-05-30). It uses Qemu 8.0.0 and gcc 12. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4324 PR: https://github.com/tianocore/edk2/pull/4460 v2: - Collect RBs and Acks - Rerun CI with current master branch v1: - intial version Oliver Steffen

[edk2-devel] [PATCH 1/1] ArmPkg: Add Pcd to disable EFI_MEMORY_ATTRIBUTE_PROTOCOL

2023-06-19 Thread Oliver Steffen
the return code of the protocol installation calls. Signed-off-by: Oliver Steffen --- PR: https://github.com/tianocore/edk2/pull/4560 --- ArmPkg/ArmPkg.dec| 3 +++ ArmPkg/Drivers/CpuDxe/CpuDxe.inf | 1 + ArmPkg/Drivers/CpuDxe/CpuDxe.c | 13 +++-- 3 files changed, 15

[edk2-devel] [PATCH 1/1] CI: Use latest image for Linux jobs (Qemu 8, gcc 12)

2023-06-01 Thread Oliver Steffen
Use the latest Linux container image (from 2023-05-30). It uses Qemu 8.0.0 and gcc 12. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4324 Signed-off-by: Oliver Steffen --- PR: https://github.com/tianocore/edk2/pull/4460 --- .azurepipelines/templates/defaults.yml | 2 +- 1 file changed

Re: [edk2-devel] [PATCH v2 1/1] OvmfPkg/QemuFlashFvbServicesRuntimeDxe: refine flash detection

2023-06-01 Thread Oliver Steffen
Quoting Gerd Hoffmann (2023-06-01 08:08:03) > Flash can be write-protected in qemu (which is usually the case for > code). In case the variable store flash block is configured read-only > ovmf wouldn't be able to store EFI variables there, so not setting up > fvb in that case (and fallhack to

Re: [edk2-devel] [PATCH v2 2/2] ArmVirtPkg/ArmVirtQemu: Avoid early ID map on ThunderX

2023-05-20 Thread Oliver Steffen
Quoting Ard Biesheuvel (2023-05-19 23:36:53) > On Fri, 19 May 2023 at 18:32, Oliver Steffen wrote: > > > > > > Hi all, > > > > I had another look at this and I can now reproduce the issue consistently, > > with a quite minimal setup, on recent Linux

Re: [edk2-devel] [PATCH v2 2/2] ArmVirtPkg/ArmVirtQemu: Avoid early ID map on ThunderX

2023-05-19 Thread Oliver Steffen
Quoting Oliver Steffen (2023-03-02 14:29:43) > On Thu, Mar 2, 2023 at 11:50 AM Ard Biesheuvel <[1]a...@kernel.org> wrote: > > On Thu, 9 Feb 2023 at 16:15, Ard Biesheuvel <[2]a...@kernel.org> wrote: > > > > On Tue, 7 Feb 2023 at 13:58, Oliver Steffen <

Re: [edk2-devel] [PATCH v2 2/2] .azurepipelines: Choose container that have installed lcov

2023-05-03 Thread Oliver Steffen
We could also switch to Fedora 37, while we are already at it. See: https://edk2.groups.io/g/devel/message/102947 But this patch looks fine to me. Reviewed-by: Oliver Steffen Quoting gua@intel.com (2023-04-27 02:34:16) > From: Gua Guo > > Azure should install code coverage t

Re: [edk2-devel] [PATCH v3 3/3] .azurepipelines: Switch linux image default to Fedora-37

2023-05-03 Thread Oliver Steffen
Note that this also switches GCC to version 12 for all architectures. Reviewed-By: Oliver Steffen Quoting gua@intel.com (2023-04-27 07:09:20) > From: Gua Guo > > Switch default linux build image from Fedora-35 to Fedora-37 > > Cc: Michael D Kinney > Cc: Sean Brogan >

[edk2-devel] [PATCH v4 2/2] ArmVirtPkg: allow setting Firmware Version from build command line

2023-04-14 Thread Oliver Steffen
RMWARE_VER is actually defined. This allows specifying the firmware version string on the build command line with -D FIRMARE_VER=... Signed-off-by: Oliver Steffen Reviewed-by: Sami Mujawar --- ArmVirtPkg/ArmVirt.dsc.inc | 4 ArmVirtPkg/ArmVirtXen.dsc | 1 - 2 files changed, 4 insertions(+),

[edk2-devel] [PATCH v4 1/2] OvmfPkg: allow setting Firmware Version from build command line

2023-04-14 Thread Oliver Steffen
ld command line with -D FIRMARE_VER=... Introduce a common include file to be used in the .dsc files for the different OVMF flavors, and add the changes there. (ArmVirtPkg already has such a file). Signed-off-by: Oliver Steffen --- OvmfPkg/Include/Dsc/OvmfPkg.dsc.inc | 9 + OvmfPkg/O

[edk2-devel] [PATCH v4 0/2] Set Firmware Version from build command line

2023-04-14 Thread Oliver Steffen
.groups.io/g/devel/message/95208 v1: https://edk2.groups.io/g/devel/message/95057 Oliver Steffen (2): OvmfPkg: allow setting Firmware Version from build command line ArmVirtPkg: allow setting Firmware Version from build command line ArmVirtPkg/ArmVirt.dsc.inc | 4 OvmfPkg/Include/Dsc

[edk2-devel] [PATCH v3 2/2] ArmVirtPkg: allow setting Firmware Version from build command line

2023-04-13 Thread Oliver Steffen
RMWARE_VER is actually defined. This allows specifying the firmware version string on the build command line with -D FIRMARE_VER=... Signed-off-by: Oliver Steffen Reviewed-by: Sami Mujawar --- ArmVirtPkg/ArmVirt.dsc.inc | 4 ArmVirtPkg/ArmVirtXen.dsc | 1 - 2 files changed, 4 insertions(+),

[edk2-devel] [PATCH v3 1/2] OvmfPkg: allow setting Firmware Version from build command line

2023-04-13 Thread Oliver Steffen
ld command line with -D FIRMARE_VER=... Introduce a common include file to be used in the .dsc files for the different OVMF flavors, and add the changes there. (ArmVirtPkg already has such a file). Signed-off-by: Oliver Steffen --- OvmfPkg/Include/Dsc/OvmfPkg.dsc.inc | 9 + OvmfPkg/O

[edk2-devel] [PATCH v3 0/2] Set Firmware Version from build command line

2023-04-13 Thread Oliver Steffen
/edk2/pull/4268 v3: - Introduce common include file for OVMF .dsc files v2: Address comments by Sami and Gerd: - Only set PCD if FIRMWARE_VER is defined - ArmVirt: move logic to ArmVirt.dsc.inc https://edk2.groups.io/g/devel/message/95208 v1: https://edk2.groups.io/g/devel/message/95057 Oliver

Re: [edk2-devel] [PATCH v2 0/1] CI: Use Fedora-37 (gcc12) image for Linux jobs

2023-04-13 Thread Oliver Steffen
On Thu, Apr 13, 2023 at 1:27 PM Oliver Steffen wrote: > Switch to the new Fedora-37 CI docker image, and with it to gcc12, for > Linux jobs. > > v2: > Use latest image (no relevant functional changes). > > v1: > Initial version. > > Oliver Steffen (1): >

[edk2-devel] [PATCH v2 1/1] CI: Use Fedora-37 (gcc12) image for Linux jobs

2023-04-13 Thread Oliver Steffen
Switch to the new Fedora-37 CI docker image, and with it to gcc12, for Linux jobs. Signed-off-by: Oliver Steffen Reviewed-by: Sunil V L Reviewed-by: Michael Kubacki Reviewed-by: Rebecca Cran --- .azurepipelines/templates/defaults.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion

[edk2-devel] [PATCH v2 0/1] CI: Use Fedora-37 (gcc12) image for Linux jobs

2023-04-13 Thread Oliver Steffen
Switch to the new Fedora-37 CI docker image, and with it to gcc12, for Linux jobs. v2: Use latest image (no relevant functional changes). v1: Initial version. Oliver Steffen (1): CI: Use Fedora-37 (gcc12) image for Linux jobs .azurepipelines/templates/defaults.yml | 2 +- 1 file changed

Re: [edk2-devel] [RESEND v1 1/1] CI: Use Fedora-37 (gcc12) image for Linux jobs

2023-03-31 Thread Oliver Steffen
On Thu, Mar 30, 2023 at 3:48 PM Dhaval Sharma wrote: > Hi Oliver, > when is this patch expected to get merged? I need to use CI with GCC12 in > order to get my changes through for this > >

[edk2-devel] [RESEND v1 0/1] CI: Use Fedora 37 / GCC 12 for Linux jobs

2023-03-14 Thread Oliver Steffen
Switch the CI (Linux) to use GCC 12 providied by a new Fedora 37 based container image. New container image: https://github.com/tianocore/containers/pull/60 Test PR: https://github.com/tianocore/edk2/pull/4108 Oliver Steffen (1): CI: Use Fedora-37 (gcc12) image for Linux jobs

[edk2-devel] [RESEND v1 1/1] CI: Use Fedora-37 (gcc12) image for Linux jobs

2023-03-14 Thread Oliver Steffen
Switch to the new Fedora-37 CI docker image, and with it to gcc12, for Linux jobs. Signed-off-by: Oliver Steffen Reviewed-by: Sunil V L Reviewed-by: Michael Kubacki --- .azurepipelines/templates/defaults.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.azurepipelines

[edk2-devel] [PATCH v1 1/1] CI: Use Fedora-37 (gcc12) image for Linux jobs

2023-03-08 Thread Oliver Steffen
Switch to the new Fedora-37 CI docker image, and with it to gcc12, for Linux jobs. Signed-off-by: Oliver Steffen --- .azurepipelines/templates/defaults.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.azurepipelines/templates/defaults.yml b/.azurepipelines/templates

[edk2-devel] [PATCH v1 0/1] CI: Use Fedora 37 / GCC 12 for Linux jobs

2023-03-08 Thread Oliver Steffen
Switch the CI (Linux) to use GCC 12 providied by a new Fedora 37 based container image. New container image: https://github.com/tianocore/containers/pull/60 Test PR: https://github.com/tianocore/edk2/pull/4108 Oliver Steffen (1): CI: Use Fedora-37 (gcc12) image for Linux jobs

Re: [edk2-devel] [PATCH v2 2/2] ArmVirtPkg/ArmVirtQemu: Avoid early ID map on ThunderX

2023-03-02 Thread Oliver Steffen
On Thu, Mar 2, 2023 at 11:50 AM Ard Biesheuvel wrote: > On Thu, 9 Feb 2023 at 16:15, Ard Biesheuvel wrote: > > > > On Tue, 7 Feb 2023 at 13:58, Oliver Steffen wrote: > > > > > > On Tue, Feb 7, 2023 at 12:57 PM Ard Biesheuvel > wrote: > > >> &g

Re: [edk2-devel] [edk2-staging/RiscV64QemuVirt PATCH V8 00/19] Add support for RISC-V virt machine

2023-02-20 Thread Oliver Steffen
Quoting Sunil V L (2023-02-17 05:27:15) > On Thu, Feb 16, 2023 at 03:45:49PM -0700, dann frazier wrote: > > On Fri, Feb 10, 2023 at 5:30 AM Sunil V L wrote: > > > > > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4076 > > > > > > Add support for RISC-V qemu virt machine. Most of the

Re: [edk2-devel] [PATCH v2 2/2] ArmVirtPkg/ArmVirtQemu: Avoid early ID map on ThunderX

2023-02-07 Thread Oliver Steffen
On Tue, Feb 7, 2023 at 12:57 PM Ard Biesheuvel wrote: > On Tue, 7 Feb 2023 at 11:51, Oliver Steffen wrote: > > > > On Thu, Feb 2, 2023 at 12:09 PM Oliver Steffen > wrote: > >> > >> > >> On Wed, Feb 1, 2023 at 2:29 PM Ard Biesheuvel wrote: &g

Re: [edk2-devel] [PATCH v2 2/2] ArmVirtPkg/ArmVirtQemu: Avoid early ID map on ThunderX

2023-02-07 Thread Oliver Steffen
On Thu, Feb 2, 2023 at 12:09 PM Oliver Steffen wrote: > > On Wed, Feb 1, 2023 at 2:29 PM Ard Biesheuvel wrote: > >> On Wed, 1 Feb 2023 at 13:59, Oliver Steffen wrote: >> > >> > On Wed, Feb 1, 2023 at 12:52 PM Ard Biesheuvel wrote: >> >> >

Re: [edk2-devel] [PATCH v2 2/2] ArmVirtPkg/ArmVirtQemu: Avoid early ID map on ThunderX

2023-02-02 Thread Oliver Steffen
On Wed, Feb 1, 2023 at 2:29 PM Ard Biesheuvel wrote: > On Wed, 1 Feb 2023 at 13:59, Oliver Steffen wrote: > > > > On Wed, Feb 1, 2023 at 12:52 PM Ard Biesheuvel wrote: > >> > >> On Wed, 1 Feb 2023 at 10:14, Oliver Steffen > wrote: > >> > >

Re: [edk2-devel] [PATCH v2 2/2] ArmVirtPkg/ArmVirtQemu: Avoid early ID map on ThunderX

2023-02-01 Thread Oliver Steffen
On Wed, Feb 1, 2023 at 12:52 PM Ard Biesheuvel wrote: > On Wed, 1 Feb 2023 at 10:14, Oliver Steffen wrote: > > > > Hi everyone! > > > > On Thu, Jan 19, 2023 at 2:21 PM Ard Biesheuvel wrote: > > > > > > On Thu, 19 Jan 2023 at 13:55, Oliver Steffen &

Re: [edk2-devel] [PATCH v2 2/2] ArmVirtPkg/ArmVirtQemu: Avoid early ID map on ThunderX

2023-02-01 Thread Oliver Steffen
Hi everyone! On Thu, Jan 19, 2023 at 2:21 PM Ard Biesheuvel wrote: > > On Thu, 19 Jan 2023 at 13:55, Oliver Steffen wrote: > > > > Quoting Gerd Hoffmann (2023-01-19 13:00:21) > > > Hi, > > > > > > > > I tried the most recent Qemu master (v7

Re: [edk2-devel] arm64 support for stuart

2023-01-25 Thread Oliver Steffen
t at least there would be a good way to bring your own tools. - Oliver > > Mike > > > > *From:* devel@edk2.groups.io *On Behalf Of *Oliver > Steffen > *Sent:* Wednesday, January 25, 2023 10:28 AM > *To:* Gerd Hoffmann > *Cc:* Ard Biesheuvel ; Michael Kubacki &

Re: [edk2-devel] arm64 support for stuart

2023-01-25 Thread Oliver Steffen
On Wed, Jan 25, 2023 at 5:56 PM Gerd Hoffmann wrote: > Hi, > > > Given that nasm is x86 specific, we should be able to work around this > > by moving the nasm_ext_dep.yaml file into the right place. > > Overall stuart feels kind of alien to linux. It just goes download > stuff from the

Re: [edk2-devel] arm64 support for stuart

2023-01-25 Thread Oliver Steffen
On Wed, Jan 25, 2023 at 5:56 PM Gerd Hoffmann wrote: > Hi, > > > Given that nasm is x86 specific, we should be able to work around this > > by moving the nasm_ext_dep.yaml file into the right place. > > Overall stuart feels kind of alien to linux. It just goes download > stuff from the

Re: [edk2-devel] [PATCH v1 1/1] .devcontainer/devcontainer.json: Add devcontainer file

2023-01-24 Thread Oliver Steffen
gt; > > > A minimal number of VS Code extensions are specified that are useful > > for edk2 development or to assist in complying with CI checks in > > place in edk2. > > > > Cc: Andrew Fish > > Cc: Chris Fernald > > Cc: Leif Lindholm > &g

Re: [edk2-devel] [PATCH v1 1/1] .devcontainer/devcontainer.json: Add devcontainer file

2023-01-23 Thread Oliver Steffen
dk2 development or to assist in complying with CI checks in > place in edk2. > > Cc: Andrew Fish [4] > Cc: Chris Fernald [5] > Cc: Leif Lindholm [6] > Cc: Michael D Kinney [7] > Cc: Oliver Steffen [8] > Signed-off-by: Michael Kubacki [9] > ---

Re: [edk2-devel] [PATCH v2 2/2] ArmVirtPkg/ArmVirtQemu: Avoid early ID map on ThunderX

2023-01-19 Thread Oliver Steffen
Quoting Gerd Hoffmann (2023-01-19 13:00:21) > Hi, > > > > I tried the most recent Qemu master (v7.2.50) and also v7.0.0, > > > on the 5.14 (RHEL) kernel and on 6.1.6-200.fc37.aarch64 (from Fedora). > > > No luck. > > > > > > > Does that include a backport of commit > >

Re: [edk2-devel] [PATCH v2 2/2] ArmVirtPkg/ArmVirtQemu: Avoid early ID map on ThunderX

2023-01-19 Thread Oliver Steffen
fferent flavor of TX2), it > crashes extremely early, presumably at the point where this ID map is > activated. > > More details at the end. > > On Thu, 19 Jan 2023 at 12:03, Oliver Steffen wrote: > > > > Quoting Ard Biesheuvel (2023-01-18 10:22:12) > &

Re: [edk2-devel] [PATCH v2 2/2] ArmVirtPkg/ArmVirtQemu: Avoid early ID map on ThunderX

2023-01-19 Thread Oliver Steffen
Quoting Ard Biesheuvel (2023-01-18 10:22:12) > On Wed, 18 Jan 2023 at 09:48, Ard Biesheuvel wrote: > > > > On Wed, 18 Jan 2023 at 09:28, Oliver Steffen wrote: > > > > > > Quoting Ard Biesheuvel (2023-01-18 08:34:32) > > > > On Wed, 18 Jan

Re: [edk2-devel] [PATCH v2 2/2] ArmVirtPkg/ArmVirtQemu: Avoid early ID map on ThunderX

2023-01-18 Thread Oliver Steffen
Quoting Ard Biesheuvel (2023-01-18 08:34:32) > On Wed, 18 Jan 2023 at 07:37, Oliver Steffen wrote: > > > > On Tue, Jan 17, 2023 at 3:57 PM Ard Biesheuvel wrote: > >> > >> On Tue, 17 Jan 2023 at 13:48, Oliver Steffen wrote: > >> > > >> &g

Re: [edk2-devel] [PATCH v2 2/2] ArmVirtPkg/ArmVirtQemu: Avoid early ID map on ThunderX

2023-01-17 Thread Oliver Steffen
On Tue, Jan 17, 2023 at 3:57 PM Ard Biesheuvel wrote: > On Tue, 17 Jan 2023 at 13:48, Oliver Steffen wrote: > > > > Hi Ard, Hi everyone, > > > > Thanks for the work! > > > > But somehow this patch (as it was merged into master branch) does not >

Re: [edk2-devel] [PATCH v11 17/17] OfmvPkg: CI: Qemu tests: set CPU to Broadwell

2023-01-17 Thread Oliver Steffen
On Tue, Jan 17, 2023 at 3:50 PM Yao, Jiewen wrote: > Cool! > Then I suggest to drop patch 17. > Perfectly fine with me. > > > -Original Message- > > From: devel@edk2.groups.io On Behalf Of Gerd > > Hoffmann > > Sent: Tuesday, January 17, 2023 8:39 PM > > To: Yao, Jiewen > > Cc:

Re: [edk2-devel] [PATCH v2 2/2] ArmVirtPkg/ArmVirtQemu: Avoid early ID map on ThunderX

2023-01-17 Thread Oliver Steffen
Hi Ard, Hi everyone, Thanks for the work! But somehow this patch (as it was merged into master branch) does not work for me on the ThunderX box we have. Any idea what could be wrong? I enabled the erratum during build ;-) CPU Info: # lscpu Architecture: aarch64 CPU op-mode(s):

Re: [edk2-devel] [PATCH v11 17/17] OfmvPkg: CI: Qemu tests: set CPU to Broadwell

2023-01-17 Thread Oliver Steffen
to Broadwell can resolve it? > any URL? > > > > > -Original Message- > > From: Oliver Steffen > > Sent: Tuesday, January 17, 2023 1:41 AM > > To: devel@edk2.groups.io > > Cc: Andrew Fish ; Ard Biesheuvel > > ; Feng, Bob C ; Bi, > > Dand

[edk2-devel] [PATCH v11 17/17] OfmvPkg: CI: Qemu tests: set CPU to Broadwell

2023-01-16 Thread Oliver Steffen
Work around a bug in Ovmf that causes Ovmf to crash on startup when running in recent versions of Qemu. Setting the cpu model to something older, for example "Broadwell" works around the issue. Signed-off-by: Oliver Steffen --- OvmfPkg/PlatformCI/PlatformBuildLib.py | 1 + 1 file

[edk2-devel] [PATCH v11 16/17] CI: use ubuntu-22.04 image (Linux only)

2023-01-16 Thread Oliver Steffen
Use the same vm_image as the other Linux CIs in ArmVirtPkg, EmulatorPkg, and OvmfPkg. Switch over to ubuntu-22.04 form ubuntu-latest. Signed-off-by: Oliver Steffen Reviewed-by: Michael Kubacki --- .azurepipelines/Ubuntu-GCC5.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[edk2-devel] [PATCH v11 14/17] EmulatorPgk: CI: use ubuntu-22.04 vm_image (Linux only)

2023-01-16 Thread Oliver Steffen
Switch over to ubuntu-22.04 as the vm_image for Linux CI jobs. The previously used ubuntu-18.04 which is not available anymore since Dec 1st 2022. Signed-off-by: Oliver Steffen Reviewed-by: Michael Kubacki --- EmulatorPkg/PlatformCI/.azurepipelines/Ubuntu-GCC5.yml | 2 +- 1 file changed, 1

[edk2-devel] [PATCH v11 15/17] OvmfPkg: CI: use ubuntu-22.04 vm_image (Linux only)

2023-01-16 Thread Oliver Steffen
Switch over to ubuntu-22.04 as the vm_image for Linux CI jobs. The previously used ubuntu-18.04 which is not available anymore since Dec 1st 2022. Signed-off-by: Oliver Steffen Reviewed-by: Michael Kubacki --- OvmfPkg/PlatformCI/.azurepipelines/Ubuntu-GCC5.yml | 2 +- 1 file changed, 1

[edk2-devel] [PATCH v11 13/17] ArmVirtPkg: CI: use ubuntu-22.04 vm_image (Linux only)

2023-01-16 Thread Oliver Steffen
Switch over to ubuntu-22.04 as the vm_image for Linux CI jobs. The previously used ubuntu-18.04 which is not available anymore since Dec 1st 2022. Signed-off-by: Oliver Steffen Reviewed-by: Michael Kubacki --- ArmVirtPkg/PlatformCI/.azurepipelines/Ubuntu-GCC5.yml | 2 +- 1 file changed, 1

[edk2-devel] [PATCH v11 12/17] BaseTools: remove ext_dep files for gcc

2023-01-16 Thread Oliver Steffen
Remove BaseTools/Bin/gcc_*_ext_dep.yaml to stop downloading gcc from external locations; use the gcc provided by the container image instead. The container image sets the variable GCC5_*_PREFIX accordingly. Signed-off-by: Oliver Steffen Reviewed-by: Michael Kubacki --- BaseTools/Bin

[edk2-devel] [PATCH v11 09/17] EmulatorPkg: CI: Use Fedora 35 container (Linux only)

2023-01-16 Thread Oliver Steffen
Python from the container image, do not download at runtime. Signed-off-by: Oliver Steffen --- EmulatorPkg/PlatformCI/.azurepipelines/Ubuntu-GCC5.yml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/EmulatorPkg/PlatformCI/.azurepipelines/Ubuntu-GCC5.yml b/EmulatorPkg

[edk2-devel] [PATCH v11 10/17] OvmfPkg: CI: Use Fedora 35 container (Linux only)

2023-01-16 Thread Oliver Steffen
Python from the container image, do not download at runtime. Signed-off-by: Oliver Steffen --- OvmfPkg/PlatformCI/.azurepipelines/Ubuntu-GCC5.yml | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/OvmfPkg/PlatformCI/.azurepipelines/Ubuntu-GCC5.yml b/OvmfPkg/PlatformCI

[edk2-devel] [PATCH v11 11/17] .pytool: CISettings.py: don't add scopes for GCC

2023-01-16 Thread Oliver Steffen
All ext_dep.yml files for gcc have been removed and gcc is expected to be installed on the system (GCC5_*_PREFIX may indicate the location). No need to adjust the toolchain scopes for Linux builds anymore. Signed-off-by: Oliver Steffen Reviewed-by: Michael Kubacki --- .pytool/CISettings.py | 9

[edk2-devel] [PATCH v11 08/17] ArmVirtPkg: CI: Use Fedora 35 container (Linux only)

2023-01-16 Thread Oliver Steffen
Python from the container image, do not download at runtime. Signed-off-by: Oliver Steffen --- ArmVirtPkg/PlatformCI/.azurepipelines/Ubuntu-GCC5.yml | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/ArmVirtPkg/PlatformCI/.azurepipelines/Ubuntu-GCC5.yml b/ArmVirtPkg

[edk2-devel] [PATCH v11 06/17] CI: Allow running in a container.

2023-01-16 Thread Oliver Steffen
Add a parameter of the pr-gate-build-job template to specify a container image URL. If the value is not '' (default), then the jobs will be run inside a container based on that image. Signed-off-by: Oliver Steffen Reviewed-by: Michael Kubacki --- .azurepipelines/templates/pr-gate-build

[edk2-devel] [PATCH v11 07/17] CI: Use Fedora 35 container (Linux only)

2023-01-16 Thread Oliver Steffen
, iasl, and nasm are pinned to avoid unintended upgrades during image rebuild. Do not run apt-get in CI jobs to install qemu and gcc dependencies. Assume the container image provides these. Use Python from the container image, do not download at runtime. Signed-off-by: Oliver Steffen

[edk2-devel] [PATCH v11 05/17] CI: add ~/.local/bin to PATH (Linux only)

2023-01-16 Thread Oliver Steffen
Without adding ~/.local/bin to PATH, `pip install` will throw an error when running inside a container. Containers will be introduced to the CI in the following commits. Signed-off-by: Oliver Steffen Reviewed-by: Michael Kubacki --- .azurepipelines/templates/platform-build-run-steps.yml | 6

[edk2-devel] [PATCH v11 04/17] OvmfPkg: CI: use Python version from defaults template

2023-01-16 Thread Oliver Steffen
Use the default Python version from the defaults template (.azurepipelines/templates/defaults.yml) in the Windows and Linux CI jobs. Previous changes to the CI job templates make it necessary to specify a version number, if Python shall be pulled at CI runtime. Signed-off-by: Oliver Steffen

[edk2-devel] [PATCH v11 03/17] EmulatorPkg: CI: use Python version from defaults template

2023-01-16 Thread Oliver Steffen
Use the default Python version from the defaults template (.azurepipelines/templates/defaults.yml) in the Windows and Linux CI jobs. Previous changes to the CI job templates make it necessary to specify a version number, if Python shall be pulled at CI runtime. Signed-off-by: Oliver Steffen

[edk2-devel] [PATCH v11 02/17] ArmVirtPkg: CI: use Python version from defaults template

2023-01-16 Thread Oliver Steffen
Use the default Python version from the defaults template (.azurepipelines/templates/defaults.yml) in the Windows and Linux CI jobs. Previous changes to the CI job templates make it necessary to specify a version number, if Python shall be pulled at CI runtime. Signed-off-by: Oliver Steffen

[edk2-devel] [PATCH v11 01/17] CI: make Python version configurable

2023-01-16 Thread Oliver Steffen
a template .azurepipelines/templates/defaults.yml, from which the default Pyhton version string can be obtained. Signed-off-by: Oliver Steffen Reviewed-by: Michael Kubacki --- .azurepipelines/Ubuntu-GCC5.yml | 9 + .azurepipelines/Windows-VS2019.yml

[edk2-devel] [PATCH v11 00/17] CI: Use Fedora 35 container for Linux jobs

2023-01-16 Thread Oliver Steffen
anization https://github.com/tianocore/containers v1: - Thread: https://edk2.groups.io/g/devel/message/89058 - Images were hosted at https://github.com/osteffenrh/edk2-build-images Signed-off-by: Oliver Steffen Acked-by: Ard Biesheuvel Acked-by: Gerd Hoffmann Reviewed-by: Chris Fernald Oliver S

Re: [edk2-devel] [PATCH 0/1] OvmfPkg/PlatformInitLib: catch QEMU's CPU hotplug reg block regression

2023-01-09 Thread Oliver Steffen
On Thu, Jan 5, 2023 at 4:19 PM Oliver Steffen wrote: > Quoting Laszlo Ersek (2023-01-05 16:12:36) > > On 1/5/23 14:52, Gerd Hoffmann wrote: > > > On Thu, Jan 05, 2023 at 02:43:32PM +0100, Oliver Steffen wrote: > > >> Quoting Gerd Hoffmann (2023-01-05 14:12:22) >

Re: [edk2-devel] [PATCH 0/1] OvmfPkg/PlatformInitLib: catch QEMU's CPU hotplug reg block regression

2023-01-05 Thread Oliver Steffen
Quoting Laszlo Ersek (2023-01-05 16:12:36) > On 1/5/23 14:52, Gerd Hoffmann wrote: > > On Thu, Jan 05, 2023 at 02:43:32PM +0100, Oliver Steffen wrote: > >> Quoting Gerd Hoffmann (2023-01-05 14:12:22) > >>> Not sure this is an option. Is nested virtualization support

Re: [edk2-devel] [PATCH 0/1] OvmfPkg/PlatformInitLib: catch QEMU's CPU hotplug reg block regression

2023-01-05 Thread Oliver Steffen
Quoting Gerd Hoffmann (2023-01-05 14:12:22) > Hi, > > > So I'm not proposing to merge this immediately; something must be fixed > > first: > > > > - use KVM in the CI env, or > > Not sure this is an option. Is nested virtualization supported in azure > pipeline VMs? If so, is /dev/kvm passed

[edk2-devel] [PATCH v10 17/17] do not merge: modify *.dsc to trigger CI

2022-12-01 Thread Oliver Steffen
Modify all *.dsc files to make sure all parts of the CI actually run. This is only needed to trigger the CI in the PR and shall not be merged. Signed-off-by: Oliver Steffen --- ArmPkg/ArmPkg.dsc | 1 + ArmPkg/Drivers/ArmCrashDumpDxe/ArmCrashDumpDxe.dsc

[edk2-devel] [PATCH v10 16/17] CI: use ubuntu-22.04 image (Linux only)

2022-12-01 Thread Oliver Steffen
Use the same vm_image as the other Linux CIs in ArmVirtPkg, EmulatorPkg, and OvmfPkg. Switch over to ubuntu-22.04 form ubuntu-latest. Signed-off-by: Oliver Steffen --- .azurepipelines/Ubuntu-GCC5.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.azurepipelines/Ubuntu-GCC5

[edk2-devel] [PATCH v10 15/17] OvmfPkg: CI: use ubuntu-22.04 vm_image (Linux only)

2022-12-01 Thread Oliver Steffen
Switch over to ubuntu-22.04 as the vm_image for Linux CI jobs. The previously used ubuntu-18.04 which is not available anymore since Dec 1st 2022. Signed-off-by: Oliver Steffen Reviewed-by: Michael Kubacki --- OvmfPkg/PlatformCI/.azurepipelines/Ubuntu-GCC5.yml | 2 +- 1 file changed, 1

[edk2-devel] [PATCH v10 10/17] OvmfPkg: CI: Use Fedora 35 container (Linux only)

2022-12-01 Thread Oliver Steffen
not run apt-get in CI jobs to install qemu and gcc dependencies. Assume the container image provides these. Use Python from the container image, do not download at runtime. Signed-off-by: Oliver Steffen --- OvmfPkg/PlatformCI/.azurepipelines/Ubuntu-GCC5.yml | 11 +++ 1 file changed, 3

[edk2-devel] [PATCH v10 14/17] EmulatorPgk: CI: use ubuntu-22.04 vm_image (Linux only)

2022-12-01 Thread Oliver Steffen
Switch over to ubuntu-22.04 as the vm_image for Linux CI jobs. The previously used ubuntu-18.04 which is not available anymore since Dec 1st 2022. Signed-off-by: Oliver Steffen Reviewed-by: Michael Kubacki --- EmulatorPkg/PlatformCI/.azurepipelines/Ubuntu-GCC5.yml | 2 +- 1 file changed, 1

[edk2-devel] [PATCH v10 13/17] ArmVirtPkg: CI: use ubuntu-22.04 vm_image (Linux only)

2022-12-01 Thread Oliver Steffen
Switch over to ubuntu-22.04 as the vm_image for Linux CI jobs. The previously used ubuntu-18.04 which is not available anymore since Dec 1st 2022. Signed-off-by: Oliver Steffen Reviewed-by: Michael Kubacki --- ArmVirtPkg/PlatformCI/.azurepipelines/Ubuntu-GCC5.yml | 2 +- 1 file changed, 1

[edk2-devel] [PATCH v10 12/17] BaseTools: remove ext_dep files for gcc

2022-12-01 Thread Oliver Steffen
Remove BaseTools/Bin/gcc_*_ext_dep.yaml to stop downloading gcc from external locations; use the gcc provided by the container image instead. The container image sets the variable GCC5_*_PREFIX accordingly. Signed-off-by: Oliver Steffen --- BaseTools/Bin/gcc_aarch64_linux_ext_dep.yaml | 21

[edk2-devel] [PATCH v10 11/17] .pytool: CISettings.py: don't add scopes for GCC

2022-12-01 Thread Oliver Steffen
All ext_dep.yml files for gcc have been removed and gcc is expected to be installed on the system (GCC5_*_PREFIX may indicate the location). No need to adjust the toolchain scopes for Linux builds anymore. Signed-off-by: Oliver Steffen Reviewed-by: Michael Kubacki --- .pytool/CISettings.py | 9

[edk2-devel] [PATCH v10 09/17] EmulatorPkg: CI: Use Fedora 35 container (Linux only)

2022-12-01 Thread Oliver Steffen
Python from the container image, do not download at runtime. Signed-off-by: Oliver Steffen Acked-by: Ray Ni --- EmulatorPkg/PlatformCI/.azurepipelines/Ubuntu-GCC5.yml | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/EmulatorPkg/PlatformCI/.azurepipelines/Ubuntu-GCC5.yml b

[edk2-devel] [PATCH v10 08/17] ArmVirtPkg: CI: Use Fedora 35 container (Linux only)

2022-12-01 Thread Oliver Steffen
not run apt-get in CI jobs to install qemu and gcc dependencies. Assume the container image provides these. Use Python from the container image, do not download at runtime. Signed-off-by: Oliver Steffen --- ArmVirtPkg/PlatformCI/.azurepipelines/Ubuntu-GCC5.yml | 11 +++ 1 file changed, 3

[edk2-devel] [PATCH v10 07/17] CI: Use Fedora 35 container (Linux only)

2022-12-01 Thread Oliver Steffen
not run apt-get in CI jobs to install qemu and gcc dependencies. Assume the container image provides these. Use Python from the container image, do not download at runtime. Signed-off-by: Oliver Steffen --- .azurepipelines/Ubuntu-GCC5.yml | 6 ++ .azurepipelines/templates

[edk2-devel] [PATCH v10 06/17] CI: Allow running in a container.

2022-12-01 Thread Oliver Steffen
Add a parameter of the pr-gate-build-job template to specify a container image URL. If the value is not '' (default), then the jobs will be run inside a container based on that image. Signed-off-by: Oliver Steffen Reviewed-by: Michael Kubacki --- .azurepipelines/templates/pr-gate-build

[edk2-devel] [PATCH v10 05/17] CI: add ~/.local/bin to PATH (Linux only)

2022-12-01 Thread Oliver Steffen
Without adding ~/.local/bin to PATH, `pip install` will throw an error when running inside a container. Containers will be introduced to the CI in the following commits. Signed-off-by: Oliver Steffen Reviewed-by: Michael Kubacki --- .azurepipelines/templates/platform-build-run-steps.yml | 6

[edk2-devel] [PATCH v10 03/17] EmulatorPkg: CI: use Python version from defaults template

2022-12-01 Thread Oliver Steffen
Use the default Python version from the defaults template (.azurepipelines/templates/defaults.yml) in the Windows and Linux CI jobs. Previous changes to the CI job templates make it necessary to specify a version number, if Python shall be pulled at CI runtime. Signed-off-by: Oliver Steffen

[edk2-devel] [PATCH v10 04/17] OvmfPkg: CI: use Python version from defaults template

2022-12-01 Thread Oliver Steffen
Use the default Python version from the defaults template (.azurepipelines/templates/defaults.yml) in the Windows and Linux CI jobs. Previous changes to the CI job templates make it necessary to specify a version number, if Python shall be pulled at CI runtime. Signed-off-by: Oliver Steffen

[edk2-devel] [PATCH v10 02/17] ArmVirtPkg: CI: use Python version from defaults template

2022-12-01 Thread Oliver Steffen
Use the default Python version from the defaults template (.azurepipelines/templates/defaults.yml) in the Windows and Linux CI jobs. Previous changes to the CI job templates make it necessary to specify a version number, if Python shall be pulled at CI runtime. Signed-off-by: Oliver Steffen

[edk2-devel] [PATCH v10 00/17] CI: Use Fedora 35 container for Linux jobs

2022-12-01 Thread Oliver Steffen
https://github.com/osteffenrh/edk2-build-images Signed-off-by: Oliver Steffen Acked-by: Ard Biesheuvel Acked-by: Gerd Hoffmann Reviewed-by: Chris Fernald Oliver Steffen (17): CI: make Python version configurable ArmVirtPkg: CI: use Python version from defaults template EmulatorPk

[edk2-devel] [PATCH v10 01/17] CI: make Python version configurable

2022-12-01 Thread Oliver Steffen
a template .azurepipelines/templates/defaults.yml, from which the default Pyhton version string can be obtained. Signed-off-by: Oliver Steffen --- .azurepipelines/Ubuntu-GCC5.yml | 4 .azurepipelines/Windows-VS2019.yml| 4 .azurepipelines

  1   2   3   >