Hi Ming,
Thanks for this patch. This patch helps to resolve Standalone MM issue while
exercising RAS use case.
Few comments mentioned inline.
- Omkar
On 10/15/21 2:39 PM, Ming Huang via groups.io wrote:
> There are two scene communicate with StandaloneMm(MM):
> 1 edk2 -> TF-A -> MM,
sage/79741
>
> Link to github branch with the patches in this series -
> https://github.com/omkkul01/edk2-platforms/tree/ras_firware_first_edk2-
> platforms_v3
>
> Omkar Anand Kulkarni (5):
> Platform/ARM: Add DMC-620 ECC error handling driver
> Platform/Sgi: dmc-620 firmwa
mp; HestErrorSourceStandaloneMM:
> > These two drivers together retrieve all possible error source descriptors
> > of
> > type GHESv2 from the MM drivers implementing HEST Error Source
> > Descriptor
> > protocol. Once all the descriptors are collected HestError
Enables firmware first error handling on the given platform. Installs
and publishes the SDEI and HEST ACPI tables required for firmware first
error handling.
Signed-off-by: Omkar Anand Kulkarni
---
Platform/ARM/SgiPkg/SgiPlatform.dsc.inc
| 10
For ACPI tables that are generated dynamically, define the ACPI table
header values that have to be used to build the table header.
Co-authored-by: Thomas Abraham
Signed-off-by: Omkar Anand Kulkarni
---
Platform/ARM/SgiPkg/SgiPlatform.dsc.inc | 7 +++
1 file changed, 7 insertions(+)
diff
Allow platforms to define the base address and size of the memory region
that is reserved for MM drivers to populate the GHES generic error
status block with information about the platform error.
Co-authored-by: Thomas Abraham
Signed-off-by: Omkar Anand Kulkarni
---
Platform/ARM/SgiPkg
Signed-off-by: Omkar Anand Kulkarni
---
Platform/ARM/SgiPkg/SgiPlatform.dsc.inc | 17 +++
Platform/ARM/SgiPkg/SgiPlatformMm.dsc.inc| 30
Platform/ARM/SgiPkg/PlatformStandaloneMm.fdf | 6
Platform/ARM/SgiPkg/SgiPlatform.fdf | 6
4 files
-authored-by: Thomas Abraham
Signed-off-by: Omkar Anand Kulkarni
---
Platform/ARM/Drivers/Dmc620Mm/Dmc620Mm.dec | 30 ++
Platform/ARM/Drivers/Dmc620Mm/Dmc620Mm.inf | 61
Platform/ARM/Drivers/Dmc620Mm/Dmc620Mm.h| 174 ++
Platform/ARM/Drivers
/79741
Link to github branch with the patches in this series -
https://github.com/omkkul01/edk2-platforms/tree/ras_firware_first_edk2-platforms_v3
Omkar Anand Kulkarni (5):
Platform/ARM: Add DMC-620 ECC error handling driver
Platform/Sgi: dmc-620 firmware-first error handling
Platform/Sgi
criptor
> protocol. Once all the descriptors are collected HestErrorSourceDxe
> appends
> it to HEST table using HestTableDxe driver.
>
> Link to github branch with the patches in this series -
> https://github.com/omkkul01/edk2/tree/ras_firware_first_edk2-
> platforms_v3
>
Added a readme file that explains the software framework for dynamic
generation of HEST table.
Signed-off-by: Omkar Anand Kulkarni
---
ArmPlatformPkg/Drivers/HestMmErrorSources/Readme.md | 66
1 file changed, 66 insertions(+)
diff --git a/ArmPlatformPkg/Drivers
Add helper macros for the generation of the HEST ACPI table. Macros to
initialize the HEST GHESv2 Notification Structure and Error Status
Structure are introduced.
Signed-off-by: Omkar Anand Kulkarni
---
EmbeddedPkg/Include/Library/AcpiLib.h | 20
1 file changed, 20
Signed-off-by: Omkar Anand Kulkarni
---
ArmPlatformPkg/ArmPlatformPkg.dec |
7 +
ArmPlatformPkg/Drivers/HestMmErrorSources/HestErrorSourceDxe.inf |
45 +++
ArmPlatformPkg/Drivers/HestMmErrorSources/HestErrorSourceStandaloneMm.inf |
51
Add the protocol definition of the MM_HEST_ERROR_SOURCE_DESC_PROTOCOL
protocol. This protocol can be implemented by MM drivers to publish
error source descriptors that have to be populated into HEST table.
Co-authored-by: Thomas Abraham
Signed-off-by: Omkar Anand Kulkarni
---
ArmPlatformPkg
interface can then be used to dynamically install the fully
populated HEST table. This allows multiple drivers and/or libraries to
dynamically register error source descriptors into the HEST table.
Co-authored-by: Thomas Abraham
Signed-off-by: Omkar Anand Kulkarni
---
MdeModulePkg/MdeModulePkg.dec
rror Source Descriptor
protocol. Once all the descriptors are collected HestErrorSourceDxe appends
it to HEST table using HestTableDxe driver.
Link to github branch with the patches in this series -
https://github.com/omkkul01/edk2/tree/ras_firware_first_edk2-platforms_v3
Omkar Anand Kulkarn
>
> Regards,
>
> Sami Mujawar
>
>
> On 10/07/2021 05:18 PM, Omkar Anand Kulkarni wrote:
> > Add helper macros for the generation of the HEST ACPI table. Macros to
> > initialize the HEST GHESv2 Notification Structure and Error Status
> > Struct
Hi Sami,
Thanks for the patch review. Please find my response inline.
Regards,
Omkar
Hi Omkar,
Please find my response inline marked [SAMI].
Regards,
Sami Mujawar
On 10/07/2021 05:18 PM, Omkar Anand Kulkarni wrote:
Add a driver that retreives error source descriptors from MM and
populates
Hi Sami,
Thanks for reviewing this patch. Please find my response inline.
Regards,
Omkar
Hi Omkar,
Please find my response below marked [SAMI]
Regards,
Sami Mujawar
On 10/07/2021 05:18 PM, Omkar Anand Kulkarni wrote:
Add the protocol definition of the MM_HEST_ERROR_SOURCE_DESC_PROTOCOL
Hi Sami,
Thanks for reviewing this patch. Please find my response inline.
Regards,
Omkar
Hi Omkar,
Please find my response marked inline as [SAMI].
Regards,
Sami Mujawar
On 10/07/2021 05:18 PM, Omkar Anand Kulkarni wrote:
Introduce the HEST table generation protocol that allows platforms
rt of a commit message for one of the patches in this series
> > (patch 2/4 or 3/4).
> >
> > Or
> >
> > 2. in a Readme.md file
> >
> > Regards,
> >
> > Sami Mujawar
> >
Ack.
- Omkar
> >
> > On 10/07/2021 05:18 PM, Omkar Anand Kulk
rce Table
> > [2] : SDEI Platform Design Document, revision b, 10 Appendix C, ACPI
> table
> > definitions for SDEI
> > [3] : ACPI Reference Specification 6.3, Table 18-393 GHESv2 Structure
> > [4] : DMC620 Dynamic Memory Controller, revision r1p0
>
ign Document, revision b, 10 Appendix C, ACPI table
> definitions for SDEI
> [3] : ACPI Reference Specification 6.3, Table 18-393 GHESv2 Structure
> [4] : DMC620 Dynamic Memory Controller, revision r1p0
> [5] : UEFI Reference Specification 2.8, Appendix N - Common Platform Error
&g
dent on the edk2 patch series
> https://edk2.groups.io/g/devel/message/77667
>
> Link to github branch with the patches in this series -
> https://github.com/omkkul01/edk2-platforms/tree/ras_firware_first_edk2-
> platforms
>
> Omkar Anand Kulkarni (5):
> Platform/ARM: Add DMC-62
For ACPI tables that are generated dynamically, define the ACPI table
header values that have to be used to build the table header.
Co-authored-by: Thomas Abraham
Signed-off-by: Omkar Anand Kulkarni
---
Platform/ARM/SgiPkg/SgiPlatform.dsc.inc | 7 +++
1 file changed, 7 insertions(+)
diff
Enables firmware first error handling on the given platform. Installs
and publishes the SDEI and HEST ACPI tables required for firmware first
error handling.
Signed-off-by: Omkar Anand Kulkarni
---
Platform/ARM/SgiPkg/SgiPlatform.dsc.inc
| 10
Signed-off-by: Omkar Anand Kulkarni
---
Platform/ARM/SgiPkg/SgiPlatform.dsc.inc | 17 +++
Platform/ARM/SgiPkg/SgiPlatformMm.dsc.inc| 30
Platform/ARM/SgiPkg/PlatformStandaloneMm.fdf | 6
Platform/ARM/SgiPkg/SgiPlatform.fdf | 6
4 files
Allow platforms to define the base address and size of the memory region
that is reserved for MM drivers to populate the GHES generic error
status block with information about the platform error.
Co-authored-by: Thomas Abraham
Signed-off-by: Omkar Anand Kulkarni
---
Platform/ARM/SgiPkg
-authored-by: Thomas Abraham
Signed-off-by: Omkar Anand Kulkarni
---
Platform/ARM/Drivers/Dmc620Mm/Dmc620Mm.dec | 30 ++
Platform/ARM/Drivers/Dmc620Mm/Dmc620Mm.inf | 60
Platform/ARM/Drivers/Dmc620Mm/Dmc620Mm.h| 175 ++
Platform/ARM/Drivers
Section
This patch series is dependent on the edk2 patch series
https://edk2.groups.io/g/devel/message/77667
Link to github branch with the patches in this series -
https://github.com/omkkul01/edk2-platforms/tree/ras_firware_first_edk2-platforms
Omkar Anand Kulkarni (5):
Platform/ARM: Add DMC-620
Add helper macros for the generation of the HEST ACPI table. Macros to
initialize the HEST GHESv2 Notification Structure and Error Status
Structure are introduced.
Signed-off-by: Omkar Anand Kulkarni
---
ArmPlatformPkg/Include/HestAcpiHeader.h | 49
1 file changed, 49
interface can then be used to dynamically install the fully
populated HEST table. This allows multiple drivers and/or libraries to
dynamically register error source descriptors into the HEST table.
Co-authored-by: Thomas Abraham
Signed-off-by: Omkar Anand Kulkarni
---
ArmPlatformPkg/ArmPlatformPkg.dec
Signed-off-by: Omkar Anand Kulkarni
---
ArmPlatformPkg/ArmPlatformPkg.dec |
7 +
ArmPlatformPkg/Drivers/HestMmErrorSources/HestErrorSourceDxe.inf |
44 +++
ArmPlatformPkg/Drivers/HestMmErrorSources/HestErrorSourceStandaloneMm.inf |
51
r1p0
[5] : UEFI Reference Specification 2.8, Appendix N - Common Platform Error
Record
[6] : UEFI Reference Specification 2.8, Section N.2.5 Memory Error Section
Link to github branch with the patches in this series -
https://github.com/omkkul01/edk2/tree/ras_firmware_first_edk2
Omkar A
Add the protocol definition of the MM_HEST_ERROR_SOURCE_DESC_PROTOCOL
protocol. This protocol can be implemented by MM drivers to publish
error source descriptors that have to be populated into HEST table.
Co-authored-by: Thomas Abraham
Signed-off-by: Omkar Anand Kulkarni
---
ArmPlatformPkg
On 6/10/21 6:44 AM, Ming Huang via groups.io wrote:
> On 6/9/21 3:10 PM, Ard Biesheuvel wrote:
> > On Tue, 8 Jun 2021 at 16:21, Ming Huang
> wrote:
> >>
> >> TF-A: TrustedFirmware-a
> >> SPM: Secure Partition Manager(MM)
> >>
> >> For AArch64, when SPM enable in TF-A, TF-A may communicate to MM
36 matches
Mail list logo
