From: Jeremy Linton
Signed-off-by: Pete Batard
---
Silicon/Broadcom/Bcm27xx/Library/Bcm2711PciHostBridgeLib/Bcm2711PciHostBridgeLib.c
| 193
Silicon/Broadcom/Bcm27xx/Library/Bcm2711PciHostBridgeLib/Bcm2711PciHostBridgeLib.inf
| 51 +
Silicon
altogether.
Signed-off-by: Pete Batard
---
Platform/RaspberryPi/RPi3/RPi3.dsc | 3 ++-
Platform/RaspberryPi/RPi4/RPi4.dsc | 2 ++
2 files changed, 4 insertions(+), 1 deletion(-)
diff --git a/Platform/RaspberryPi/RPi3/RPi3.dsc
b/Platform/RaspberryPi/RPi3/RPi3.dsc
index 945baa5021f8..2368b04f40a4 100644
Hi Leif,
On 2019.12.11 14:14, Leif Lindholm wrote:
On Wed, Dec 11, 2019 at 11:24:00 +, Pete Batard wrote:
Similar to what is the case with the Raspberry Pi 3, the Raspberry Pi
4 UEFI firmware requires the provision of a Trusted Firmware binary
(TF-A).
The binary is built for a dtb base
belong in the UEFI memory map to begin with, omit them
entirely.
Signed-off-by: Pete Batard
---
Platform/RaspberryPi/Include/Library/RPiMem.h| 7 ---
Platform/RaspberryPi/Library/MemoryInitPeiLib/MemoryInitPeiLib.c | 10
++
Platform/RaspberryPi/Library/PlatformLib
This series adds basic support to build the Raspberry Pi 4 platform.
It requires the earlier series, that add binary files for the platform,
to have been applied to edk2-non-osi.
For the introduction of the platform, USB support is not yet enabled
which means that user I/O has to be carried out
between PL011 and miniUART for serial.
Details on how to use the resulting firmware, and especially how
to configure the media for boot, are provided in the Readme.
Signed-off-by: Pete Batard
---
Platform/RaspberryPi/RPi4/RPi4.dsc | 637
Platform/RaspberryPi/RPi4/RPi4.fdf
From: Samer El-Haj-Mahmoud
For this initial commit, we duplicate the RPi3 ones.
Signed-off-by: Pete Batard
---
Platform/RaspberryPi/RPi4/AcpiTables/AcpiTables.h | 76 +++
Platform/RaspberryPi/RPi4/AcpiTables/AcpiTables.inf | 40 ++
Platform/RaspberryPi/RPi4/AcpiTables/Csrt.aslc | 326
added
after ACPI 5.1, we can simply use that version to keep Linux happy.
Signed-off-by: Pete Batard
---
Platform/RaspberryPi/RPi4/AcpiTables/AcpiTables.h | 26 -
Platform/RaspberryPi/RPi4/AcpiTables/AcpiTables.inf | 12 ++-
Platform/RaspberryPi/RPi4/AcpiTables/Csrt.aslc | 25
From: Ard Biesheuvel
Having RAM and SoC register regions overlap is problematic for MMIO,
since, at the very least, we don't want these regions to be declared
as cacheable.
Signed-off-by: Pete Batard
---
Platform/RaspberryPi/Library/PlatformLib/RaspberryPiMem.c | 36
+---
1
.
Signed-off-by: Pete Batard
---
Platform/RaspberryPi/RPi4/TrustedFirmware/License.txt | 26
Platform/RaspberryPi/RPi4/TrustedFirmware/Readme.md | 12 +
Platform/RaspberryPi/RPi4/TrustedFirmware/bl31_miniuart.bin | Bin 0 -> 41072
bytes
Platf
This series of patches adds the binaries we need available to introduce
Raspberry Pi 4 support.
Similar to the Pi 3, we must have TF-A and Device Tree binaries we can embed.
Pete Batard (2):
Platforms/RPi4: Add Device Tree
Platforms/RPi4: Add Trusted Firmware binaries
Platform/RaspberryPi
/raspberrypi/firmware/tree/master/boot
Signed-off-by: Pete Batard
---
Platform/RaspberryPi/RPi4/DeviceTree/License.txt | 340
Platform/RaspberryPi/RPi4/DeviceTree/Readme.md | 13 +
Platform/RaspberryPi/RPi4/DeviceTree/bcm2711-rpi-4-b.dtb | Bin 0 -> 40697 bytes
to
SerialPortConsoleRedirectionTable.h too.
Note that we followed the same idiosyncrasies as DebugPort2Table
for naming these new macros.
Signed-off-by: Pete Batard
---
MdePkg/Include/IndustryStandard/SerialPortConsoleRedirectionTable.h | 10
++
1 file changed, 10 insertions(+)
diff --git
a/MdePkg/Include
From: Andrei Warkentin
This is mostly a maintainability improvement for the
InitializeSdMmcDevice () call achieved by factorizing the
code related to SCR execution into a new SdExecuteScr () call.
Signed-off-by: Pete Batard
---
Platform/RaspberryPi/Drivers/MmcDxe/MmcIdentification.c | 105
Changes from v1 (https://edk2.groups.io/g/devel/message/51334):
- Moved RNG related changes into their own series
- Fix a whitespace issue in the last patch
Andrei Warkentin (2):
Platform/RPi/MmcDxe: Factorize SCR call and clean up MMC init
Platform/RPi/MmcDxe: Improve MMC driver stability
From: Samer El-Haj-Mahmoud
The Raspberry Pi 4 has a new SD controller. As a result we must
handle SD routing according to the model, which we perform in
the Config driver by using the GetModelFamily () call that was
recently introduced.
Signed-off-by: Pete Batard
---
Platform/RaspberryPi
InitializeMmcDevice ()
in case of failure.
Signed-off-by: Pete Batard
---
Platform/RaspberryPi/Drivers/MmcDxe/Mmc.c | 7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/Platform/RaspberryPi/Drivers/MmcDxe/Mmc.c
b/Platform/RaspberryPi/Drivers/MmcDxe/Mmc.c
index c3c7279e4707..f6c4cc7bc3a3
Hi Ard,
On 2019.12.02 16:03, Ard Biesheuvel wrote:
On Mon, 2 Dec 2019 at 11:55, Pete Batard wrote:
This patch series is targetted at adding support for the Bcm2838
Random Generator Driver, so that it can be used on the Raspberry
Pi 4.
Pete Batard (3):
Silicon/Broadcom/Bcm283x: Rename
This patch series is targetted at adding support for the Bcm2838
Random Generator Driver, so that it can be used on the Raspberry
Pi 4.
Pete Batard (3):
Silicon/Broadcom/Bcm283x: Rename Bcm2835 RNG driver
Silicon/Broadcom/Bcm283x: Move Bcm2835 RNG defines to their own header
Silicon
implementation.
Signed-off-by: Pete Batard
---
Silicon/Broadcom/Bcm283x/Drivers/Bcm2835RngDxe/Bcm2835RngDxe.c | 2 +-
Silicon/Broadcom/Bcm283x/Include/IndustryStandard/Bcm2835Rng.h | 22
Silicon/Broadcom/Bcm283x/Include/IndustryStandard/Bcm2836.h| 9
3 files changed
-off-by: Pete Batard
---
Platform/RaspberryPi/RPi3/RPi3.dsc
| 2 +-
Platform/RaspberryPi/RPi3/RPi3.fdf
| 2 +-
Silicon/Broadcom/Bcm283x/Drivers/{RngDxe/RngDxe.c =>
Bcm2835Rng
This adds the Bcm2838 Random Number Generator Driver, which
is also the type of RNG that the Bmc2711-based Raspberry Pi 4
uses.
Signed-off-by: Pete Batard
---
Silicon/Broadcom/Bcm283x/Drivers/Bcm2838RngDxe/Bcm2838RngDxe.c | 285
Silicon/Broadcom/Bcm283x/Drivers
On 2019.11.27 15:24, Philippe Mathieu-Daudé wrote:
On 11/27/19 1:37 PM, Pete Batard wrote:
From: Samer El-Haj-Mahmoud
The Raspberry Pi 4 has a new SD controller. As a result we must
handle SD routing according to the model, which we perform in
the Config driver by using the GetModelFamily
On 2019.11.27 14:47, Philippe Mathieu-Daudé wrote:
On 11/27/19 1:37 PM, Pete Batard wrote:
Add missing RNG registers,
This is one change.
prefer reusing shorter define's
instead of PCDs and clean up spacing.
This is another change.
All these changes belong to a "cleanup" categ
On 2019.11.27 13:17, Ard Biesheuvel wrote:
On Wed, 27 Nov 2019 at 14:09, Pete Batard wrote:
On 2019.11.27 13:00, Ard Biesheuvel wrote:
On Wed, 27 Nov 2019 at 13:56, Pete Batard wrote:
On 2019.11.27 12:48, Ard Biesheuvel wrote:
On Wed, 27 Nov 2019 at 13:37, Pete Batard wrote:
Add
On 2019.11.27 13:00, Ard Biesheuvel wrote:
On Wed, 27 Nov 2019 at 13:56, Pete Batard wrote:
On 2019.11.27 12:48, Ard Biesheuvel wrote:
On Wed, 27 Nov 2019 at 13:37, Pete Batard wrote:
Add missing RNG registers, prefer reusing shorter define's
instead of PCDs and clean up spacing
On 2019.11.27 12:48, Ard Biesheuvel wrote:
On Wed, 27 Nov 2019 at 13:37, Pete Batard wrote:
Add missing RNG registers, prefer reusing shorter define's
instead of PCDs and clean up spacing.
Is there a source for these register definitions?
I used the most recent Linux driver I could find
On 2019.11.27 12:44, Ard Biesheuvel wrote:
On Wed, 27 Nov 2019 at 13:37, Pete Batard wrote:
The Bcm283x Random Number Generator does not work in regular mode
on the Bcm2711 powered Raspberry Pi 4. It does however work when
using FIFO mode. So we add this new mode, which is governed by the
use
(2):
Platform/RPi/MmcDxe: Factorize SCR call and clean up MMC init
Platform/RPi/MmcDxe: Improve MMC driver stability
Pete Batard (2):
Silicon/Bcm283x: Clean up Bcm2836.h header
Silicon/Bcm283x: Add FIFO mode for RNG
Samer El-Haj-Mahmoud (1):
Platform/RPi: Set SD routing according to model
regular mode, a
Pi 3 doesn't seem to support FIFO mode, which is why we can't
switch to simply using FIFO mode for both platforms.
We also fix the register to which RNG_WARMUP_COUNT is written,
which was incorrect.
Signed-off-by: Pete Batard
---
Silicon/Broadcom/Bcm283x/Bcm283x.dec
From: Samer El-Haj-Mahmoud
The Raspberry Pi 4 has a new SD controller. As a result we must
handle SD routing according to the model, which we perform in
the Config driver by using the GetModelFamily () call that was
recently introduced.
Signed-off-by: Pete Batard
---
Platform/RaspberryPi
From: Andrei Warkentin
This is mostly a maintainability improvement for the
InitializeSdMmcDevice () call achieved by factorizing the
code related to SCR execution into a new SdExecuteScr () call.
Signed-off-by: Pete Batard
---
Platform/RaspberryPi/Drivers/MmcDxe/MmcIdentification.c | 105
InitializeMmcDevice ()
in case of failure.
Signed-off-by: Pete Batard
---
Platform/RaspberryPi/Drivers/MmcDxe/Mmc.c | 7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/Platform/RaspberryPi/Drivers/MmcDxe/Mmc.c
b/Platform/RaspberryPi/Drivers/MmcDxe/Mmc.c
index c3c7279e4707..f6c4cc7bc3a3
Add missing RNG registers, prefer reusing shorter define's
instead of PCDs and clean up spacing.
Signed-off-by: Pete Batard
---
Silicon/Broadcom/Bcm283x/Include/IndustryStandard/Bcm2836.h | 23
1 file changed, 14 insertions(+), 9 deletions(-)
diff --git a/Silicon/Broadcom
From: Ard Biesheuvel
Using DEBUG () at runtime can crash the OS if we don't take care to
inhibit serial output to MMIO mapped UARTs that we don't inform the
OS about via the memory map.
So use a version of DebugLib that does exactly that for the RTC
driver.
Signed-off-by: Pete Batard
These two patches were provided by Ard against the current Pi 4
development effort, but it makes a lot of sense to have them in
the Pi 3 tree as well, especially as the first one addresses an
issue that can also be experienced on the platform when using the
the DEBUG version of the firmware
From: Ard Biesheuvel
acpiview is a UEFI shell command that can be used to inspect and
validate ACPI tables from the pre-OS environment. Let's add it to
our build of the shell.
Signed-off-by: Pete Batard
---
Platform/RaspberryPi/RPi3/RPi3.dsc | 1 +
1 file changed, 1 insertion(+)
diff --git
EmbeddedPkg/EmbeddedPkg.dsc | 5 +
3 files changed, 305 insertions(+)
Reviewed-by: Philippe Mathieu-Daude
Tested-by: Pete Batard
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#51270): https://edk2
-by: Pete Batard
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#51269): https://edk2.groups.io/g/devel/message/51269
Mute This Topic: https://groups.io/mt/61950463/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2
stly be a re-hashing of what I have already
tried to point out. Therefore, with the clarification above having been
made, I am planning to leave the matter at that.
Regards,
/Pete
On 2019.11.21 09:04, Laszlo Ersek wrote:
On 11/21/19 09:55, Laszlo Ersek wrote:
On 11/20/19 22:50, Pete Batard w
Hi Leif,
On 2019.11.20 10:27, Leif Lindholm wrote:
On Tue, Nov 19, 2019 at 04:30:05PM +, Pete Batard wrote:
Please keep in mind that when open source maintainers take ownership
of your code, they assume the responsibility to ensure that it doesn't
get broken by future updates elsewhere
On 2019.11.19 15:07, Ard Biesheuvel wrote:
On Mon, 18 Nov 2019 at 19:32, Pete Batard wrote:
On 2019.11.18 18:05, Leif Lindholm wrote:
On Mon, Nov 18, 2019 at 05:58:05PM +, Pete Batard wrote:
On 2019.11.18 17:51, Leif Lindholm wrote:
On Thu, Nov 14, 2019 at 04:07:33PM +, Pete Batard
On 2019.11.19 12:02, Philippe Mathieu-Daudé wrote:
On 11/19/19 12:38 PM, Pete Batard wrote:
From: Samer El-Haj-Mahmoud
Add a missing entry for the "Raspberry Pi Compute Module 3+" in
RpiFirmwareGetModelName ().
Signed-off-by: Leif Lindholm
I feel really lost with how the S-o-b a
On 2019.11.19 11:43, Philippe Mathieu-Daudé wrote:
On 11/19/19 12:38 PM, Pete Batard wrote:
From: Samer El-Haj-Mahmoud
Define BCM2836_SOC_REGISTERS from PcdBcm283xRegistersAddress. This is
needed in preparation for adding Raspberry Pi 4 support, since the two
Pi's have a different base
also fix SoC register space that should have been marked as reserved
but wasn't until now and remove the unreferenced mSystemMemoryEnd extern
in MemoryInitPeiLib.c.
RaspberryPiMem.c incorporates some code from ArmJunoMem.c.
Signed-off-by: Pete Batard
---
Platform/RaspberryPi/Include/Library
From: Samer El-Haj-Mahmoud
Define BCM2836_SOC_REGISTERS from PcdBcm283xRegistersAddress. This is
needed in preparation for adding Raspberry Pi 4 support, since the two
Pi's have a different base addresses for the Bcm283x specific registers.
Signed-off-by: Pete Batard
---
Platform/RaspberryPi
for the Pi 4 and should also be easier to maintain
than if using individual model detection.
Signed-off-by: Pete Batard
---
Platform/RaspberryPi/Drivers/RpiFirmwareDxe/RpiFirmwareDxe.c | 61
Platform/RaspberryPi/Include/Protocol/RpiFirmware.h | 8 +++
2 files changed, 69
abetical order where possible
- Use a single PCD for the SoC registers base address and use offsets to derive
the other registers address from that PCD
- Add a comment in RaspberryPiHelper.S to indicate that x1 keeps its value
- Mention that RaspberryPiMem.c is derived from code from ArmJunoM
From: Samer El-Haj-Mahmoud
Add a missing entry for the "Raspberry Pi Compute Module 3+" in
RpiFirmwareGetModelName ().
Signed-off-by: Leif Lindholm
---
Platform/RaspberryPi/Drivers/RpiFirmwareDxe/RpiFirmwareDxe.c | 3 +++
1 file changed, 3 insertions(+)
diff --git
From: Samer El-Haj-Mahmoud
Remove hardcoded base addresses for Mailbox, Watchdog, SDIO and
DW2 USB and use an offset indexed on PcdBcm283xRegistersAddress
instead. This is needed in preparation for adding Raspberry Pi 4
support.
Signed-off-by: Pete Batard
---
Platform/RaspberryPi/Drivers
for the new registers for now (set from a PCD as is the
case for Bcm283x) but which should get populated further as we add
support for the Raspberry Pi 4.
Signed-off-by: Pete Batard
Reviewed-by: Leif Lindholm
---
Silicon/Broadcom/Bcm27xx/Bcm27xx.dec| 22
unused variables such as mGPUMemoryBase and mGPUMemoryLength.
Signed-off-by: Pete Batard
---
Platform/RaspberryPi/Include/IndustryStandard/RpiMbox.h | 1 +
Platform/RaspberryPi/Library/PlatformLib/AArch64/RaspberryPiHelper.S | 76
++--
Platform/RaspberryPi/Library
On 2019.11.18 18:05, Leif Lindholm wrote:
On Mon, Nov 18, 2019 at 05:58:05PM +, Pete Batard wrote:
On 2019.11.18 17:51, Leif Lindholm wrote:
On Thu, Nov 14, 2019 at 04:07:33PM +, Pete Batard wrote:
From: Samer El-Haj-Mahmoud
Add GetModelFamily to RASPBERRY_PI_FIRMWARE_PROTOCOL
On 2019.11.18 17:51, Leif Lindholm wrote:
On Thu, Nov 14, 2019 at 04:07:33PM +, Pete Batard wrote:
From: Samer El-Haj-Mahmoud
Add GetModelFamily to RASPBERRY_PI_FIRMWARE_PROTOCOL.
This uses the board revision to return a numeric value representing
the RPi family (1=RPi, 2=RPi2, 3=RPi3
On 2019.11.18 17:38, Leif Lindholm wrote:
On Mon, Nov 18, 2019 at 05:34:25PM +, Pete Batard wrote:
Hi Leif,
On 2019.11.18 17:20, Leif Lindholm wrote:
On Thu, Nov 14, 2019 at 04:07:37PM +, Pete Batard wrote:
This patch improves memory initialization for the Raspberry Pi Platform
Hi Leif,
On 2019.11.18 17:20, Leif Lindholm wrote:
On Thu, Nov 14, 2019 at 04:07:37PM +, Pete Batard wrote:
This patch improves memory initialization for the Raspberry Pi Platform by:
Using VideoCore mailbox data to reserve only the regions that are actually
mapped. Especially, besides
Hi Philippe,
On 2019.11.18 11:13, Philippe Mathieu-Daudé wrote:
Hi Pete, Samer,
On 11/14/19 5:07 PM, Pete Batard wrote:
From: Samer El-Haj-Mahmoud
Set BCM2836_WDOG_BASE_ADDRESS and BCM2836_MBOX_BASE_ADDRESS to
using PCDs instead of hard-coded addresses. This is needed in
preparation
Hi Michael,
On 2019.11.14 16:36, Michael Brown wrote:
On 14/11/2019 16:07, Pete Batard wrote:
+typedef
+EFI_STATUS
+(EFIAPI *GET_MODEL_FAMILY) (
+ UINT32 *ModelFamily
+ );
+
typedef
EFI_STATUS
(EFIAPI *GET_FIRMWARE_REVISION) (
@@ -143,6 +150,7 @@ typedef struct {
GET_MODEL
unused variables such as mGPUMemoryBase and mGPUMemoryLength.
Signed-off-by: Pete Batard
---
Platform/RaspberryPi/Include/IndustryStandard/RpiMbox.h | 1 +
Platform/RaspberryPi/Library/PlatformLib/AArch64/RaspberryPiHelper.S | 75
++--
Platform/RaspberryPi/Library
From: Samer El-Haj-Mahmoud
Replace MMCHS1BASE with PcdMmcHs1BaseAddress. This is
needed in preparation for adding Raspberry Pi 4 support
Signed-off-by: Pete Batard
---
Platform/RaspberryPi/Drivers/ArasanMmcHostDxe/ArasanMmcHostDxe.inf | 1 +
Platform/RaspberryPi/RPi3/RPi3.dsc
From: Samer El-Haj-Mahmoud
Replace DW2_USB_BASE_ADDRESS with PcdDw2UsbBaseAddress. This is
needed in preparation for adding Raspberry Pi 4 support.
Signed-off-by: Pete Batard
---
Platform/RaspberryPi/Drivers/DwUsbHostDxe/DwUsbHostDxe.inf | 1 +
Platform/RaspberryPi/Drivers/DwUsbHostDxe
From: Samer El-Haj-Mahmoud
Set BCM2836_WDOG_BASE_ADDRESS and BCM2836_MBOX_BASE_ADDRESS to
using PCDs instead of hard-coded addresses. This is needed in
preparation for adding Raspberry Pi 4 support.
Signed-off-by: Pete Batard
---
Platform/RaspberryPi/Drivers/RpiFirmwareDxe/RpiFirmwareDxe.inf
also fix SoC register space that should have been marked as reserved
but wasn't until now and remove the unreferenced mSystemMemoryEnd extern
in MemoryInitPeiLib.c.
Signed-off-by: Pete Batard
---
Platform/RaspberryPi/Include/Library/RPiMem.h | 26 +++
Platform/RaspberryPi
for the new registers for now (set from a PCD as is the
case for Bcm283x) but which should get populated further as we add
support for the Raspberry Pi 4.
Signed-off-by: Pete Batard
---
Silicon/Broadcom/Bcm27xx/Bcm27xx.dec| 22
Silicon/Broadcom/Bcm27xx
for the Pi 4 and should also be easier to maintain
than if using individual model detection.
Also add a missing entry for the "Raspberry Pi Compute Module 3+" in
RpiFirmwareGetModelName ().
Signed-off-by: Pete Batard
---
Platform/RaspberryPi/Drivers/RpiFirmwareDxe/RpiFirmware
From: Samer El-Haj-Mahmoud
Define BCM2836_SOC_REGISTERS from PcdBcm283xRegistersAddress. This is
needed in preparation for adding Raspberry Pi 4 support, since the two
Pi's have a different base addresses for the Bcm283x specific registers.
Signed-off-by: Pete Batard
---
Platform/RaspberryPi
support for the new Bcm2711 SoC in
Silicon.
Some cleanup of the memory init is also applied to make that part more
generic as well as improve long term maintainability.
Regards,
/Pete
Pete Batard (3):
Silicon/Broadcom: Add Bcm2711 header
Platform/RPi: Read more variables from VideoCore
On 2019.11.07 17:27, Leif Lindholm wrote:
On Thu, Nov 07, 2019 at 05:05:20PM +, Pete Batard wrote:
Hi Leif,
On 2019.11.07 16:21, Leif Lindholm wrote:
Patch looks good, but the term "command line" is a bit confusing.
I assume we're talking about whatever way parameters are passe
t arguments" work for you? Or if
you prefer "(external) boot parameters" should be applicable too.
Regards,
/Pete
/
Leif
On Mon, Nov 04, 2019 at 04:06:17PM +, Pete Batard wrote:
From: Andrei Warkentin
It is possible for the command line to be empty
(Cmd->TagHea
From: Andrei Warkentin
It is possible for the command line to be empty
(Cmd->TagHead.TagValueSize = 0), in which case the code should not
attempt to read the value at CommandLine[-1].
Signed-off-by: Pete Batard
---
Platform/RaspberryPi/Drivers/RpiFirmwareDxe/RpiFirmwareDxe.c | 3 ++-
1 f
The existing logo bmp had its black level set to 7 instead of 0, which
produces a poor image quality on some LCDs. This patch fixes that.
Signed-off-by: Pete Batard
---
Platform/RaspberryPi/Drivers/LogoDxe/Logo.bmp | Bin 185398 -> 185398 bytes
1 file changed, 0 insertions(+), 0 deleti
On 2019.10.21 15:39, Leif Lindholm wrote:
On Mon, Oct 21, 2019 at 03:28:37PM +0100, Pete Batard wrote:
Hi Leif,
On 2019.10.21 14:46, Leif Lindholm wrote:
On Mon, Oct 21, 2019 at 03:24:47PM +0200, Ard Biesheuvel wrote:
On Mon, 21 Oct 2019 at 15:09, Philippe Mathieu-Daudé wrote:
If anything
Hi Leif,
On 2019.10.21 14:46, Leif Lindholm wrote:
On Mon, Oct 21, 2019 at 03:24:47PM +0200, Ard Biesheuvel wrote:
On Mon, 21 Oct 2019 at 15:09, Philippe Mathieu-Daudé wrote:
On 10/21/19 2:52 PM, Pete Batard wrote:
Hi Philippe,
On 2019.10.21 13:28, Philippe Mathieu-Daudé wrote:
Hi Pete
Hi Ard,
On 2019.10.21 14:24, Ard Biesheuvel wrote:
On Mon, 21 Oct 2019 at 15:09, Philippe Mathieu-Daudé wrote:
On 10/21/19 2:52 PM, Pete Batard wrote:
Hi Philippe,
On 2019.10.21 13:28, Philippe Mathieu-Daudé wrote:
Hi Pete,
On 10/21/19 1:25 PM, Pete Batard wrote:
In preparation
Hi Philippe,
On 2019.10.21 13:28, Philippe Mathieu-Daudé wrote:
Hi Pete,
On 10/21/19 1:25 PM, Pete Batard wrote:
In preparation for adding Raspberry Pi 4 support, the Pi 3 platform
is restructured by factorizing all the drivers and libraries that are
going to be commonly used by the two
-off-by: Pete Batard
---
Platform/RaspberryPi/{RPi3 => }/Drivers/LogoDxe/License.txt | 0
Platform/RaspberryPi/{RPi3 => }/Drivers/LogoDxe/Logo.bmp | Bin
Platform/RaspberryPi/{RPi3 => }/Drivers/LogoDxe/Logo.c | 0
Platform/RaspberryPi/{RPi3 => }/Drivers/Logo
tables, is moved up
into a new common RaspberryPi/ subdirectory that will serve both
platforms. The .dec is also moved to this directory, under a new
RaspberryPi.dec name, and existing references to it are updated.
No other changes are being applied at this stage.
Signed-off-by: Pete Batard
On 2019.10.18 13:52, Leif Lindholm wrote:
On Fri, Oct 18, 2019 at 01:41:30PM +0100, Pete Batard wrote:
TFTP support, which is enabled by default, can be disabled by setting
INCLUDE_TFTP_COMMAND to FALSE.
Would you be OK with flipping the default to FALSE?
Yes, I have no issue with a default
Previous version had '!ifdef $(INCLUDE_TFTP_COMMAND)' in the .fdf whereas
it was supposed to be '!if $(INCLUDE_TFTP_COMMAND) == TRUE'.
This v2 fixes that.
Pete Batard (1):
Platform/RPi3: Add TFTP command to UEFI Shell
Platform/RaspberryPi/RPi3/RPi3.dsc | 8
Platform/RaspberryPi/RPi3
TFTP support, which is enabled by default, can be disabled by setting
INCLUDE_TFTP_COMMAND to FALSE.
Signed-off-by: Pete Batard
---
Platform/RaspberryPi/RPi3/RPi3.dsc | 8
Platform/RaspberryPi/RPi3/RPi3.fdf | 3 +++
2 files changed, 11 insertions(+)
diff --git a/Platform/RaspberryPi
TFTP support, which is enabled by default, can be disabled by setting
INCLUDE_TFTP_COMMAND to FALSE.
Signed-off-by: Pete Batard
---
Platform/RaspberryPi/RPi3/RPi3.dsc | 8
Platform/RaspberryPi/RPi3/RPi3.fdf | 3 +++
2 files changed, 11 insertions(+)
diff --git a/Platform/RaspberryPi
On 2019.10.16 14:24, Leif Lindholm wrote:
On Wed, Oct 16, 2019 at 01:56:15PM +0200, Philippe Mathieu-Daudé wrote:
On 10/16/19 1:43 PM, Pete Batard wrote:
DEBUG_WARNING was invalid. DEBUG_WARN is the proper channel name to use.
Oops.
+1
Yeah, my bad here.
I was under the impression
DEBUG_WARNING was invalid. DEBUG_WARN is the proper channel name to use.
Signed-off-by: Pete Batard
---
Platform/RaspberryPi/RPi3/Drivers/PlatformSmbiosDxe/PlatformSmbiosDxe.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
a/Platform/RaspberryPi/RPi3/Drivers
.
Signed-off-by: Pete Batard
Reviewed-by: Laszlo Ersek
---
OvmfPkg/Library/PlatformBootManagerLib/BdsPlatform.c | 15 ---
1 file changed, 12 insertions(+), 3 deletions(-)
diff --git a/OvmfPkg/Library/PlatformBootManagerLib/BdsPlatform.c
b/OvmfPkg/Library/PlatformBootManagerLib
Changes from previous version:
- Additional empty comment lines above and below, to keep with existing comment
style
- Similar logic is applied to ArmVirtPkg/PlatformBootManagerLib, since the same
issue may manifest itself here.
Pete Batard (2):
OvmfPkg/PlatformBootManagerLib: Don't update
.
Signed-off-by: Pete Batard
Reviewed-by: Laszlo Ersek
---
ArmVirtPkg/Library/PlatformBootManagerLib/PlatformBm.c | 14 +++---
1 file changed, 11 insertions(+), 3 deletions(-)
diff --git a/ArmVirtPkg/Library/PlatformBootManagerLib/PlatformBm.c
b/ArmVirtPkg/Library
On 2019.10.14 12:53, Philippe Mathieu-Daudé wrote:
On 10/14/19 1:44 PM, Pete Batard wrote:
Hi Philippe,
On 2019.10.14 11:01, Philippe Mathieu-Daudé wrote:
Hi Pete,
On 10/11/19 1:07 PM, Pete Batard wrote:
The board revision is the proper channel to use to detect the amount of
RAM available
Hi Philippe,
On 2019.10.14 11:01, Philippe Mathieu-Daudé wrote:
Hi Pete,
On 10/11/19 1:07 PM, Pete Batard wrote:
The board revision is the proper channel to use to detect the amount of
RAM available as bits [20-22] report the effective RAM size for the board
starting with 256 MB (000b
Independently of the OvmfPkg fix, I think Lazlo's fix is what we ultimately
want to have, as the logic of not wanting to get calls for progress updates
if the Timeout Pcd is zet to zero stands. Plus we want to handle the 0x
case.
Therefore I am submitting Lazlo's proposed patch as well,
don't
call PlatformBootManagerWaitCallback() with a zero argument as doing so
would produce an unwarranted jump to full progress completion which is
likely to throw off users.
Signed-off-by: Pete Batard
---
MdeModulePkg/Universal/BdsDxe/BdsEntry.c | 12 +++-
1 file changed, 11 insertions
.
Signed-off-by: Pete Batard
---
OvmfPkg/Library/PlatformBootManagerLib/BdsPlatform.c | 13 ++---
1 file changed, 10 insertions(+), 3 deletions(-)
diff --git a/OvmfPkg/Library/PlatformBootManagerLib/BdsPlatform.c
b/OvmfPkg/Library/PlatformBootManagerLib/BdsPlatform.c
index 70df6b841acc
Hi Lazlo,
On 2019.10.11 12:50, Laszlo Ersek wrote:
Hi,
On 10/11/19 03:19, Liming Gao wrote:
Andrew:
I verify the change (2de1f611be06ded3a59726a4052a9039be7d459b
MdeModulePkg/BdsDxe: Also call PlatformBootManagerWaitCallback on 0)
in Emulator.
It works, because PCD value is set to
String parsing code is added to BIOSInfoUpdateSmbiosType0() so that
any numeric "x.y" value being passed in PcdFirmwareVersionString is
now used to populate the BIOS major and minor.
Signed-off-by: Pete Batard
---
Platform/RaspberryPi/RPi3/Drivers/PlatformSmbiosDxe/PlatformSmbios
Changes from v2:
- Consistent use of curly brackets for if statements
- Remove unused variables that may produce an issue with git bisect
- Use gEfiMdeModulePkgTokenSpaceGuid.PcdFirmwareVendor to populate vendor
Note that 5/5, which has been R-b, is unchanged.
Pete Batard (5):
Platform/RPi3
Improve RpiFirmwareGetSerial() to derive a serial number from the
MAC address, in case the platform returns 0 for the serial number.
Signed-off-by: Pete Batard
---
Platform/RaspberryPi/RPi3/Drivers/RpiFirmwareDxe/RpiFirmwareDxe.c | 9 -
1 file changed, 8 insertions(+), 1 deletion
This patch cleans up the population SMBIOS entries by removing elements
that we don't have data for, as well as properly filling the ones for
which we do, through the newly added queries from RpiFirmwareDxe.
Signed-off-by: Pete Batard
---
Platform/RaspberryPi/RPi3/Drivers/PlatformSmbiosDxe
in PlatformSmbiosDxe.
Signed-off-by: Pete Batard
---
Platform/RaspberryPi/RPi3/Drivers/RpiFirmwareDxe/RpiFirmwareDxe.c | 158
+++-
Platform/RaspberryPi/RPi3/Include/Protocol/RpiFirmware.h | 58 +--
2 files changed, 199 insertions(+), 17 deletions(-)
diff --git
The board revision is the proper channel to use to detect the amount of
RAM available as bits [20-22] report the effective RAM size for the board
starting with 256 MB (000b) and doubling in size for each value.
Signed-off-by: Pete Batard
Reviewed-by: Leif Lindholm
---
Platform/RaspberryPi/RPi3
On 2019.10.10 17:49, Leif Lindholm wrote:
On Thu, Oct 10, 2019 at 01:41:20PM +0100, Pete Batard wrote:
It's a disagreement. And the same goes for 3/5 & 4/5. Please see the note I
wrote in 0/5 for the v2, because the cover letter this is usually the place
I try to clarify elements that may t
On 2019.10.10 17:43, Leif Lindholm wrote:
On Thu, Oct 10, 2019 at 01:41:06PM +0100, Pete Batard wrote:
Hi Leif,
On 2019.10.10 09:39, Leif Lindholm wrote:
On Tue, Oct 08, 2019 at 01:38:37PM +0100, Pete Batard wrote:
This patch introduces the capability to also query the Model Name
301 - 400 of 464 matches
Mail list logo
