Re: [edk2-devel] [edk2-libc Patch 1/1] AppPkg/Applications/Python/Python3.6.8: add IA32 support for py3 package creation batch script

2021-09-23 Thread Rebecca Cran
Sorry I don't see it. Could you re-send it with "PATCH v2" in the subject line (by passing -v2 to "git format-patch") if you didn't already please? -- Rebecca Cran On 9/22/21 10:22 PM, Jayaprakash, N wrote: Thank you Rebecca. I have submitted the updated patch for

[edk2-devel] [PATCH v3 2/2] BaseTools: Switch to downloading the AARCH64 compiler from Arm's site

2021-09-23 Thread Rebecca Cran
Linaro no longer do gcc releases - they're done by Arm now. Update gcc_aarch64_linux_ext_dep.yaml to fetch the latest AARCH64 gcc release (10.3-2021.07) from their site. Signed-off-by: Rebecca Cran --- BaseTools/Bin/gcc_aarch64_linux_ext_dep.yaml | 10 +- BaseTools/Plugin

[edk2-devel] [PATCH v3 1/2] BaseTools: Switch to downloading the ARM compiler from Arm's site

2021-09-23 Thread Rebecca Cran
Linaro no longer do gcc releases - they're done by Arm now. Update gcc_arm_linux_ext_dep.yaml to fetch the latest ARM gcc release (10.3-2021.07) from their site. Signed-off-by: Rebecca Cran --- BaseTools/Bin/gcc_arm_linux_ext_dep.yaml | 10 +- BaseTools/Plugin

[edk2-devel] [PATCH v3 0/2] BaseTools: Switch to downloading the ARM and AARCH64 compilers from Arm's site

2021-09-23 Thread Rebecca Cran
/show_bug.cgi?id=3594 PR: https://github.com/tianocore/edk2/pull/1909 Changes from v2 to v3: Fixed the author to be @nuviainc.com instead of @bsdio.com. Rebecca Cran (2): BaseTools: Switch to downloading the ARM compiler from Arm's site BaseTools: Switch to downloading the AARCH64 compiler from

Re: [edk2-devel] [PATCH 1/1] Qemu: SbsaQemu: Set the DSDT revision value to 2 to use 64-bit math

2021-09-23 Thread Rebecca Cran
old that in. Reviewed-by: Leif Lindholm Yes, please do. -- Rebecca Cran -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#81031): https://edk2.groups.io/g/devel/message/81031 Mute This Topic: https://groups.io/mt/85802081/21656 Group Ow

Re: [edk2-devel] [edk2-libc Patch 1/1] AppPkg/Applications/Python/Python3.6.8: add IA32 support for py3 package creation batch script

2021-09-22 Thread Rebecca Cran
You should be able to use the same branch. -- Rebecca Cran On 9/21/21 8:33 PM, Jayaprakash, N wrote: Hi Rebecca, Can I resubmit the patch after making these changes in the same development branch or does it require creating a new branch? Regards, JP -Original Message- From: devel

[edk2-devel] [PATCH v2 2/2] BaseTools: Switch to downloading the AARCH64 compiler from Arm's site

2021-09-22 Thread Rebecca Cran
From: Rebecca Cran Linaro no longer do gcc releases - they're done by Arm now. Update gcc_aarch64_linux_ext_dep.yaml to fetch the latest AARCH64 gcc release (10.3-2021.07) from their site. Signed-off-by: Rebecca Cran --- BaseTools/Bin/gcc_aarch64_linux_ext_dep.yaml | 10

[edk2-devel] [PATCH v2 1/2] BaseTools: Switch to downloading the ARM compiler from Arm's site

2021-09-22 Thread Rebecca Cran
From: Rebecca Cran Linaro no longer do gcc releases - they're done by Arm now. Update gcc_arm_linux_ext_dep.yaml to fetch the latest ARM gcc release (10.3-2021.07) from their site. Signed-off-by: Rebecca Cran --- BaseTools/Bin/gcc_arm_linux_ext_dep.yaml | 10

[edk2-devel] [PATCH v2 0/2] BaseTools: Switch ARM/AARCH64 CI gcc from Linaro to Arm

2021-09-22 Thread Rebecca Cran
/show_bug.cgi?id=3594 PR: https://github.com/tianocore/edk2/pull/1909 Changes from v1 to v2: Updated LinuxGcc5ToolChain.py to fix the toolchain prefix. Rebecca Cran (2): BaseTools: Switch to downloading the ARM compiler from Arm's site BaseTools: Switch to downloading the AARCH64 compiler from

[edk2-devel] [PATCH 1/1] Qemu: SbsaQemu: Set the DSDT revision value to 2 to use 64-bit math

2021-09-22 Thread Rebecca Cran
Set the DSDT revision value to 2 by using the define from Acpi60.h EFI_ACPI_6_0_DIFFERENTIATED_SYSTEM_DESCRIPTION_TABLE_REVISION. This causes the AML interpreter to use full 64-bit integers and math. Signed-off-by: Rebecca Cran --- Silicon/Qemu/SbsaQemu/AcpiTables/Dsdt.asl | 6 -- 1 file

Re: [edk2-devel] [edk2-platforms PATCH 1/4] BeagleBoardPkg: Remove the configuration and image headers from flash

2021-09-21 Thread Rebecca Cran
Since it's been a week - "ping". -- Rebecca Cran On 9/14/21 8:39 AM, Leif Lindholm wrote: Ard, I think you were the one who converted the old crazy header stuff to what we have now. Do you remember how this all fits together? For the *other* 3 patches, but not this one: Reviewe

Re: [edk2-devel] [edk2-libc Patch 1/1] AppPkg/Applications/Python/Python3.6.8: add IA32 support for py3 package creation batch script

2021-09-21 Thread Rebecca Cran
ipt. Enhanced the script take Architecture as an additional parameter. With this the script can be used to create deployable Python 3.6.8 EFI package from X64 and IA32 builds as required by the user Cc: Rebecca Cran Cc: Michael D Kinney Signed-off-by: Jayaprakash N --- .../Python

[edk2-devel] [PATCH v2 1/1] MdeModulePkg: Add MpServicesTest application to exercise MP Services

2021-09-20 Thread Rebecca Cran
Add a new MpServicesTest application under MdeModulePkg/Application that exercises the EFI_MP_SERVICES_PROTOCOL. Signed-off-by: Rebecca Cran --- MdeModulePkg/Application/MpServicesTest/MpServicesTest.c | 433 MdeModulePkg/Application/MpServicesTest/MpServicesTest.inf

[edk2-devel] [PATCH v2 0/1] MdeModulePkg: Add MpServicesTest.efi to exercise EFI_MP_SERVICES_PROTOCOL

2021-09-20 Thread Rebecca Cran
Add a new application to MdeModulePkg to exercise EFI_MP_SERVICES_PROTOCOL. Changes from v1 to v2: Added Doxygen comments to the functions. Rebecca Cran (1): MdeModulePkg: Add MpServicesTest application to exercise MP Services MdeModulePkg/Application/MpServicesTest/MpServicesTest.c | 433

Re: [edk2-devel] [PATCH 1/1] ArmPkg/ProcessorSubClassDxe: Fix the format of ProcessorId

2021-09-16 Thread Rebecca Cran
Reviewed-by: Rebecca Cran -- Rebecca Cran On 9/15/21 7:55 AM, Nhi Pham wrote: According to SMBIOS 3.4, section 7.5.3.3 ARM64-class CPUs, if SMCCC_ARCH_SOC_ID is supported, the first DWORD is the JEP-106 code and the second DWORD is the SoC revision value. But in the current implementation

Re: [edk2-devel] [edk2-libc Patch 1/1] AppPkg/Applications/Python/Python3.6.8: add support for atexit builtin module in py 3.6.8

2021-09-15 Thread Rebecca Cran
Reviewed-by: Rebecca Cran Pushed as 60added7a61075607080ff718d7fa5e764a37044. -- Rebecca Cran On 9/14/21 9:28 AM, Jayaprakash, N wrote: REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3626 This commit adds support for the atexit a builtin module in standard python 3.6.8 to it's UEFI

Re: [edk2-devel] [PATCH 0/3] Add support for gdb and lldb

2021-09-14 Thread Rebecca Cran
I was wondering what your plan for committing these to the repo is? It would be nice to get them committed so people can start using them. -- Rebecca Cran On 8/8/21 3:46 PM, Andrew Fish via groups.io wrote: This patch set adds debugging support for gdb and lldb. It also adds generic

[edk2-devel] [edk2-platforms PATCH 4/4] Omap35xxPkg: InterruptDxe: add gEfiCpuArchProtocolGuid runtime dependency

2021-09-10 Thread Rebecca Cran
InterruptDxe requires gEfiCpuArchProtocolGuid: change the Depex line for TexasInstruments/Omap35xxPkg/InterruptDxe so the driver that provides gEfiCpuArchProtocolGuid is loaded before it. Signed-off-by: Rebecca Cran --- Silicon/TexasInstruments/Omap35xxPkg/InterruptDxe/InterruptDxe.inf | 2

[edk2-devel] [edk2-platforms PATCH 1/4] BeagleBoardPkg: Remove the configuration and image headers from flash

2021-09-10 Thread Rebecca Cran
Remove the configuration and image headers from the flash image. This was likely intended for the UEFI firmware to be loaded by the ROM code, but the BeagleBoard only has 64KB SRAM and so EDK2 needs to be executed as a second stage loader. Signed-off-by: Rebecca Cran --- Platform/BeagleBoard

[edk2-devel] [edk2-platforms PATCH 0/4] Some BeagleBoardPkg fixes

2021-09-10 Thread Rebecca Cran
the MLO loader but at 720KB it's too large for the ROM loader. I suspect I have gaps in my understanding of the board, which might make these patches unnecessary. Patch 3/4 isn't required, I just got irritated with the messages complaining about misaligned sections and decided to fix it. Rebecca Cran

[edk2-devel] [edk2-platforms PATCH 2/4] BeagleBoardPkg: Remove PerformanceLib from build

2021-09-10 Thread Rebecca Cran
PerformanceLib is related to building the ACPI Firmware Performance Data Table (FPDT). Since BeagleBoardPkg targets 32-bit ARM systems where ACPI isn't relevant, remove it. Signed-off-by: Rebecca Cran --- Platform/BeagleBoard/BeagleBoardPkg/BeagleBoardPkg.dsc | 3 --- 1 file changed, 3

[edk2-devel] [edk2-platforms PATCH 3/4] BeagleBoardPkg: Align PE sections to 4K

2021-09-10 Thread Rebecca Cran
Add build options to BeagleBoardPkg.dsc to align PE sections to 4K. This avoids warnings during boot when loading drivers. Signed-off-by: Rebecca Cran --- Platform/BeagleBoard/BeagleBoardPkg/BeagleBoardPkg.dsc | 4 1 file changed, 4 insertions(+) diff --git a/Platform/BeagleBoard

[edk2-devel] [PATCH 1/1] MdeModulePkg: Add MpServicesTest application to exercise MP Services

2021-09-10 Thread Rebecca Cran
Add a new MpServicesTest application under MdeModulePkg/Application that exercises the EFI_MP_SERVICES_PROTOCOL. Signed-off-by: Rebecca Cran --- MdeModulePkg/Application/MpServicesTest/MpServicesTest.c | 389 MdeModulePkg/Application/MpServicesTest/MpServicesTest.inf

Re: [edk2-devel] [edk2-libc Patch 1/1] edk2-libc/Readme.md: Updated Readme.md with Python 3.6.8 License details

2021-09-10 Thread Rebecca Cran
Pushed as ce35be387725cf6bb1caefa4d4b0bd48ea72cbfa. -- Rebecca Cran On 9/8/21 10:54 AM, Jayaprakash Nevara wrote: REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3611 This commit contains updates made to the Readme.md file of edk2-libc repo to add the Python 3.6.8 license

Re: [edk2-devel] [edk2-libc Patch 1/1] edk2-libc/Readme.md: Updated Readme.md with Python 3.6.8 License details

2021-09-10 Thread Rebecca Cran
Sorry for the delay -- I've been trying to find time to make sure I can follow the process correctly. I've just pushed the change as ce35be387725cf6bb1caefa4d4b0bd48ea72cbfa. For future patches, please add a Signed-off-by line. -- Rebecca Cran On 9/9/21 12:12 AM, Jayaprakash, N wrote

Re: [edk2-devel] [edk2-libc Patch 1/1] AppPkg/Applications/Python/Python-3.6.8: Py 3.6.8 UEFI changes

2021-09-02 Thread Rebecca Cran
Thanks, that makes sense. I haven't reviewed the entire patch, so I've given an Acked-by instead. -- Rebecca Cran On 9/2/21 2:46 PM, Kinney, Michael D wrote: Hi Rebecca, Responses below. Some of the items you are observing are due to following the exact same pattern as the Python 2.x

Re: [edk2-devel] [edk2-libc Patch 1/1] AppPkg/Applications/Python/Python-3.6.8: Py 3.6.8 UEFI changes

2021-09-02 Thread Rebecca Cran
/Python-3.6.8/create_python368_pkg.bat The xcopy commands should probably have error checking after them. -- Rebecca Cran -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#80177): https://edk2.groups.io/g/devel/message/80177 Mute

Re: [edk2-devel] [edk2-libc Patch] StdLib/LibC: Fix corner case in use of StrnCpyS() and AsciiStrnCpyS()

2021-09-01 Thread Rebecca Cran
Reviewed-by: Rebecca Cran -- Rebecca Cran On 9/1/21 1:18 AM, Michael D Kinney wrote: REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3361 DestMax must be > Length or StrnCpyS() and AsciiStrnCpyS() return an error. Set DestMax to n + 1 for these LibC APIs. Cc: Rebecca Cran

[edk2-devel] MdeModulePkg: ARM alignment issues in InsertFpdt function in DxeCorePerformanceLib

2021-08-31 Thread Rebecca Cran
of the FPDT_DUAL_GUID_STRING_EVENT_RECORD structure is unaligned. I don't know if we should disable alignment checking for BeagleBoardPkg, or change DxeCorePerformanceLib? -- Rebecca Cran -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#80045): https://edk2

Re: [edk2-devel] [edk2-libc Patch 0/2] Resolve CLANGPDB build issues

2021-08-31 Thread Rebecca Cran
For the series: Reviewed-by: Rebecca Cran On 8/31/21 3:49 PM, Michael D Kinney wrote: REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1618 * Disable warnings for unused variables * Define __FILE__ to be __FILE_NAME__ * Disable warnings for unused command line arguments. * Define

Re: [edk2-devel] [edk2-libc Patch] StdLib: Update libs for safe string functional issues

2021-08-31 Thread Rebecca Cran
Reviewed-by: Rebecca Cran On 8/31/21 3:20 PM, Michael D Kinney wrote: From: Jayaprakash Nevara REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3361 Update use of safe string functions that incorrectly assume that the maximum size of a string is UNICODE_STRING_MAX. This assumption

[edk2-devel] [PATCH 1/1] MdeModulePkg: Fix typo of "memory" in RamDiskDxe debug message

2021-08-30 Thread Rebecca Cran
Fix a typo of "memory" in a debug message in RamDiskProtocol.c. Signed-off-by: Rebecca Cran --- MdeModulePkg/Universal/Disk/RamDiskDxe/RamDiskProtocol.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MdeModulePkg/Universal/Disk/RamDiskDxe/RamDiskProtocol.c b/Md

[edk2-devel] [PATCH v2 2/2] BaseTools: Switch to downloading the AARCH64 compiler from Arm's site

2021-08-29 Thread Rebecca Cran
Linaro no longer do gcc releases - they're done by Arm now. Update gcc_aarch64_linux_ext_dep.yaml to fetch the latest AARCH64 gcc release (10.3-2021.07) from their site and fix LinuxGcc5ToolChain.py with the new GCC_AARCH64_PREFIX. Signed-off-by: Rebecca Cran --- BaseTools/Bin

[edk2-devel] [PATCH v2 1/2] BaseTools: Switch to downloading the ARM compiler from Arm's site

2021-08-29 Thread Rebecca Cran
Linaro no longer do gcc releases - they're done by Arm now. Update gcc_arm_linux_ext_dep.yaml to fetch the latest ARM gcc release (10.3-2021.07) from their site and fix LinuxGcc5ToolChain.py with the new GCC_ARM_PREFIX. Signed-off-by: Rebecca Cran --- BaseTools/Bin/gcc_arm_linux_ext_dep.yaml

[edk2-devel] [PATCH v2 0/2] BaseTools: Switch to downloading the ARM/AARCH64 compiler from Arm's site

2021-08-29 Thread Rebecca Cran
Linaro no longer do gcc releases - Arm creates them now. Update the gcc_[arm,aarch64]_linux_ext_dep.yaml files in BaseTools/Bin to switch from Linaro's old release to the latest gcc 10.3-2021.07 release from Arm and fix LinuxGcc5ToolChain.py with the new gcc prefix. Rebecca Cran (2

Re: [edk2-devel] [PATCH 0/2] BaseTools: Switch ARM/AARCH64 CI gcc from Linaro to Arm

2021-08-27 Thread Rebecca Cran
On 8/27/2021 1:31 PM, Ard Biesheuvel wrote: On Thu, 26 Aug 2021 at 23:03, Rebecca Cran wrote: I've created a ticket in Bugzilla: https://bugzilla.tianocore.org/show_bug.cgi?id=3594. -- Rebecca Cran On 8/22/21 11:35 PM, Rebecca Cran wrote: Linaro no longer do gcc releases - Arm creates

Re: [edk2-devel] [PATCH 0/2] BaseTools: Switch ARM/AARCH64 CI gcc from Linaro to Arm

2021-08-26 Thread Rebecca Cran
I've created a ticket in Bugzilla: https://bugzilla.tianocore.org/show_bug.cgi?id=3594. -- Rebecca Cran On 8/22/21 11:35 PM, Rebecca Cran wrote: Linaro no longer do gcc releases - Arm creates them now. Update the gcc_[arm,aarch64]_linux_ext_dep.yaml files in BaseTools/Bin to switch from

[edk2-devel] [PATCH 2/2] BaseTools: Switch to downloading the AARCH64 compiler from Arm's site

2021-08-22 Thread Rebecca Cran
Linaro no longer do gcc releases - they're done by Arm now. Update gcc_aarch64_linux_ext_dep.yaml to fetch the latest AARCH64 gcc release (10.3-2021.07) from their site. Signed-off-by: Rebecca Cran --- BaseTools/Bin/gcc_aarch64_linux_ext_dep.yaml | 10 +- 1 file changed, 5 insertions

[edk2-devel] [PATCH 0/2] BaseTools: Switch ARM/AARCH64 CI gcc from Linaro to Arm

2021-08-22 Thread Rebecca Cran
with GCC5_[ARM,AARCH64]_PREFIX. I don't know if there are more changes I need to add, or if it's a problem with the CI system. Rebecca Cran (2): BaseTools: Switch to downloading the ARM compiler from Arm's site BaseTools: Switch to downloading the AARCH64 compiler from Arm's site BaseTools

[edk2-devel] [PATCH 1/2] BaseTools: Switch to downloading the ARM compiler from Arm's site

2021-08-22 Thread Rebecca Cran
Linaro no longer do gcc releases - they're done by Arm now. Update gcc_arm_linux_ext_dep.yaml to fetch the latest ARM gcc release (10.3-2021.07) from their site. Signed-off-by: Rebecca Cran --- BaseTools/Bin/gcc_arm_linux_ext_dep.yaml | 10 +- 1 file changed, 5 insertions(+), 5

[edk2-devel] [edk2-platforms PATCH 1/1] Fix AMD/OverdriveBoard and SoftIron/Overdrive1000Board builds

2021-08-20 Thread Rebecca Cran
BdsDxe depends on VariablePolicyHelperLib, so move it out from VariableRuntimeDxe.inf and add it to LibraryClasses.DXE_DRIVER and LibraryClasses.DXE_RUNTIMER_DRIVER. This fixes the build of AMD/OverdriveBoard and SoftIron/Overdrive1000Board. Signed-off-by: Rebecca Cran --- Platform/AMD

[edk2-devel] [edk2-platforms PATCH 0/1] Fix the AMD/OverdriveBoard and

2021-08-20 Thread Rebecca Cran
This patch fixes the AMD/OverdriveBoard and AMD/Overdrive1000Board builds. I don't have an AMD Overdrive, but I tested the Overdrive1000Board changes on my Overdrive 1000 system by booting openSUSE Leap 15.3 and FreeBSD 12. Rebecca Cran (1): Fix AMD/OverdriveBoard and SoftIron

Re: [edk2-devel] [edk2-libc Patch] StdLib/LibC/Uefi/Devices/Utility: Fix use after free

2021-08-18 Thread Rebecca Cran
Reviewed-by: Rebecca Cran -- Rebecca Cran On 8/18/21 5:45 PM, Michael D Kinney wrote: REF: https://bugzilla.tianocore.org/show_bug.cgi?id=38 Set MPath to NULL after free(MPath) to guarantee that MPath is not used after the free() call. Cc: Rebecca Cran Signed-off-by: Michael D Kinney

Re: [edk2-devel] [edk2-libc Patch] AppPkg/Applications/Sockets/SetHostName: Fix spelling of "Platform"

2021-08-18 Thread Rebecca Cran
Reviewed-by: Rebecca Cran -- Rebecca Cran On 8/18/21 4:49 PM, Michael D Kinney wrote: REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1664 Cc: Rebecca Cran Signed-off-by: Michael D Kinney --- AppPkg/Applications/Sockets/SetHostName/SetHostName.c | 2 +- 1 file changed, 1 insertion

Re: [edk2-devel] [edk2-libc Patch] StdLib/Include/sys/syslimits.h: Increase OPEN_MAX from 20 to 255

2021-08-18 Thread Rebecca Cran
Reviewed-by: Rebecca Cran On 8/13/21 10:33 AM, Michael D Kinney wrote: From: Jayaprakash Nevara REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3548 A port of Python 3.6.8 interpreter for UEFI uses the standard C Library from the edk2-libc project. The python interpreter fails

Re: [edk2-devel] [edk2-libc Patch] StdLib/LibC/StdLib: Handle possible math overflow in malloc()

2021-08-18 Thread Rebecca Cran
Reviewed-by: Rebecca Cran Not sure the first \n is needed though. -- Rebecca Cran On 8/18/21 4:03 PM, Michael D Kinney wrote: REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1510 Check for addition overflow in malloc() when computing NodeSize and return error if overflow is detected

Re: [edk2-devel] [edk2-libc Patch] StdLib/PosixLib/GetPass: Update to use safe string functions

2021-08-18 Thread Rebecca Cran
Reviewed-by: Rebecca Cran -- Rebecca Cran On 8/17/21 9:32 AM, Michael D Kinney wrote: REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3361 Cc: Rebecca Cran Signed-off-by: Michael D Kinney --- StdLib/PosixLib/GetPass/GetPass.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion

Re: [edk2-devel] [edk2-libc Patch V2 0/9] Update for edk2/master and VS2017/VS2019

2021-08-18 Thread Rebecca Cran
For the entire series: Reviewed-by: Rebecca Cran -- Rebecca Cran On 8/18/21 3:28 PM, Michael D Kinney wrote: REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3549 New in V2 = * Add LibNetUtil to StdLib/BsdSocketLib in alphebetic order * Add comments explaining why SocketDxe

Re: [edk2-devel] [edk2-libc Patch 0/9] Update for edk2/master and VS2017/VS2019

2021-08-18 Thread Rebecca Cran
For patches 1,2,4,7-9: Reviewed-by: Rebecca Cran -- Rebecca Cran On 8/17/21 11:41 PM, Michael D Kinney wrote: Update AppPkg and StdLib* to build using latest edk2/master and support VS2017 and VS2019. Most of the changes are related to warning levels, missing symbols and duplicate

Re: [edk2-devel] [edk2-libc Patch 3/9] StdLib: Remove SocketDxe from build

2021-08-18 Thread Rebecca Cran
Maybe add a comment saying why it's disabled, in case fixing it takes some time? -- Rebecca Cran On 8/17/21 11:42 PM, Michael D Kinney wrote: REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3549 SocketDxe generates build failures with VS2017 and VS2019 due to use of weak references

Re: [edk2-devel] [edk2-libc Patch] Maintainers.txt: Update maintainers for AppPkg and StdLib*

2021-08-17 Thread Rebecca Cran
Reviewed-by: Rebecca Cran On 8/17/21 9:16 AM, Michael D Kinney wrote: Cc: Rebecca Cran Cc: Daryl McDaniel Cc: Jaben Carsey Signed-off-by: Michael D Kinney --- Maintainers.txt | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/Maintainers.txt b/Maintainers.txt

Re: [edk2-devel] Progress on getting Uncrustify working for EDK2?

2021-08-16 Thread Rebecca Cran
cc devel@ . On 8/16/21 1:33 PM, Rebecca Cran wrote: I noticed a message on Twitter about an idea of using Uncrustify for EDK2 instead of the ECC tool, and came across https://www.mail-archive.com/search?l=devel@edk2.groups.io=subject:%22Re%5C%3A+%5C%5Bedk2%5C-devel%5C%5D+TianoCore+Community

Re: [edk2-devel] [PATCH 0/3] Add support for gdb and lldb

2021-08-12 Thread Rebecca Cran
or: Frame is invalid. However, I can run 'bt' and get what looks like a good stack trace. With the latest code on your private branch, I still see non-ASCII characters that look out of place. e.g. In efi_debugging.py line 627, "Attributes" is underlined with a mixture of hy

Re: [edk2-devel] [edk2-libc PATCH 1/1] Update LibC to use safe string functions

2021-08-12 Thread Rebecca Cran
Thanks! I've just closed https://bugzilla.tianocore.org/show_bug.cgi?id=3361 . -- Rebecca Cran On 8/12/21 8:16 PM, Kinney, Michael D wrote: Pushed 66dd218b89c6cf84b439618338c563274ed0ae4c Mike -Original Message- From: Kinney, Michael D Sent: Thursday, August 12, 2021 7:10 PM

Re: [edk2-devel] [PATCH v2] Xcode.md: Update instructions to work on modern macOS and Xcode versions

2021-08-12 Thread Rebecca Cran
Thanks, that looks good. Rebecca Cran > On Aug 12, 2021, at 7:32 PM, gaoliming wrote: > > Rebecca: > I just merge it. Please check. > > Thanks > Liming >> -邮件原件- >> 发件人: devel@edk2.groups.io 代表 Rebecca Cran >> 发送时间: 2021年8月13日 0:56 >

Re: [edk2-devel] [PATCH v2] Xcode.md: Update instructions to work on modern macOS and Xcode versions

2021-08-12 Thread Rebecca Cran
Could you push the commit please? https://github.com/tianocore/tianocore.github.io/wiki/Xcode is still showing the old content. Thanks. Rebecca Cran On 7/22/2021 1:10 AM, Andrew Fish wrote: Reviewed-by: Andrew Fish On Jul 21, 2021, at 4:56 PM, Rebecca Cran wrote: The existing

Re: [edk2-devel] [PATCH 0/3] Add support for gdb and lldb

2021-08-11 Thread Rebecca Cran
of typos of 'dictionary': _dict_ : dictionay -- Rebecca Cran On 8/8/21 3:46 PM, Andrew Fish via groups.io wrote: This patch set adds debugging support for gdb and lldb. It also adds generic debugging classes that use a file like object to make it easy to import into any debugger that supports

Re: [edk2-devel] [edk2-discuss] State of the `edk2-libc` project

2021-08-02 Thread Rebecca Cran
By the lack of replies, I suspect we should bring it up as a topic of discussion in the Community Meeting next week. -- Rebecca Cran On 7/14/21 1:43 PM, Rebecca Cran wrote: I submitted a patch to fix it several weeks ago, but it never got committed. Rebecca Cran On Jul 14, 2021, at 11:36

Re: [edk2-devel] "StdLibPkg" branch on edk2-staging

2021-07-28 Thread Rebecca Cran
as: StdLib, StdLibPrivateInternalFiles W: https://github.com/tianocore/tianocore.github.io/wiki/StdLib M: Daryl McDaniel M: Jaben Carsey -- Rebecca Cran On 7/28/21 4:25 PM, tim.le...@insyde.com wrote: I would point out that there was significant work on libc in the past (see https

Re: [edk2-devel] "StdLibPkg" branch on edk2-staging

2021-07-28 Thread Rebecca Cran
I think it's mostly been abandoned, and people are expected to use native UEFI functions instead. Personally I'd like to see it continue to be maintained. -- Rebecca Cran On 7/28/21 9:45 AM, Maciej Rabeda wrote: Naturally. Since it is there, why is it not used for brotli, openssl

Re: [edk2-devel] "StdLibPkg" branch on edk2-staging

2021-07-28 Thread Rebecca Cran
Are you aware of the edk2-libc project at https://github.com/tianocore/edk2-libc ? -- Rebecca Cran On 7/27/21 9:48 AM, Maciej Rabeda wrote: Hi, I have submitted a new edk2-staging branch named "StdLibPkg". https://github.com/tianocore/edk2-staging/tree/StdLibPkg Branch contai

Re: [edk2-devel] [tianocore.github.io.wiki PATCH 1/1] Xcode.md: Update instructions to work on modern macOS and Xcode versions

2021-07-21 Thread Rebecca Cran
Thanks. I've just sent out a v2 with the MacPorts instructions removed. -- Rebecca Cran On 7/21/21 8:30 AM, Andrew Fish wrote: On Jul 21, 2021, at 7:24 AM, Rebecca Cran <mailto:rebe...@bsdio.com>> wrote: I think most people (including myself) use brew nowadays, which install

[edk2-devel] [PATCH v2] Xcode.md: Update instructions to work on modern macOS and Xcode versions

2021-07-21 Thread Rebecca Cran
tools with it, leaving steps for using Homebrew. Signed-off-by: Rebecca Cran --- Xcode.md | 172 +--- 1 file changed, 78 insertions(+), 94 deletions(-) diff --git a/Xcode.md b/Xcode.md index 3d220a5..8af2653 100644 --- a/Xcode.md +++ b/Xcode.md @@ -1,43 +1,28 @@ -This page

Re: [edk2-devel] [tianocore.github.io.wiki PATCH 1/1] Xcode.md: Update instructions to work on modern macOS and Xcode versions

2021-07-21 Thread Rebecca Cran
I think most people (including myself) use brew nowadays, which installs to /usr/local/bin so the instructions work. I was wondering if we should remove the MacPorts instructions? -- Rebecca Cran On 7/20/21 11:37 PM, Andrew Fish wrote: These Xcode instructions look good to me in general

Re: [edk2-devel] [edk2-libc PATCH 1/1] Update LibC to use safe string functions

2021-07-20 Thread Rebecca Cran
This hasn't had any reviews yet. Could someone take a look at it please? Thanks. Rebecca Cran On 6/7/21 10:21 AM, Rebecca Cran via groups.io wrote: The insecure string functions such as StrCpy were removed a while ago, breaking the StdLib build. Migrate StdLib/LibC to the safe string

Re: [edk2-devel] Gdb and lldb support for OVMF and more

2021-07-20 Thread Rebecca Cran
uot;[edk2-devel] [tianocore.github.io.wiki PATCH 1/1] Xcode.md: Update instructions to work on modern macOS and Xcode versions" please? If you don't have time to verify them, perhaps they could be committed anyway since they're likely more accurate than the existing outdated page? Thanks. Re

Re: [edk2-devel] [PATCH v3 2/2] OvmfPkg/Bhyve: use static PCI32Base address

2021-07-02 Thread Rebecca Cran
Acked-by: Rebecca Cran On 7/1/21 6:01 AM, Corvin Köhne wrote: It's neccessary to allocate a Graphics Stolen Memory area to enable GPU-Passthrough for integrated Intel GPUs. Therefore, use a new memory layout with a static Pci32Baseaddress. Old layout: [..., lowmemlimit] RAM

Re: [EXTERNAL] Re: [edk2-devel] Do the edk2 CI unit tests work in Linux?

2021-07-01 Thread Rebecca Cran
a lot. -- Rebecca Cran On 7/1/21 7:36 PM, Steven Shi wrote: I already installed mono, but NuGet.exe still fails to work in my side. I’m behind a proxy but don’t know how to configure the NuGet.exe proxy in .pytool. Below is my verbose error message. (unit_test_env) jshi19@ub2-uefi-b01

Re: [edk2-devel] Do the edk2 CI unit tests work in Linux?

2021-06-29 Thread Rebecca Cran
Your Linux distribution should have a nuget package available (e.g. https://packages.ubuntu.com/hirsute/nuget) but the EDK2 CI is designed to use the copy of nuget installed with the edk2toolext package. -- Rebecca Cran On 6/29/21 9:44 AM, Steven Shi wrote: Cran, Thanks. I’m curious

Re: [edk2-devel] Do the edk2 CI unit tests work in Linux?

2021-06-29 Thread Rebecca Cran
I think he's referring to NuGet.exe, which unless you're familiar with .NET appears to be a Windows executable. -- Rebecca Cran On 6/29/21 9:59 AM, Bret Barkelew wrote: Which executable are you referring to? Also, yes, it is entirely possible that Linux has more dependencies since

Re: [edk2-devel] Do the edk2 CI unit tests work in Linux?

2021-06-29 Thread Rebecca Cran
NuGet.exe is a .NET assembly/executable, so on Linux you'll need to install Mono (https://www.mono-project.com/). -- Rebecca Cran On 6/28/21 7:45 PM, Steven Shi wrote: Hello, I’m interested in the edk2 CI unit tests(https://github.com/tianocore/edk2/tree/master/.pytool <ht

Re: [edk2-devel] Recommended VSCode Extensions and Settings

2021-06-17 Thread Rebecca Cran
I wonder, should we add a .vscode directory in the edk2 repo and add the recommended extensions to an extensions.json file (See Workspace Recommended Extensions in https://code.visualstudio.com/docs/editor/extension-marketplace)? -- Rebecca Cran On 6/17/21 12:39 AM, Nate DeSimone wrote

[edk2-devel] OvmfPkgIa32X64.dsc is broken: OvmfPkg/Sec/SecMain.inf NOT found in DSC file; Is it really a binary module?

2021-06-16 Thread Rebecca Cran
ild total time: 00:00:01 -- Rebecca Cran -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#76645): https://edk2.groups.io/g/devel/message/76645 Mute This Topic: https://groups.io/mt/83597788/21656 Group Owner: devel+ow...@edk2.groups

[edk2-devel] [PATCH v2 1/1] ArmPkg: Move cache defs used in Universal/Smbios into ArmCache.h

2021-06-14 Thread Rebecca Cran
Many of the cache definitions in ArmLibPrivate.h are being used outside of ArmLib, in Universal/Smbios. Move them into ArmCache.h to make them public, and remove the include of ArmLibPrivate.h from files in Universal/Smbios. Signed-off-by: Rebecca Cran --- ArmPkg/Include/IndustryStandard

Re: [edk2-devel] [PATCH] MdePkg/Include: Smbios Specification 3.4.0 changes

2021-06-13 Thread Rebecca Cran
There’s a typo of ‘persistent’ in: // Optane DC Presistent Memory in SMBIOS spec 3.4.0 Rebecca Cran > On Jun 2, 2021, at 10:46 AM, Thotala, Gopi wrote: > >  > Initial patch submitted for review. > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages

[edk2-devel] [PATCH] BaseTools: Fix spelling of "overwrite" and "overwriting" in toolset.bat

2021-06-12 Thread Rebecca Cran
The words "overwrite" and "overwriting" are one word and shouldn't have hyphens. Signed-off-by: Rebecca Cran --- BaseTools/toolsetup.bat | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/BaseTools/toolsetup.bat b/BaseTools/toolsetup.bat index 4b

[edk2-devel] [PATCH] BaseTools: Reset ERRORLEVEL in toolsetup.bat after edk2basetools check

2021-06-12 Thread Rebecca Cran
When using the in-source BaseTools, edksetup.bat will exit with an ERRORLEVEL of 1 because the line in toolsetup.bat "%PYTHON_COMMAND% -c "import edk2basetools" >NUL 2>NUL" fails. Ensure ERRORLEVEL is set to 0 when edksetup.bat or toolsetup.bat is successfully run. S

[edk2-devel] [PATCH] BaseTools: Remove check for Split.exe in toolset.bat

2021-06-12 Thread Rebecca Cran
Split is now a Python tool, so BaseTools\Bin\Win32\Split.exe no longer exists. Remove the check for it from toolsetup.bat to prevent the erroneous claim that the binary C tools are missing. Signed-off-by: Rebecca Cran --- BaseTools/toolsetup.bat | 1 - 1 file changed, 1 deletion(-) diff --git

Re: 回复: [edk2-devel] [PATCH] EmulatorPkg: Update lldbefi.py to work with current lldb which uses python3

2021-06-12 Thread Rebecca Cran
Could someone commit this please? -- Rebecca Cran On 5/17/21 6:45 PM, gaoliming wrote: Rebecca: This change supports python2 & python3 both. So, I think this is a good fix. Reviewed-by: Liming Gao Thanks Liming -邮件原件- 发件人: devel@edk2.groups.io 代表 Rebecca Cran 发送时间: 2021年5

[edk2-devel] [PATCH] OvmfPkg/Bhyve: Remove Xen remnants

2021-06-12 Thread Rebecca Cran
Several Xen remnants were left over from adapting the Ovmf code for Bhyve. Remove them. Signed-off-by: Rebecca Cran --- OvmfPkg/Bhyve/AcpiPlatformDxe/AcpiPlatform.h | 7 --- OvmfPkg/Bhyve/BhyveX64.dsc | 1 - OvmfPkg/Bhyve/PlatformPei/Platform.h | 17

[edk2-devel] [PATCH] OvmfPkg/Bhyve: clean up TPM_ENABLE remnants

2021-06-12 Thread Rebecca Cran
TPM support hasn't been tested and any lines in the .dsc and .fdf files that appear to show support are bogus. Remove them. This fixes https://bugzilla.tianocore.org/show_bug.cgi?id=3354 . Signed-off-by: Rebecca Cran --- OvmfPkg/Bhyve/BhyveX64.dsc | 64 OvmfPkg/Bhyve

Re: [edk2-devel] [PATCH 1/1] ArmPkg: Move cache defs used in Universal/Smbios into ArmLib.h

2021-06-10 Thread Rebecca Cran
On 6/10/21 9:04 AM, Ard Biesheuvel wrote: On Tue, 8 Jun 2021 at 15:54, Rebecca Cran wrote: Many of the cache definitions in ArmLibPrivate.h are being used outside of ArmLib, in Universal/Smbios. Move them into ArmLib.h to make them public, and remove the include of ArmLibPrivate.h from files

[edk2-devel] [PATCH 1/1] ArmPkg: Move cache defs used in Universal/Smbios into ArmLib.h

2021-06-08 Thread Rebecca Cran
Many of the cache definitions in ArmLibPrivate.h are being used outside of ArmLib, in Universal/Smbios. Move them into ArmLib.h to make them public, and remove the include of ArmLibPrivate.h from files in Universal/Smbios. Signed-off-by: Rebecca Cran --- ArmPkg/Include/Library/ArmLib.h

[edk2-devel] [edk2-libc PATCH 1/1] Update LibC to use safe string functions

2021-06-07 Thread Rebecca Cran
The insecure string functions such as StrCpy were removed a while ago, breaking the StdLib build. Migrate StdLib/LibC to the safe string versions. Signed-off-by: Rebecca Cran --- StdLib/LibC/StdLib/Environs.c | 11 ++- StdLib/LibC/StdLib/realpath.c | 5 +++-- StdLib

Re: [edk2-devel] [tianocore.github.io.wiki PATCH 1/1] Xcode.md: Update instructions to work on modern macOS and Xcode versions

2021-06-03 Thread Rebecca Cran
Is there any way I can help? For example I have a Mac Pro I could give you remote access to. -- Rebecca Cran On 5/23/21 3:00 PM, Andrew (EFI) Fish wrote: I’ll take a look . I need to grab a blank system and give it a try. Sent from my iPhone On May 23, 2021, at 9:12 AM, Rebecca Cran

[edk2-devel] [edk2-platforms PATCH 1/1] Readme.md: Refer users to the Arm GNU-A Downloads page for toolchains

2021-05-28 Thread Rebecca Cran
Arm now provides the latest gcc toolchains for aarch64 and arm: the Linaro page that was linked to no longer exists. Signed-off-by: Rebecca Cran --- Readme.md | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/Readme.md b/Readme.md index aba26e29a672..d8cd211334bc 100644

[edk2-devel] [PATCH v2] Platform/ARM: Update Readme.md

2021-05-28 Thread Rebecca Cran
. Signed-off-by: Rebecca Cran Reviewed-by: Chris Jones --- Platform/ARM/Readme.md | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/Platform/ARM/Readme.md b/Platform/ARM/Readme.md index e1a405b700..fae854fe6d 100644 --- a/Platform/ARM/Readme.md +++ b/Platform

Re: [edk2-devel] [PATCH 30/43] OvmfPkg/Bhyve: consume PciHostBridgeLibScan

2021-05-26 Thread Rebecca Cran
Biesheuvel Cc: Jordan Justen Cc: Peter Grehan Cc: Philippe Mathieu-Daudé Cc: Rebecca Cran Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2122 Signed-off-by: Laszlo Ersek --- OvmfPkg/Bhyve/BhyveX64.dsc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/OvmfPkg/Bhyv

Re: [edk2-devel] [PATCH 24/43] OvmfPkg/Bhyve: make "PcdPciDisableBusEnumeration" Fixed-at-Build

2021-05-26 Thread Rebecca Cran
Cc: Jordan Justen Cc: Peter Grehan Cc: Philippe Mathieu-Daudé Cc: Rebecca Cran Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2122 Signed-off-by: Laszlo Ersek --- OvmfPkg/Bhyve/BhyveX64.dsc| 2 +- OvmfPkg/Bhyve/PlatformPei/PlatformPei.inf | 1 - 2 files changed, 1 inse

Re: [edk2-devel] [PATCH 17/43] OvmfPkg/Bhyve/AcpiPlatformDxe: fix file path typo in comment

2021-05-26 Thread Rebecca Cran
pe Mathieu-Daudé Cc: Rebecca Cran Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2122 Signed-off-by: Laszlo Ersek --- OvmfPkg/Bhyve/AcpiPlatformDxe/AcpiPlatform.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/OvmfPkg/Bhyve/AcpiPlatformDxe/AcpiPlatform.c b/OvmfPkg/B

Re: [edk2-devel] [tianocore.github.io.wiki PATCH 1/1] Xcode.md: Update instructions to work on modern macOS and Xcode versions

2021-05-25 Thread Rebecca Cran
tever your local clone contains. And, only the "master" branch matters for rendering, AFAICT. Ah, got it - thanks. The updated Xcode.md page is at https://github.com/bcran/edk2/wiki/Xcode -- Rebecca Cran -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to th

Re: [edk2-devel] [tianocore.github.io.wiki PATCH 1/1] Xcode.md: Update instructions to work on modern macOS and Xcode versions

2021-05-23 Thread Rebecca Cran
On 5/23/2021 2:51 AM, Laszlo Ersek wrote: On 05/21/21 20:28, Rebecca Cran wrote: Could someone review this please? I submitted it almost 2 weeks ago. I've been aware of it, but I've not once launched (or even seen) Xcode, so I can't verify the patch. One thing by which you could help Andrew

Re: [edk2-devel] [tianocore.github.io.wiki PATCH 1/1] Xcode.md: Update instructions to work on modern macOS and Xcode versions

2021-05-21 Thread Rebecca Cran
Could someone review this please? I submitted it almost 2 weeks ago. -- Rebecca Cran On 5/9/21 1:18 PM, Rebecca Cran wrote: The existing instructions no longer work on macOS Big Sur and Xcode 12.5. Update them to include for example using lldb instead of gdb, installing XQuartz, and using

[edk2-devel] [PATCH 1/1] Update Home.md with the latest stable tag

2021-05-19 Thread Rebecca Cran
Update the home page to list the correct latest stable tag of edk2-stable202102. Signed-off-by: Rebecca Cran --- Home.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Home.md b/Home.md index cf165b06194b..9d067ffe97f9 100644 --- a/Home.md +++ b/Home.md @@ -1,6 +1,6

Re: [edk2-devel] [PATCH] EmulatorPkg: Update lldbefi.py to work with current lldb which uses python3

2021-05-17 Thread Rebecca Cran
Could someone review this please? Thanks. Rebecca Cran On 5/9/21 1:26 PM, Rebecca Cran wrote: The version of lldb shipping with macOS Big Sur is lldb-1205.0.27.3, and it uses python3. Update lldbefi.py to work with it, including removing the unused 'commands' import and fixing the print

Re: [edk2-devel] [tianocore.github.io.wiki PATCH 1/1] Xcode.md: Update instructions to work on modern macOS and Xcode versions

2021-05-17 Thread Rebecca Cran
Andrew, could you review this please? Thanks. Rebecca Cran On 5/9/21 1:18 PM, Rebecca Cran wrote: The existing instructions no longer work on macOS Big Sur and Xcode 12.5. Update them to include for example using lldb instead of gdb, installing XQuartz, and using modern names such as macOS

[edk2-devel] [edk2-platforms PATCH] Platform/ARM: Update Readme.md

2021-05-13 Thread Rebecca Cran
. Signed-off-by: Rebecca Cran --- Platform/ARM/Readme.md | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/Platform/ARM/Readme.md b/Platform/ARM/Readme.md index e1a405b700..afc9ad3646 100644 --- a/Platform/ARM/Readme.md +++ b/Platform/ARM/Readme.md @@ -8,10 +8,8

Re: [edk2-devel] Build fails with VS2012

2021-05-10 Thread Rebecca Cran
try without building it themselves? Or would that be something that might be useful for me to implement as a third-party solution? -- Rebecca Cran On 5/10/21 5:31 PM, Michael D Kinney wrote: I think there a few categories of tool chains: 1) Tool chains that are in tools_def.txt and are used

[edk2-devel] [PATCH v3 2/2] SecurityPkg: Add support for RngDxe on AARCH64

2021-05-10 Thread Rebecca Cran
AARCH64 support has been added to BaseRngLib via the optional ARMv8.5 FEAT_RNG. Refactor RngDxe to support AARCH64, note support for it in the VALID_ARCHITECTURES line of RngDxe.inf and enable it in SecurityPkg.dsc. Signed-off-by: Rebecca Cran --- SecurityPkg/SecurityPkg.dec

[edk2-devel] [PATCH v3 1/2] MdePkg/BaseRngLib: Add support for ARMv8.5 RNG instructions

2021-05-10 Thread Rebecca Cran
Make BaseRngLib more generic by moving x86-specific functionality into 'Rand' and adding files under 'AArch64' to support the optional ARMv8.5 RNG instruction RNDR that is a part of FEAT_RNG. Signed-off-by: Rebecca Cran --- MdePkg/MdePkg.dec| 9 +- MdePkg

<    6   7   8   9   10   11   12   13   14   15   >