[edk2-devel] [PATCH v8 20/21] ArmPkg: Add SMBIOS PCDs to ArmPkg.dec

2021-02-07 Thread Rebecca Cran
Platforms are expected to override these PCDs to provide relevant information to SMBIOS. Signed-off-by: Rebecca Cran Reviewed-by: Leif Lindholm --- ArmPkg/ArmPkg.dec | 17 + 1 file changed, 17 insertions(+) diff --git a/ArmPkg/ArmPkg.dec b/ArmPkg/ArmPkg.dec index eaf1072d9ef3

[edk2-devel] [PATCH v8 19/21] ArmPkg: Add Universal/Smbios/SmbiosMiscDxe/Type32

2021-02-07 Thread Rebecca Cran
This code provides information for the SMBIOS Type 32 table. Signed-off-by: Rebecca Cran Reviewed-by: Leif Lindholm Reviewed-by: Samer El-Haj-Mahmoud --- ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type32/MiscBootInformationData.c | 32 + ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type32

[edk2-devel] [PATCH v8 18/21] ArmPkg: Add Universal/Smbios/SmbiosMiscDxe/Type13

2021-02-07 Thread Rebecca Cran
This code provides information for the SMBIOS Type 13 table. Signed-off-by: Rebecca Cran Reviewed-by: Leif Lindholm --- ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type13/MiscNumberOfInstallableLanguagesData.c | 33 ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type13

[edk2-devel] [PATCH v8 17/21] ArmPkg: Add Universal/Smbios/SmbiosMiscDxe/Type03

2021-02-07 Thread Rebecca Cran
This code provides information for the SMBIOS Type 3 table. Signed-off-by: Rebecca Cran Reviewed-by: Leif Lindholm Reviewed-by: Samer El-Haj-Mahmoud --- ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type03/MiscChassisManufacturerData.c | 52 + ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type03

[edk2-devel] [PATCH v8 16/21] ArmPkg: Add Universal/Smbios/SmbiosMiscDxe/Type02

2021-02-07 Thread Rebecca Cran
This code provides information for the SMBIOS Type 2 table. Signed-off-by: Rebecca Cran Reviewed-by: Leif Lindholm Reviewed-by: Samer El-Haj-Mahmoud --- ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type02/MiscBaseBoardManufacturerData.c | 46 ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type02

[edk2-devel] [PATCH v8 15/21] ArmPkg: Add Universal/Smbios/SmbiosMiscDxe/Type01

2021-02-07 Thread Rebecca Cran
This code provides information for the SMBIOS Type 1 table. Signed-off-by: Rebecca Cran Reviewed-by: Leif Lindholm Reviewed-by: Samer El-Haj-Mahmoud --- ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type01/MiscSystemManufacturerData.c | 36 ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type01

[edk2-devel] [PATCH v8 14/21] ArmPkg: Add Universal/Smbios/SmbiosMiscDxe/Type00

2021-02-07 Thread Rebecca Cran
This code provides information for the SMBIOS Type 0 table. Signed-off-by: Rebecca Cran Reviewed-by: Samer El-Haj-Mahmoud Reviewed-by: Leif Lindholm --- ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type00/MiscBiosVendorData.c | 93 ++ ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type00

[edk2-devel] [PATCH v8 13/21] ArmPkg: Add Universal/Smbios/ProcessorSubClassDxe

2021-02-07 Thread Rebecca Cran
ProcessorSubClassDxe provides SMBIOS CPU information using generic methods combined with calls into OemMiscLib. Signed-off-by: Rebecca Cran Reviewed-by: Samer El-Haj-Mahmoud --- ArmPkg/ArmPkg.dsc | 2 + ArmPkg/Universal/Smbios

[edk2-devel] [PATCH v8 12/21] ArmPkg: Add Universal/Smbios/OemMiscLibNull

2021-02-07 Thread Rebecca Cran
Add a Null implementation of OemMiscLib. OemMiscLib provides functions that platforms implement to fill in SMBIOS information for the SmbiosMiscDxe and ProcessSubClassDxe drivers. Signed-off-by: Rebecca Cran Acked-by: Leif Lindholm --- ArmPkg/ArmPkg.dsc

[edk2-devel] [PATCH v8 11/21] ArmPkg: Add Library/OemMiscLib.h

2021-02-07 Thread Rebecca Cran
OemMiscLib.h provides the interface which platforms should implement to interact with the SmbiosMiscDxe and ProcessorSubClassDxe drivers to update SMBIOS tables. Signed-off-by: Rebecca Cran Acked-by: Leif Lindholm --- ArmPkg/Include/Library/OemMiscLib.h | 167 1 file

[edk2-devel] [PATCH v8 10/21] ArmPkg: Add helper to read the CCSIDR2 register

2021-02-07 Thread Rebecca Cran
Add helper function to read the CCSIDR2 register. This is used when CCIDX is supported in AARCH32 mode. Signed-off-by: Rebecca Cran Reviewed-by: Leif Lindholm --- ArmPkg/Library/ArmLib/ArmLibPrivate.h | 11 +++ ArmPkg/Library/ArmLib/Arm/ArmLibSupportV7.S | 10

[edk2-devel] [PATCH v8 09/21] ArmPkg: Add helper to read CCIDX status

2021-02-07 Thread Rebecca Cran
Add a helper function to determine CCIDX support. Signed-off-by: Rebecca Cran Reviewed-by: Sami Mujawar Reviewed-by: Leif Lindholm --- ArmPkg/Include/Library/ArmLib.h| 11 +++ ArmPkg/Library/ArmLib/AArch64/AArch64Lib.c | 19 ++- ArmPkg/Library/ArmLib/Arm

[edk2-devel] [PATCH v8 08/21] ArmPkg: Add definition of the maximum cache level in ARMv8-A

2021-02-07 Thread Rebecca Cran
The ARM Architecture Reference Manual for ARMv8-A defines up to seven levels of cache, L1 through L7. Define MAX_ARM_CACHE_LEVEL to be 7. Signed-off-by: Rebecca Cran Reviewed-by: Leif Lindholm Reviewed-by: Sami Mujawar --- ArmPkg/Include/Library/ArmLib.h | 4 1 file changed, 4 insertions

[edk2-devel] [PATCH v8 06/21] ArmPkg: Fix the return type of the ReadCCSIDR function

2021-02-07 Thread Rebecca Cran
for the function. Signed-off-by: Rebecca Cran Reviewed-by: Sami Mujawar Reviewed-by: Leif Lindholm --- ArmPkg/Library/ArmLib/ArmLibPrivate.h | 9 - ArmPkg/Library/ArmLib/AArch64/ArmLibSupportV8.S | 2 +- ArmPkg/Library/ArmLib/Arm/ArmLibSupportV7.S | 2 +- ArmPkg/Library/ArmLib/Arm

[edk2-devel] [PATCH v8 07/21] ArmPkg: Update ArmLibPrivate.h with cache register definitions

2021-02-07 Thread Rebecca Cran
Update the cache definitions in ArmLibPrivate.h based on current ARMv8 documentation. Signed-off-by: Rebecca Cran Reviewed-by: Leif Lindholm Reviewed-by: Sami Mujawar --- ArmPkg/Library/ArmLib/ArmLibPrivate.h | 97 1 file changed, 97 insertions(+) diff --git a/ArmPkg

[edk2-devel] [PATCH v8 05/21] ArmPkg: Add helper function to read the Memory Model Feature Register 4

2021-02-07 Thread Rebecca Cran
In AARCH32, CCIDX support is indicated in the MMFR4 register - unlike under AARCH64 where it's in MMFR2. Add a helper function to read it. Signed-off-by: Rebecca Cran Reviewed-by: Sami Mujawar Reviewed-by: Leif Lindholm --- ArmPkg/Library/ArmLib/Arm/ArmV7Lib.h | 8 ++-- ArmPkg

[edk2-devel] [PATCH v8 04/21] ArmPkg: Add helper to read the Memory Model Features Register 2

2021-02-07 Thread Rebecca Cran
Add helper function to read the MMFR2 register. We will need this to determine CCIDX support. Signed-off-by: Rebecca Cran Reviewed-by: Leif Lindholm Reviewed-by: Sami Mujawar --- ArmPkg/Library/ArmLib/AArch64/AArch64Lib.h | 11 +++ ArmPkg/Library/ArmLib/AArch64/AArch64Support.S

[edk2-devel] [PATCH v8 03/21] ArmPkg: Add register encoding definition for MMFR2

2021-02-07 Thread Rebecca Cran
Add register encoding definition for Memory Model Feature Register 2. We need to define it here because we build for ARMv8.0, which doesn't have it. Signed-off-by: Rebecca Cran Reviewed-by: Leif Lindholm Reviewed-by: Sami Mujawar --- ArmPkg/Include/Chipset/AArch64.h | 4 1 file changed

[edk2-devel] [PATCH v8 02/21] MdePkg: Update IndustryStandard/SmBios.h with processor status data

2021-02-07 Thread Rebecca Cran
Add a bitfield that describes the structure of the byte in the Status field of the SMBIOS Type 4 Processor Information table. Signed-off-by: Rebecca Cran Reviewed-by: Leif Lindholm Acked-by: Sami Mujawar --- MdePkg/Include/IndustryStandard/SmBios.h | 13 + 1 file changed, 13

[edk2-devel] [PATCH v8 01/21] ArmPkg: Add ARM SMC Architecture functions to ArmStdSmc.h

2021-02-07 Thread Rebecca Cran
The ARM SMC Architecture functions were missing from ArmStdSmc.h. Add them, based on the SMC Calling Convention version 1.2 specification. Signed-off-by: Rebecca Cran Reviewed-by: Leif Lindholm Reviewed-by: Sami Mujawar --- ArmPkg/Include/IndustryStandard/ArmStdSmc.h | 16 1

[edk2-devel] [PATCH v8 00/21] ArmPkg,MdePkg: Add Universal/Smbios, and related changes

2021-02-07 Thread Rebecca Cran
Ecc tool o Ran smbiosview in the UEFI Shell Rebecca Cran (21): ArmPkg: Add ARM SMC Architecture functions to ArmStdSmc.h MdePkg: Update IndustryStandard/SmBios.h with processor status data ArmPkg: Add register encoding definition for MMFR2 ArmPkg: Add helper to read the Memory Model

[edk2-devel] [PATCH v7 21/21] ArmPkg: Add Universal/Smbios/SmbiosMiscDxe

2021-01-31 Thread Rebecca Cran
SmbiosMiscDxe provides SMBIOS tables 0, 1, 2, 3, 13, and 32. Signed-off-by: Rebecca Cran Reviewed-by: Leif Lindholm Reviewed-by: Samer El-Haj-Mahmoud --- ArmPkg/ArmPkg.dsc | 1 + ArmPkg/Universal/Smbios/SmbiosMiscDxe/SmbiosMiscDxe.inf

[edk2-devel] [PATCH v7 19/21] ArmPkg: Add Universal/Smbios/SmbiosMiscDxe/Type32

2021-01-31 Thread Rebecca Cran
This code provides information for the SMBIOS Type 32 table. Signed-off-by: Rebecca Cran Reviewed-by: Leif Lindholm Reviewed-by: Samer El-Haj-Mahmoud --- ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type32/MiscBootInformationData.c | 32 + ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type32

[edk2-devel] [PATCH v7 20/21] ArmPkg: Add SMBIOS PCDs to ArmPkg.dec

2021-01-31 Thread Rebecca Cran
Platforms are expected to override these PCDs to provide relevant information to SMBIOS. Signed-off-by: Rebecca Cran Reviewed-by: Leif Lindholm --- ArmPkg/ArmPkg.dec | 17 + 1 file changed, 17 insertions(+) diff --git a/ArmPkg/ArmPkg.dec b/ArmPkg/ArmPkg.dec index eaf1072d9ef3

[edk2-devel] [PATCH v7 18/21] ArmPkg: Add Universal/Smbios/SmbiosMiscDxe/Type13

2021-01-31 Thread Rebecca Cran
This code provides information for the SMBIOS Type 13 table. Signed-off-by: Rebecca Cran Reviewed-by: Leif Lindholm --- ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type13/MiscNumberOfInstallableLanguagesData.c | 33 ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type13

[edk2-devel] [PATCH v7 17/21] ArmPkg: Add Universal/Smbios/SmbiosMiscDxe/Type03

2021-01-31 Thread Rebecca Cran
This code provides information for the SMBIOS Type 3 table. Signed-off-by: Rebecca Cran Reviewed-by: Leif Lindholm Reviewed-by: Samer El-Haj-Mahmoud --- ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type03/MiscChassisManufacturerData.c | 52 + ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type03

[edk2-devel] [PATCH v7 16/21] ArmPkg: Add Universal/Smbios/SmbiosMiscDxe/Type02

2021-01-31 Thread Rebecca Cran
This code provides information for the SMBIOS Type 2 table. Signed-off-by: Rebecca Cran Reviewed-by: Leif Lindholm Reviewed-by: Samer El-Haj-Mahmoud --- ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type02/MiscBaseBoardManufacturerData.c | 46 ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type02

[edk2-devel] [PATCH v7 15/21] ArmPkg: Add Universal/Smbios/SmbiosMiscDxe/Type01

2021-01-31 Thread Rebecca Cran
This code provides information for the SMBIOS Type 1 table. Signed-off-by: Rebecca Cran Reviewed-by: Leif Lindholm Reviewed-by: Samer El-Haj-Mahmoud --- ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type01/MiscSystemManufacturerData.c | 36 ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type01

[edk2-devel] [PATCH v7 14/21] ArmPkg: Add Universal/Smbios/SmbiosMiscDxe/Type00

2021-01-31 Thread Rebecca Cran
This code provides information for the SMBIOS Type 0 table. Signed-off-by: Rebecca Cran Reviewed-by: Samer El-Haj-Mahmoud Reviewed-by: Leif Lindholm --- ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type00/MiscBiosVendorData.c | 93 ++ ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type00

[edk2-devel] [PATCH v7 13/21] ArmPkg: Add Universal/Smbios/ProcessorSubClassDxe

2021-01-31 Thread Rebecca Cran
ProcessorSubClassDxe provides SMBIOS CPU information using generic methods combined with calls into OemMiscLib. Signed-off-by: Rebecca Cran Reviewed-by: Samer El-Haj-Mahmoud --- ArmPkg/ArmPkg.dsc | 2 + ArmPkg/Universal/Smbios

[edk2-devel] [PATCH v7 12/21] ArmPkg: Add Universal/Smbios/OemMiscLibNull

2021-01-31 Thread Rebecca Cran
Add a Null implementation of OemMiscLib. OemMiscLib provides functions that platforms implement to fill in SMBIOS information for the SmbiosMiscDxe and ProcessSubClassDxe drivers. Signed-off-by: Rebecca Cran Acked-by: Leif Lindholm --- ArmPkg/ArmPkg.dsc

[edk2-devel] [PATCH v7 11/21] ArmPkg: Add Library/OemMiscLib.h

2021-01-31 Thread Rebecca Cran
OemMiscLib.h provides the interface which platforms should implement to interact with the SmbiosMiscDxe and ProcessorSubClassDxe drivers to update SMBIOS tables. Signed-off-by: Rebecca Cran Acked-by: Leif Lindholm --- ArmPkg/Include/Library/OemMiscLib.h | 166 1 file

[edk2-devel] [PATCH v7 10/21] ArmPkg: Add helper to read the CCSIDR2 register

2021-01-31 Thread Rebecca Cran
Add helper function to read the CCSIDR2 register. This is used when CCIDX is supported in AARCH32 mode. Signed-off-by: Rebecca Cran Reviewed-by: Leif Lindholm --- ArmPkg/Library/ArmLib/ArmLibPrivate.h | 11 +++ ArmPkg/Library/ArmLib/Arm/ArmLibSupportV7.S | 10

[edk2-devel] [PATCH v7 09/21] ArmPkg: Add helper to read CCIDX status

2021-01-31 Thread Rebecca Cran
Add a helper function to determine CCIDX support. Signed-off-by: Rebecca Cran Reviewed-by: Sami Mujawar Reviewed-by: Leif Lindholm --- ArmPkg/Include/Library/ArmLib.h| 11 +++ ArmPkg/Library/ArmLib/AArch64/AArch64Lib.c | 19 ++- ArmPkg/Library/ArmLib/Arm

[edk2-devel] [PATCH v7 08/21] ArmPkg: Add definition of the maximum cache level in ARMv8-A

2021-01-31 Thread Rebecca Cran
The ARM Architecture Reference Manual for ARMv8-A defines up to seven levels of cache, L1 through L7. Define MAX_ARM_CACHE_LEVEL to be 7. Signed-off-by: Rebecca Cran Reviewed-by: Leif Lindholm Reviewed-by: Sami Mujawar --- ArmPkg/Include/Library/ArmLib.h | 4 1 file changed, 4 insertions

[edk2-devel] [PATCH v7 06/21] ArmPkg: Fix the return type of the ReadCCSIDR function

2021-01-31 Thread Rebecca Cran
for the function. Signed-off-by: Rebecca Cran Reviewed-by: Sami Mujawar Reviewed-by: Leif Lindholm --- ArmPkg/Library/ArmLib/ArmLibPrivate.h | 9 - ArmPkg/Library/ArmLib/AArch64/ArmLibSupportV8.S | 2 +- ArmPkg/Library/ArmLib/Arm/ArmLibSupportV7.S | 2 +- ArmPkg/Library/ArmLib/Arm

[edk2-devel] [PATCH v7 07/21] ArmPkg: Update ArmLibPrivate.h with cache register definitions

2021-01-31 Thread Rebecca Cran
Update the cache definitions in ArmLibPrivate.h based on current ARMv8 documentation. Signed-off-by: Rebecca Cran Reviewed-by: Leif Lindholm Reviewed-by: Sami Mujawar --- ArmPkg/Library/ArmLib/ArmLibPrivate.h | 97 1 file changed, 97 insertions(+) diff --git a/ArmPkg

[edk2-devel] [PATCH v7 05/21] ArmPkg: Add helper function to read the Memory Model Feature Register 4

2021-01-31 Thread Rebecca Cran
In AARCH32, CCIDX support is indicated in the MMFR4 register - unlike under AARCH64 where it's in MMFR2. Add a helper function to read it. Signed-off-by: Rebecca Cran Reviewed-by: Sami Mujawar Reviewed-by: Leif Lindholm --- ArmPkg/Library/ArmLib/Arm/ArmV7Lib.h | 8 ++-- ArmPkg

[edk2-devel] [PATCH v7 04/21] ArmPkg: Add helper to read the Memory Model Features Register 2

2021-01-31 Thread Rebecca Cran
Add helper function to read the MMFR2 register. We will need this to determine CCIDX support. Signed-off-by: Rebecca Cran Reviewed-by: Leif Lindholm Reviewed-by: Sami Mujawar --- ArmPkg/Library/ArmLib/AArch64/AArch64Lib.h | 11 +++ ArmPkg/Library/ArmLib/AArch64/AArch64Support.S

[edk2-devel] [PATCH v7 01/21] ArmPkg: Add ARM SMC Architecture functions to ArmStdSmc.h

2021-01-31 Thread Rebecca Cran
The ARM SMC Architecture functions were missing from ArmStdSmc.h. Add them, based on the SMC Calling Convention version 1.2 specification. Signed-off-by: Rebecca Cran Reviewed-by: Leif Lindholm Reviewed-by: Sami Mujawar --- ArmPkg/Include/IndustryStandard/ArmStdSmc.h | 16 1

[edk2-devel] [PATCH v7 03/21] ArmPkg: Add register encoding definition for MMFR2

2021-01-31 Thread Rebecca Cran
Add register encoding definition for Memory Model Feature Register 2. We need to define it here because we build for ARMv8.0, which doesn't have it. Signed-off-by: Rebecca Cran Reviewed-by: Leif Lindholm Reviewed-by: Sami Mujawar --- ArmPkg/Include/Chipset/AArch64.h | 4 1 file changed

[edk2-devel] [PATCH v7 02/21] MdePkg: Update IndustryStandard/SmBios.h with processor status data

2021-01-31 Thread Rebecca Cran
Add a bitfield that describes the structure of the byte in the Status field of the SMBIOS Type 4 Processor Information table. Signed-off-by: Rebecca Cran Reviewed-by: Leif Lindholm Acked-by: Sami Mujawar --- MdePkg/Include/IndustryStandard/SmBios.h | 13 + 1 file changed, 13

[edk2-devel] [PATCH v7 00/21] ArmPkg,MdePkg: Add Universal/Smbios, and related changes

2021-01-31 Thread Rebecca Cran
series with the additional changes. Testing: o Ran Ecc tool and fixed various issues. Several remain, but I think they're bogus. o Ran FWTS. o Ran smbiosview in the UEFI Shell, and dmidecode in Linux. Rebecca Cran (21): ArmPkg: Add ARM SMC Architecture functions to ArmStdSmc.h MdePkg

Re: [edk2-devel] [PATCH v6 14/22] ArmPkg: Add Universal/Smbios/ProcessorSubClassDxe

2021-01-27 Thread Rebecca Cran
On 1/25/21 12:04 PM, Leif Lindholm wrote: On Thu, Jan 14, 2021 at 09:36:20 -0700, Rebecca Cran wrote: +// Sets the HII variable `x` if `pcd` isn't empty +#define SET_HII_STRING_IF_PCD_NOT_EMPTY(pcd, x) \ +x##Str = (CHAR16 *)PcdGetPtr (pcd); \ +if (StrLen (x##Str) >

Re: [edk2-devel] [PATCH v6 20/22] ArmPkg: Add Universal/Smbios/SmbiosMiscDxe/Type32

2021-01-25 Thread Rebecca Cran
On 1/15/21 2:10 PM, Samer El-Haj-Mahmoud wrote: Samer El-Haj-Mahmoud Samer, Was this supposed to have a "Reviewed-by" tag at the start of the line? -- Rebecca Cran -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#707

Re: [EXTERNAL] Re: [edk2-devel] Ecc style errors when running EDK2 CI locally without specifying a target (NO-TARGET)

2020-09-30 Thread Rebecca Cran
ed my repo's `master`, it both runs much faster, and succeeds. A weekly build which runs Ecc over all the code and compiles a report of issues might be nice. -- Rebecca Cran On 9/30/20 5:59 PM, Sean Brogan wrote: Not sure i follow your first question but running without a "-t" specifi

[edk2-devel] Ecc style errors when running EDK2 CI locally without specifying a target (NO-TARGET)

2020-09-30 Thread Rebecca Cran
nderscore characters, '_' ERROR - *file: .../edk2/DynamicTablesPkg/Include/Library/AmlLib/AmlLib.h ERROR - *Line number: 41 ERROR - *The #ifndef name [AML_HANDLE] does not follow the rules ERROR - When I specify "-t DEBUG,RELEASE,NOOPT" it completes successfully. -- Rebecca Cran -=-

[edk2-devel] [edk2-test] Contributions.txt still mentions the TianoCore Contribution Agreement

2020-09-24 Thread Rebecca Cran
While working on the SctPkg, I noticed the Contributions.txt file in the top of the repo still mentions the TianoCore Contribution Agreement. Does it need updated? -- Rebecca Cran -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online

[edk2-devel] [edk2-test] [PATCH 2/3] uefi-sct: Fix the mailing list address in Maintainers.txt and Readme.md

2020-09-24 Thread Rebecca Cran
The mailing list has changed from lists.01.org to groups.io. Update Maintainers.txt and Readme.md to match. Signed-off-by: Rebecca Cran --- uefi-sct/Maintainers.txt | 2 +- uefi-sct/Readme.md | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/uefi-sct/Maintainers.txt b

[edk2-devel] [edk2-test] [PATCH 3/3] uefi-sct/SctPkg: Fix some indentation issues in build.sh

2020-09-24 Thread Rebecca Cran
build.sh contains a mixture of tabs and spaces, with differing numbers of spaces used for indents. Update it so any single block only uses one style of indentation. Signed-off-by: Rebecca Cran --- uefi-sct/SctPkg/build.sh | 33 - 1 file changed, 16 insertions

[edk2-devel] [edk2-test] [PATCH 1/3] uefi-sct/SctPkg: Fix build.sh when specifying GCC5 toolchain

2020-09-24 Thread Rebecca Cran
build.sh usage indicates that "GCC5" can be specified, but it's currently rejected due to a case statement only matching "GCC" or "gcc". Fix this by adding a wildcard match. Signed-off-by: Rebecca Cran --- uefi-sct/SctPkg/build.sh | 2 +- 1 file changed, 1 ins

[edk2-devel] [edk2-test] [PATCH 2/3] uefi-sct: Fix the mailing list address in Maintainers.txt and Readme.md

2020-09-24 Thread Rebecca Cran
The mailing list has changed from lists.01.org to groups.io. Update Maintainers.txt and Readme.md to match. Signed-off-by: Rebecca Cran --- uefi-sct/Maintainers.txt | 2 +- uefi-sct/Readme.md | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/uefi-sct/Maintainers.txt b

[edk2-devel] [edk2-test] [PATCH 3/3] uefi-sct/SctPkg: Fix some indentation issues in build.sh

2020-09-24 Thread Rebecca Cran
build.sh contains a mixture of tabs and spaces, with differing numbers of spaces used for indents. Update it so any single block only uses one style of indentation. Signed-off-by: Rebecca Cran --- uefi-sct/SctPkg/build.sh | 33 - 1 file changed, 16 insertions

[edk2-devel] [edk2-test] [PATCH 0/3] Fixes to SctPkg/build.sh

2020-09-24 Thread Rebecca Cran
I noticed the GCC5 SctPkg build was broken. This patch series fixes it and also resolves a couple of other issues I found. Rebecca Cran (3): uefi-sct/SctPkg: Fix build.sh when specifying GCC5 toolchain uefi-sct: Fix the mailing list address in Maintainers.txt and Readme.md uefi-sct

[edk2-devel] [edk2-test] [PATCH 1/3] uefi-sct/SctPkg: Fix build.sh when specifying GCC5 toolchain

2020-09-24 Thread Rebecca Cran
build.sh usage indicates that "GCC5" can be specified, but it's currently rejected due to a case statement only matching "GCC" or "gcc". Fix this by adding a wildcard match. Signed-off-by: Rebecca Cran --- uefi-sct/SctPkg/build.sh | 2 +- 1 file changed, 1 ins

Re: [edk2-devel] [PATCH 22/22] .mailmap: add entries for Rebecca Cran

2020-09-08 Thread Rebecca Cran
preferable to collect them all under your real name Rebecca Cran. Ah, ok sorry I hadn't realized. Unless you prefer the former output, please ACK this patch. Acked-by: Rebecca Cran I can respin this one patch later, or we can add your @nuviainc.com email address separately, later on. (NB

Re: [edk2-devel] [PATCH 22/22] .mailmap: add entries for Rebecca Cran

2020-09-07 Thread Rebecca Cran
On 9/7/20 1:31 PM, Laszlo Ersek wrote: ... for git-shortlog purposes. NOTE: this patch does not introduce a cross-domain mapping; it only maps both email addresses of Rebecca to the full name "Rebecca Cran". I'm no longer using the bluestop.org email address for EDK2 mail, but

[edk2-devel] [PATCH 1/1] OvmfPkg/Bhyve: rename files to remove 'Pkg' infix

2020-08-17 Thread Rebecca Cran
OvmfPkg is the package, so while there are files to build bhyve separately, they shouldn't have 'Pkg' in the name. Signed-off-by: Rebecca Cran Cc: Jordan Justen Cc: Laszlo Ersek Cc: Ard Biesheuvel Cc: Peter Grehan --- OvmfPkg/Bhyve/{BhyvePkgX64.dsc => BhyveX64.dsc}

Re: [edk2-devel] [PATCH v4 3/5] OvmfPkg: Add RngLib based on TimerLib for Crypto

2020-08-14 Thread Rebecca Cran
yveX64.fdf Rebecca, could you please submit a patch with such renames? Yes, I'll submit a patch in the next couple of days - I'm still catching up from traveling this past week. -- Rebecca Cran -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Re

[edk2-devel] Adding bhyve to the Continuous Integration system

2020-08-09 Thread Rebecca Cran
OvmfPkg.ci.yaml instead? -- Rebecca Cran -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#63894): https://edk2.groups.io/g/devel/message/63894 Mute This Topic: https://groups.io/mt/76090747/21656 Group Owner: devel+ow...@edk2.groups.io

[edk2-devel] [PATCH 1/1] Maintainers.txt: Add bhyve reviewers

2020-08-01 Thread Rebecca Cran
Bhyve files are under OvmfPkg, in OvmfPkg/Bhyve and various files in OvmfPkg/Library and OvmfPkg/Include. Update Maintainers.txt to indicate reviewers for all bhyve-specific files. Signed-off-by: Rebecca Cran Cc: Andrew Fish Cc: Laszlo Ersek Cc: Leif Lindholm Cc: Michael D Kinney Cc: Jordan

Re: [edk2-devel] [PATCH] OvmfPkg: fix DEC spec violation introduced by Bhyve addition

2020-08-01 Thread Rebecca Cran
as Rebecca (and hopefully Sean) confirm the change is OK. - Rebecca, please account for the movements / renames in the present patch in your upcoming patch for "Maintainers.txt". Thanks! Reviewed-by: Rebecca Cran Thanks! And sorry for the disruption. -- Re

Re: [edk2-devel] [PATCH 1/1] Add BhyvePkg, to support the bhyve hypervisor

2020-07-31 Thread Rebecca Cran
, and will see if I can work around them. -- Rebecca Cran -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#63596): https://edk2.groups.io/g/devel/message/63596 Mute This Topic: https://groups.io/mt/75472166/21656 Group Owner: devel+ow...@edk2

Re: [edk2-devel] [PATCH 1/1] Add BhyvePkg, to support the bhyve hypervisor

2020-07-30 Thread Rebecca Cran
On 7/13/20 2:25 PM, Rebecca Cran wrote: On 7/13/20 12:09 PM, Laszlo Ersek wrote: Can you please ping me when the PatchCheck.py problem has been solved, so I can go ahead with the merge? Will do. Hi Laszlo, I just rebased the bhyve commit against the latest edk2 master

Re: [edk2-devel] [PATCH 00/15] Add a plugin LicenseCheck in open ci

2020-07-30 Thread Rebecca Cran
To: Rebecca Cran ; devel@edk2.groups.io; Zhang, Shenglei Cc: Kinney, Michael D ; Sean Brogan ; Bret Barkelew ; Dong, Eric ; Laszlo Ersek ; Gao, Zhichao ; Yao, Jiewen ; Chao Zhang ; Justen, Jordan L ; Maciej Rabeda ; Wu, Jiaxin ; Fu, Siyuan ; Wang, Jian J ; Wu, Hao A ; Andrew Fish ; Ni, Ray

Re: [edk2-devel] [PATCH 00/15] Add a plugin LicenseCheck in open ci

2020-07-24 Thread Rebecca Cran
cense check for some files like generated files. Has there been any progress on this? I'm waiting for it because it's required for my bhyve changes. -- Rebecca Cran -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#63268): https://ed

Re: [edk2-devel] [PATCH 0/2] BaseTools: Convert ReadMe.txt to reStructuredText

2020-07-16 Thread Rebecca Cran
On 7/7/20 5:13 PM, Rebecca Cran wrote: I noticed ReadMe.txt was a little outdated. I updated it to match current functionality (e.g. BaseTools works on both 32-bit and 64-bit Windows). Since the formatting was neither RST or MD, I converted it to RST and renamed to ReadMe.rst to match the edk2

Re: [edk2-devel] [PATCH 1/1] Add BhyvePkg, to support the bhyve hypervisor

2020-07-13 Thread Rebecca Cran
On 7/13/20 12:09 PM, Laszlo Ersek wrote: Can you please ping me when the PatchCheck.py problem has been solved, so I can go ahead with the merge? Will do. -- Rebecca Cran -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#62455

Re: [edk2-devel] [PATCH 1/1] Add BhyvePkg, to support the bhyve hypervisor

2020-07-13 Thread Rebecca Cran
On 7/13/20 10:16 AM, Laszlo Ersek wrote: My understanding has been that you and Peter Grehan would be added as "R"s to Maintainers.txt, covering "OvmfPkg/Bhyve/". Has anything changed in that regard? No, that's still the plan. I'll update Maintainers.txt in a follow-up

Re: [edk2-devel] [PATCH 0/1] Add BhyvePkg, to support the bhyve hypervisor

2020-07-12 Thread Rebecca Cran
set to be committed. -- Rebecca Cran -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#62390): https://edk2.groups.io/g/devel/message/62390 Mute This Topic: https://groups.io/mt/75471578/21656 Group Owner: devel+ow...@edk2.groups.io Unsub

[edk2-devel] [PATCH 0/1] Add BhyvePkg, to support the bhyve hypervisor

2020-07-12 Thread Rebecca Cran
This depends on the pending changes to PatchCheck.py Rebecca Cran (1): Add BhyvePkg, to support the bhyve hypervisor OvmfPkg/Bhyve/AcpiPlatformDxe/AcpiPlatform.c | 251 +++ OvmfPkg/Bhyve/AcpiPlatformDxe/AcpiPlatform.h | 77 + .../Bhyve/AcpiPlatformDxe/AcpiPlatformDxe.inf | 65

[edk2-devel] [PATCH 0/2] BaseTools: Convert ReadMe.txt to reStructuredText

2020-07-07 Thread Rebecca Cran
cx_freeze might be obsolete. Signed-off-by: Rebecca Cran Cc: Bob Feng Cc: Liming Gao Rebecca Cran (2): BaseTools: Update ReadMe.txt to match current functionality BaseTools: rename ReadMe.txt to ReadMe.rst BaseTools/ReadMe.rst | 41 ++ BaseTools/ReadMe.txt

[edk2-devel] [PATCH 2/2] BaseTools: rename ReadMe.txt to ReadMe.rst

2020-07-07 Thread Rebecca Cran
The ReadMe file is now RST, so update the filename extension to match. Signed-off-by: Rebecca Cran Cc: Bob Feng Cc: Liming Gao --- BaseTools/{ReadMe.txt => ReadMe.rst} | 0 1 file changed, 0 insertions(+), 0 deletions(-) rename BaseTools/{ReadMe.txt => ReadMe.rst} (100%) diff

[edk2-devel] [PATCH 1/2] BaseTools: Update ReadMe.txt to match current functionality

2020-07-07 Thread Rebecca Cran
ReadMe.txt contained outdated information. Update it to match current functionality (e.g. sqlite3 is no longer used), and convert the formatting from ad-hoc to reStructuredText. Signed-off-by: Rebecca Cran Cc: Bob Feng Cc: Liming Gao --- BaseTools/ReadMe.txt | 38

Re: [edk2-devel] OvmfPkg: Adding support for bhyve as OvmfPkg/Bhyve

2020-07-02 Thread Rebecca Cran
to land, then send the bhyve patch to the list. I think at this point I've updated all the licenses to be BSD+Patent with the exception of the generated file. -- Rebecca Cran -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#62005

[edk2-devel] OvmfPkg: Adding support for bhyve as OvmfPkg/Bhyve

2020-06-26 Thread Rebecca Cran
WAS GENERATED BY "VbeShim.sh". DO NOT EDIT. // -- Rebecca Cran -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#61746): https://edk2.groups.io/g/devel/message/61746 Mute This Topic: https://groups.io/mt/75126896/21656 Group Owner

Re: [EXTERNAL] [edk2-devel] [edk2-rfc] GitHub Pull Request based Code Review Process

2020-05-27 Thread Rebecca Cran
email line 1548. So I ended up copying it to one of my FreeBSD systems and sent it from there. -- Rebecca Cran -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#60363): https://edk2.groups.io/g/devel/message/60363 Mute This To

[edk2-devel] [PATCH v2 1/1] CryptoPkg: Fix VS2017 build problem for ARM/AARCH64

2020-05-27 Thread Rebecca Cran
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2029 1. CryptPkcs7VerifyEku.c contains internal/x509_int.h header file, this file contains internal/refcount.h file, if _M_ARM or _M_ARM64 defined, it will contains (intrin.h). So we undef these flags for MSVC. It will fix include

Re: [edk2-devel] OVMF gdb seems to require "stone knives and bearskins" to debug code?

2020-05-25 Thread Rebecca Cran
it. However, since I work on platforms which have lldb in base (FreeBSD) or are easily available (Linux), I'd certainly be interested if you were to open source the efi_symolicate.py script and I could learn how to use lldb. -- Rebecca Cran -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You

Re: [edk2-devel] [PATCH 1/1] CryptoPkg: Fix VS2017 build problem for ARM/AARCH64

2020-05-20 Thread Rebecca Cran
On 5/20/2020 2:26 PM, Rebecca Cran wrote: REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2029 1. CryptPkcs7VerifyEku.c contains internal/x509_int.h header file, this file contains internal/refcount.h file, if _M_ARM or _M_ARM64 defined, it will contains (intrin.h). So we undef

[edk2-devel] [PATCH 1/1] CryptoPkg: Fix VS2017 build problem for ARM/AARCH64

2020-05-20 Thread Rebecca Cran
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2029 1. CryptPkcs7VerifyEku.c contains internal/x509_int.h header file, this file contains internal/refcount.h file, if _M_ARM or _M_ARM64 defined, it will contains (intrin.h). So we undef these flags for MSVC. It will fix include

[edk2-devel] Official way to build BaseTools - Edk2ToolsBuild.py?

2020-05-19 Thread Rebecca Cran
rm and tries to use GCC, Clang etc. - and perhaps also to add a '--verbose' argument that can be used to give a more specific error message when it fails. -- Rebecca Cran -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#59919): http

Re: [EXTERNAL] Re: [edk2-devel] [edk2-rfc] GitHub Pull Request based Code Review Process

2020-05-17 Thread Rebecca Cran
people don't even check email any more! So someone had set up a Slack channel where Github pull requests were posted/linked, and we were supposed to react with thumbs-up, "OK" etc. emoji to indicate we'd seen/reviewed/accepted the request. -- Rebecca Cran -=-=-=-=-=-=-=-=-=-=-=-

Re: [EXTERNAL] Re: [edk2-devel] [edk2-rfc] GitHub Pull Request based Code Review Process

2020-05-14 Thread Rebecca Cran
the usability of Github Pull Requests for a project the size of EDK2, but I hope to be proven wrong. -- Rebecca Cran -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#59601): https://edk2.groups.io/g/devel/message/59601 Mute This Topic: https

Re: [edk2-devel] Where to put the bhyve code in the edk2 repo: BhyvePkg, or under OvmfPkg?

2020-05-14 Thread Rebecca Cran
arly integrate changes into the bhyve/* branches. — Rebecca Cran -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#59586): https://edk2.groups.io/g/devel/message/59586 Mute This Topic: https://groups.io/mt/74075377/21656 Group Owner: deve

Re: [edk2-devel] Where to put the bhyve code in the edk2 repo: BhyvePkg, or under OvmfPkg?

2020-05-14 Thread Rebecca Cran
on from discussing where the code should live, since I'd like to get my changes committed wherever and start creating builds for people who are waiting for them and improve bhyve support in edk2. -- Rebecca Cran -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent

Re: [edk2-devel] Where to put the bhyve code in the edk2 repo: BhyvePkg, or under OvmfPkg?

2020-05-14 Thread Rebecca Cran
gressions. Yes, I believe that would be acceptable. Has there been a decision on the directory structure yet, or is that likely to be something that will need resolved at the next Stewards Meeting? — Rebecca Cran -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this

Re: [edk2-devel] Where to put the bhyve code in the edk2 repo: BhyvePkg, or under OvmfPkg?

2020-05-13 Thread Rebecca Cran
and Azure Agent support has been fixed on FreeBSD. -- Rebecca Cran -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#59480): https://edk2.groups.io/g/devel/message/59480 Mute This Topic: https://groups.io/mt/74075377/21656 Group Owner

Re: [edk2-devel] BDS Phase Output Menu

2020-05-12 Thread Rebecca Cran
/Application/BootManagerMenuApp/BootManagerMenuApp.inf ? It looks like it might be possible to avoid going into the BIOS Setup and instead have BDS display a list of available boot options -- like that which is often available by pressing F8 during boot on hardware platforms. -- Rebecca Cran

Re: [edk2-devel] BDS Phase Output Menu

2020-05-12 Thread Rebecca Cran
t; in the UEFI Shell, or press F1/F2/Del (I can't recall which) during boot. -- Rebecca Cran -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#59350): https://edk2.groups.io/g/devel/message/59350 Mute This Topic: https://groups.io/mt/741633

Re: [edk2-devel] Where to put the bhyve code in the edk2 repo: BhyvePkg, or under OvmfPkg?

2020-05-11 Thread Rebecca Cran
I’d be interested in working to improve any problems it currently has. I’m also planning to work on the Azure agent for FreeBSD and get a set of CI tests running for it. — Rebecca Cran -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#59

Re: [edk2-devel] [edk2-rfc] GitHub Pull Request based Code Review Process

2020-05-10 Thread Rebecca Cran
ounds like we've resolved the problems with Mergify, so it's not important. https://help.github.com/en/github/administering-a-repository/configuring-commit-squashing-for-pull-requests -- Rebecca Cran -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Re

Re: [edk2-devel] [PATCH v5 1/1] OvmfPkg: replace old EFI_D_ debug levels with new DEBUG_ ones

2020-05-09 Thread Rebecca Cran
On 4/29/20 3:53 PM, Rebecca Cran wrote: Generated mechanically with: find OvmfPkg -type f -exec sed -i -e 's/EFI_D_/DEBUG_/g' {} \; Could I get a review on this please? -- Rebecca Cran -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply

Re: [edk2-devel] [edk2-rfc] GitHub Pull Request based Code Review Process

2020-05-09 Thread Rebecca Cran
a user submits the Pull Request, and the final CI checks that run before the request is merged? Also, I'm wondering why Mergify is being used instead of the maintainer hitting the "Merge Pull Request" button, or however it's worded? -- Rebecca Cran -=-=-=-=-=-=-=-=-=-=-=- Groups.io

[edk2-devel] Problems using Block Io protocol in a CSM (worked in UDK2014.SP1, no longer works on master)

2020-05-08 Thread Rebecca Cran
add a dependency to make it work again? -- Rebecca Cran -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#58937): https://edk2.groups.io/g/devel/message/58937 Mute This Topic: https://groups.io/mt/74089165/21656 Group Owner: devel+ow...@e

[edk2-devel] Where to put the bhyve code in the edk2 repo: BhyvePkg, or under OvmfPkg?

2020-05-08 Thread Rebecca Cran
virtual platforms and not edk2-platforms, where code for physical platforms will reside. -- Rebecca Cran -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#58895): https://edk2.groups.io/g/devel/message/58895 Mute This Topic: https

[edk2-devel] [PATCH v2 1/1] ShellPkg: smbiosview - print field values as unsigned integers

2020-05-06 Thread Rebecca Cran
This prevents overflow when printing DWORD fields such as the type 17 tables's extended DIMM size. Signed-off-by: Rebecca Cran Cc: Ray Ni Cc: Zhichao Gao Cc: Philippe Mathieu-Daude --- .../UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c | 6 +++--- 1 file changed, 3 insertions(+), 3

[edk2-devel] [PATCH 1/1] OvmfPkg: Add BaseResetSystemLibBhyve.inf

2020-05-03 Thread Rebecca Cran
Introduce BaseResetSystemLibBhyve.inf, to support powering off bhyve guests. Signed-off-by: Rebecca Cran Cc: Jordan Justen Cc: Laszlo Ersek Cc: Ard Biesheuvel --- Laszlo: I couldn't find your email specifying specific changes to make, so I hope I've caught all of them. OvmfPkg/Include

[edk2-devel] [PATCH v3 1/1] OvmfPkg: Add QemuFwCfgLibNull

2020-05-03 Thread Rebecca Cran
Add a null implementation library for QemuFwCfgLib, in order to support building PciHostBridgeLib for bhyve. Signed-off-by: Rebecca Cran Cc: Jordan Justen Cc: Laszlo Ersek Cc: Ard Biesheuvel Cc: Philippe Mathieu-Daudé --- I think I've addressed all previous review feedback this time

[edk2-devel] [PATCH 1/1] BaseTools: add repo name option to SetupGit.py

2020-05-01 Thread Rebecca Cran
for, if not detected automatically Signed-off-by: Rebecca Cran Cc: Bob Feng Cc: Liming Gao --- Tested with: pylama : no new issues detected Option tested: -n : correctly said a parameter was needed -n edk2 : configured the repo for edk2 -n edk2-foo : errored out

<    8   9   10   11   12   13   14   15   >