Since Python3 is now required, we can remove the checks for PYTHON3_ENABLE
and PYTHON3 and simplify the code in toolsetup.bat. Also, remove the
leftover from when we supported freezing Python code.
While here, fix a couple of typos and improve error messages.
Signed-off-by: Rebecca Cran
lenv since it installs python.exe and pythonw.exe in
venv\Scripts. toolsetup.bat therefore fails to detect the Pip BaseTools and
uses the in-source Basetools.
GitHub PR: https://github.com/tianocore/edk2/pull/4302
GitHub branch: https://github.com/bcran/edk2/tree/py3
Rebecca Cran (6):
BaseToo
to be run that needs quotes around it.
--
Rebecca Cran
On 4/24/23 00:14, Michael D Kinney wrote:
Hi Rebecca,
I have seen some issues with CLANGDWARF and need a little time to investigate
further.
Mike
-Original Message-
From: Rebecca Cran
Sent: Friday, April 21, 2023 10:15 AM
,
reason: connect ETIMEDOUT 192.30.255.117:443
Error: Unable to download and extract CodeQL CLI
https://www.githubstatus.com/ reports there's an ongoing issue affecting
several services.
--
Rebecca Cran
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View
It is something I could help troubleshoot in parallel?
--
Rebecca Cran
On 4/24/23 00:14, Kinney, Michael D wrote:
Hi Rebecca,
I have seen some issues with CLANGDWARF and need a little time to investigate
further.
Mike
-Original Message-
From: Rebecca Cran
Sent: Friday, April
Add quotes around the OBJCOPY command in build_rule.template to fix the
case where LLVM is installed on Windows in a path with spaces such as
C:\Program Files\LLVM.
Signed-off-by: Rebecca Cran
---
BaseTools/Conf/build_rule.template | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff
Add quotes around the OBJCOPY command in build_rule.template to fix the
case where LLVM is installed on Windows in a path with spaces such as
C:\Program Files\LLVM.
Signed-off-by: Rebecca Cran
---
BaseTools/Conf/build_rule.template | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff
Thanks, I've been able to reproduce the failure.
Since it's a simple fix and is independent of my other changes, I'd
prefer to avoid making this patch series larger and instead fix this first.
I'll send out a patch in a few minutes.
--
Rebecca Cran
On 4/24/23 05:28, Feng, Bob C wrote
The newest release listed in Bugzilla is edk2-stable202105.
Could someone add the newer releases please?
Thanks.
Rebecca Cran
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#103479): https://edk2.groups.io/g/devel/message/103479
Mute
Since gitbook.io is no longer used, update the remaining links to point
to the documents on tianocore-docs.github.io instead.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Rebecca Cran
---
CET-in-SMM.md | 2 +-
EDK-II-Code-Formatting.md | 2
Thanks, I've fixed the issues you noted and sent out a v5 series.
I kept your Reviewed-by on 01/13 despite making minor changes to fix the
build on Windows: I hope that was okay.
--
Rebecca Cran
On 4/20/23 20:32, gaoliming wrote:
Rebecca:
I add my comments below.
-邮件原件-
发件人
Bump VERSION to 3.00 and explain the changes made to the toolchains.
Signed-off-by: Rebecca Cran
Reviewed-by: Liming Gao
---
BaseTools/Conf/tools_def.template | 7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/BaseTools/Conf/tools_def.template
b/BaseTools/Conf
In order to make it clear for anyone reading tools_def.template, add
a section for deprecated tool chains and move GCC48, GCC49 and GCC5
into it.
Signed-off-by: Rebecca Cran
Reviewed-by: Liming Gao
---
BaseTools/Conf/tools_def.template | 31 +++
1 file changed, 23
The GCC48, GCC49 and GCC5 toolchains will be deleted in the coming
months. Inform users that they're deprecated and tell them what replaces
them.
Signed-off-by: Rebecca Cran
Reviewed-by: Liming Gao
---
BaseTools/Source/Python/build/build.py | 14 ++
1 file changed, 14 insertions
Avoid calling LoadConfiguration twice, in both InitPreBuild and
InitBuild. Since InitPreBuild is called first, delete the second call
from InitBuild.
Signed-off-by: Rebecca Cran
Reviewed-by: Liming Gao
---
BaseTools/Source/Python/build/build.py | 4 +---
1 file changed, 1 insertion(+), 3
Add a 'GCC' toolchain that's a copy of the existing GCC5 definition.
Add a 'GCCNOLTO' toolchain that's a copy of the existing GCC49
toolchain.
Signed-off-by: Rebecca Cran
---
UnitTestFrameworkPkg/UnitTestFrameworkPkgHost.dsc.inc | 4
IntelFsp2Pkg/Tools/Tests/QemuFspPkg.dsc
Update the Visual Studio toolchain descriptions in
tools_def.txt.template:
- The WinDDK is no longer needed.
- Update 3 is required for VS 2015.
- VS 2005 has been removed.
Signed-off-by: Rebecca Cran
Reviewed-by: Liming Gao
---
BaseTools/Conf/tools_def.template | 7 ++-
1 file changed, 2
-off-by: Rebecca Cran
Reviewed-by: Oliver Smith-Denny
Reviewed-by: Liming Gao
---
BaseTools/Conf/tools_def.template | 98
--
1 file changed, 98 deletions(-)
diff --git a/BaseTools/Conf
Remove the unused IPHONE_TOOLS and SOURCERY_CYGWIN_TOOLS definitions
from Conf/tools_def.template.
Signed-off-by: Rebecca Cran
Reviewed-by: Oliver Smith-Denny
Reviewed-by: Liming Gao
---
BaseTools/Conf/tools_def.template | 4
1 file changed, 4 deletions(-)
diff --git a/BaseTools/Conf
Since Visual Studio versions older than VS2015 are no longer supported,
remove mention of them from edksetup.bat.
Signed-off-by: Rebecca Cran
Reviewed-by: Oliver Smith-Denny
Reviewed-by: Liming Gao
Reviewed-by: Leif Lindholm
---
edksetup.bat | 6 +-
1 file changed, 1 insertion(+), 5
Since Visual Studio versions older than VS2015 are no longer supported,
remove mention of them from MdePkg.
Signed-off-by: Rebecca Cran
Reviewed-by: Oliver Smith-Denny
Reviewed-by: Liming Gao
---
MdePkg/Include/Ia32/ProcessorBind.h | 8 ++--
MdePkg/Include/X64/ProcessorBind.h | 8
Remove remnants of Visual Studio 2008-2013 support from
Conf/tools_def.txt and various batch scripts.
Signed-off-by: Rebecca Cran
Reviewed-by: Oliver Smith-Denny
Reviewed-by: Liming Gao
---
BaseTools/Conf/tools_def.template | 12
BaseTools/Scripts/SetVisualStudio.bat | 22
With recent changes, Visual Studio versions older than VS2015 are
unable to build EDK2 code.
To avoid confusion, remove VS2008, 2010, 2012 and 2013 toolchain
definitions from Conf/tools_def.template, leaving only versions that can
be used to successfully build firmware.
Signed-off-by: Rebecca
the compiler flags in
BaseCryptLib and OpensslLib.
Signed-off-by: Rebecca Cran
Reviewed-by: Liming Gao
---
CryptoPkg/Library/BaseCryptLib/BaseCryptLib.inf | 3 +--
CryptoPkg/Library/BaseCryptLib/PeiCryptLib.inf | 3 +--
CryptoPkg/Library/BaseCryptLib/RuntimeCryptLib.inf
installed in Visual Studio: use llvm-objcopy and the
tools prefix.
- Added flags for GCCNOLTO to UnitTestFrameworkPkgHost.dsc.inc
- Added GCC flags to CryptoPkg/Library/OpensslLib/*.inf
Rebecca Cran (13):
BaseTools,CryptoPkg: Update CLANGDWARF, remove CLANG 35/38 toolchains
BaseTools: Rem
nd,
to indicate to Doxygen to add a line break.
--
Rebecca Cran
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#103405): https://edk2.groups.io/g/devel/message/103405
Mute This Topic: https://groups.io/mt/98390298/21656
Group Owner: deve
-80c7-040377c664fd=a7f329c1-489d-56ab-b670-1c248e984338
--
Rebecca Cran
On 4/20/23 11:29, Leif Lindholm wrote:
On Thu, Apr 20, 2023 at 16:44:23 +0200, Marcin Juszkiewicz wrote:
App goes through ID_AA64*_EL1 system registers and decode their values.
Signed-off-by: Marcin Juszkiewicz
Bump VERSION to 3.00 and explain the changes made to the toolchains.
Signed-off-by: Rebecca Cran
---
BaseTools/Conf/tools_def.template | 7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/BaseTools/Conf/tools_def.template
b/BaseTools/Conf/tools_def.template
index
In order to make it clear for anyone reading tools_def.template, add
a section for deprecated tool chains and move GCC48, GCC49 and GCC5
into it.
Signed-off-by: Rebecca Cran
---
BaseTools/Conf/tools_def.template | 31 +++
1 file changed, 23 insertions(+), 8 deletions
The GCC48, GCC49 and GCC5 toolchains will be deleted in the coming
months. Inform users that they're deprecated and tell them what replaces
them.
Signed-off-by: Rebecca Cran
---
BaseTools/Source/Python/build/build.py | 14 ++
1 file changed, 14 insertions(+)
diff --git a/BaseTools
Avoid calling LoadConfiguration twice, in both InitPreBuild and
InitBuild. Since InitPreBuild is called first, delete the second call
from InitBuild.
Signed-off-by: Rebecca Cran
---
BaseTools/Source/Python/build/build.py | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git
Add a 'GCC' toolchain that's a copy of the existing GCC5 definition.
Add a 'GCCNOLTO' toolchain that's a copy of the existing GCC48
toolchain.
Signed-off-by: Rebecca Cran
---
UnitTestFrameworkPkg/UnitTestFrameworkPkgHost.dsc.inc | 2 ++
IntelFsp2Pkg/Tools/Tests/QemuFspPkg.dsc
Update the Visual Studio toolchain descriptions in
tools_def.txt.template:
- The WinDDK is no longer needed.
- Update 3 is required for VS 2015.
- VS 2005 has been removed.
Signed-off-by: Rebecca Cran
---
BaseTools/Conf/tools_def.template | 7 ++-
1 file changed, 2 insertions(+), 5
-off-by: Rebecca Cran
Reviewed-by: Oliver Smith-Denny
---
BaseTools/Conf/tools_def.template | 98
--
1 file changed, 98 deletions(-)
diff --git a/BaseTools/Conf/tools_def.template
b/BaseTools/Conf
Remove the unused IPHONE_TOOLS and SOURCERY_CYGWIN_TOOLS definitions
from Conf/tools_def.template.
Signed-off-by: Rebecca Cran
Reviewed-by: Oliver Smith-Denny
---
BaseTools/Conf/tools_def.template | 4
1 file changed, 4 deletions(-)
diff --git a/BaseTools/Conf/tools_def.template
b
Since Visual Studio versions older than VS2015 are no longer supported,
remove mention of them from edksetup.bat.
Signed-off-by: Rebecca Cran
Reviewed-by: Oliver Smith-Denny
---
edksetup.bat | 6 +-
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/edksetup.bat b/edksetup.bat
Since Visual Studio versions older than VS2015 are no longer supported,
remove mention of them from MdePkg.
Signed-off-by: Rebecca Cran
Reviewed-by: Oliver Smith-Denny
---
MdePkg/Include/Ia32/ProcessorBind.h | 8 ++--
MdePkg/Include/X64/ProcessorBind.h | 8 ++--
2 files changed, 4
With recent changes, Visual Studio versions older than VS2015 are
unable to build EDK2 code.
To avoid confusion, remove VS2008, 2010, 2012 and 2013 toolchain
definitions from Conf/tools_def.template, leaving only versions that can
be used to successfully build firmware.
Signed-off-by: Rebecca
Remove remnants of Visual Studio 2008-2013 support from
Conf/tools_def.txt and various batch scripts.
Signed-off-by: Rebecca Cran
Reviewed-by: Oliver Smith-Denny
---
BaseTools/Conf/tools_def.template | 12
BaseTools/Scripts/SetVisualStudio.bat | 22
the compiler flags in
BaseCryptLib and OpensslLib.
Signed-off-by: Rebecca Cran
---
CryptoPkg/Library/BaseCryptLib/BaseCryptLib.inf | 3 +--
CryptoPkg/Library/BaseCryptLib/PeiCryptLib.inf | 3 +--
CryptoPkg/Library/BaseCryptLib/RuntimeCryptLib.inf | 3 +--
CryptoPkg
he VERSION section in tools_def.template.
- Various fixes to the CLANGDWARF flags.
Changes from v3 to v4
=
- Use lld for -a ARM -t CLANGDWARF.
Rebecca Cran (13):
BaseTools,CryptoPkg: Update CLANGDWARF, remove CLANG 35/38 toolchains
BaseTools: Remove VS2008, 2010, 2012 and 2013
Reviewed-by: Rebecca Cran
On 4/18/23 10:11 AM, mikub...@linux.microsoft.com wrote:
From: Michael Kubacki
HostBasedUnitTestRunner.py is a build plugin responsible for locating
and executing host-based unit tests.
Recently, commit 6bb00aa introduced support for the plugin to
generate code
Hi Richard,
I was wondering if you'd seen my questions about ECM and NCM, and rate
limiting?
--
Rebecca Cran
On 4/11/23 6:31 AM, Rebecca Cran wrote:
Yes, you can add me as a reviewer.
A couple more comments on the patches: why are ECM and NCM disabled by
default?
I've tested on my
it in this patch
series but revisit it later on.
--
Rebecca Cran
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#103098): https://edk2.groups.io/g/devel/message/103098
Mute This Topic: https://groups.io/mt/98302347/21656
Group Owner: devel+ow...@edk2
On 4/17/23 4:17 AM, Gerd Hoffmann wrote:
On Fri, Apr 14, 2023 at 06:13:03AM -0600, Rebecca Cran wrote:
Sorry for not commenting on this earlier.
Would it be better to have people use the build `--pcd` option instead? e.g.
build
--pcd="gEfiMdeModulePkgTokenSpaceGuid.PcdFirmwareVersionS
%a: RSDP not found\n", __func__));
Should these DEBUG_INFO messages which appear to be warnings/errors use
DEBUG_WARN or DEBUG_ERROR, instead?
--
Rebecca Cran
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#103089): https://edk2.groups.io
Pushed as
https://github.com/tianocore/edk2/commit/6ded9f50c3aa123fe581c42ff6c03789b9b593c1
.
--
Rebecca Cran
On 12/16/22 15:35, Michael D Kinney wrote:
Hi Pedro,
This is great feature. We may have some other big changes
in our git history that we may want to have an option to ignore
Bump VERSION to 3.00 and explain the changes made to the toolchains.
Signed-off-by: Rebecca Cran
---
BaseTools/Conf/tools_def.template | 7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/BaseTools/Conf/tools_def.template
b/BaseTools/Conf/tools_def.template
index
In order to make it clear for anyone reading tools_def.template, add
a section for deprecated tool chains and move GCC48, GCC49 and GCC5
into it.
Signed-off-by: Rebecca Cran
---
BaseTools/Conf/tools_def.template | 31 +++-
1 file changed, 23 insertions(+), 8 deletions(-)
diff
The GCC48, GCC49 and GCC5 toolchains will be deleted in the coming
months. Inform users that they're deprecated and tell them what replaces
them.
Signed-off-by: Rebecca Cran
---
BaseTools/Source/Python/build/build.py | 14 ++
1 file changed, 14 insertions(+)
diff --git a/BaseTools
Avoid calling LoadConfiguration twice, in both InitPreBuild and
InitBuild. Since InitPreBuild is called first, delete the second call
from InitBuild.
Signed-off-by: Rebecca Cran
---
BaseTools/Source/Python/build/build.py | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git
Add a 'GCC' toolchain that's a copy of the existing GCC5 definition.
Add a 'GCCNOLTO' toolchain that's a copy of the existing GCC48
toolchain.
Signed-off-by: Rebecca Cran
---
UnitTestFrameworkPkg/UnitTestFrameworkPkgHost.dsc.inc | 2 +
IntelFsp2Pkg/Tools/Tests/QemuFspPkg.dsc
-off-by: Rebecca Cran
Reviewed-by: Oliver Smith-Denny
---
BaseTools/Conf/tools_def.template | 98
1 file changed, 98 deletions(-)
diff --git a/BaseTools/Conf/tools_def.template
b/BaseTools/Conf/tools_def.template
index 39f17067e153..5fad1b292a60 100755
--- a/BaseTools/Conf
Update the Visual Studio toolchain descriptions in
tools_def.txt.template:
- The WinDDK is no longer needed.
- Update 3 is required for VS 2015.
- VS 2005 has been removed.
Signed-off-by: Rebecca Cran
---
BaseTools/Conf/tools_def.template | 7 ++-
1 file changed, 2 insertions(+), 5
Remove the unused IPHONE_TOOLS and SOURCERY_CYGWIN_TOOLS definitions
from Conf/tools_def.template.
Signed-off-by: Rebecca Cran
Reviewed-by: Oliver Smith-Denny
---
BaseTools/Conf/tools_def.template | 4
1 file changed, 4 deletions(-)
diff --git a/BaseTools/Conf/tools_def.template
b
Since Visual Studio versions older than VS2015 are no longer supported,
remove mention of them from edksetup.bat.
Signed-off-by: Rebecca Cran
Reviewed-by: Oliver Smith-Denny
---
edksetup.bat | 6 +-
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/edksetup.bat b/edksetup.bat
Since Visual Studio versions older than VS2015 are no longer supported,
remove mention of them from MdePkg.
Signed-off-by: Rebecca Cran
Reviewed-by: Oliver Smith-Denny
---
MdePkg/Include/Ia32/ProcessorBind.h | 8 ++--
MdePkg/Include/X64/ProcessorBind.h | 8 ++--
2 files changed, 4
Remove remnants of Visual Studio 2008-2013 support from
Conf/tools_def.txt and various batch scripts.
Signed-off-by: Rebecca Cran
Reviewed-by: Oliver Smith-Denny
---
BaseTools/Conf/tools_def.template | 12
BaseTools/Scripts/SetVisualStudio.bat | 22 +--
BaseTools/Scripts
With recent changes, Visual Studio versions older than VS2015 are
unable to build EDK2 code.
To avoid confusion, remove VS2008, 2010, 2012 and 2013 toolchain
definitions from Conf/tools_def.template, leaving only versions that can
be used to successfully build firmware.
Signed-off-by: Rebecca
the compiler flags in
BaseCryptLib and OpensslLib.
Signed-off-by: Rebecca Cran
---
CryptoPkg/Library/BaseCryptLib/BaseCryptLib.inf | 3 +-
CryptoPkg/Library/BaseCryptLib/PeiCryptLib.inf | 3 +-
CryptoPkg/Library/BaseCryptLib/RuntimeCryptLib.inf | 3 +-
CryptoPkg
he VERSION section in tools_def.template.
- Various fixes to the CLANGDWARF flags.
Rebecca Cran (13):
BaseTools,CryptoPkg: Update CLANGDWARF, remove CLANG 35/38 toolchains
BaseTools: Remove VS2008, 2010, 2012 and 2013 toolchain definitions
BaseTools: Remove VS2008-VS2013 remnants
MdePkg: Rem
If it passes CI, then for the series:
Reviewed-by: Rebecca Cran
On 4/14/23 02:02, Gerd Hoffmann wrote:
There is alot of code duplication between BaseTools and MdePkg (and also
MdeModulePkg). This patch series starts reducing this by removing some
header files. BaseTools are switched over
? I think it would complain about the
alignment here.
--
Rebecca Cran
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#102997): https://edk2.groups.io/g/devel/message/102997
Mute This Topic: https://groups.io/mt/98257902/21656
Group Owner
Sorry for not commenting on this earlier.
Would it be better to have people use the build `--pcd` option instead?
e.g. build
--pcd="gEfiMdeModulePkgTokenSpaceGuid.PcdFirmwareVersionString=edk2-stable202302".
--
Rebecca Cran
On 4/14/23 02:33, Oliver Steffen wrote:
ArmVirtXen.
);
+ DEBUG ((DEBUG_ERROR, "Juno rev=%d\n", JunoRevision));
Should that be DEBUG_INFO? Or is it DEBUG_ERROR because of the value of
PcdDebugPrintErrorLevel which doesn't include INFO messages?
I was just wondering a few days ago whether it should be 0x804F
instead of 0x800F?
ns if it's
present) if you've run "python3 BaseTools/Scripts/SetupGit.py".
Running that script will also setup repo-local settings to have patches
generated and sent in the expected format.
--
Rebecca Cran
On 12/6/22 00:29, Corvin Köhne wrote:
Signed-off-by: Corvin Köhne
Revie
New code should use the C99 macro __func__ instead of the pre-Standard
macro __FUNCTION__. Update PatchCheck.py to reject patches with the
latter.
Signed-off-by: Rebecca Cran
---
BaseTools/Scripts/PatchCheck.py | 6 ++
1 file changed, 6 insertions(+)
diff --git a/BaseTools/Scripts
/BaseTools/Source/C'
make: *** [GNUmakefile:19: Source/C] Error 2
make: Leaving directory '/home/bcran/src/uefi/edk2/BaseTools'
--
Rebecca Cran
On 4/13/23 02:53, Gerd Hoffmann wrote:
There is alot of code duplication between BaseTools and MdePkg (and also
MdeModulePkg). This patch series start
to exclude .py which would catch this change to PatchCheck.py.
--
Rebecca Cran
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#102859): https://edk2.groups.io/g/devel/message/102859
Mute This Topic: https://groups.io/mt/98117903/21656
Group
Could I get some reviews on this please?
--
Rebecca Cran
On 4/6/23 7:28 PM, Rebecca Cran wrote:
To help people format patches with the correct options, add an alias
named 'fp' to SetupGit.py that runs format-patch with '-M --stat=1000
--stat-graph-width=20'.
Signed-off-by: Rebecca Cran
Could I get some reviews on this please?
--
Rebecca Cran
On 4/6/23 7:30 PM, Rebecca Cran wrote:
New code should use the C99 macro __func__ instead of the pre-Standard
macro __FUNCTION__. Update PatchCheck.py to reject patches with the
latter.
Signed-off-by: Rebecca Cran
---
BaseTools
From: Rebecca Cran
Add a new library, JedecJep106Lib which provides a service to return the
JEDEC JEP106 manufacturer string given the code and continuation bytes
values.
Signed-off-by: Rebecca Cran
---
MdePkg/MdePkg.dec|3 +
MdePkg/MdePkg.dsc
make[1]: Leaving directory '/home/bcran/src/uefi/edk2/BaseTools/Source/C'
make: *** [GNUmakefile:19: Source/C] Error 2
make: Leaving directory '/home/bcran/src/uefi/edk2/BaseTools'
--
Rebecca Cran
On 4/11/23 9:45 AM, Gerd Hoffmann wrote:
There is alot of code duplication between BaseTools
I've pushed the patches to a branch at
https://github.com/bcran/edk2/tree/usbnetworkpkg-202304
--
Rebecca Cran
On 4/7/23 5:27 AM, Richard Ho (何明忠) wrote:
This driver provides UEFI driver for USB RNDIS device
Signed-off-by: Richard Ho
Cc: Andrew Fish
Cc: Leif Lindholm
Cc: Michael D
Enable the NOOPT build for the Juno platform. This is useful for
source-level debugging.
Signed-off-by: Rebecca Cran
---
Platform/ARM/JunoPkg/ArmJuno.dsc | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Platform/ARM/JunoPkg/ArmJuno.dsc b/Platform/ARM/JunoPkg/ArmJuno.dsc
index
of the Flash Device but is instead selected to reduce the amount of
time needed to copy the image to the target.
Update the BlockSize and NumBlocks to reflect the 256KB block size of
the main area on the Juno R2.
Signed-off-by: Rebecca Cran
---
Platform/ARM/JunoPkg/ArmJuno.fdf | 15 +++
1
with
HTTPS boot and dynamic framework pkg uses around 72%, giving plenty of
headroom for future growth.
Since the NOOPT build makes source-level debugging via Arm Development
Studio so much more useful, enable it in the .dsc file.
Rebecca Cran (2):
Platform/ARM/JunoPkg: Bump the FV size to 2MB
Platform
Pushed as
f2cc962cd28fe75fb4edf230d69e99c346fe9c8a..61652efd04a7585a779226137d0f9739a75aac69.
--
Rebecca Cran
On 4/6/23 4:23 PM, Rebecca Cran wrote:
Following on from commit b17a3a133b18fb41493fba7d86e9b5804ea6a8cf which
updated MdePkg to be more C11 compliant by replacing the pre-standard
From: Rebecca Cran
Add a new library, JedecJep106Lib which provides a service to return the
JEDEC JEP106 manufacturer string given the code and continuation bytes
values.
Signed-off-by: Rebecca Cran
---
MdePkg/MdePkg.dec|3 +
MdePkg/MdePkg.dsc
function to return the length of the longest string.
Rebecca Cran (1):
MdePkg: Add new JedecJep106Lib to fetch JEDEC JEP106 manufacturer
MdePkg/MdePkg.dec|3 +
MdePkg/MdePkg.dsc|2 +
MdePkg/Library/JedecJep106Lib
variables, not structure
declarations.
Mike
-Original Message-
From: devel@edk2.groups.io On Behalf Of Rebecca Cran
Sent: Friday, April 7, 2023 3:59 PM
To: Kinney, Michael D ; devel@edk2.groups.io; Liu,
Zhiguang ; Gao, Liming
Cc: Rebecca Cran
Subject: Re: [edk2-devel] [PATCH v2 1/1] MdePkg
I guess GLOBAL_REMOVE_IF_UNREFERENCED should be added to the struct too?
On 4/7/23 4:42 PM, Rebecca Cran wrote:
On 4/7/23 2:25 PM, Kinney, Michael D wrote:
Comments below.
Hopefully this lib would only be used by modules that get compressed.
I guess so, but that's for the user to decide
uld be in the SMBIOS Type 17 table before doing the SPD
parsing.
I'll remove it for now, and if it's really needed I can add it back in.
--
Rebecca Cran
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#102738): https://edk2.groups.io/g/de
/blob/master/MdePkg/Include/IndustryStandard/SdramSpdDdr4.h).
--
Rebecca Cran
On 2/14/23 2:47 PM, Rebecca Cran wrote:
+Liming
On 2/14/23 08:36, Rebecca Cran wrote:
Copying the style of SdramSpdDdr4.h, add DDR5 SPD definitions to
SpdDdr5.h per JEDEC JESD400-5A.01 specification
(https
From: Rebecca Cran
Add a new library, JedecJep106Lib which provides a service to return the
JEDEC JEP106 manufacturer string given the code and continuation bytes
values.
Signed-off-by: Rebecca Cran
---
MdePkg/MdePkg.dec|3 +
MdePkg/MdePkg.dsc
/edk2/tree/jep106
GitHub PR: https://github.com/tianocore/edk2/pull/4255
Rebecca Cran (1):
MdePkg: Add new JedecJep106Lib to fetch JEDEC JEP106 manufacturer
MdePkg/MdePkg.dec|3 +
MdePkg/MdePkg.dsc|2 +
MdePkg/Library
New code should use the C99 macro __func__ instead of the pre-Standard
macro __FUNCTION__. Update PatchCheck.py to reject patches with the
latter.
Signed-off-by: Rebecca Cran
---
BaseTools/Scripts/PatchCheck.py | 4
1 file changed, 4 insertions(+)
diff --git a/BaseTools/Scripts
To help people format patches with the correct options, add an alias
named 'fp' to SetupGit.py that runs format-patch with '-M --stat=1000
--stat-graph-width=20'.
Signed-off-by: Rebecca Cran
---
BaseTools/Scripts/SetupGit.py | 2 ++
1 file changed, 2 insertions(+)
diff --git a/BaseTools
to compile. A workaround is to define __func__ as
__FUNCTION__ :
#define __func__ __FUNCTION__
Signed-off-by: Rebecca Cran
---
FmpDevicePkg/FmpDxe/VariableSupport.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/FmpDevicePkg/FmpDxe/VariableSupport.c
b/FmpDevicePkg/FmpDxe
to compile. A workaround is to define __func__ as
__FUNCTION__ :
#define __func__ __FUNCTION__
Signed-off-by: Rebecca Cran
---
UefiPayloadPkg/Library/PciHostBridgeLib/PciHostBridgeLib.c | 4 ++--
UefiPayloadPkg/UefiPayloadEntry/Ia32/DxeLoadFunc.c | 2 +-
2 files changed, 3 insertions
to compile. A workaround is to define __func__ as
__FUNCTION__ :
#define __func__ __FUNCTION__
Signed-off-by: Rebecca Cran
---
EmulatorPkg/Library/RedfishPlatformHostInterfaceLib/RedfishPlatformHostInterfaceLib.c
| 2 +-
EmulatorPkg/Win/Host/WinPacketFilter.c
will fail to compile. A workaround is to define __func__ as
__FUNCTION__ :
#define __func__ __FUNCTION__
Signed-off-by: Rebecca Cran
---
SourceLevelDebugPkg/Library/DebugCommunicationLibUsb3/DebugCommunicationLibUsb3Dxe.c
| 4 ++--
SourceLevelDebugPkg/Library/DebugCommunicationLibUsb3
to compile. A workaround is to define __func__ as
__FUNCTION__ :
#define __func__ __FUNCTION__
Signed-off-by: Rebecca Cran
---
NetworkPkg/HttpDxe/HttpsSupport.c | 16
NetworkPkg/IScsiDxe/IScsiMisc.c | 4 ++--
2 files changed, 10 insertions(+), 10 deletions(-)
diff --git
to compile. A workaround is to define __func__ as
__FUNCTION__ :
#define __func__ __FUNCTION__
Signed-off-by: Rebecca Cran
---
CryptoPkg/Library/TlsLib/TlsConfig.c | 8
CryptoPkg/Library/TlsLib/TlsProcess.c | 4 ++--
2 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/CryptoPkg
to compile. A workaround is to define __func__ as
__FUNCTION__ :
#define __func__ __FUNCTION__
Signed-off-by: Rebecca Cran
---
StandaloneMmPkg/Library/StandaloneMmCoreEntryPoint/Arm/SetPermissions.c
| 22 ++--
StandaloneMmPkg/Library
. A workaround is to define __func__ as
__FUNCTION__ :
#define __func__ __FUNCTION__
Signed-off-by: Rebecca Cran
---
PrmPkg/Application/PrmInfo/PrmInfo.c
| 6 +--
PrmPkg/Library/DxePrmContextBufferLib/DxePrmContextBufferLib.c
| 10
will fail to compile. A workaround is to define __func__ as
__FUNCTION__ :
#define __func__ __FUNCTION__
Signed-off-by: Rebecca Cran
---
UnitTestFrameworkPkg/Library/UnitTestBootLibUsbClass/UnitTestBootLibUsbClass.c
| 12 -
UnitTestFrameworkPkg/Library
to compile. A workaround is to define __func__ as
__FUNCTION__ :
#define __func__ __FUNCTION__
Signed-off-by: Rebecca Cran
---
ArmPlatformPkg/Drivers/SP805WatchdogDxe/SP805Watchdog.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/ArmPlatformPkg/Drivers/SP805WatchdogDxe
to compile. A workaround is to define __func__ as
__FUNCTION__ :
#define __func__ __FUNCTION__
Signed-off-by: Rebecca Cran
---
RedfishPkg/Library/PlatformHostInterfaceBmcUsbNicLib/PlatformHostInterfaceBmcUsbNicLib.c
| 36 ++--
RedfishPkg/Library/RedfishPlatformCredentialIpmiLib
to compile. A workaround is to define __func__ as
__FUNCTION__ :
#define __func__ __FUNCTION__
Signed-off-by: Rebecca Cran
---
EmbeddedPkg/Drivers/ConsolePrefDxe/ConsolePrefDxe.c | 18
EmbeddedPkg/Drivers/DtPlatformDxe/DtPlatformDxe.c | 10 -
EmbeddedPkg
301 - 400 of 1416 matches
Mail list logo
