Re: [edk2-devel] [PATCH V2 1/1] MdePkg: Update the definition of FileName on EFI_FILE_INFO

2024-01-22 Thread Ren, Suqiang
Hi Mike, Thanks for reviewing. Patch updated here: https://edk2.groups.io/g/devel/message/114182. From my check this change need not update with the same function header. Can you help to review again? Thanks Ren, Suqiang -Original Message- From: Kinney

[edk2-devel] [PATCH V3 1/1] MdePkg: Update the definition of FileName on EFI_FILE_INFO

2024-01-22 Thread Ren, Suqiang
Add the description of FileName[1] to align with UEFI spec 2.10. REF: UEFI spec 2.10 section 13.5.16 Signed-off-by: Suqiang Ren Cc: Michael D Kinney Cc: Liming Gao Cc: Zhiguang Liu --- MdePkg/Include/Guid/FileInfo.h | 1 + 1 file changed, 1 insertion(+) diff --git

Re: [edk2-devel] [PATCH 1/1] MdePkg: Add EFI_UNSUPPORTED return for some Runtime Service functions

2024-01-19 Thread Ren, Suqiang
Hi All, Any comments about this patch? Thanks Ren, Suqiang -Original Message- From: Ren, SuqiangX Sent: Thursday, January 11, 2024 5:05 PM To: devel@edk2.groups.io Cc: Kinney, Michael D ; Gao, Liming ; Liu, Zhiguang Subject: RE: [edk2-devel] [PATCH 1/1] MdePkg: Add

Re: [edk2-devel] [PATCH V2 1/1] MdePkg: Update the definition of FileName on EFI_FILE_INFO

2024-01-19 Thread Ren, Suqiang
Hi All, Any comments about this patch? Thanks Ren, Suqiang -Original Message- From: Ren, SuqiangX Sent: Thursday, January 11, 2024 5:04 PM To: devel@edk2.groups.io Cc: Kinney, Michael D ; Gao, Liming ; Liu, Zhiguang Subject: RE: [edk2-devel] [PATCH V2 1/1] MdePkg

Re: [edk2-devel] [PATCH 1/1] MdePkg: Update the comments of HiiConfigAccess ExtractConfig

2024-01-14 Thread Ren, Suqiang
Hi Liming, Could you help to merge below patches which all your reviewed-by? Thanks! https://github.com/tianocore/edk2/pull/5170 https://github.com/tianocore/edk2/pull/5186 https://github.com/tianocore/edk2/pull/5190 Thanks Ren, Suqiang -Original Message

Re: [edk2-devel] [PATCH 1/1] MdePkg: Add EFI_UNSUPPORTED return for some Runtime Service functions

2024-01-11 Thread Ren, Suqiang
Hi All, Any comments about this patch? Thanks Ren, Suqiang -Original Message- From: devel@edk2.groups.io On Behalf Of Ren, Suqiang Sent: Wednesday, December 27, 2023 4:47 PM To: devel@edk2.groups.io Cc: Kinney, Michael D ; Gao, Liming ; Liu, Zhiguang Subject: [edk2

Re: [edk2-devel] [PATCH V2 1/1] MdePkg: Update the definition of FileName on EFI_FILE_INFO

2024-01-11 Thread Ren, Suqiang
Hi All, Any comments about this patch? Thanks Ren, Suqiang -Original Message- From: devel@edk2.groups.io On Behalf Of Ren, Suqiang Sent: Tuesday, December 26, 2023 1:22 PM To: devel@edk2.groups.io Cc: Kinney, Michael D ; Gao, Liming ; Liu, Zhiguang Subject: [edk2

Re: [edk2-devel] [PATCH V3 0/2] Change the comments RFC1323 to RFC7323

2024-01-09 Thread Ren, Suqiang
Hi Liming, Thanks for review this Pull Request: https://github.com/tianocore/edk2/pull/5190. Since All checks have passed. Could you please help to push it? Thanks Ren, Suqiang -Original Message- From: devel@edk2.groups.io On Behalf Of gaoliming via groups.io Sent

Re: [edk2-devel] [PATCH 1/1] MdePkg: Update the comments of HiiConfigAccess ExtractConfig

2024-01-08 Thread Ren, Suqiang
Hi Liming, Could you please help to check and merge this patch? https://github.com/tianocore/edk2/pull/5170 Thanks Ren, Suqiang -Original Message- From: gaoliming Sent: Saturday, December 23, 2023 10:10 AM To: devel@edk2.groups.io; Ren, SuqiangX Cc: Kinney, Michael D

Re: [edk2-devel] [PATCH V2 1/1] [MdePkg] Updated the definition of EFI_NVDIMM_LABEL_FLAGS_LOCAL

2024-01-07 Thread Ren, Suqiang
Hi Liming, Could you please have a check and merge this patch? https://github.com/tianocore/edk2/pull/5167 Thanks Ren, Suqiang -Original Message- From: gaoliming Sent: Thursday, December 21, 2023 9:02 AM To: devel@edk2.groups.io; Ren, SuqiangX Cc: Kinney, Michael D

Re: [edk2-devel] [PATCH 1/1] MdePkg: Update the comments of callback in EFI_FORM_BROWSER2_PROTOCOL

2024-01-07 Thread Ren, Suqiang
Add the Pull Request link: https://github.com/tianocore/edk2/pull/5186. Hi Liming, Could you please have a check and merge this patch? Thanks Ren, Suqiang -Original Message- From: Ren, SuqiangX Sent: Tuesday, January 2, 2024 10:43 AM To: 'gaoliming' ; devel@edk2.groups.io Cc

Re: [edk2-devel] [PATCH V3 0/2] Change the comments RFC1323 to RFC7323

2024-01-03 Thread Ren, Suqiang
Add the Pull Request link: https://github.com/tianocore/edk2/pull/5190. Thanks Ren, Suqiang -Original Message- From: devel@edk2.groups.io On Behalf Of Ren, Suqiang Sent: Tuesday, January 2, 2024 2:33 PM To: devel@edk2.groups.io; Ren, SuqiangX Cc: Kinney, Michael D ; Gao, Liming ; Liu

Re: [edk2-devel] [PATCH 1/1] MdePkg: Update the definition of CapsuleImageSize on EFI_CAPSULE_HEADER

2024-01-03 Thread Ren, Suqiang
Hi Liming, Thanks for reminding me. Here are the PR for test CI: https://github.com/tianocore/edk2/pull/5189. Could you help to merge this patch? Thanks Ren, Suqiang -Original Message- From: gaoliming Sent: Wednesday, January 3, 2024 8:50 AM To: Ren, SuqiangX ; devel

Re: [edk2-devel] [PATCH V3 0/2] Change the comments RFC1323 to RFC7323

2024-01-01 Thread Ren, Suqiang
Hi Liming, This patch has reviewed by Kasbekar, Saloni: https://edk2.groups.io/g/devel/message/112933 Could you help to merge this patch? Thanks Ren, Suqiang -Original Message- From: devel@edk2.groups.io On Behalf Of Ren, Suqiang Sent: Tuesday, December 26

Re: [edk2-devel] [PATCH 1/1] MdePkg: Update the comments of callback in EFI_FORM_BROWSER2_PROTOCOL

2024-01-01 Thread Ren, Suqiang
Hi Liming, This patch has also reviewed by Felix Polyudov: https://edk2.groups.io/g/devel/message/113002 Could you help to merge this patch? Thanks Ren, Suqiang -Original Message- From: gaoliming Sent: Saturday, December 23, 2023 10:02 AM To: devel@edk2.groups.io

Re: [edk2-devel] [PATCH 1/1] MdePkg: Update the definition of CapsuleImageSize on EFI_CAPSULE_HEADER

2024-01-01 Thread Ren, Suqiang
Hi Liming, This patch has also reviewed by Felix Polyudov: https://edk2.groups.io/g/devel/message/113003 Could you help to merge this patch? Thanks Ren, Suqiang -Original Message- From: gaoliming Sent: Saturday, December 23, 2023 10:01 AM To: devel@edk2.groups.io

[edk2-devel] [PATCH 1/1] MdePkg: Add EFI_UNSUPPORTED return for some Runtime Service functions

2023-12-27 Thread Ren, Suqiang
According to UEFI Spec 2.10 page 206, if any EFI_RUNTIME_SERVICES* calls are not supported for use by the OS at runtime, an EFI_RT_PROPERTIES_TABLE configuration table should be published describing which runtime services are supported at runtime. So need to add EFI_UNSUPPORTED return for some

[edk2-devel] [PATCH V3 1/2] MdePkg: RFC1323 definition changed to RFC7323

2023-12-26 Thread Ren, Suqiang
Change the description of RFC1323 to RFC7323 to align with UEFI spec 2.10. REF: UEFI spec 2.10 Table 28.2.5 Signed-off-by: Suqiang Ren Cc: Michael D Kinney Cc: Liming Gao Cc: Zhiguang Liu Reviewed-by: Liming Gao --- MdePkg/Include/Protocol/Tcp6.h | 4 ++-- 1 file changed, 2 insertions(+),

[edk2-devel] [PATCH V3 2/2] NetworkPkg: RFC1323 definition changed to RFC7323

2023-12-26 Thread Ren, Suqiang
According to UEFI spec 2.10, the definition of RFC1323 has changed to RFC7323 on EFI_TCP6_OPTION. So align this change on NetworkPkg. REF: UEFI spec 2.10 Table 28.2.5 Signed-off-by: Suqiang Ren Cc: Saloni Kasbekar Cc: Zachary Clark-williams --- NetworkPkg/TcpDxe/TcpInput.c | 2 +-

[edk2-devel] [PATCH V3 0/2] Change the comments RFC1323 to RFC7323

2023-12-26 Thread Ren, Suqiang
REF: UEFI spec 2.10 Table 28.2.5 Change the description of RFC1323 to align with UEFI spec 2.10. v3: Add the NetworkPkg change for RFC1323. v2: Update the commit message. Signed-off-by: Suqiang Ren Cc: Michael D Kinney Cc: Liming Gao Cc: Zhiguang Liu Cc: Saloni Kasbekar Cc: Zachary

Re: [edk2-devel] [PATCH 1/1] MdePkg: Updated the definition of FileName on EFI_FILE_INFO

2023-12-25 Thread Ren, Suqiang
Thanks for review, patch updated. Thanks Ren, Suqiang -Original Message- From: devel@edk2.groups.io On Behalf Of Pedro Falcato Sent: Sunday, December 24, 2023 3:18 AM To: devel@edk2.groups.io; Ren, SuqiangX Cc: Kinney, Michael D ; Gao, Liming ; Liu, Zhiguang ; Li, Yi1 Subject: Re

[edk2-devel] [PATCH V2 1/1] MdePkg: Update the definition of FileName on EFI_FILE_INFO

2023-12-25 Thread Ren, Suqiang
Add the description of FileName to align with UEFI spec 2.10. REF: UEFI spec 2.10 Table 13.5.16 Signed-off-by: Suqiang Ren Cc: Michael D Kinney Cc: Liming Gao Cc: Zhiguang Liu --- MdePkg/Include/Guid/FileInfo.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[edk2-devel] [PATCH V2 1/1] MdePkg: Update the definition of EFI_TCP6_OPTION

2023-12-22 Thread Ren, Suqiang
Change the description of EnableTimeStamp and EnableWindowScaling to align with UEFI spec 2.10. REF: UEFI spec 2.10 Table 28.2.5 Signed-off-by: RenSuqiang Cc: Michael D Kinney Cc: Liming Gao Cc: Zhiguang Liu Cc: Yi Li --- MdePkg/Include/Protocol/Tcp6.h | 4 ++-- 1 file changed, 2

[edk2-devel] [PATCH 1/1] MdePkg: Update the definition of EFI_TCP6_OPTION

2023-12-22 Thread Ren, Suqiang
Change the description of EnableNagle and EnableTimeStamp to align with UEFI spec 2.10. REF: UEFI spec 2.10 Table 28.2.5 Signed-off-by: RenSuqiang Cc: Michael D Kinney Cc: Liming Gao Cc: Zhiguang Liu Cc: Yi Li --- MdePkg/Include/Protocol/Tcp6.h | 4 ++-- 1 file changed, 2 insertions(+), 2

[edk2-devel] [PATCH 1/1] MdePkg: Update the definition of CapsuleImageSize on EFI_CAPSULE_HEADER

2023-12-22 Thread Ren, Suqiang
Add the description of CapsuleImageSize to align with UEFI spec 2.10. REF: UEFI spec 2.10 Table 8.5.3.1 Signed-off-by: RenSuqiang Cc: Michael D Kinney Cc: Liming Gao Cc: Zhiguang Liu Cc: Yi Li --- MdePkg/Include/Uefi/UefiSpec.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff