Re: [edk2-devel] [edk2-platforms][PATCH v4 0/8] Platform/Sgi: Add support for RD-Fremont platform

2024-03-04 Thread Thomas Abraham
1/RdV1.dsc => RdFremont/RdFremont.dsc} > (77%) > create mode 100644 > Platform/ARM/SgiPkg/AcpiTables/RdFremontAcpiTables.inf > create mode 100644 Platform/ARM/SgiPkg/AcpiTables/RdFremont/Dsdt.asl > create mode 100644 Platform/ARM/SgiPkg/AcpiTables/RdFremont/Madt.aslc > create

Re: [edk2-devel] [edk2-platforms][PATCH v5 0/6] Platform/Sgi: Add support for RD-N2-Cfg3 and RD-V2 platform

2024-03-04 Thread Thomas Abraham
> | 14 > - > Platform/ARM/SgiPkg/RdN2Cfg3/RdN2Cfg3.fdf.inc > | 10 > > 12 files changed, 136 insertions(+), 23 deletions(-) > create mode 100644 Platform/ARM/SgiPkg/RdN2Cfg3/RdN2Cfg3.dsc > copy Platform/ARM/SgiPkg/AcpiTables/{RdN2

Re: [edk2-devel] [edk2-platforms][PATCH V2 2/2] Platform/Sgi: Extend SMBIOS support for RD-V2 platform

2023-12-14 Thread Thomas Abraham
; > +/* L1 data cache */ > +mArmRdSmbiosType7[1].Base.MaximumCacheSize2 = 64;// 64KB > +mArmRdSmbiosType7[1].Base.InstalledSize2 = 64; // 64KB > +mArmRdSmbiosType7[1].Base.Associativity = CacheAssociativity4Way; > +/* L2 cache */ &

Re: [edk2-devel] [edk2-platforms][PATCH V2 1/2] Platform/Sgi: Define RD-V2 platform id values

2023-12-14 Thread Thomas Abraham
dLookup[] = { > RD_N2_CONF_ID, > 1 >}, > + { > +RdV2, > +RD_V2_PART_NUM, > +RD_V2_CONF_ID, > +0 > + }, > }; > > EFI_BOOT_MODE > -- > 2.34.1 Reviewed-by: Thomas Abraham -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive

Re: [edk2-devel] [edk2-platforms][PATCH V1 5/5] Platform/ARM/N1Sdp: Enable FaultTolerantWrite Dxe driver for N1Sdp

2023-12-07 Thread Thomas Abraham
niversal/ResetSystemRuntimeDxe/ResetSystemRuntimeDxe.in > f > >INF MdeModulePkg/Universal/CapsuleRuntimeDxe/CapsuleRuntimeDxe.inf > > + INF > MdeModulePkg/Universal/FaultTolerantWriteDxe/FaultTolerantWriteDxe.inf > >INF > MdeModulePkg/Universal/MonotonicCounter

Re: [edk2-devel] [edk2-platforms][PATCH V1 4/5] Platform/ARM/N1Sdp: Persistent storage for N1Sdp

2023-12-07 Thread Thomas Abraham
> # FDF file of N1Sdp > > # > > -# Copyright (c) 2018 - 2021, ARM Limited. All rights reserved. > > +# Copyright (c) 2018 - 2023, ARM Limited. All rights reserved. > > # > > # SPDX-License-Identifier: BSD-2-Clause-Patent > > ## > > @@ -140,

Re: [edk2-devel] [edk2-platforms][PATCH V1 3/5] Platform/ARM/N1Sdp: NOR flash Dxe Driver for N1Sdp

2023-12-07 Thread Thomas Abraham
is driver be moved to either the edk2-platform drivers/ or the Platform/Arm/Drivers directory? Otherwise, looks okay. Reviewed-by: Thomas Abraham [snip] -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#112194): https://edk2.groups.io/g/de

Re: [edk2-devel] [edk2-platforms][PATCH V1 2/5] Silicon/ARM/NeoverseN1Soc: NOR flash library for N1Sdp

2023-12-07 Thread Thomas Abraham
Hi Sahil, > -Original Message- > From: devel@edk2.groups.io On Behalf Of sahil via > groups.io > Sent: Thursday, November 16, 2023 11:46 AM > To: devel@edk2.groups.io > Cc: Ard Biesheuvel ; Leif Lindholm > ; Sami Mujawar ; > Sahil Kaushal > Subject: [edk2-devel] [edk2-platforms][PATCH

Re: [edk2-devel] [edk2-platforms][PATCH V1 1/5] Silicon/ARM/NeoverseN1Soc: Enable SCP QSPI flash region

2023-12-07 Thread Thomas Abraham
QSPI_AHB_BASE; > > + VirtualMemoryTable[Index].VirtualBase = > NEOVERSEN1SOC_SCP_QSPI_AHB_BASE; > > + VirtualMemoryTable[Index].Length = > NEOVERSEN1SOC_SCP_QSPI_AHB_SZ; > > + VirtualMemoryTable[Index].Attributes = > ARM_MEMORY_REGION_ATTRIBUTE_DE

Re: [edk2-devel] [edk2-platforms][PATCH V3 1/1] Platform/ARM/N1sdp: Add support to parse NT_FW_CONFIG

2023-12-07 Thread Thomas Abraham
Hi Sahil, > -Original Message- > From: devel@edk2.groups.io On Behalf Of sahil via > groups.io > Sent: Wednesday, August 23, 2023 12:03 PM > To: devel@edk2.groups.io > Cc: Ard Biesheuvel ; Leif Lindholm > ; Sami Mujawar ; Sahil > > Subject: [edk2-devel] [edk2-platforms][PATCH V3 1/1]

Re: [edk2-devel] [PATCH 1/1] ShellPkg/SmbiosView: Add Type45 entry to query table

2023-12-06 Thread Thomas Abraham
Reviewed-by: Thomas Abraham -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#112135): https://edk2.groups.io/g/devel/message/112135 Mute This Topic: https://groups.io/mt/101736631/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe

Re: [edk2-devel] [PATCH edk2-platforms v2 1/1] Platform/ARM: Fix the build failure DxeCore

2023-11-30 Thread Thomas Abraham
ecordLib.inf > > [LibraryClasses.common.SEC] > > DebugAgentLib|ArmPkg/Library/DebugAgentSymbolsBaseLib/DebugAgentSymb > olsBaseLib.inf > -- > Guid("CE165669-3EF3-493F-B85D-6190EE5B9759") Reviewed-by: Thomas Abraham -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You re

Re: [edk2-devel] [PATCH edk2-platforms 5/5] Platform/ARM/Sgi: Add VariableFlashInfoLib to SgiPlatformMm.dsc.inc

2023-01-26 Thread Thomas Abraham
|MdePkg/Library/BaseSafeIntLib/BaseSafeIntLib.inf + VariableFlashInfoLib|MdeModulePkg/Library/BaseVariableFlashInfoLib/BaseVariableFlashInfoLib.inf !endif Thanks for this fix. Reviewed-by: Thomas Abraham

Re: [edk2-devel] [PATCH edk2-platforms 2/5] Platform/StandaloneMm: Remove '-march=armv8-a+nofp' flag

2023-01-26 Thread Thomas Abraham
nts.common] # ### [BuildOptions.AARCH64] -GCC:*_*_*_DLINK_FLAGS = -z common-page-size=0x1000 -march=armv8-a+nofp +GCC:*_*_*_DLINK_FLAGS = -z common-page-size=0x1000 GCC:*_*_*_CC_FLAGS = -mstrict-align [BuildOptions.ARM] Reviewed-by: Thom

Re: [edk2-devel] [PATCH edk2-platforms 1/5] Platform/ARM/SgiPkg: Remove '-march=armv8-a+nofp' flag

2023-01-26 Thread Thomas Abraham
[Components.AARCH64] # ### [BuildOptions.AARCH64] - GCC:*_*_*_CC_FLAGS = -mstrict-align -march=armv8-a+nofp -D DISABLE_NEW_DEPRECATED_INTERFACES + GCC:*_*_*_CC_FLAGS = -mstrict-align -D DISABLE_NEW_DEPRECATED_INTERFACES GCC:*_*_*_DLINK_FLAGS = -z common-page-size=0x1000 Thanks for this fix. Reviewe

Re: [edk2-devel] [edk2-platforms][PATCH V1 1/1] Platform/ARM/N1sdp: Add support to parse NT_FW_CONFIG

2023-01-25 Thread Thomas Abraham
Hi Sahil, On 06/01/2023 06:11, sahil via groups.io wrote: NT_FW_CONFIG DTB contains platform information passed by Tf-A boot stage. This information is used for Virtual memory map generation during PEI phase and passed on to DXE phase as a HOB, where it is used in ConfigurationManagerDxe.

Re: [edk2-devel] [edk2-platforms][PATCH V1 1/1] Platform/ARM/N1Sdp: Modify IRQ ID of Debug UART and routing to IOFPGA UART1

2023-01-25 Thread Thomas Abraham
Hi Sahil, On 06/01/2023 06:09, sahil via groups.io wrote: From: Himanshu Sharma In DBG2 table, IRQ ID was set as 0 for the UART. This overwrote the IPI0 trigger method to "level", which prevented SGI0 to be enabled again after a CPU offline/online cycle. This patch fixes the above issue by

Re: [edk2-devel] [edk2-platforms][PATCH V1 1/1] Platform/ARM/N1Sdp: Fix RemoteDdrSize cast

2023-01-25 Thread Thomas Abraham
Hi Sahil, On 06/01/2023 06:07, sahil via groups.io wrote: RemoteDdrSize calculation wraps around when booting N1Sdp in multichip mode. Casting it to UINT64 to fix the issue. The change looks okay but can the commit message be expanded to explain how this issue surfaced. RemoteDdrSize was

Re: [edk2-devel] [PATCH edk2-platforms 1/1] Platform/ARM: Update Morello and SgiPkg for ARM_CORE_INFO Mpidr change

2022-09-11 Thread Thomas Abraham
mCoreInfoTable[] = { { // Cluster 0, Core 0 -0x0, 0x0, +0x000, }, }; Reviewed-by: Thomas Abraham -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#93634): https://edk2.groups.io/g/devel/message/93634 Mute This Topic

Re: [edk2-devel] [edk2-platforms][PATCH] Platform/Sgi: Remove inaccurate comment in dsc file

2022-09-06 Thread Thomas Abraham
Reviewed-by: Thomas Abraham -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#93218): https://edk2.groups.io/g/devel/message/93218 Mute This Topic: https://groups.io/mt/93479835/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https

Re: [edk2-devel] [PATCH edk2-platforms v3 03/12] Platform/ARM: SGI: Update for IORT revision macro renaming

2022-07-14 Thread Thomas Abraham
(EFI_ACPI_6_0_IO_REMAPPING_TABLE), // NodeOffset Reviewed-by: Thomas Abraham Thanks. -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#91349): https://edk2.groups.io/g/devel/message/91349 Mute This Topic: https://groups.io/mt/92334294/21656 Group Owner

Re: [edk2-devel] [PATCH edk2-platforms v2 03/11] Platform/ARM: SGI: Update for IORT revision macro renaming

2022-07-06 Thread Thomas Abraham
Hi Sami, On 06/07/2022 16:15, Sami Mujawar wrote: Hi Thomas, Please find my response inline marked [SAMI]. Regards, Sami Mujawar On 06/07/2022 03:18 pm, Thomas Abraham wrote: On 06/07/2022 11:39, Sami Mujawar wrote: The IORT Specification E.d updates the IORT table revision to 5

Re: [edk2-devel] [edk2][PATCH V3 1/1] ArmPlatformPkg/PrePeiCore: Explicitly invoke constructor for SEC phase

2022-07-06 Thread Thomas Abraham
Reviewed-by: Thomas Abraham Tested-by: Thomas Abraham Thanks. -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#91115): https://edk2.groups.io/g/devel/message/91115 Mute This Topic: https://groups.io/mt/92206586/21656 Group Owner: devel+ow

Re: [edk2-devel] [PATCH edk2-platforms v2 03/11] Platform/ARM: SGI: Update for IORT revision macro renaming

2022-07-06 Thread Thomas Abraham
with all the other table revision macros? ), 3, // NumNodes sizeof (EFI_ACPI_6_0_IO_REMAPPING_TABLE), // NodeOffset Reviewed-by: Thomas Abraham Thanks. -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#91114

Re: [edk2-devel] [edk2-platforms][PATCH 0/2] Platform/Sgi: Update serial port usage

2022-07-04 Thread Thomas Abraham
| 17 - 10 files changed, 41 insertions(+), 2 deletions(-) For this series - Reviewed-by: Thomas Abraham Tested-by: Thomas Abraham Thanks. -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#91048): https://edk2.g

Re: [edk2-devel] [PATCH] ArmPlatformPkg: Add PCD for serial debug port interrupt

2022-06-22 Thread Thomas Abraham
On 22/06/2022 15:52, Ard Biesheuvel wrote: On Wed, 22 Jun 2022 at 12:12, Thomas Abraham wrote: Add a PCD to specify the interrupt number of the serial debug port controller. Why do we need this? The commit message will be updated in next version of this patch the describes the need

[edk2-devel] [PATCH v2] ArmPlatformPkg: Add PCD for serial debug port interrupt

2022-06-22 Thread Thomas Abraham
the interrupt number assigned to the serial debug port controller. Signed-off-by: Thomas Abraham --- ArmPlatformPkg/ArmPlatformPkg.dec | 1 + 1 file changed, 1 insertion(+) Changes since v1 - Updated commit message and removed the Change-Id line as suggested by Ard. diff --git a/ArmPlatformPkg

Re: [edk2-devel] [edk2-platforms][PATCH V3 0/2] Uart segregation patch series

2022-06-22 Thread Thomas Abraham
insertions(+), 80 deletions(-) For this series - Reviewed-by: Thomas Abraham -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#90680): https://edk2.groups.io/g/devel/message/90680 Mute This Topic: https://groups.io/mt/91920025/21656 Group Owner

[edk2-devel] [PATCH] ArmPlatformPkg: Add PCD for serial debug port interrupt

2022-06-22 Thread Thomas Abraham
Add a PCD to specify the interrupt number of the serial debug port controller. Signed-off-by: Thomas Abraham Change-Id: I4ce6d29cdf5e8b5fcbfe740269d966a53f2b852a --- ArmPlatformPkg/ArmPlatformPkg.dec | 1 + 1 file changed, 1 insertion(+) diff --git a/ArmPlatformPkg/ArmPlatformPkg.dec b

Re: [edk2-devel] [edk2-platforms][PATCH V2 2/2] Platform/Sgi: Route logs to different sets of consoles

2022-06-20 Thread Thomas Abraham
Hi Rohit, On 20/06/2022 16:25, Rohit Mathew via groups.io wrote: Route secure (from secure partition) and non-secure console messages to different sets of UART console ports. This aligns with the security state the PE is in when logs are put out. In addition, this allows consolidation of UART

Re: [edk2-devel] [edk2-platforms] [PATCH 1/1] Platform/Sgi: Add support to disable isolated cpus

2022-06-17 Thread Thomas Abraham
Abraham Tested-by: Thomas Abraham -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#90576): https://edk2.groups.io/g/devel/message/90576 Mute This Topic: https://groups.io/mt/91816363/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe

Re: [edk2-devel] [edk2-platforms][PATCH V1 0/7] Fix ACPI Low Power Idle states for RD platforms

2022-06-11 Thread Thomas Abraham
s/RdV1Mc/Dsdt.asl | 8 +- > Platform/ARM/SgiPkg/AcpiTables/Sgi575/Dsdt.asl | 8 +- > 7 files changed, 28 insertions(+), 144 deletions(-) > > For this series - Reviewed-by: Thomas Abraham -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online

Re: [edk2-devel] [edk2-platforms][PATCH V3 0/9] Upadate the ACPI tables for RD platforms

2022-06-11 Thread Thomas Abraham
For this series - Reviewed-by: Thomas Abraham -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#90458): https://edk2.groups.io/g/devel/message/90458 Mute This Topic: https://groups.io/mt/91650531/21656 Group Owner: devel+ow...@edk2

Re: [edk2-devel] [edk2-platforms][PATCH V2 0/9] Upadate the ACPI tables for RD platforms

2022-04-18 Thread Thomas Abraham
: Update ACPI version to v6.4 for Rd-V1-MC platform Platform/Sgi: Update ACPI version to v6.4 for Rd-N2 platform Platform/Sgi: Update ACPI version to v6.4 for Rd-N2-Cfg1 platform For this series - Reviewed-by: Thomas Abraham IMPORTANT NOTICE: The contents of this email and any attachments

Re: [edk2-devel] [edk2-platforms][PATCH V1 1/1] Platform/Sgi: Remove SLC entry from PPTT table

2022-04-18 Thread Thomas Abraham
RdV1Mc/Pptt.aslc | 23 ---= > > 8 files changed, 26 insertions(+), 131 deletions(-) Reviewed-by: Thomas Abraham -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#89017): https://edk2.groups.io/g/devel/message/89017 Mu

Re: [edk2-devel] [edk2-platforms][PATCH v2 5/5] Platform/Sgi: Cleanup build options for StandaloneMM context

2021-06-14 Thread Thomas Abraham
Omkar Anand Kulkarni > Signed-off-by: Pranav Madhu > --- > Platform/ARM/SgiPkg/SgiPlatformMm.dsc.inc | 6 ++ > 1 file changed, 2 insertions(+), 4 deletions(-) Reviewed-by: Thomas Abraham [...] -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this

Re: [edk2-devel] [edk2-platforms][PATCH v2 4/5] Platform/Sgi: update _OSC control method to control LPI and CPPC

2021-06-14 Thread Thomas Abraham
+ > Platform/ARM/SgiPkg/AcpiTables/RdV1/Dsdt.asl| 15 +++ > Platform/ARM/SgiPkg/AcpiTables/RdV1Mc/Dsdt.asl | 15 > +++ > Platform/ARM/SgiPkg/AcpiTables/Sgi575/Dsdt.asl | 8 > 17 files changed, 115 insertions(+) Reviewed-b

Re: [edk2-devel] [edk2-platforms][PATCH v2 2/5] Platform/Sgi: Add GED support

2021-06-14 Thread Thomas Abraham
| 3 ++ > Platform/ARM/SgiPkg/AcpiTables/RdV1McAcpiTables.inf | 3 ++ > Platform/ARM/SgiPkg/AcpiTables/Sgi575AcpiTables.inf | 3 ++ > Platform/ARM/SgiPkg/AcpiTables/SsdtEvents.asl | 49 > > 12 files changed, 88 insertions(+) Reviewed-by: Thomas Ab

Re: [edk2-devel] [edk2-platforms][PATCH v2 1/5] Platform/Sgi: Enable PrimeCell GPIO

2021-06-14 Thread Thomas Abraham
Platform/ARM/SgiPkg/AcpiTables/SsdtEvents.asl | 67 > ++++++++ > 12 files changed, 115 insertions(+) Reviewed-by: Thomas Abraham [...] -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#76466): https://edk2.groups.io/g/devel/

Re: [edk2-devel] [edk2-platforms][PATCH V1 0/3] Platform/Sgi: enable support for UEFI secure boot

2021-06-01 Thread Thomas Abraham
latform_secure_boot > > Sayanta Pattanayak (3): > Platform/Sgi: refactor StandaloneMM platform description file > Platform/Sgi: add StandaloneMM usable NorFlashPlatformLib > Platform/Sgi: enable support for UEFI secure boot For this patch series: Reviewed-by: Thomas Abraham

Re: [edk2-devel] [edk2-platforms PATCH 1/1] Readme.md: Refer users to the Arm GNU-A Downloads page for toolchains

2021-05-30 Thread Thomas Abraham
On 5/29/21 12:00 AM, Rebecca Cran wrote: > Arm now provides the latest gcc toolchains for aarch64 and arm: the > Linaro page that was linked to no longer exists. > > Signed-off-by: Rebecca Cran > --- > Readme.md | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-)

Re: [edk2-devel] [edk2-platforms][PATCH V1 0/6] Platform/Sgi: Add initial support for RD-N2-Cfg1 platform

2021-05-19 Thread Thomas Abraham
rm > > Pranav Madhu (5): > Platform/Sgi: ACPI PPTT table for RD-N2-Cfg1 platform > Platform/Sgi: Low Power Idle states for RD-N2-Cfg1 > Platform/Sgi: ACPI CPPC support for RD-N2-Cfg1 > Platform/Sgi: Define RD-N2-Cfg1 platform id values > Platform/

Re: [edk2-devel] [edk2-platforms][PATCH V3 00/11] Add SMBIOS tables for Arm's Reference Design platforms

2021-05-19 Thread Thomas Abraham
e16 Table > Platform/Sgi: Add SMBIOS Type17 Table > Platform/Sgi: Add SMBIOS Type19 Table > Platform/Sgi: Add SMBIOS Type32 Table For this series: Reviewed-by: Thomas Abraham [...] IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privil

Re: [edk2-devel] [edk2-platforms][PATCH v2 1/6] Platform/ARM/SgiPkg: sync with edk2 StandaloneMmCpu path change

2021-05-17 Thread Thomas Abraham
Ard Biesheuvel > Cc: Ilias Apalodimas > Cc: Leif Lindholm > Cc: Sami Mujawar > Cc: Sughosh Ganu > Cc: Thomas Abraham > Signed-off-by: Etienne Carriere > --- > Changes since v1: > - split change in 3: this change relates to Platform/ARM/SgiPkg only. > ---

Re: [edk2-devel] [edk2-platforms][PATCH V1 00/17] Enable idle state and CPPC support for RD platform

2021-05-03 Thread Thomas Abraham
/Pranav-Madhu/edk2- > platforms/tree/topics/rd_power_management For this series: Reviewed-by: Thomas Abraham > > Pranav Madhu (17): > Platform/Sgi: Macro definitions for ACPI _OSC > Platform/Sgi: Add CPU container for SGI-575 > Platform/Sgi: Low Power Idle states for SGI-575 &g

Re: [edk2-devel] [edk2-platforms][PATCH V2 0/8] Platform/Sgi: Add PPTT table for Neoverse Reference Design platforms

2021-05-03 Thread Thomas Abraham
tforms which is mandatory as per Arm SystemReady SR > specification. > > Link to github branch with the patches in this series - > https://github.com/Pranav-Madhu/edk2-platforms/tree/topics/rd_pptt For this series: Reviewed-by: Thomas Abraham > > Pranav Madhu (8): > Platform

Re: [edk2-devel] [edk2-staging][PATCH V1 0/5] Resolve dependency from MmUnblockMemoryLib

2021-03-14 Thread Thomas Abraham
Hi Kun, > -Original Message- > From: devel@edk2.groups.io On Behalf Of Thomas > Abraham via groups.io > Sent: Thursday, March 11, 2021 11:39 AM > To: devel@edk2.groups.io; kuqi...@gmail.com > Cc: Chasel Chiu ; Nate DeSimone > ; Liming Gao ; > Eric Dong ; Michael D

Re: [edk2-devel] [edk2-staging][PATCH V1 0/5] Resolve dependency from MmUnblockMemoryLib

2021-03-10 Thread Thomas Abraham
On 3/11/21 1:37 AM, Kun Qin via groups.io wrote: > The merging of commit range c5740f360636..59a3ccb09e7a on edk2 master has > separated Tcg2Smm driver into 2 functional componnents, Tcg2Acpi and Tcg2 > MM driver. They also introduced dependency of MmUnblockMemoryLib on > VariableSmmRuntimeDxe as

[edk2-devel] [edk2-platforms][PATCH] Platform/Sgi: add platform documentation

2021-03-07 Thread Thomas Abraham
Add a document that provides information about the platforms supported by the package 'SgiPkg', the build environment, links to additional documentation and corresponding platform fvp. Signed-off-by: Thomas Abraham Change-Id: If59c06b0ab2e4445f1c59499e43c544ba4ea40a2 --- Platform/ARM/SgiPkg

Re: [edk2-devel] [edk2-platforms][PATCH V1 1/5] Platform/ARM/Morello: Add Platform library implementation

2021-02-26 Thread Thomas Abraham
On 2/24/21 6:42 PM, Chandni Cherukuri via groups.io wrote: > From: Anurag Koul > > This patch adds initial Morello Platform Library support. > It includes virtual memory map and helper functions for > platform initialization. > > Co-authored-by: Chandni Cherukuri > Signed-off-by: Chandni

Re: [edk2-devel] [PATCH edk2-platforms v1 1/1] Platform/ARM/VExpressPkg: Remove non-ASCII characters

2021-02-17 Thread Thomas Abraham
Reviewed-by: Thomas Abraham -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#71748): https://edk2.groups.io/g/devel/message/71748 Mute This Topic: https://groups.io/mt/80706889/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe

Re: [edk2-devel] [PATCH edk2-platforms v1 1/1] Maintainers.txt: Update Arm platform maintainer

2021-02-08 Thread Thomas Abraham
t; Cc: Ard Biesheuvel > Cc: Thomas Abraham > Cc: Leif Lindholm > Signed-off-by: Sami Mujawar > --- > Maintainers.txt | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Maintainers.txt b/Maintainers.txt > index > 34f0b585815f36e44c0e7f3366a39ebe9cf

Re: [edk2-devel] [edk2-platforms][PATCH V1 00/11] Add SMBIOS tables for SGI/RD platforms

2021-01-26 Thread Thomas Abraham
rm/ARM/SgiPkg: Add SMBIOS Type4 Table > Platform/ARM/SgiPkg: Add SMBIOS Type7 Table > Platform/ARM/SgiPkg: Add SMBIOS Type16 Table > Platform/ARM/SgiPkg: Add SMBIOS Type17 Table > Platform/ARM/SgiPkg: Add SMBIOS Type19 Table > Platform/ARM/SgiPkg: Add SMBIOS Type32 Table For th

Re: [edk2-devel] [edk2-platforms][PATCH V1 1/1] Platform/ARM/SgiPkg: Update ACPI Table revision

2021-01-19 Thread Thomas Abraham
ables/Sgi575/Dsdt.asl | 4 ++-- > Platform/ARM/SgiPkg/AcpiTables/Ssdt.asl | 4 ++-- > Platform/ARM/SgiPkg/AcpiTables/SsdtRos.asl | 4 ++-- > 9 files changed, 20 insertions(+), 17 deletions(-) Reviewed-by: Thomas Abraham [...] IMPORTANT NOTICE: The contents of this email and any a

Re: [edk2-devel] [PATCH edk2-platforms v1 1/1] Platform/ARM: TimerLib based RngLib for CryptoPkg

2020-10-02 Thread Thomas Abraham
ngLib. > > > > Note: The TimerLib based implementation of RngLib replicates past > > behavior when used with OpenSSL. However, this should not be used > > in production as a real source of entropy. > > > > Signed-off-by: Sami Mujawar > > Reviewed-by

Re: [edk2-devel] [edk2-platforms] [PATCH v2] SgiPkg/RdN1EdgeX2: Add missing reference to PcdChipCount

2020-08-24 Thread Thomas Abraham
st of > PCDs to be looked up. > > Signed-off-by: Vijayenthiran Subramaniam Reviewed-by: Thomas Abraham > --- > > Changes since v1: > - Add commit id in commit message for which this patch fixes the build > failure. > > Platform/ARM/SgiPkg/AcpiTables/RdN1EdgeX2

Re: [edk2-devel] [PATCH edk2-platforms v1 1/1] Platform/ARM/SgiPkg: Replace BSD License with BSD+Patent License

2020-08-18 Thread Thomas Abraham
ables/SsdtRos.asl | 10 ++ > 7 files changed, 14 insertions(+), 56 deletions(-) Reviewed-by: Thomas Abraham Thank you Sami for this update. - Thomas. -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#644

Re: [edk2-devel] [edk2-platforms][PATCH v5 0/5] Add initial support for N1SDP board

2020-07-22 Thread Thomas Abraham
con/ARM/N1SoC: Implement the PciHostBridgeLib library > Platform/ARM/N1SDP: Add initial N1SDP platform support > > Pranav Madhu (1): > Maintainers.txt: Add Silicon/ARM directory For this series: Reviewed-by: Thomas Abraham > > Silicon/ARM/NeoverseN1Soc/NeoverseN1Soc.d

Re: [edk2-devel] [edk2-platforms][PATCH v4 0/5] Platform: Add initial support for N1SDP board

2020-07-21 Thread Thomas Abraham
Hi Pranav, On Sun, Jul 19, 2020 at 2:19 PM Pranav Madhu wrote: > > Changes since v3: > - Addressed all the comments from Leif. As part of the clean up that > resulted from addressing the comments, some of the comments where not > applicable anymore (due to fragments of code that had comments

Re: [edk2-devel] [edk2-platforms][PATCH v4 2/5] Silicon/ARM/N1SoC: Implement Neoverse N1 Soc specific PciExpressLib

2020-07-21 Thread Thomas Abraham
Hi Pranav, On Sun, Jul 19, 2020 at 2:19 PM Pranav Madhu wrote: > > From: Deepak Pandey > > A slave error is generated when host accesses the config space of > non-available device or unimplemented function on a given bus. So > implement a Neoverse N1 SoC specific PciExpressLib library with a >

Re: [edk2-devel] [edk2-platforms][PATCH v3 0/4] Platform: Add initial support for N1SDP board

2020-07-06 Thread Thomas Abraham
t; Silicon/ARM/N1SoC: Implement Neoverse N1 Soc specific PciExpressLib > Silicon/ARM/N1SoC: Implement the PciHostBridgeLib library > Platform/ARM/N1SDP: Add initial N1SDP platform support For this series: Reviewed-by: Thomas Abraham > > Silicon/ARM/NeoverseN1Soc/NeoverseN1SocPl

Re: [edk2-devel] [edk2-platforms][PATCH v2 0/4] Platform: Add initial support for N1SDP board

2020-06-27 Thread Thomas Abraham
Platform/ARM/N1SDP: Add initial N1SDP platform support Apart from one comment on the first patch, rest looks okay. With that fixed, For this series: Reviewed-by: Thomas Abraham > > Silicon/ARM/N1Sdp/N1SdpPlatform.dec| 49 + > Platform/ARM/N1SdpPkg/N1SdpPla

Re: [edk2-devel] [edk2-platforms][PATCH v2 1/4] Silicon/ARM/N1SDP: Add platform library implementation

2020-06-27 Thread Thomas Abraham
ned-off-by: Pranav Madhu Please see one comment below. Rest looks okay. Reviewed-by: Thomas Abraham > > diff --git a/Silicon/ARM/N1Sdp/N1SdpPlatform.dec > b/Silicon/ARM/N1Sdp/N1SdpPlatform.dec > new file mode 100644 > index ..2edd6b17be91 > --- /dev/null > +++ b/

Re: [edk2-devel] [edk2-platforms][PATCH v4 0/9]Platform/Arm/Sgi: Add platform support for RD-Daniel

2020-04-14 Thread Thomas Abraham
n File > Platform/ARM/Sgi: Add support for remote numa memory nodes > Platform/ARM/Sgi: Add SRAT table for RdN1Edge dual-chip platform For the series: Reviewed-by: Thomas Abraham > > .../SgiPkg/AcpiTables/RdDanielCfgM/Dsdt.asl | 118 + > .../SgiPkg/AcpiTables/RdDanielCf

Re: [edk2-devel] [edk2-platforms][PATCH v3 0/8] Add platform support for RD-Daniel

2020-03-29 Thread Thomas Abraham
ARM/SgiPkg: add ACPI tables for RD-Daniel Config-XLR > Platform/ARM/Sgi: add initial support for RD-Daniel Config-XLR > platform > > Thomas Abraham (1): > Maintainers.txt: Update Arm platform reviewers list > > Vijayenthiran Subramaniam (1): > Platform/ARM/SgiPkg:

Re: [edk2-devel] [edk2-platforms][PATCH 8/8] Platform/ARM/Sgi: Add initial support for RD-Daniel Config-XLR platform

2020-03-16 Thread Thomas Abraham
On Thu, Mar 12, 2020 at 8:06 PM Aditya Angadi wrote: > > For RD-Daniel Config-XLR, use multichip mode information from the SGI > platform descriptor HOB to pick the correct ACPI table to be installed. > > Signed-off-by: Aditya Angadi Reviewed-by: Thomas Abraham > --- >

Re: [edk2-devel] [edk2-platforms][PATCH 7/8] Platform/ARM/SgiPkg: add ACPI tables for RD-Daniel Config-XLR

2020-03-16 Thread Thomas Abraham
On Thu, Mar 12, 2020 at 8:06 PM Aditya Angadi wrote: > > RD-Daniel Config-XLR is a platform in which four identical chips are connected > via a high speed CCIX link. Add Madt and Dsdt tables for the same. > > Signed-off-by: Aditya Angadi Reviewed-by: Thomas Abraham >

Re: [edk2-devel] [edk2-platforms][PATCH 6/8] Platform/ARM/Sgi: Add initial support for RD-Daniel Config-M platform

2020-03-16 Thread Thomas Abraham
On Thu, Mar 12, 2020 at 8:06 PM Aditya Angadi wrote: > > Add information in the SGI platform descriptor HOB to pick the correct > ACPI table to install for RD-Daniel Config-M > > Signed-off-by: Aditya Angadi Reviewed-by: Thomas Abraham > --- > .../SgiPkg/Drivers/Plat

Re: [edk2-devel] [edk2-platforms][PATCH 4/8] Platform/ARM/SgiPkg: remove PcdCoreCount and PcdClusterCount

2020-03-16 Thread Thomas Abraham
On Thu, Mar 12, 2020 at 8:06 PM Aditya Angadi wrote: > > The number of CPUs depend on the SGI/RD platform. So instead of > defining a Fixed PCD to specify the value of core and cluster count, > let each platform define these values. > > Signed-off-by: Aditya Angadi Reviewed-

Re: [edk2-devel] [edk2-platforms][PATCH 3/8] Platform/ARM/SgiPkg: move common platform description to SSDT

2020-03-16 Thread Thomas Abraham
On Thu, Mar 12, 2020 at 8:05 PM Aditya Angadi wrote: > > Move common platform description entries in platfrom specific DSDT to > a SSDT that can be reused on all SGI/RD platforms. > > Signed-off-by: Aditya Angadi Reviewed-by: Thomas Abraham > --- > .../ARM/SgiPkg/AcpiTab

Re: [edk2-devel] [edk2-platforms][PATCH 2/8] Platform/ARM/SgiPkg: move the GIC related ACPI helper macros

2020-03-16 Thread Thomas Abraham
On Thu, Mar 12, 2020 at 8:05 PM Aditya Angadi wrote: > > Move the ACPI helper macros defines related to GIC structure, > distributor, redistributor and ITS to SgiAcpiHeader.h as these are > common across ARM SGI/RD platforms. > > Signed-off-by: Aditya Angadi Reviewed-

Re: [edk2-devel] [edk2-platforms][PATCH 1/8] Platform/ARM/SgiPkg: Create individual Platform Description File

2020-03-16 Thread Thomas Abraham
Vijayenthiran Subramaniam Reviewed-by: Thomas Abraham > --- > Platform/ARM/SgiPkg/Include/SgiPlatform.h | 7 +--- > .../Library/PlatformLib/PlatformLib.inf | 3 +- > .../Library/PlatformLib/PlatformLibMem.c | 8 ++-- > Platform/ARM/SgiPkg/RdE1Edge.dsc

Re: [edk2-devel] [edk2-platforms] [PATCH v2] Platform/ARM/SgiPkg: Fix constant-logical-operand clang error

2020-03-16 Thread Thomas Abraham
Reviewed-by: Thomas Abraham -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#55868): https://edk2.groups.io/g/devel/message/55868 Mute This Topic: https://groups.io/mt/71391950/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe

Re: [edk2-devel] [PATCH edk2-platforms 13/16] Platform/SgiPkg: Update FDF to use NetworkPkg's include fragment file.

2019-05-17 Thread Thomas Abraham
On Fri, May 17, 2019 at 1:56 AM Leif Lindholm wrote: > > On Wed, May 15, 2019 at 04:56:58PM +0800, Zhang, Shenglei wrote: > > This patch updates the platform FDF files to use the include fragment > > files provided by NetworkPkg. > > > > Signed-off-by: Shenglei Zhang > > --- > >

Re: [edk2-devel] [PATCH 3/3] ArmPlatformPkg:Delete FrameworkDatabase from ArmPlatformPkg

2019-05-08 Thread Thomas Abraham
anks, Thomas. > > Regards, > > Sami Mujawar > > -Original Message- > From: Leif Lindholm > Sent: 07 May 2019 10:31 AM > To: Fan, ZhijuX > Cc: devel@edk2.groups.io; Thomas Abraham ; Sami > Mujawar ; Cohen, Eugene > Subject: Re: [PATCH 3/3] ArmPlatformPkg