Reviewed-by: Tinh Nguyen
@Leif, @Ard, Please help us to merge this series
Thanks,
- Tinh
On 11/05/2023 14:51, Minh Nguyen wrote:
Currently, the implementation starts link training and put device
out-of-reset right away. This make LinkStat and BlockEventStat registers
indicate that link is
Reviewed-by: Tinh Nguyen
On 11/05/2023 14:51, Minh Nguyen wrote:
Because PCIe Auto bifurcation feature doesn't depend on the default
Devmap mode so that "DevMapModeAuto" is unnecessary in retrieving
the PCIe Devmap default mode.
Signed-off-by: Minh Nguyen
---
From: Minh Nguyen
In FailSafe context, there's one field to indicate which setting is using
to boot (BOOT_LAST_KNOWN_SETTINGS, BOOT_DEFAULT_SETTINGS, BOOT_NORMAL).
At SCP and ATF side, they will check their NVPARAM for Failsafe
(NV_SI_PMPRO_FAILURE_FAILSAFE - NV_SI_ATF_FAILURE_FAILSAFE) to
Reviewed-by: Tinh Nguyen
Regards,
- Tinh
On 12/05/2023 16:58, Chang, Abner via groups.io wrote:
From: Abner Chang
Add IpmiBmcElog to ManageabilityPkg.
Signed-off-by: Abner Chang
Cc: Isaac Oram
Cc: Abdul Lateef Attar
Cc: Nickle Wang
---
Features/ManageabilityPkg/ManageabilityPkg.dec
There is a minor typo below
Reviewed-by: Tinh Nguyen
Regards,
- Tinh
On 12/05/2023 16:58, abner.ch...@amd.com wrote:
From: Abner Chang
IpmiBmcElog is cloned from
edk2-platforms/Features/Intel/OutOfBandManagement/
IpmiFeaturePkg/BmcElog in order to consolidate
edk2 system manageability
Reviewed-by: Tinh Nguyen
Regards,
- Tinh
On 12/05/2023 11:06, Chang, Abner via groups.io wrote:
From: Abner Chang
Add IpmiOsWdt to ManageabilityPkg.
Signed-off-by: Abner Chang
Cc: Isaac Oram
Cc: Abdul Lateef Attar
Cc: Nickle Wang
---
Features/ManageabilityPkg/ManageabilityPkg.dec
Reviewed-by: Tinh Nguyen
Regards,
- Tinh
On 12/05/2023 11:06, Chang, Abner via groups.io wrote:
From: Abner Chang
IpmiOsWdt is cloned from
edk2-platforms/Features/Intel/OutOfBandManagement/
IpmiFeaturePkg/OsWdt in order to consolidate
edk2 system manageability support in one place.
Reviewed-by: Tinh Nguyen
There is a minor typo that I commented on below.
On 13/05/2023 19:33, abner.ch...@amd.com wrote:
From: Abner Chang
IpmiFrb is cloned from
edk2-platforms/Features/Intel/OutOfBandManagement/
IpmiFeaturePkg/Frb in order to consolidate
edk2 system manageability support
oh, sorry, I have some personal issues and not follow up recently,
Abner, thanks for letting me know
- Tinh
On 12/05/2023 16:16, Chang, Abner wrote:
[AMD Official Use Only - General]
Hi Tinh, It is already merged.
Abner
-Original Message-
From: Tinh Nguyen
Sent: Friday, May 12,
Hi Liming,
If there are no concerns, can you assist in merging them?
Thanks
- Tinh
On 08/05/2023 08:07, gaoliming wrote:
Reviewed-by: Liming Gao
-邮件原件-
发件人: Tinh Nguyen
发送时间: 2023年5月7日 17:29
收件人: devel@edk2.groups.io
抄送: patc...@amperecomputing.com; michael.d.kin...@intel.com;
Reviewed-by: Tinh Nguyen
Thanks,
- Tinh
On 12/05/2023 10:26, abner.ch...@amd.com wrote:
From: Abner Chang
IpmiFru is cloned from
edk2-platforms/Features/Intel/OutOfBandManagement/
IpmiFeaturePkg/IpmiFru in order to consolidate
edk2 system manageability support in one place.
Uncustify is
, such as MdePkg/IndustryStandard: Add IPMI Interface Capabilities
definitions
Thanks
Liming
-邮件原件-
发件人: devel@edk2.groups.io 代表 Tinh Nguyen
via groups.io
发送时间: 2023年5月3日 19:24
收件人: devel@edk2.groups.io
抄送: patc...@amperecomputing.com; michael.d.kin...@intel.com;
gaolim...@byosoft.com.cn
This adds more definitions for the IPMI Get System Interface
Capabilities command.
Signed-off-by: Tinh Nguyen
Cc: Michael D Kinney
Cc: Liming Gao
Cc: Zhiguang Liu
Cc: Abner Chang
Reviewed-by: Abner Chang
---
MdePkg/Include/IndustryStandard/IpmiNetFnApp.h | 46
1 file
BZ#: 4434 - Add IPMI SSIF definitions.
This change adds new PCDs for IPMI SSIF.
Specification reference:
https://www.intel.com/content/www/us/en/products/docs/servers/ipmi/ipmi-second-gen-interface-spec-v2-rev1-1.html
Signed-off-by: Tinh Nguyen
Cc: Michael D Kinney
Cc: Liming Gao
Cc:
BZ#: 4434 - Add IPMI SSIF definitions.
Specification reference:
https://www.intel.com/content/www/us/en/products/docs/servers/ipmi/ipmi-second-gen-interface-spec-v2-rev1-1.html
Signed-off-by: Tinh Nguyen
Cc: Michael D Kinney
Cc: Liming Gao
Cc: Zhiguang Liu
Cc: Abner Chang
Reviewed-by: Abner
Change from v3:
- Add IPMI key word to commit subject
Change from v2:
- Add the carbon copy (Cc) in the commit message.
- Add Bugzilla ID in the commit message.
- Mention why I set the number of retries as 250.
Change from v1:
- Separate the commit for the IPMI SSIF header and IPMI
Hi Abner,
I have updated the v3.
Thanks,
Tinh
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#103907): https://edk2.groups.io/g/devel/message/103907
Mute This Topic: https://groups.io/mt/98644351/21656
Group Owner:
This adds more definitions for the IPMI Get System Interface
Capabilities command.
Signed-off-by: Tinh Nguyen
Cc: Michael D Kinney
Cc: Liming Gao
Cc: Zhiguang Liu
Cc: Abner Chang
Reviewed-by: Abner Chang
---
MdePkg/Include/IndustryStandard/IpmiNetFnApp.h | 46
1 file
BZ#: 4434 - Add IPMI SSIF definitions.
This change adds new PCDs for IPMI SSIF.
Specification reference:
https://www.intel.com/content/www/us/en/products/docs/servers/ipmi/ipmi-second-gen-interface-spec-v2-rev1-1.html
Signed-off-by: Tinh Nguyen
Cc: Michael D Kinney
Cc: Liming Gao
Cc:
BZ#: 4434 - Add IPMI SSIF definitions.
Specification reference:
https://www.intel.com/content/www/us/en/products/docs/servers/ipmi/ipmi-second-gen-interface-spec-v2-rev1-1.html
Signed-off-by: Tinh Nguyen
Cc: Michael D Kinney
Cc: Liming Gao
Cc: Zhiguang Liu
Cc: Abner Chang
Reviewed-by: Abner
Change from v2:
- Add the carbon copy (Cc) in the commit message.
- Add Bugzilla ID in the commit message.
- Mention why I set the number of retries as 250.
Change from v1:
- Separate the commit for the IPMI SSIF header and IPMI SSIF PCDs
- Correct some indent and comment style.
-
This adds more definitions for the IPMI Get System Interface
Capabilities command.
Signed-off-by: Tinh Nguyen
Reviewed-by: Abner Chang
---
MdePkg/Include/IndustryStandard/IpmiNetFnApp.h | 46
1 file changed, 46 insertions(+)
diff --git
This change adds new PCDs for IPMI SSIF.
Specification reference:
https://www.intel.com/content/www/us/en/products/docs/servers/ipmi/ipmi-second-gen-interface-spec-v2-rev1-1.html
Signed-off-by: Tinh Nguyen
---
MdePkg/MdePkg.dec | 26
1 file changed, 26 insertions(+)
diff
Specification reference:
https://www.intel.com/content/www/us/en/products/docs/servers/ipmi/ipmi-second-gen-interface-spec-v2-rev1-1.html
Signed-off-by: Tinh Nguyen
---
MdePkg/Include/IndustryStandard/IpmiSsif.h | 98
1 file changed, 98 insertions(+)
diff --git
Change from v1:
- Separate the commit for the IPMI SSIF header and IPMI SSIF PCDs
- Correct some indent and comment style.
- Change the PCDs name for a more readable.
- Support KCS/SMIC Interface Capabilities too.
Tinh Nguyen (3):
MdePkg/IndustryStandard: Add definitions for IPMI SSIF
Hi Abner,
On 29/04/2023 10:22, Chang, Abner wrote:
[AMD Official Use Only - General]
Hi Tinh,
Below is my comments,
-Original Message-
From: Tinh Nguyen
Sent: Friday, April 28, 2023 12:00 PM
To: devel@edk2.groups.io
Cc: patc...@amperecomputing.com; michael.d.kin...@intel.com;
Hi Abner,
Sorry, but I don't have a tianocore bugzilla account.
Please help me to file it on BZ.
Thanks,
- Tinh
On 29/04/2023 10:35, Chang, Abner wrote:
[AMD Official Use Only - General]
Hi Tinh,
Could you please also create a BZ ticket for tracking this? Thus this
information will be
Hi Gao,
Thanks for your feedback. I will separate it in v2.
Thanks,
Tinh
From: gaoliming
Sent: Friday, April 28, 2023 12:17 PM
To: Tinh Nguyen OS ; devel@edk2.groups.io
Cc: Open Source Submission ;
michael.d.kin...@intel.com ; zhiguang@intel.com
;
This adds more definitions for the IPMI Get System Interface
Capabilities command.
Signed-off-by: Tinh Nguyen
---
MdePkg/Include/IndustryStandard/IpmiNetFnApp.h | 31
1 file changed, 31 insertions(+)
diff --git a/MdePkg/Include/IndustryStandard/IpmiNetFnApp.h
Specification reference:
https://www.intel.com/content/www/us/en/products/docs/servers/ipmi/ipmi-second-gen-interface-spec-v2-rev1-1.html
Signed-off-by: Tinh Nguyen
---
MdePkg/MdePkg.dec | 26 ++
MdePkg/Include/IndustryStandard/IpmiSsif.h | 98
The first of a series of patches for IPMI SSIF support.
Tinh Nguyen (2):
MdePkg/IndustryStandard: Adds definitions for IPMI SSIF
MdePkg/IndustryStandard/IpmiNetFnApp.h: Add more definitions
MdePkg/MdePkg.dec | 26 ++
Reviewed-by: Tinh Nguyen
On 4/21/2023 12:22 PM, Chang, Abner via groups.io wrote:
From: Abner Chang
Update GetTransportCapability to support
Maximum Transfer Unit (MTU) of transport interface.
Signed-off-by: Abner Chang
Cc: Isaac Oram
Cc: Abdul Lateef Attar
Cc: Nickle Wang
Cc: Igor
On 4/21/2023 7:51 AM, Chang, Abner wrote:
[EXTERNAL EMAIL NOTICE: This email originated from an external sender. Please
be mindful of safe email handling and proprietary information protection
practices.]
[AMD Official Use Only - General]
-Original Message-
From: Tinh Nguyen
Hi Abner,
I have some inline comments below
On 18/04/2023 14:15, Chang, Abner via groups.io wrote:
From: Abner Chang
Update GetTransportCapability to support
Maximum Transfer Unit (MTU) of transport interface.
Signed-off-by: Abner Chang
Cc: Isaac Oram
Cc: Abdul Lateef Attar
Cc: Nickle
Reviewed-by: Tinh Nguyen
On 18/04/2023 14:15, abner.ch...@amd.com wrote:
From: Abner Chang
Add FDF include files for build in ManageabilityPkg
modules to firmware device.
Signed-off-by: Abner Chang
Cc: Isaac Oram
Cc: Abdul Lateef Attar
Cc: Nickle Wang
Cc: Igor Kulchytskyy
Cc: Tinh
Reviewed-by: Tinh Nguyen
On 18/04/2023 14:15, abner.ch...@amd.com wrote:
From: Abner Chang
Relocate Manageability.dsc to just under \Include
folder.
Signed-off-by: Abner Chang
Cc: Isaac Oram
Cc: Abdul Lateef Attar
Cc: Nickle Wang
Cc: Igor Kulchytskyy
Cc: Tinh Nguyen
---
Reviewed-by: Tinh Nguyen
On 18/04/2023 14:15, abner.ch...@amd.com wrote:
From: Abner Chang
Add PCDs to control ManageabilityPkg
modules.
Signed-off-by: Abner Chang
Cc: Isaac Oram
Cc: Abdul Lateef Attar
Cc: Nickle Wang
Cc: Igor Kulchytskyy
Cc: Tinh Nguyen
---
order. They are both called in PlatformBootManagerLib. So, I think you
should handle this issue in PlatformBootManagerLib.
Thanks
Liming
-邮件原件-
发件人:devel@edk2.groups.io 代表 Tinh Nguyen
via groups.io
发送时间: 2023年4月18日 12:25
收件人: Ni, Ray;devel@edk2.groups.io;
tinhngu...@os.amperec
RefreshAllOptions() implementation to
control the order without adding a new API.
Thanks,
ray
-Original Message-
From: devel@edk2.groups.io On Behalf Of Tinh
Nguyen via groups.io
Sent: Tuesday, April 11, 2023 1:35 AM
To: devel@edk2.groups.io; tinhngu...@os.amperecomputing.com
Cc: patc
|||Reviewed-by: Tinh Nguyen |
On 4/17/2023 7:55 PM, abner.ch...@amd.com wrote:
From: Abner Chang
Signed-off-by: Abner Chang
Cc: Isaac Oram
Cc: Abdul Lateef Attar
Cc: Nickle Wang
Cc: Tinh Nguyen
---
Features/ManageabilityPkg/ManageabilityPkg.dec | 10 +-
Reviewed-by: Tinh Nguyen
On 15/04/2023 18:57, abner.ch...@amd.com wrote:
[EXTERNAL EMAIL NOTICE: This email originated from an external sender. Please
be mindful of safe email handling and proprietary information protection
practices.]
From: Abner Chang
Add AARCH64 support in
Hi Abner,
Please assist me in changing the email address to
tinhngu...@os.amperecomputing.com.
Reviewed-by: Tinh Nguyen
On 15/04/2023 18:57, abner.ch...@amd.com wrote:
[EXTERNAL EMAIL NOTICE: This email originated from an external sender. Please
be mindful of safe email handling and
Hi Abner,
On 17/04/2023 10:01, Chang, Abner wrote:
[EXTERNAL EMAIL NOTICE: This email originated from an external sender. Please
be mindful of safe email handling and proprietary information protection
practices.]
[AMD Official Use Only - General]
-Original Message-
From: Tinh
On 4/16/2023 5:50 PM, Chang, Abner wrote:
[EXTERNAL EMAIL NOTICE: This email originated from an external sender. Please
be mindful of safe email handling and proprietary information protection
practices.]
[AMD Official Use Only - General]
Tink and Nickle,
Two feedbacks in below,
Hi Nickle,
Please find my inline comments below
On 4/12/2023 10:17 AM, Nickle Wang wrote:
[EXTERNAL EMAIL NOTICE: This email originated from an external sender. Please
be mindful of safe email handling and proprietary information protection
practices.]
This change implements the blob
Gentle ping, I’m looking for some feedback on this patch. Could someone
please help me to review it?
On 4/6/2023 3:19 PM, Tinh Nguyen via groups.io wrote:
This introduces the EDKII_PLATFORM_BOOT_MANAGER_PROTOCOL_REVISION2,
which adds a new UpdateBootOrder() function to support customizing
Hi Abner,
As someone mentioned before, you should move this library for arm/arm64
to Manageability.dsc
btw, the files that are included in dsc should have the extension dsc.inc.
Regards,
Tinh
On 4/3/2023 10:04 PM, abner.ch...@amd.com wrote:
[EXTERNAL EMAIL NOTICE: This email originated
Hi Abner,
I checked and found that some files were not formatted with uncrustify.
Please run it for the whole package.
You can append this commit to the of the series.
On 4/3/2023 10:04 PM, Chang, Abner via groups.io wrote:
From: Abner Chang
Fix Uncrustify errors of IPMI protocol
and KCS
Please find my inline comment below
On 4/3/2023 10:04 PM, Chang, Abner via groups.io wrote:
From: Abner Chang
1. Add a helper function to output payload binary
to debug output device.
2. Add a helper function to split payload into
packages according to maximum transfer unit
of
This introduces the EDKII_PLATFORM_BOOT_MANAGER_PROTOCOL_REVISION2,
which adds a new UpdateBootOrder() function to support customizing
the boot options order according to the platform-specific policy.
Signed-off-by: Tinh Nguyen
---
Changes since v1: Correct the format of the email.
Hi Rebecca,
Thanks for your information, I will update it in v2
Thanks,
Tinh
On 4/6/2023 6:05 AM, Rebecca Cran wrote:
Tinh,
You appear to be sending emails in quoted-printable format, while we
prefer them in 8bit encoding: quoted-printable causes issues such as
equals signs being
This introduces the EDKII_PLATFORM_BOOT_MANAGER_PROTOCOL_REVISION2,
which adds a new UpdateBootOrder() function to support customizing
the boot options order according to the platform-specific policy.
Signed-off-by: Tinh Nguyen
---
MdeModulePkg/Include/Protocol/PlatformBootManager.h | 24
Thank you Abner,
Let's go on
Regards,
- Tinh
On 3/29/2023 8:32 AM, Chang, Abner wrote:
[AMD Official Use Only - General]
Hi Tinh,
See my response below,
-Original Message-
From: devel@edk2.groups.io On Behalf Of Tinh
Nguyen via groups.io
Sent: Tuesday, March 28, 2023 8:37 PM
Hi Abner,
How can I include this package into flash description? May we lack the
FDF file?
We can refer to AdvanceFeaturePkg, could have PreMemory.fdf and
PostMemory.fdf
BTW, Please add PCDs to the feature configuration; this will be very
useful when other transport drivers are
Hi Abner,
The DXE and PEI modules should work on aarch64.
Please see my suggestion below.
On 3/22/2023 9:48 AM, Chang, Abner via groups.io wrote:
From: Abner Chang
Add Ipmi Protocol/Ppi/SMM modules to ManageabilityPkg.
Signed-off-by: Abner Chang
Cc: Liming Gao
Cc: Isaac Oram
Cc: Nate
The BIOS Firmware Version in the SMBIOS Type 0 can be fetched from
the fixed PcdFirmwareVersionString or platform specific OemMiscLib.
In fact, the support from OemMiscLib comes into play when the firmware
version may be modified at boot time for extended information.
Therefore, the priority of
Thank you for your hard work
Reviewed-by: Tinh Nguyen
On 3/25/2023 8:46 PM, Chang, Abner wrote:
[EXTERNAL EMAIL NOTICE: This email originated from an external sender. Please
be mindful of safe email handling and proprietary information protection
practices.]
[AMD Official Use Only -
On 24/03/2023 10:15, Chang, Abner via groups.io wrote:
From: Abner Chang
BZ #4354
This change adds definitions for IPMI KCS.
Spec ref:
https://www.intel.com/content/www/us/en/products/docs/servers/ipmi/ipmi-second-gen-interface-spec-v2-rev1-1.html
Signed-off-by: Abner Chang
Cc: Michael D
Hi Abner,
On 3/22/2023 9:48 AM, Chang, Abner via groups.io wrote:
From: Abner Chang
Add Ipmi Protocol/Ppi/SMM implementations.
The underlying implementation of transport
interface depends on the binded
ManageabilityTransportLib.
Signed-off-by: Abner Chang
Cc: Liming Gao
Cc: Isaac Oram
Hi Abner,
On 3/22/2023 9:48 AM, Chang, Abner via groups.io wrote:
From: Abner Chang
The helper functions library facilitates reducing
duplicated code in the manageability transport
library instances.
Signed-off-by: Abner Chang
Cc: Liming Gao
Cc: Isaac Oram
Cc: Nate DeSimone
Cc: Nickle
Hi Abner,
On 3/23/2023 8:57 PM, Chang, Abner via groups.io wrote:
From: Abner Chang
BZ #4354
This change adds definitions for IPMI KCS.
Spec ref:
https://www.intel.com/content/www/us/en/products/docs/servers/ipmi/ipmi-second-gen-interface-spec-v2-rev1-1.html
Signed-off-by: Abner Chang
Cc:
Thanks Oliver
will be improved in the next version
- Tinh
On 3/21/2023 11:57 PM, Oliver Smith-Denny wrote:
One nit below, otherwise:
Reviewed-by: Oliver Smith-Denny
Thanks!
On 3/20/2023 8:16 PM, Tinh Nguyen via groups.io wrote:
The BIOS Firmware Version in the SMBIOS Type 0 can
Hi Leif,
Do you have any concerns? Could I add you to the review list?
Thanks,
Tinh
On 3/21/2023 10:16 AM, Tinh Nguyen wrote:
The BIOS Firmware Version in the SMBIOS Type 0 can be fetched from
the fixed PcdFirmwareVersionString or platform specific OemMiscLib.
In fact, the support from
The BIOS Firmware Version in the SMBIOS Type 0 can be fetched from
the fixed PcdFirmwareVersionString or platform specific OemMiscLib.
In fact, the support from OemMiscLib comes into play when the firmware
version may be modified at boot time for extended information.
Therefore, the priority of
The BIOS Firmware Version in the SMBIOS Type 0 can be fetched from
the fixed PcdFirmwareVersionString or platform specific OemMiscLib.
In fact, the support from OemMiscLib comes into play when the firmware
version may be modified at boot time for extended information.
Therefore, the priority of
Thank you for your feedback; I will submit v2 as soon as possible.
Regards,
Tinh
On 3/15/2023 12:59 AM, Rebecca Cran wrote:
On 3/14/23 6:48 AM, Leif Lindholm wrote:
No objection to that.
But can we do it like this?:
Change GetBiosVersion to SetBiosVersion and in MiscBiosVendor, only call
I sorry for not seeing your and Leif's emails, so I added you again.
- Tinh
On 3/16/2023 8:00 PM, Rebecca Cran wrote:
Given Leif's comments, I was expecting a new version with some changes.
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply
I sorry for not seeing your and Leif's emails, so I added you again.
- Tinh
On 3/16/2023 8:00 PM, Rebecca Cran wrote:
Given Leif's comments, I was expecting a new version with some changes.
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply
+ Rebecca
Could you kindly help me in reviewing this patch?
Thanks,
- Tinh
On 13/03/2023 13:43, Tinh Nguyen wrote:
The BIOS Firmware Version in the SMBIOS Type 0 can be fetched from
the fixed PcdFirmwareVersionString or platform specific OemMiscLib.
In fact, the support from OemMiscLib comes
Hi Leif,
My comments is in below
On 3/13/2023 10:03 PM, Leif Lindholm wrote:
On Mon, Mar 13, 2023 at 13:43:21 +0700, Tinh Nguyen wrote:
The BIOS Firmware Version in the SMBIOS Type 0 can be fetched from
the fixed PcdFirmwareVersionString or platform specific OemMiscLib.
In fact, the support
The BIOS Firmware Version in the SMBIOS Type 0 can be fetched from
the fixed PcdFirmwareVersionString or platform specific OemMiscLib.
In fact, the support from OemMiscLib comes into play when the firmware
version may be modified at boot time for extended information.
Therefore, the priority of
Hi Abner,
I'm not sure if I understand this module completely.
This module is another IPMI solution? we will utilize either
ManageabilityPkg (using IPMI protocol specified in the EDK2 repo) or
IpmiFeaturePkg (using IpmiTransportProtocol). How do I use
IpmiCommandLib
Tested on Mt Jade Platform (with enableratelimiting true)
Tested-by: Tinh Nguyen
Thanks,
Tinh
On 09/03/2023 09:40, RichardHo [何明忠] via groups.io wrote:
This driver provides UEFI driver for USB CDC ECM device
Signed-off-by: Richard Ho
Cc: Andrew Fish
Cc: Leif Lindholm
Cc: Michael D Kinney
Hi,
I'm not sure if I understand this module completely.
This module is another IPMI solution?! we will utilize either
ManageabilityPkg or IpmiFeaturePkg. And the IPMI protocol specified in
the EDK2 repo is used by ManageabilityPkg.
Can we make the IpmiCommandLib more generic so that we
Hi Abner,
Any plan to support SMBUS system interface (ssif)?
- Tinh
On 03/03/2023 09:31, Chang, Abner via groups.io wrote:
From: Abner Chang
BZ #4354
This change adds definitions for IPMI KCS.
Signed-off-by: Abner Chang
Cc: Michael D Kinney
Cc: Liming Gao
Cc: Zhiguang Liu
Cc: Nickle
Hi Richard,
Please check my inline comment
Could you apply this to the NCM driver? It looks like they share the
same logic.
Thanks,
Tinh
On 18/02/2023 16:47, RichardHo [何明忠] via groups.io wrote:
+
+/**
+ Check if the USB CDC Data(UsbIo) installed and return USB CDC Data Handle.
+
+
On 18/02/2023 16:47, RichardHo [何明忠] via groups.io wrote:
+ PrintRndisMsg (RndisMsg);
+
+ Status = UsbIo->UsbControlTransfer (
+UsbIo,
+,
+EfiUsbDataOut,
+USB_ETHERNET_TRANSFER_TIMEOUT,
+
On 2/21/2023 1:45 AM, Rebecca Cran via groups.io wrote:
> There isn't supposed to be whitespace for "@param [in,out]" between "in"
> and "out". clang generates the following warning:
>
> test.c:8:9: warning: whitespace is not allowed in parameter passing direction
> [-Wdocumentation-pedantic]
>
On 2/15/2023 10:13 PM, Rebecca Cran via groups.io wrote:
+[PcdsFixedAtBuild, PcdsPatchableInModule, PcdsDynamic, PcdsDynamicEx]
+ ## Support rate limiting
+ gUsbNetworkPkgTokenSpaceGuid.EnableRateLimiting|FALSE|BOOLEAN|0x00010001
+
+ ## The rate limiting Credit value is check in rate limiter
On 2/7/2023 3:20 PM, Michael Brown wrote:
> On 07/02/2023 06:21, Tinh Nguyen via groups.io wrote:
>> From: Tinh Nguyen
>> Date: Tue, 7 Feb 2023 12:43:17 +0700
>> Subject: [PATCH] UsbNetworkPkg: Support rate limitting
>>
>> Signed-off-by: Tinh Nguyen
>
>
On 1/12/2023 3:36 PM, Richard Ho (何明忠) wrote:
> Hi Michael,
>
> We add this patch in my X86 platform and use the NCM device to test IPV4 PXE
> boot from 1330MB ISO file.
>
> No this patch: 35 sec to download 1330M ISO file
> Add this patch: 181 sec to download 1330M ISO file
>
> The patch will
Hi Michael,
I did a quick check, and it looks good ^^. I have pushed it here:
Commits · tinhnampere/edk2 (github.com)
<https://github.com/tinhnampere/edk2/commits/fix/UsbNet>
- Tinh
On 11/01/2023 16:55, Michael Brown wrote:
On 11/01/2023 07:34, Tinh Nguyen via groups.io wrote:
Hi,
I have changed the Metronome driver from EmbeddedPkg to MdeModulePkg,
but the performance is still very slow.
- Tinh
On 10/01/2023 12:07, Rebecca Cran wrote:
You might still be using the Metronome driver from EmbeddedPkg instead
of MdeModulePkg. That will for example cause gBS->Stall to
Hi everyone,
I found my answer, Reclaim() function calls Fault Tolerant Write protocol, it
is a boot-time service and not available on runtime
Maybe it is a dummy question, why do we support Fault Tolerant Write protocol
in runtime?
Thanks a lot
Tinh Nguyen
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io
84 matches
Mail list logo
