Sunny, Apologies for late response. (Not keeping well these days)
Ok, PSB my remarks.
#1. True, if an entity is independently getting build must be prefixed with
Pkg. In my previous discussion with Leif
(https://edk2.groups.io/g/devel/message/70090) Leif requested a reason of this
kind of
Sunny, Thank you for reviewing my code. Here are my remarks. PSB
From: Sunny Wang
Sent: Monday, July 12, 2021 4:07 PM
To: Vikas Singh ; devel@edk2.groups.io
Cc: Sami Mujawar ; l...@nuviainc.com ;
Meenakshi Aggarwal (meenakshi.aggar...@nxp.com) ;
Samer
Sunny,thanks for your review and PSB my remarks.
From: Sunny Wang
Sent: Monday, July 12, 2021 4:03 PM
To: Vikas Singh ; devel@edk2.groups.io
; Meenakshi Aggarwal (meenakshi.aggar...@nxp.com)
; l...@nuviainc.com
Cc: Sami Mujawar ; l...@nuviainc.com ;
Samer
This patch enables the use of ConfigurationManager (CM) and
its services to leverage the Dynamic ACPI support for NXP's
LS1046aFrwy platform.
Signed-off-by: Vikas Singh
---
Platform/NXP/LS1046aFrwyPkg/Include/Platform.h | 152
Platform/NXP/LS1046aFrwyPkg/LS1046aFrwyPkg.dsc
This patch adds platform specific DSDT generator
and Clk dsdt properties for LS1046AFRWY platform.
Reviewed-by: Leif Lindholm
Signed-off-by: Vikas Singh
---
Platform/NXP/LS1046aFrwyPkg/AcpiTablesInclude/Dsdt/Clk.asl
| 60 +
This patch adds a generic method to get Silicon Version Register (SVR)
on LS1046A SoC. This method will be generic for all platfroms based
on LS1046A SoC, like - LS1046AFRWY, LS1046ARDB.
Signed-off-by: Vikas Singh
---
Silicon/NXP/LS1046A/Library/SocLib/SocLib.c | 16
1 file
This patch replaces the logic in ConfigurationManager to print platform
name based on platform ID with a simple #define PLAT_SOC_NAME defined in
platform headers.
This also removes duplication of the SVR_LX2160A, SVR_SOC_VER, SVR_MAJOR
and SVR_MINOR macro definitions between SoC headers and
This patch series basically aims to extend the Dynamic ACPI
framework towards NXP's LS1046AFRWY platform.
In continuation to https://edk2.groups.io/g/devel/message/71709
The change set in the series is in below order -
(1)Introducing a new platform specific macro "PLAT_SOC_NAME"
This macro will
On Tue, Jun 15, 2021 at 3:07 AM Leif Lindholm wrote:
>
> On Fri, Jun 11, 2021 at 21:22:00 +0530, Vikas Singh wrote:
> > This patch adds platform specific DSDT generator
> > and Clk dsdt properties for LS1046AFRWY platform.
> >
> > Signed-off-by: Vikas Singh
> > ---
> >
On Tue, Jun 15, 2021 at 2:58 AM Leif Lindholm wrote:
>
> On Fri, Jun 11, 2021 at 21:21:59 +0530, Vikas Singh wrote:
> > This patch set extends Configuration Manager (CM) and
> > its services to leverage the Dynamic ACPI support for
> > NXP's LS1046aFrwy platform.
>
> This patch does not touch
On Tue, Jun 15, 2021 at 2:29 AM Leif Lindholm wrote:
>
> On Fri, Jun 11, 2021 at 21:21:58 +0530, Vikas Singh wrote:
> > This change set intend to add a generic method to get
>
> Does it intend to add, or does it add?
>
> /
> Leif
>
Leif, this patch adds a generic method to get the SVR
On Tue, Jun 15, 2021 at 2:28 AM Leif Lindholm wrote:
>
> On Fri, Jun 11, 2021 at 21:21:57 +0530, Vikas Singh wrote:
> > Summary -
> > 1.Configuration Manager(CM) is a common implementation
> > and should not evaluate the SoC version using macro's
> > However CM must directly consume SoC ver
This patch adds platform specific DSDT generator
and Clk dsdt properties for LS1046AFRWY platform.
Signed-off-by: Vikas Singh
---
Platform/NXP/LS1046aFrwyPkg/AcpiTablesInclude/Dsdt/Clk.asl
| 60 +
Platform/NXP/LS1046aFrwyPkg/AcpiTablesInclude/Dsdt/Dsdt.asl
This patch set extends Configuration Manager (CM) and
its services to leverage the Dynamic ACPI support for
NXP's LS1046aFrwy platform.
Refer-https://edk2.groups.io/g/devel/message/71710
Signed-off-by: Vikas Singh
---
Platform/NXP/LS1046aFrwyPkg/Include/Platform.h | 155
This change set intend to add a generic method to get
access to SoC's Silicon Version Register (SVR) and its
handling for LS1046aFrwy platform.
Signed-off-by: Vikas Singh
---
Silicon/NXP/LS1046A/Library/SocLib/SocLib.c | 16
1 file changed, 16 insertions(+)
diff --git
Summary -
1.Configuration Manager(CM) is a common implementation
and should not evaluate the SoC version using macro's
However CM must directly consume SoC ver string from
platfrom who is extending CM services for ACPI table
generation.
2.Platforms who extends CM services for themselves
This patch series basically aims to extend the Dynamic ACPI
framework towards NXP's LS1046AFRWY platform.
Refer- https://edk2.groups.io/g/devel/message/71709
The change set in the series is in below order -
(1)Introducing a new platform specific macro "PLAT_SOC_NAME"
This macro will be consumed
This patch adds platform specific DSDT generator
and Clk dsdt properties for LS1046AFRWY platform.
Signed-off-by: Vikas Singh
---
.../AcpiTablesInclude/Dsdt/Clk.asl| 60
.../AcpiTablesInclude/Dsdt/Dsdt.asl | 15 ++
.../AcpiTablesInclude/PlatformAcpiDsdtLib.inf |
Summary -
1.Configuration Manager(CM) is a common implementation
and should not evaluate the SoC version using macro's
However CM must directly consume SoC ver string from
platfrom who is extending CM services for ACPI table
generation.
2.Platforms who extends CM services for themselves
This patch set extends Configuration Manager (CM) and
its services to leverage the Dynamic ACPI support for
NXP's LS1046aFrwy platform.
Refer-https://edk2.groups.io/g/devel/message/71710
Signed-off-by: Vikas Singh
---
.../NXP/LS1046aFrwyPkg/Include/Platform.h | 155 ++
This change set intend to add a generic method to get
access to SoC's Silicon Version Register (SVR) and its
handling for LS1046aFrwy platform.
Signed-off-by: Vikas Singh
---
Silicon/NXP/LS1046A/Library/SocLib/SocLib.c | 16
1 file changed, 16 insertions(+)
diff --git
This patch series basically aims to extend the Dynamic ACPI
framework towards NXP's LS1046AFRWY platform.
Refer- https://edk2.groups.io/g/devel/message/71709
The change set in the series is in below order -
(1)Introducing a new platform specific macro "PLAT_SOC_NAME"
This macro will be consumed
On Tue, Feb 16, 2021 at 5:29 PM Vikas Singh
wrote:
>
> On Mon, Feb 15, 2021 at 6:48 PM Leif Lindholm wrote:
> >
> > Hi Vikas,
> >
> > Apologies for very slow review.
> >
> > However, this set doesn't build for me.
> > It fails with
> >
> > In file included from
> >
These changes add platform specific DSDT generator
and Clk dsdt properties for LX2160ARDB.
Signed-off-by: Vikas Singh
---
Platform/NXP/ConfigurationManagerPkg/ConfigurationManagerDxe/ConfigurationManager.c
| 9 ++
These changes intend to add Common Configuration Manager (CM)
for all fsl platforms and Platform headers consumed by CM for
LX2160ARDB.
Signed-off-by: Vikas Singh
---
Platform/NXP/ConfigurationManagerPkg/ConfigurationManagerDxe/ConfigurationManager.c
| 834
This patch series sets the foundation of Dynamic ACPI framework for all
fsl layerscape platforms. In order to achieve:
- Configurable firmware builds.
- Unify firmware build for similar platforms.
- Minimize/eliminate human induced errors.
- Validate and generate firmware that complies
On Wed, Jan 27, 2021 at 12:21 PM Vikas Singh
wrote:
>
> On Tue, Jan 26, 2021 at 4:49 PM Leif Lindholm wrote:
> >
> > Hi Vikas,
> >
> > On Tue, Jan 19, 2021 at 10:11:43 +0530, Vikas Singh wrote:
> > > > > > > +/** A helper macro for returning configuration manager objects
> > > > > > > +*/
> > >
On Tue, Jan 26, 2021 at 4:49 PM Leif Lindholm wrote:
>
> Hi Vikas,
>
> On Tue, Jan 19, 2021 at 10:11:43 +0530, Vikas Singh wrote:
> > > > > > +/** A helper macro for returning configuration manager objects
> > > > > > +*/
> > > > > > +#define HANDLE_CM_OBJECT(ObjId, CmObjectId, Object,
These changes add platform specific DSDT generator
and Clk dsdt properties for LX2160ARDB.
Signed-off-by: Vikas Singh
---
.../ConfigurationManagerDxe/ConfigurationManager.c | 9 ++
.../ConfigurationManagerDxe/ConfigurationManager.h | 4 +-
.../ConfigurationManagerDxe.inf
These changes intend to add Common Configuration Manager (CM)
for all fsl platforms and Platform headers consumed by CM for
LX2160ARDB.
Signed-off-by: Vikas Singh
---
.../ConfigurationManagerDxe/ConfigurationManager.c | 834 +
This patch series sets the foundation of Dynamic ACPI framework for all
fsl layerscape platforms. In order to achieve:
- Configurable firmware builds.
- Unify firmware build for similar platforms.
- Minimize/eliminate human induced errors.
- Validate and generate firmware that complies
On Tue, Jan 26, 2021 at 3:11 AM Sami Mujawar wrote:
>
> Hi Vikas,
>
> On Mon, Jan 18, 2021 at 09:06 AM, Vikas Singh wrote:
>
> + // Add the dsdt aml code here, Currently NULL place holder.
> + *Table = (EFI_ACPI_DESCRIPTION_HEADER *)_aml_code;
>
> Do you intend to process the DSDT data in this
On Mon, Jan 18, 2021 at 10:25 PM Leif Lindholm wrote:
>
> +Sami,
>
> On Sat, Jan 16, 2021 at 10:15:41 +0530, Vikas Singh wrote:
> > On Sun, Jan 10, 2021 at 8:56 AM Leif Lindholm wrote:
> > >
> > > On Tue, Dec 29, 2020 at 12:55:58 +0530, Vikas Singh wrote:
> > > > These changes intend to add
> >
33 matches
Mail list logo
