[edk2-devel] [PATCH v1 0/1] MinPlatformPkg: Fix DxePhatAcpiLib.inf path

2024-05-09 Thread VivianNK
REF: https://github.com/VivianNK/edk2-platforms/tree/remove_unused_inf Bug fix. When building MinPlatformPkg, a build error occured because the inf was not found. The path was incorrect -- DxePhatAcpiLib folder doesn't exist, PhatAcpiLib does. Cc: Chasel Chiu Cc: Nate DeSimone Signed-off

[edk2-devel] [PATCH v1 1/1] MinPlatformPkg: Fix DxePhatAcpiLib.inf path in dsc

2024-05-09 Thread VivianNK
When building MinPlatformPkg, a build error occured because the inf was not found. The path was incorrect -- DxePhatAcpiLib folder doesn't exist, PhatAcpiLib does. Cc: Chasel Chiu Cc: Nate DeSimone Signed-off-by: Vivian Nowka-Keane --- Platform/Intel/MinPlatformPkg/MinPlatformPkg.dsc | 4 ++--

[edk2-devel] [PATCH v1 0/1] Add MockBiosIdLib to BoardModulePkg

2024-05-08 Thread VivianNK
This patch adds a mock library for MockBiosIdLib. REF: https://github.com/VivianNK/edk2-platforms/tree/vnowkakeane/MockBiosIdLib_v1 Cc: Eric Dong Cc: Liming Gao Signed-off-by: Vivian Nowka-Keane Bhavani Subramanian (1): BoardModulePkg: Added Mock library for BiosIdLib Platform/Intel

[edk2-devel] [PATCH v1 1/1] BoardModulePkg: Added Mock library for BiosIdLib

2024-05-08 Thread VivianNK
From: Bhavani Subramanian Added a gmock for GoogleTests that pull in BiosIdLib. Cc: Eric Dong Cc: Liming Gao Signed-off-by: Vivian Nowka-Keane --- Platform/Intel/BoardModulePkg/BoardModulePkg.dec | 1 +

Re: [edk2-devel] [PATCH v2 0/7] Uncrustify GoogleTest update

2023-10-24 Thread VivianNK
-by: Michael D Kinney -Original Message- From:devel@edk2.groups.io    On Behalf Of VivianNK Sent: Wednesday, August 16, 2023 2:15 PM To:devel@edk2.groups.io Subject: [edk2-devel] [PATCH v2 0/7] Uncrustify GoogleTest update v1 -> v2:   - Update commit message to explain the audit o

Re: [edk2-devel] [PATCH v2 0/7] Uncrustify GoogleTest update

2023-09-27 Thread VivianNK
Hi Mike, Can you help merge this? Looks like it has all of the reviews. Thank you! - Vivian On 9/12/2023 7:42 AM, Michael D Kinney wrote: Series Reviewed-by: Michael D Kinney -Original Message- From:devel@edk2.groups.ioOn Behalf Of VivianNK Sent: Wednesday, August 16, 2023 2:15

[edk2-devel] [PATCH v2 0/7] Uncrustify GoogleTest update

2023-08-16 Thread VivianNK
v1 -> v2: - Update commit message to explain the audit only mode change is temporary to prevent intermediate CI failures. - Format patch Cc's correctly v1 archive:https://edk2.groups.io/g/devel/message/107665 VivianNK (7): .pytool: Set uncrustify check to audit only (temporary) .pyt

[edk2-devel] [PATCH v1 0/7] Uncrustify GoogleTest update

2023-08-09 Thread VivianNK
forward all GoogleTest files will be included in uncrustify formatting checks, leading to more consistency and greater readability. VivianNK (7): .pytool: Set uncrustify check to audit only .pytool: Add cpp support to uncrustify plugin MdeModulePkg: Applyy uncrustify formatting to relevant files