Re: [edk2-devel] [Patch V2 1/5] MdeModulePkg: add MpService2Ppi field in SMM_S3_RESUME_STATE

2023-09-07 Thread Wang, Jian J
Reviewed-by: Jian J Wang Regards, Jian > -Original Message- > From: Tan, Dun > Sent: Wednesday, September 06, 2023 11:22 AM > To: devel@edk2.groups.io; Tan, Dun > Cc: Ni, Ray ; Wang, Jian J ; Gao, > Liming > Subject: RE: [edk2-devel] [Patch V2 1/5] MdeModuleP

Re: [edk2-devel] [Patch V6 02/14] MdeModulePkg: Remove other attribute protection in UnsetGuardPage

2023-06-16 Thread Wang, Jian J
Reviewed-by: Jian J Wang Regards, Jian > -Original Message- > From: devel@edk2.groups.io On Behalf Of duntan > Sent: Friday, June 09, 2023 5:16 PM > To: devel@edk2.groups.io > Cc: Gao, Liming ; Ni, Ray ; > Wang, Jian J ; Ard Biesheuvel > > Subject: [edk

[edk2-devel] [PATCH] Maintainers.txt: update maintainer for CryptoPkg

2023-06-15 Thread Wang, Jian J
Cc: Jiewen Yao [jyao1] Cc: Yi Li [liyi77] Cc: Xiaoyu Lu [xiaoyuxlu] Cc: Guomin Jiang [guominjia] Signed-off-by: Jian J Wang --- Maintainers.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Maintainers.txt b/Maintainers.txt index 42e40dced3..c645df397c 100644 ---

Re: [edk2-devel] [PATCH V3 8/8] MdeModulePkg/SmmCore: Perf-log PlatformHookBefore/AfterSmmDispatch

2023-06-15 Thread Wang, Jian J
Reviewed-by: Jian J Wang Regards, Jian > -Original Message- > From: Ni, Ray > Sent: Tuesday, June 13, 2023 2:13 PM > To: devel@edk2.groups.io > Cc: Wang, Jian J ; Gao, Liming > ; Wu, Jiaxin > Subject: [PATCH V3 8/8] MdeModulePkg/SmmCore: Perf-log

Re: [edk2-devel] [PATCH V3 6/8] MdeModulePkg/SmmCorePerformanceLib: Disable perf-logging at runtime

2023-06-15 Thread Wang, Jian J
Reviewed-by: Jian J Wang Regards, Jian > -Original Message- > From: Ni, Ray > Sent: Tuesday, June 13, 2023 2:13 PM > To: devel@edk2.groups.io > Cc: Wu, Jiaxin ; Bi, Dandan ; Gao, > Liming ; Wang, Jian J ; > Dong, Eric > Subject: [PATCH V3 6/8] MdeModuleP

Re: [edk2-devel] [PATCH V3 5/8] MdeModulePkg/SmmPerformanceLib: Disable perf-logging after ExitBS

2023-06-15 Thread Wang, Jian J
Reviewed-by: Jian J Wang Regards, Jian > -Original Message- > From: Ni, Ray > Sent: Tuesday, June 13, 2023 2:13 PM > To: devel@edk2.groups.io > Cc: Wu, Jiaxin ; Bi, Dandan ; Gao, > Liming ; Wang, Jian J ; > Dong, Eric > Subject: [PATCH V3 5/8] MdeModulePkg/Sm

Re: [edk2-devel] [PATCH V3 4/8] MdeModulePkg/SmmCore: Add perf-logging for SmmDriverDispatchHandler

2023-06-15 Thread Wang, Jian J
Reviewed-by: Jian J Wang Regards, Jian > -Original Message- > From: Ni, Ray > Sent: Tuesday, June 13, 2023 2:13 PM > To: devel@edk2.groups.io > Cc: Wang, Jian J ; Gao, Liming > ; Wu, Jiaxin ; Dong, Eric > > Subject: [PATCH V3 4/8] MdeModulePkg/S

Re: [edk2-devel] [PATCH V3 3/8] MdeModulePkg/SmmCore: Add perf-logging for time-consuming procedures

2023-06-15 Thread Wang, Jian J
Reviewed-by: Jian J Wang Regards, Jian > -Original Message- > From: Ni, Ray > Sent: Tuesday, June 13, 2023 2:13 PM > To: devel@edk2.groups.io > Cc: Wang, Jian J ; Gao, Liming > ; Wu, Jiaxin ; Dong, Eric > > Subject: [PATCH V3 3/8] MdeModulePkg/SmmCore: A

Re: [edk2-devel] [Patch V2 3/8] MdeModulePkg: Add CpuPageTableLib required by DxeIpl in DSC

2023-04-14 Thread Wang, Jian J
oups.io > Cc: Wang, Jian J ; Gao, Liming > ; Ni, Ray > Subject: [Patch V2 3/8] MdeModulePkg: Add CpuPageTableLib required by DxeIpl > in DSC > > Add CpuPageTableLib instance required by DxeIpl in > MdeModulePkg.dsc. > > Signed-off-by: Dun Tan > Cc: J

Re: [edk2-devel] [Patch V2 5/8] MdeModulePkg: Add UefiCpuPkg.dec to pass DependencyCheck

2023-04-14 Thread Wang, Jian J
Cc: Gao, Liming ; Ni, Ray ; > Wang, Jian J > Subject: [Patch V2 5/8] MdeModulePkg: Add UefiCpuPkg.dec to pass > DependencyCheck > > Add UefiCpuPkg/UefiCpuPkg.dec in MdeModulePkg.ci.yaml to pass > DependencyCheck since DxeIpl in MdeModulePkg needs to consume > CpuPageTableLib in

Re: [edk2-devel] [Patch 0/2] Add and use FirmwareVolumeShadowPpi

2023-03-26 Thread Wang, Jian J
For the patch series, Reviewed-by: Jian J Wang Regards, Jian > -Original Message- > From: Kinney, Michael D > Sent: Wednesday, March 22, 2023 10:06 AM > To: devel@edk2.groups.io > Cc: Yao, Jiewen ; Wang, Jian J ; > Gao, Liming ; Patel, Umang > > Subject:

[edk2-devel] [PATCH] SecurityPkg: deprecate RpmcLib and VariableKeyLib

2022-12-14 Thread Wang, Jian J
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2594 There's no real usage of these two libraries. They're deprecated. Cc: Jiewen Yao Cc: Michael D Kinney Cc: Nishant C Mistry Cc: Judah Vang Signed-off-by: Jian J Wang --- SecurityPkg/Include/Library/RpmcLib.h | 42

Re: [edk2-devel] [PATCH v5 19/19] SecurityPkg: Add references to new *.inf files

2022-11-22 Thread Wang, Jian J
Reviewed-by: Jian J Wang Regards, Jian > -Original Message- > From: Vang, Judah > Sent: Sunday, November 06, 2022 3:35 PM > To: devel@edk2.groups.io > Cc: Wang, Jian J ; Yao, Jiewen ; > Mistry, Nishant C > Subject: [PATCH v5 19/19] SecurityPkg: Add referenc

Re: [edk2-devel] [PATCH v5 17/19] SecurityPkg: Add EncryptionVariable lib with AES

2022-11-21 Thread Wang, Jian J
Judah, Just some typos found. See inline comments below starting with "[JianJW]". With them addressed, Reviewed-by: Jian J Wang Regards, Jian > -Original Message- > From: Vang, Judah > Sent: Sunday, November 06, 2022 3:35 PM > To: devel@edk2.groups.io &g

Re: [edk2-devel] [PATCH v5 15/19] SecurityPkg: Add null encryption variable libs

2022-11-21 Thread Wang, Jian J
Reviewed-by: Jian J Wang Regards, Jian > -Original Message- > From: Vang, Judah > Sent: Sunday, November 06, 2022 3:35 PM > To: devel@edk2.groups.io > Cc: Wang, Jian J ; Yao, Jiewen ; > Mistry, Nishant C > Subject: [PATCH v5 15/19] SecurityPkg: Add null enc

Re: [edk2-devel] [PATCH v5 11/19] SecurityPkg: Add new KeyService types and defines

2022-11-21 Thread Wang, Jian J
Reviewed-by: Jian J Wang Regards, Jian > -Original Message- > From: Vang, Judah > Sent: Sunday, November 06, 2022 3:35 PM > To: devel@edk2.groups.io > Cc: Wang, Jian J ; Yao, Jiewen ; > Mistry, Nishant C > Subject: [PATCH v5 11/19] SecurityPkg: Add new KeyServ

Re: [edk2-devel] [PATCH v5 09/19] MdeModulePkg: Reference Null ProtectedVariableLib

2022-11-21 Thread Wang, Jian J
Reviewed-by: Jian J Wang Regards, Jian > -Original Message- > From: Vang, Judah > Sent: Sunday, November 06, 2022 3:35 PM > To: devel@edk2.groups.io > Cc: Wang, Jian J ; Gao, Liming > ; Mistry, Nishant C > Subject: [PATCH v5 09/19] MdeModulePkg: Reference Null

Re: [edk2-devel] [PATCH v5 06/19] MdeModulePkg: Add Null ProtectedVariable Library

2022-11-21 Thread Wang, Jian J
Judah, Just some typos. See inline comments starting with "[JianJW]". With them addressed, Reviewed-by: Jian J Wang Regards, Jian > -Original Message- > From: Vang, Judah > Sent: Sunday, November 06, 2022 3:35 PM > To: devel@edk2.groups.io > Cc: W

Re: [edk2-devel] [PATCH v5 04/19] MdeModulePkg: Add new include files

2022-11-21 Thread Wang, Jian J
Reviewed-by: Jian J Wang Regards, Jian > -Original Message- > From: Vang, Judah > Sent: Sunday, November 06, 2022 3:35 PM > To: devel@edk2.groups.io > Cc: Wang, Jian J ; Gao, Liming > ; Mistry, Nishant C > Subject: [PATCH v5 04/19] MdeModulePkg: Add new include

Re: [edk2-devel] [PATCH v5 07/19] MdeModulePkg: Add new Variable functionality

2022-11-13 Thread Wang, Jian J
convention. Regards, Jian > -Original Message- > From: devel@edk2.groups.io On Behalf Of Wang, Jian > J > Sent: Monday, November 14, 2022 11:43 AM > To: Vang, Judah ; devel@edk2.groups.io > Cc: Gao, Liming ; Wu, Hao A > ; Mistry, Nishant C > Subject: Re: [edk

Re: [edk2-devel] [PATCH v5 07/19] MdeModulePkg: Add new Variable functionality

2022-11-13 Thread Wang, Jian J
Hi Judah, See my comments (starting with [JianJW]) inline below. > -Original Message- > From: Vang, Judah > Sent: Sunday, November 06, 2022 3:35 PM > To: devel@edk2.groups.io > Cc: Wang, Jian J ; Gao, Liming > ; Wu, Hao A ; Mistry, > Nishant C > Subject: [PATC

Re: [edk2-devel] [PATCH v4 07/28] MdeModulePkg: Add new Variable functionality

2022-11-13 Thread Wang, Jian J
Sorry, please ignore this one. I should reply the one from v5. Regards, Jian > -Original Message- > From: devel@edk2.groups.io On Behalf Of Wang, Jian > J > Sent: Monday, November 14, 2022 1:39 AM > To: Vang, Judah ; devel@edk2.groups.io > Cc: Gao, Liming ; Wu, Hao A &

Re: [edk2-devel] [PATCH v4 07/28] MdeModulePkg: Add new Variable functionality

2022-11-13 Thread Wang, Jian J
Hi Judah, See my comments (starting with [JianJW]) inline below. Regards, Jian > -Original Message- > From: Vang, Judah > Sent: Thursday, August 11, 2022 2:53 PM > To: devel@edk2.groups.io > Cc: Wang, Jian J ; Gao, Liming > ; Wu, Hao A ; Mistry, > Nishant C >

Re: [edk2-devel] [Patch 1/1] CryptoPkg/Test: Simplify BaseCryptLib host based unit tests

2022-11-01 Thread Wang, Jian J
Reviewed-by: Jian J Wang Regards, Jian > -Original Message- > From: Kinney, Michael D > Sent: Saturday, October 29, 2022 3:01 AM > To: devel@edk2.groups.io > Cc: Yao, Jiewen ; Wang, Jian J ; > Lu, Xiaoyu1 ; Jiang, Guomin > Subject: [Patch 1/1] CryptoPkg/Test:

Re: [edk2-devel] [PATCH v4 19/28] SecurityPkg: Add references to new *.inf files

2022-08-21 Thread Wang, Jian J
Reviewed-by: Jian J Wang Regards, Jian > -Original Message- > From: Vang, Judah > Sent: Thursday, August 11, 2022 2:53 PM > To: devel@edk2.groups.io > Cc: Wang, Jian J ; Yao, Jiewen ; > Mistry, Nishant C > Subject: [PATCH v4 19/28] SecurityPkg: Add referenc

Re: [edk2-devel] [PATCH v4 17/28] SecurityPkg: Add EncryptionVariable lib with AES

2022-08-21 Thread Wang, Jian J
Reviewed-by: Jian J Wang Regards, Jian > -Original Message- > From: Vang, Judah > Sent: Thursday, August 11, 2022 2:53 PM > To: devel@edk2.groups.io > Cc: Wang, Jian J ; Yao, Jiewen ; > Xu, Min M ; Mistry, Nishant C > > Subject: [PATCH v4 17/28] SecurityPkg

Re: [edk2-devel] [PATCH v4 16/28] SecurityPkg: Add VariableKey library function

2022-08-21 Thread Wang, Jian J
rds, Jian > -Original Message- > From: Vang, Judah > Sent: Thursday, August 11, 2022 2:53 PM > To: devel@edk2.groups.io > Cc: Wang, Jian J ; Yao, Jiewen ; > Mistry, Nishant C > Subject: [PATCH v4 16/28] SecurityPkg: Add VariableKey library function > > REF:

Re: [edk2-devel] [PATCH v4 15/28] SecurityPkg: Add null encryption variable libs

2022-08-21 Thread Wang, Jian J
Reviewed-by: Jian J Wang Regards, Jian > -Original Message- > From: Vang, Judah > Sent: Thursday, August 11, 2022 2:53 PM > To: devel@edk2.groups.io > Cc: Wang, Jian J ; Yao, Jiewen ; > Mistry, Nishant C > Subject: [PATCH v4 15/28] SecurityPkg: Add null enc

Re: [edk2-devel] [PATCH v4 14/28] SecurityPkg: Fix GetVariableKey API

2022-08-21 Thread Wang, Jian J
Reviewed-by: Jian J Wang Regards, Jian > -Original Message- > From: Vang, Judah > Sent: Thursday, August 11, 2022 2:53 PM > To: devel@edk2.groups.io > Cc: Wang, Jian J ; Yao, Jiewen ; > Mistry, Nishant C > Subject: [PATCH v4 14/28] SecurityPkg: Fix GetVariableKe

Re: [edk2-devel] [PATCH v4 12/28] SecurityPkg: Add new variable types and functions

2022-08-21 Thread Wang, Jian J
Reviewed-by: Jian J Wang Regards, Jian > -Original Message- > From: Vang, Judah > Sent: Thursday, August 11, 2022 2:53 PM > To: devel@edk2.groups.io > Cc: Wang, Jian J ; Yao, Jiewen ; > Mistry, Nishant C > Subject: [PATCH v4 12/28] SecurityPkg: Add new variabl

Re: [edk2-devel] [PATCH v4 11/28] SecurityPkg: Add new KeyService types and defines

2022-08-21 Thread Wang, Jian J
Reviewed-by: Jian J Wang Regards, Jian > -Original Message- > From: Vang, Judah > Sent: Thursday, August 11, 2022 2:53 PM > To: devel@edk2.groups.io > Cc: Wang, Jian J ; Yao, Jiewen ; > Mistry, Nishant C > Subject: [PATCH v4 11/28] SecurityPkg: Add new KeyServ

Re: [edk2-devel] [PATCH v4 04/28] MdeModulePkg: Add new include files

2022-08-18 Thread Wang, Jian J
Reviewed-by: Jian J Wang Regards, Jian > -Original Message- > From: Vang, Judah > Sent: Thursday, August 11, 2022 2:53 PM > To: devel@edk2.groups.io > Cc: Wang, Jian J ; Gao, Liming > ; Mistry, Nishant C > Subject: [PATCH v4 04/28] MdeModulePkg: Add new include

Re: [edk2-devel] [PATCH v4 06/28] MdeModulePkg: Add Null ProtectedVariable Library

2022-08-18 Thread Wang, Jian J
Reviewed-by: Jian J Wang Regards, Jian > -Original Message- > From: Vang, Judah > Sent: Thursday, August 11, 2022 2:53 PM > To: devel@edk2.groups.io > Cc: Wang, Jian J ; Gao, Liming > ; Mistry, Nishant C > Subject: [PATCH v4 06/28] MdeModulePkg: Add Null Prot

Re: [edk2-devel] [PATCH v3] MdeModulePkg/Include: Long debug string is truncated to 104 char

2022-07-18 Thread Wang, Jian J
Reviewed-by: Jian J Wang Regards, Jian > -Original Message- > From: Lai, Cosmo > Sent: Friday, July 15, 2022 9:43 AM > To: devel@edk2.groups.io > Cc: Lai, Cosmo ; Wang, Jian J ; > Gao, Liming ; Bi, Dandan > Subject: [PATCH v3] MdeModulePkg/Include: Long debu

Re: [edk2-devel] [PATCH v2] MdeModulePkg/Include: Long debug string is truncated to 104 char

2022-07-17 Thread Wang, Jian J
Reviewed-by: Jian J Wang Regards, Jian > -Original Message- > From: devel@edk2.groups.io On Behalf Of Cosmo Lai > Sent: Wednesday, July 13, 2022 3:26 PM > To: devel@edk2.groups.io > Cc: Lai, Cosmo > Subject: [edk2-devel] [PATCH v2] MdeModulePkg/Include: Long debug string is >

Re: [edk2-devel] [PATCH] DxeMain: Fix the bug that StackGuard is not enabled

2022-06-11 Thread Wang, Jian J
Reviewed-by: Jian J Wang Regards, Jian > -Original Message- > From: Ni, Ray > Sent: Friday, June 10, 2022 4:50 PM > To: devel@edk2.groups.io > Cc: Wang, Jian J ; Gao, Liming > > Subject: [PATCH] DxeMain: Fix the bug that StackGuard is not enabled > &g

Re: [edk2-devel] [PATCH 1/5] CpuException: Avoid allocating code pages for DXE instance

2022-05-24 Thread Wang, Jian J
I see. With its addressed, Reviewed-by: Jian J Wang Regards, Jian > -Original Message- > From: Ni, Ray > Sent: Tuesday, May 24, 2022 4:02 PM > To: Wang, Jian J ; devel@edk2.groups.io > Cc: Dong, Eric > Subject: Re: [edk2-devel] [PATCH 1/5] CpuException: Avoid alloc

Re: [edk2-devel] [PATCH 4/5] CpuException: Remove InitializeCpuInterruptHandlers

2022-05-24 Thread Wang, Jian J
Another patch works for me. Reviewed-by: Jian J Wang Regards, Jian > -Original Message- > From: Ni, Ray > Sent: Tuesday, May 24, 2022 4:04 PM > To: Wang, Jian J ; devel@edk2.groups.io > Cc: Dong, Eric > Subject: Re: [edk2-devel] [PATCH 4/5] Cp

Re: [edk2-devel] [PATCH 1/5] CpuException: Avoid allocating code pages for DXE instance

2022-05-22 Thread Wang, Jian J
Ray, You changed "%rep 32" to "%rep 256" in Ia32/ExceptionHandlerAsm.nasm. According to my understanding and your comments, this should be done only to X64 code, right? Regards, Jian > -Original Message- > From: devel@edk2.groups.io On Behalf Of Ni, Ray > Sent: Friday, May 20, 2022

Re: [edk2-devel] [PATCH 2/5] CpuException: Init global variables in-place

2022-05-22 Thread Wang, Jian J
Reviewed-by: Jian J Wang Regards, Jian > -Original Message- > From: devel@edk2.groups.io On Behalf Of Ni, Ray > Sent: Friday, May 20, 2022 10:16 PM > To: devel@edk2.groups.io > Cc: Dong, Eric > Subject: [edk2-devel] [PATCH 2/5] CpuException: Init global variables in-place > >

Re: [edk2-devel] [PATCH 3/5] CpuException: Avoid allocating page but using global variables

2022-05-22 Thread Wang, Jian J
Reviewed-by: Jian J Wang Regards, Jian > -Original Message- > From: devel@edk2.groups.io On Behalf Of Ni, Ray > Sent: Friday, May 20, 2022 10:16 PM > To: devel@edk2.groups.io > Cc: Dong, Eric > Subject: [edk2-devel] [PATCH 3/5] CpuException: Avoid allocating page but > using >

Re: [edk2-devel] [PATCH 4/5] CpuException: Remove InitializeCpuInterruptHandlers

2022-05-22 Thread Wang, Jian J
Hi Ray, Both CpuDxe.c and CpuExceptionCommon.h have CPU_INTERRUPT_NUM defined. I'd suggest to move it to a common place, such as BaseLib.h. I don't see any issue if they are defined to different value. It just gives me a feeling that it might cause potential problems sometimes in the future.

Re: [edk2-devel] [PATCH 5/5] CpuException: Add InitializeSeparateExceptionStacks

2022-05-22 Thread Wang, Jian J
Reviewed-by: Jian J Wang Regards, Jian > -Original Message- > From: Ni, Ray > Sent: Friday, May 20, 2022 10:16 PM > To: devel@edk2.groups.io > Cc: Dong, Eric ; Wang, Jian J > Subject: [PATCH 5/5] CpuException: Add InitializeSeparateExceptio

Re: [edk2-devel] [Patch v2 14/28] SecurityPkg: Add null encryption variable libs

2022-05-22 Thread Wang, Jian J
Judah, My comments below > -Original Message- > From: Vang, Judah > Sent: Saturday, April 30, 2022 2:04 AM > To: devel@edk2.groups.io > Cc: Wang, Jian J ; Yao, Jiewen ; > Mistry, Nishant C > Subject: [Patch v2 14/28] SecurityPkg: Add null encryption variable

Re: [edk2-devel] [Patch v2 13/28] SecurityPkg: Fix GetVariableKey API

2022-05-22 Thread Wang, Jian J
Judah, My comments below > -Original Message- > From: Vang, Judah > Sent: Saturday, April 30, 2022 2:04 AM > To: devel@edk2.groups.io > Cc: Wang, Jian J ; Yao, Jiewen ; > Mistry, Nishant C > Subject: [Patch v2 13/28] SecurityPkg: Fix GetVariableKe

Re: [edk2-devel] [Patch v2 12/28] SecurityPkg: Add new variable types and functions

2022-05-22 Thread Wang, Jian J
o > Cc: Wang, Jian J ; Yao, Jiewen ; > Mistry, Nishant C > Subject: [Patch v2 12/28] SecurityPkg: Add new variable types and functions > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2594 > > Add new variable encryption/decryption function prototypes. > Add ne

Re: [edk2-devel] [Patch v2 11/28] SecurityPkg: Update RPMC APIs with index

2022-05-22 Thread Wang, Jian J
Reviewed-by: Jian J Wang Regards, Jian > -Original Message- > From: Vang, Judah > Sent: Saturday, April 30, 2022 2:04 AM > To: devel@edk2.groups.io > Cc: Wang, Jian J ; Yao, Jiewen ; > Mistry, Nishant C > Subject: [Patch v2 11/28] SecurityPkg: Update RPMC API

Re: [edk2-devel] [Patch v2 10/28] SecurityPkg: Add new KeyService types and defines

2022-05-22 Thread Wang, Jian J
Judah, > -Original Message- > From: Vang, Judah > Sent: Saturday, April 30, 2022 2:04 AM > To: devel@edk2.groups.io > Cc: Wang, Jian J ; Yao, Jiewen ; > Mistry, Nishant C > Subject: [Patch v2 10/28] SecurityPkg: Add new KeyService types and de

Re: [edk2-devel] [Patch v2 08/28] MdeModulePkg: Add new Variable functionality

2022-05-22 Thread Wang, Jian J
Judah, One general comment: please add variable store provision/recovery flow and explanations in the readme. See my other inline comments below. Regards, Jian > -Original Message- > From: Vang, Judah > Sent: Saturday, April 30, 2022 2:04 AM > To: devel@edk2.groups.io >

Re: [edk2-devel] [Patch v2 07/28] MdeModulePkg: Add Null ProtectedVariable Library

2022-05-22 Thread Wang, Jian J
age- > From: Vang, Judah > Sent: Saturday, April 30, 2022 2:04 AM > To: devel@edk2.groups.io > Cc: Wang, Jian J ; Gao, Liming > ; Mistry, Nishant C > Subject: [Patch v2 07/28] MdeModulePkg: Add Null ProtectedVariable Library > > REF: https://bugzilla.tianocore.org/sh

Re: [edk2-devel] [Patch v2 02/28] SecurityPkg: Add new GUIDs for

2022-05-12 Thread Wang, Jian J
Reviewed-by: Jian J Wang Regards, Jian > -Original Message- > From: Vang, Judah > Sent: Saturday, April 30, 2022 2:04 AM > To: devel@edk2.groups.io > Cc: Wang, Jian J ; Yao, Jiewen ; > Mistry, Nishant C > Subject: [Patch v2 02/28] SecurityPkg: Add new GUID

Re: [edk2-devel] [Patch v2 03/28] MdeModulePkg: Update AUTH_VARIABLE_INFO struct

2022-05-12 Thread Wang, Jian J
Reviewed-by: Jian J Wang Regards, Jian > -Original Message- > From: Vang, Judah > Sent: Saturday, April 30, 2022 2:04 AM > To: devel@edk2.groups.io > Cc: Wang, Jian J ; Gao, Liming > ; Mistry, Nishant C > Subject: [Patch v2 03/28] MdeModulePkg: Update AUTH

Re: [edk2-devel] [Patch v2 01/28] MdeModulePkg: Add new GUID for Variable Store Info

2022-05-12 Thread Wang, Jian J
Reviewed-by: Jian J Wang Regards, Jian > -Original Message- > From: Vang, Judah > Sent: Saturday, April 30, 2022 2:04 AM > To: devel@edk2.groups.io > Cc: Wang, Jian J ; Gao, Liming > ; Mistry, Nishant C > Subject: [Patch v2 01/28] MdeModulePkg: Add new GUID fo

Re: [edk2-devel] [Patch v2 04/28] MdeModulePkg: Add reference to new Ppi Guid

2022-05-12 Thread Wang, Jian J
Reviewed-by: Jian J Wang Regards, Jian > -Original Message- > From: Vang, Judah > Sent: Saturday, April 30, 2022 2:04 AM > To: devel@edk2.groups.io > Cc: Wang, Jian J ; Gao, Liming > ; Mistry, Nishant C > Subject: [Patch v2 04/28] MdeModulePkg: Add reference to

Re: [edk2-devel] [Patch v2 05/28] MdeModulePkg: Add new ProtectedVariable GUIDs

2022-05-12 Thread Wang, Jian J
Reviewed-by: Jian J Wang Regards, Jian > -Original Message- > From: Vang, Judah > Sent: Saturday, April 30, 2022 2:04 AM > To: devel@edk2.groups.io > Cc: Wang, Jian J ; Gao, Liming > ; Mistry, Nishant C > Subject: [Patch v2 05/28] MdeModulePkg: Add new ProtectedVa

Re: [edk2-devel] [Patch v2 06/28] MdeModulePkg: Add new include files

2022-05-12 Thread Wang, Jian J
Hi Judah, Please check my comments inlined below. Regards, Jian > -Original Message- > From: Vang, Judah > Sent: Saturday, April 30, 2022 2:04 AM > To: devel@edk2.groups.io > Cc: Wang, Jian J ; Gao, Liming > ; Mistry, Nishant C > Subject: [Patch v2 06/28] MdeModul

Re: [edk2-devel] [PATCH] Bug 3898 - S3 Resume result in executing garbage address

2022-04-25 Thread Wang, Jian J
Reviewed-by: Jian J Wang Regards, Jian > -Original Message- > From: devel@edk2.groups.io On Behalf Of cbduggap > Sent: Monday, April 25, 2022 12:39 PM > To: devel@edk2.groups.io > Subject: [edk2-devel] [PATCH] Bug 3898 - S3 Resume result in executing garbage > address > > In Release

Re: [edk2-devel] [PATCH v1 1/1] MdeModulePkg: PiSmmCore: Inspect memory guarded with pool headers

2022-04-21 Thread Wang, Jian J
It looks good to me. Thanks for fixing it. Reviewed-by: Jian J Wang Regards, Jian > -Original Message- > From: devel@edk2.groups.io On Behalf Of Kun Qin > Sent: Wednesday, March 16, 2022 12:00 PM > To: devel@edk2.groups.io > Cc: Yao, Jiewen ; Dong, Eric ; Ni, >

Re: [edk2-devel] [PATCH] MdeModulePkg/dec: update the PcdCpuStackGuard property

2022-04-11 Thread Wang, Jian J
Reviewed-by: Jian J Wang Regards, Jian > -Original Message- > From: Chen, Gang C > Sent: Friday, April 08, 2022 11:52 AM > To: devel@edk2.groups.io > Cc: Jiang, Guomin ; Bi, Dandan > ; Zhang, Di ; Wang, Jian J > ; Gao, Liming ; Dong, Eric > ; Ni, Ray > Su

Re: [edk2-devel] 回复: [PATCH v1 01/28] MdeModulePkg: Add a new GUID

2022-03-29 Thread Wang, Jian J
it and use it to give summary description for the whole patch series. Regards, Jian > -Original Message- > From: devel@edk2.groups.io On Behalf Of gaoliming > Sent: Monday, March 28, 2022 4:55 PM > To: Vang, Judah ; devel@edk2.groups.io > Cc: Wang, Jian J ; Mistry, Nishant

Re: [edk2-devel] [PATCH v1 02/28] SecurityPkg: Add new GUIDs

2022-03-29 Thread Wang, Jian J
ay, March 26, 2022 7:21 AM > To: devel@edk2.groups.io > Cc: Wang, Jian J ; Yao, Jiewen ; > Mistry, Nishant C > Subject: [PATCH v1 02/28] SecurityPkg: Add new GUIDs > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2594 > > Add new GUIDs > > Cc: Jian J Wang &

Re: [edk2-devel] [PATCH v1 01/28] MdeModulePkg: Add a new GUID

2022-03-28 Thread Wang, Jian J
Reviewed-by: Jian J Wang Regards, Jian > -Original Message- > From: Vang, Judah > Sent: Saturday, March 26, 2022 6:03 AM > To: devel@edk2.groups.io > Cc: Wang, Jian J ; Gao, Liming > ; Mistry, Nishant C > Subject: [PATCH v1 01/28] MdeModulePkg: Add a new

Re: [edk2-devel] [PATCH V8 35/47] MdeModulePkg: Skip setting IA32_ERER.NXE if it has already been set

2022-03-14 Thread Wang, Jian J
Reviewed-by: Jian J Wang Regards, Jian > -Original Message- > From: Xu, Min M > Sent: Saturday, March 12, 2022 9:54 AM > To: devel@edk2.groups.io > Cc: Xu, Min M ; Wang, Jian J ; > Wu, Hao A ; Brijesh Singh ; > Aktas, Erdem ; James Bottomley > ; Yao, Jiewen

Re: [edk2-devel] [PATCH V8 36/47] MdeModulePkg: Add PcdTdxSharedBitMask

2022-03-14 Thread Wang, Jian J
Reviewed-by: Jian J Wang Regards, Jian > -Original Message- > From: Xu, Min M > Sent: Saturday, March 12, 2022 9:54 AM > To: devel@edk2.groups.io > Cc: Xu, Min M ; Wang, Jian J ; > Wu, Hao A ; Brijesh Singh ; > Aktas, Erdem ; James Bottomley > ; Yao, Jiewen

Re: [edk2-devel] [PATCH V7 25/37] MdeModulePkg: EFER should not be changed in TDX

2022-03-03 Thread Wang, Jian J
Ok for me. Regards, Jian > -Original Message- > From: Xu, Min M > Sent: Friday, March 04, 2022 8:19 AM > To: Wang, Jian J ; devel@edk2.groups.io > Cc: Wu, Hao A ; Brijesh Singh ; > Aktas, Erdem ; James Bottomley > ; Yao, Jiewen ; Tom Lendacky > ; Gerd Hoffmann

Re: [edk2-devel] [PATCH V7 26/37] MdeModulePkg: Add PcdTdxSharedBitMask

2022-03-02 Thread Wang, Jian J
age- > From: Xu, Min M > Sent: Monday, February 28, 2022 3:21 PM > To: devel@edk2.groups.io > Cc: Xu, Min M ; Wang, Jian J ; > Wu, Hao A ; Brijesh Singh ; > Aktas, Erdem ; James Bottomley > ; Yao, Jiewen ; Tom Lendacky > ; Gerd Hoffmann > Subject: [PAT

Re: [edk2-devel] [PATCH V7 25/37] MdeModulePkg: EFER should not be changed in TDX

2022-03-02 Thread Wang, Jian J
age- > From: Xu, Min M > Sent: Monday, February 28, 2022 3:21 PM > To: devel@edk2.groups.io > Cc: Xu, Min M ; Wang, Jian J ; > Wu, Hao A ; Brijesh Singh ; > Aktas, Erdem ; James Bottomley > ; Yao, Jiewen ; Tom Lendacky > ; Gerd Hoffmann > Subject: [PATCH V7 25/37] MdeModuleP

Re: [edk2-devel][PATCH] edk2/MdeModulePkg/Debuglib: Add Standalone MM support

2022-02-28 Thread Wang, Jian J
Reviewed-by: Jian J Wang Regards, Jian > -Original Message- > From: Jiang, Xiaolu > Sent: Friday, February 25, 2022 9:56 AM > To: devel@edk2.groups.io > Cc: Jiang, Xiaolu ; Wang, Jian J > ; Gao, Liming > Subject: [edk2-devel][PATCH] edk2/MdeModulePkg/Debuglib

Re: [edk2-devel] [PATCH] edk2/MdeModulePkg/Debuglib: Add Standalone MM support

2022-02-24 Thread Wang, Jian J
, Xiaolu ; Wang, Jian J > ; Gao, Liming > Subject: [edk2-devel] [PATCH] edk2/MdeModulePkg/Debuglib: Add Standalone > MM support > > https://bugzilla.tianocore.org/show_bug.cgi?id=3844 > > This change added Standalone MM instance of DebugLib. > > Cc: Jian J Wang > Cc:

Re: [edk2-devel] Uncrustify Conversion Detailed Plan and Extended Hard Freeze Update #4

2021-12-06 Thread Wang, Jian J
For CryptoPkg, SecurityPkg and SignedCapsulePkg, Reviewed-by: Jian J Wang Regards, Jian > -Original Message- > From: devel@edk2.groups.io On Behalf Of Michael D > Kinney > Sent: Monday, December 06, 2021 9:18 AM > To: Michael Kubacki ; devel@edk2.groups.io; >

Re: [edk2-devel] Uncrustify Conversion Detailed Plan and Extended Hard Freeze Update #4

2021-11-30 Thread Wang, Jian J
For SignedCapulePkg, Reviewed-by: Jian J Wang Regards, Jian > -Original Message- > From: devel@edk2.groups.io On Behalf Of Michael D > Kinney > Sent: Wednesday, December 01, 2021 6:34 AM > To: devel@edk2.groups.io; Kinney, Michael D ; > Michael Kubacki ; Andrew Fish >

Re: [edk2-devel] Uncrustify Conversion Detailed Plan and Extended Hard Freeze Update #4

2021-11-30 Thread Wang, Jian J
For SecurityPkg and CryptoPkg, Reviewed-by: Jian J Wang Regards, Jian > -Original Message- > From: devel@edk2.groups.io On Behalf Of Michael D > Kinney > Sent: Wednesday, December 01, 2021 6:34 AM > To: devel@edk2.groups.io; Kinney, Michael D ; > Michael Kubacki ; Andrew Fish >

Re: [edk2-devel] [Patch 04/12] CryptoPkg: Update YAML to ignore specific ECC files/errors

2021-11-27 Thread Wang, Jian J
Reviewed-by: Jian J Wang Regards, Jian > -Original Message- > From: Kinney, Michael D > Sent: Wednesday, November 24, 2021 5:21 AM > To: devel@edk2.groups.io > Cc: Yao, Jiewen ; Wang, Jian J ; > Lu, XiaoyuX ; Jiang, Guomin ; > Sean Brogan ; Bret Barkelew >

Re: [edk2-devel][PATCH v4] MdeModulePkg/DxeCapsuleLibFmp: Use new Variable Lock interface

2021-11-02 Thread Wang, Jian J
Just a format issue (see inline comment). With it addressed, Reviewed-by: Jian J Wang Regards, Jian > -Original Message- > From: devel@edk2.groups.io On Behalf Of Yang Jie > Sent: Friday, October 29, 2021 11:10 AM > To: devel@edk2.groups.io > Cc: Wang, Jian J

Re: [edk2-devel] [PATCH v2 1/1] SecurityPkg/FvReportPei: Remove the ASSERT to allow neither M nor V

2021-10-28 Thread Wang, Jian J
Reviewed-by: Jian J Wang Regards, Jian > -Original Message- > From: Jiang, Guomin > Sent: Friday, October 15, 2021 12:31 PM > To: devel@edk2.groups.io > Cc: Yao, Jiewen ; Wang, Jian J > Subject: [PATCH v2 1/1] SecurityPkg/FvReportPei: Remove the ASSERT to allow

Re: [edk2-devel] [PATCH v6 1/3] MdeModulePkg/SortLib: Add QuickSort function on BaseLib

2021-10-19 Thread Wang, Jian J
Reviewed-by: Jian J Wang Regards, Jian > -Original Message- > From: Kuo, IanX > Sent: Monday, October 18, 2021 12:21 PM > To: devel@edk2.groups.io > Cc: Chan, Amy ; Ni, Ray ; Kuo, IanX > ; Wang, Jian J ; Liming Gao > > Subject: [PATCH v6 1/3] MdeModulePk

Re: [edk2-devel] [PATCH v3] MdeModulePkg/Core/Dxe: Acquire a lock when iterating gHandleList

2021-10-13 Thread Wang, Jian J
Reviewed-by: Jian J Wang Regards, Jian > -Original Message- > From: Ma, Hua > Sent: Wednesday, October 13, 2021 3:45 PM > To: devel@edk2.groups.io > Cc: Ma, Hua ; Wang, Jian J ; > Liming Gao ; Bi, Dandan ; > Ni, Ray > Subject: [PATCH v3] MdeModulePkg/Core/

Re: [edk2-devel] [PATCH v2] MdeModulePkg/Core/Dxe: Acquire a lock when iterating gHandleList

2021-10-12 Thread Wang, Jian J
t; To: devel@edk2.groups.io > Cc: Ma, Hua ; Wang, Jian J ; > Liming Gao ; Bi, Dandan ; > Ni, Ray > Subject: [PATCH v2] MdeModulePkg/Core/Dxe: Acquire a lock when iterating > gHandleList > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3680 > > This patch fix

Re: [edk2-devel] [PATCH V2 1/1] SecurityPkg: Add debug log for indicating IBB verified OBB successfully

2021-09-16 Thread Wang, Jian J
Reviewed-by: Jian J Wang Regards, Jian > -Original Message- > From: Yang, Longlong > Sent: Friday, September 17, 2021 10:51 AM > To: devel@edk2.groups.io > Cc: Yang, Longlong ; Yao, Jiewen > ; Wang, Jian J ; Xu, Min M > ; Zhang, Qi1 > Subject: [PATCH V2 1/1] Se

Re: [edk2-devel] [PATCH] MdeModulePkg PCD: FSP NotifyPhase APIs caused 100ms delay

2021-08-11 Thread Wang, Jian J
Reviewed-by: Jian J Wang Regards, Jian > -Original Message- > From: Yeh, GregX > Sent: Monday, August 09, 2021 10:28 AM > To: devel@edk2.groups.io > Cc: Wang, Jian J ; Wu, Hao A ; > Bi, Dandan ; Liming Gao > Subject: [PATCH] MdeModulePkg PCD: FSP NotifyPhase AP

Re: [edk2-devel] [RFC] MemoryProtectionLib for Dynamic Memory Guard Settings

2021-07-28 Thread Wang, Jian J
.@linux.microsoft.com; Wang, Jian J ; Wu, > Hao A ; Bi, Dandan ; > gaolim...@byosoft.com.cn; Dong, Guo ; Ma, Maurice > ; You, Benjamin > Subject: [RFC] MemoryProtectionLib for Dynamic Memory Guard Settings > > Current memory protection settings rely on FixedAtBuild PCD val

Re: [edk2-devel] [PATCHV2] CryptoPkg/BaseCryptLib: Enabled CryptSha512 for Smm/Runtime drivers

2021-06-23 Thread Wang, Jian J
Pushed at eba32695ee6979137c86c3d20d0711d49d5c3ba8 Regards, Jian > -Original Message- > From: Yao, Jiewen > Sent: Thursday, June 24, 2021 10:06 AM > To: devel@edk2.groups.io; gaolim...@byosoft.com.cn; Xue, Shengfeng > ; Wang, Jian J > Cc: Xue, ShengfengX > Sub

Re: [edk2-devel] [PATCH] SecurityPkg: TcgStorageOpalLib: Initialize SupportedAttributes parameter.

2021-06-15 Thread Wang, Jian J
Acked-by: Jian J Wang > -Original Message- > From: Kuo, Scottie > Sent: Tuesday, June 01, 2021 5:26 PM > To: Yao, Jiewen ; devel@edk2.groups.io; Wang, Jian J > > Cc: Zhang, Qi1 ; Kumar, Rahul1 > ; Chu, Maggie > Subject: RE: [PATCH] SecurityPkg: TcgSt

Re: [edk2-devel] [PATCH v1 3/3] CryptoPkg/BaseCryptLib: Fix possible uninitialized use

2021-05-18 Thread Wang, Jian J
Ard, Patch 1&2 haven't got r-b. I'm not sure we can merge patch 3 separately. Regards, Jian > -Original Message- > From: Ard Biesheuvel > Sent: Tuesday, May 18, 2021 3:27 PM > To: edk2-devel-groups-io ; Liming Gao (Byosoft address) > > Cc: ser...@posteo.net; Yao,

Re: [edk2-devel] [PATCH v3 1/1] CryptoPkg: BaseCryptLib: Add RSA PSS verify support

2021-05-13 Thread Wang, Jian J
Pushed at 22ac5cc9d9db34056f7c97e994fd9def683ebb2e Regards, Jian > -Original Message- > From: Yao, Jiewen > Sent: Wednesday, May 05, 2021 10:09 AM > To: Agrawal, Sachin ; devel@edk2.groups.io > Cc: Wang, Jian J ; Lu, XiaoyuX ; > Jiang, Guomin > Subject: RE: [PA

Re: [edk2-devel] [Patch v2 2/4] CryptoPkg/Library/Include: Allow CPU specific defines to be predefined

2021-04-15 Thread Wang, Jian J
Reviewed-by: Jian J Wang Regards, Jian > -Original Message- > From: Kinney, Michael D > Sent: Wednesday, April 14, 2021 11:28 AM > To: devel@edk2.groups.io > Cc: Yao, Jiewen ; Wang, Jian J ; > Lu, XiaoyuX ; Jiang, Guomin ; > Andrew Fish ; Abner Chang >

Re: [edk2-devel] [PATCH EDK2 v2 1/1] SecurityPkg/FvReportPei: remove redundant sizeof

2021-04-13 Thread Wang, Jian J
Yes, it's a typo. Thanks for fixing it. Reviewed-by: Jian J Wang Regards, Jian > -Original Message- > From: Yao, Jiewen > Sent: Wednesday, April 14, 2021 9:56 AM > To: devel@edk2.groups.io; xiewen...@huawei.com; Wang, Jian J > ; ler...@redhat.com > Cc: songdo

Re: [edk2-devel] [PATCH v2 1/1] SecurityPkg/Tcg2Smm: Initialize local Status variable

2021-04-12 Thread Wang, Jian J
Pushed @ 54211ab10fcd8532b49f4024ebdb601a8eb07e3e Regards, Jian > -Original Message- > From: Michael Kubacki > Sent: Tuesday, April 13, 2021 1:54 AM > To: devel@edk2.groups.io; ler...@redhat.com > Cc: Yao, Jiewen ; Wang, Jian J ; > Zhang, Qi1 ; Kumar, Rahul1 ; > K

Re: [edk2-devel] [PATCH] CryptoPkg/OpensslLib: Upgrade OpenSSL to 1.1.1j

2021-03-18 Thread Wang, Jian J
k2.groups.io > Cc: Liu, WeiX C ; Wang, Jian J > Subject: [PATCH] CryptoPkg/OpensslLib: Upgrade OpenSSL to 1.1.1j > > From: Liu Wei > > Update openssl from 1.1.1g to 1.1.1j. Current OpenSSL version > 1.1.1g contains the vulnerabilities of CVE-2021-23841 and > CVE-20

Re: [edk2-devel] [PATCH v7 00/14] Add the VariablePolicy feature

2020-09-22 Thread Wang, Jian J
.groups.io On Behalf Of Bret > Barkelew > Sent: Friday, August 28, 2020 1:51 PM > To: devel@edk2.groups.io > Cc: Yao, Jiewen ; Chao Zhang > ; Wang, Jian J ; Wu, Hao A > ; Gao, Liming ; Justen, Jordan L > ; Laszlo Ersek ; Ard Biesheuvel > ; Andrew Fish ; Ni, Ray > > Su

Re: [edk2-devel] [PATCH v6 00/14] Add the VariablePolicy feature

2020-09-14 Thread Wang, Jian J
, Jian From: Bret Barkelew Sent: Friday, September 11, 2020 11:18 PM To: devel@edk2.groups.io; b...@corthon.com; Wang, Jian J Cc: Yao, Jiewen ; Zhang, Chao B ; Wang, Jian J ; Wu, Hao A ; Gao, Liming ; Justen, Jordan L ; Laszlo Ersek ; Ard Biesheuvel ; Andrew Fish ; Ni, Ray Subject: RE: [edk2

Re: [edk2-devel] [PATCH] SecurityPkg/DxeImageVerificationLib: Disable SHA1 base on MACRO

2020-09-06 Thread Wang, Jian J
Reviewed-by: Jian J Wang Regards, Jian > -Original Message- > From: Gao, Zhichao > Sent: Monday, August 31, 2020 1:13 PM > To: devel@edk2.groups.io > Cc: Yao, Jiewen ; Wang, Jian J ; > Xu, Min M ; Zhang, Qi1 > Subject: [PATCH] SecurityPkg/DxeImageVerificationL

Re: [edk2-devel] [PATCH v3] MdeModulePkg/Library: add PEIM and SEC module type to TpmMeasurementLibNull

2020-09-02 Thread Wang, Jian J
Reviewed-by: Jian J Wang Regards, Jian > -Original Message- > From: Zhang, Qi1 > Sent: Tuesday, September 01, 2020 3:26 PM > To: devel@edk2.groups.io > Cc: Zhang, Qi1 ; Wang, Jian J ; > Wu, Hao A ; Yao, Jiewen ; > Laszlo Ersek > Subject: [PATCH v3] MdeMod

Re: [edk2-devel] [PATCH] MdeModulePkg/Library: change TpmMeasurementLibNull to BASE library.

2020-08-29 Thread Wang, Jian J
Reviewed-by: Jian J Wang Regards, Jian > -Original Message- > From: Zhang, Qi1 > Sent: Friday, August 28, 2020 2:15 PM > To: devel@edk2.groups.io > Cc: Zhang, Qi1 ; Wang, Jian J ; > Wu, Hao A ; Yao, Jiewen > Subject: [PATCH] MdeModulePkg/Library: change

Re: [edk2-devel] [Patch] SecurityPkg/OpalPassword: Fix spelling mistake

2020-08-18 Thread Wang, Jian J
Reviewed-by: Jian J Wang Regards, Jian > -Original Message- > From: devel@edk2.groups.io On Behalf Of Michael D > Kinney > Sent: Saturday, August 01, 2020 9:21 AM > To: devel@edk2.groups.io > Cc: Zhang, Qi1 ; Kumar, Rahul1 > > Subject: [edk2-devel] [Patch] SecurityPkg/OpalPassword:

Re: [edk2-devel] [Patch 5/6] SecurityPkg: Fix spelling mistake for occurred

2020-08-18 Thread Wang, Jian J
Reviewed-by: Jian J Wang Regards, Jian > -Original Message- > From: devel@edk2.groups.io On Behalf Of Michael D > Kinney > Sent: Saturday, August 01, 2020 9:05 AM > To: devel@edk2.groups.io > Cc: Zhang, Qi1 ; Kumar, Rahul1 > > Subject: [edk2-devel] [Patch 5/6] SecurityPkg: Fix

[edk2-devel] [PATCH] CryptoPkg/BaseCryptLib: add crypto algorithms needed by variable protection

2020-08-17 Thread Wang, Jian J
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2594 Crypto algorithms, hkdf-sha256/hmac-sha256/aes, are needed to verify integrity of variable data, derive hmac and encryption keys, and encrypt/decrypt varible. Replacing null version source code with real implementations makes sure we can

Re: [edk2-devel] [PATCH EDK2 v2 1/1] SecurityPkg/DxeImageVerificationLib:Enhanced verification of Offset

2020-08-17 Thread Wang, Jian J
way is really safe. Regards, Jian > -Original Message- > From: devel@edk2.groups.io On Behalf Of Laszlo Ersek > Sent: Tuesday, August 18, 2020 12:53 AM > To: Yao, Jiewen ; devel@edk2.groups.io; > xiewen...@huawei.com; Wang, Jian J > Cc: huangmin...@huawei.com; songdon

Re: [edk2-devel] [edk2-wiki][PATCH v3] Update the Boot Guard TOCTOU wiki page.

2020-08-17 Thread Wang, Jian J
Reviewed-by: Jian J Wang Regards, Jian > -Original Message- > From: devel@edk2.groups.io On Behalf Of Guomin > Jiang > Sent: Wednesday, August 12, 2020 3:21 PM > To: devel@edk2.groups.io > Cc: Wang, Jian J ; Gao, Liming > Subject: [edk2-devel] [edk2-wiki][PATC

Re: [edk2-devel] [PATCH v3 0/8] Need add a FSP binary measurement

2020-08-17 Thread Wang, Jian J
For the whole series, Reviewed-by: Jian J Wang Regards, Jian > -Original Message- > From: Zhang, Qi1 > Sent: Friday, August 14, 2020 2:32 PM > To: devel@edk2.groups.io > Cc: Zhang, Qi1 ; Yao, Jiewen ; > Wang, Jian J ; Wu, Hao A ; Chiu, > Chasel ;

  1   2   3   4   5   >