Cc: Rebecca Cran
Cc: Liming Gao
Cc: Bob Feng
Signed-off-by: Yuwei Chen
---
BaseTools/Source/Python/FMMT/FMMT.py | 2 ++
1 file changed, 2 insertions(+)
diff --git a/BaseTools/Source/Python/FMMT/FMMT.py
b/BaseTools/Source/Python/FMMT/FMMT.py
index 26fc4c5792..d9f1c265a7 100644
Reviewed-by: Yuwei Chen
> -Original Message-
> From: Yang, Yuting2
> Sent: Wednesday, March 27, 2024 4:43 PM
> To: devel@edk2.groups.io
> Cc: Rebecca Cran ; Liming Gao
> ; Feng, Bob C ; Chen,
> Christine
> Subject: [Patch V2] [edk2-staging] BaseTools:
Ali, please also create PR in BaseTools repo.
Reviewed-by: Yuwei Chen
> -Original Message-
> From: S, Ashraf Ali
> Sent: Wednesday, February 28, 2024 5:57 PM
> To: devel@edk2.groups.io
> Cc: S, Ashraf Ali ; Rebecca Cran
> ; Liming Gao ; Feng, Bob
> C ; Chen, C
Thanks a lot Rebecca~~
Thanks,
Christine
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Michael
> D Kinney
> Sent: Saturday, February 17, 2024 1:24 AM
> To: Rebecca Cran ; Joey Vagedes
> ; Rebecca Cran
> ; devel@edk2.groups.io; Sean
> ; Michael Kubacki
>
> Cc: Kinney,
> > C ; Yang, Yuting2 ;
> > Hartung, Stephen
> > Subject: Re: [edk2-devel] [edk2-stable202311][PATCH] BaseTools: Python
> > VfrCompiler implementation
> >
> > On Thu, Dec 7, 2023 at 9:08 AM Yuwei Chen
> wrote:
> > >
> > > Hi Liming,
ssion issue? Or does it resolve new usage? I am curious why it
is not reported before.
Thanks
Liming
> -邮件原件-
> 发件人: devel@edk2.groups.io<mailto:devel@edk2.groups.io>
> mailto:devel@edk2.groups.io>> 代表 Yuwei Chen
> 发送时间: 2024年1月8日 13:37
> 收件人: devel@edk2.
Hi Liming and Cran,
We should merge this fixing patch asap as it influences BaseTool's usage.
Thanks,
Christine
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Yuwei
> Chen
> Sent: Monday, January 8, 2024 9:16 AM
> To: Joey Vagedes ; devel@edk2.groups.i
Hi Joey,
Thanks for fixing.
Reviewed-by: Yuwei Chen
> -Original Message-
> From: Joey Vagedes
> Sent: Friday, December 29, 2023 12:48 AM
> To: devel@edk2.groups.io
> Cc: Rebecca Cran ; Gao, Liming
> ; Feng, Bob C ; Chen,
> Christine
> Subject: [PATCH v1
Reviewed-by: Yuwei Chen
> -Original Message-
> From: S, Ashraf Ali
> Sent: Monday, December 25, 2023 11:28 PM
> To: devel@edk2.groups.io
> Cc: S, Ashraf Ali ; Chen, Christine
> ; Rebecca Cran ; Gao, Liming
> ; Feng, Bob C ; Chan,
> Amy ; Chaganty, Rangasa
Reviewed-by: Yuwei Chen
> -Original Message-
> From: Liu, Liqi
> Sent: Tuesday, December 12, 2023 4:42 PM
> To: devel@edk2.groups.io
> Cc: Liu, Liqi ; Chen, Christine ;
> Feng, Bob C ; Chaganty, Rangasai V
> ; Gao, Liming
> Subject: [PATCH V2 1/1] Silicon
Edk2-basetools repo PR link:
https://github.com/tianocore/edk2-basetools/pull/100
Thanks,
Christine
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Yuwei
> Chen
> Sent: Friday, December 15, 2023 5:12 PM
> To: devel@edk2.groups.io
> Cc: Rebecca Cran ; Ga
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4624
Currently, Python FMMT tool does not support automatically
select FMMTConf.ini file which saves GuidTool settings.
This patch supports this features.
Cc: Rebecca Cran
Cc: Liming Gao
Cc: Bob Feng
Signed-off-by: Yuwei Chen
+Cc Yang, Yuting2
> -Original Message-
> From: Yang, Yuting2
> Sent: Tuesday, December 12, 2023 5:01 PM
> To: devel@edk2.groups.io
> Cc: Rebecca Cran ; Gao, Liming
> ; Feng, Bob C ; Chen,
> Christine
> Subject: [Patch V2] BaseTools: VfrCompiler Adds DefaultValueError Feature
>
> Add
gt; Feng, Bob C
> > > Cc: 'Rebecca Cran' ; Guo, Gua
>
> > > Subject: 回复: [edk2-devel] [Patch V2 1/4] BaseTools: fixing FMMT
> > ShrinkFv
> > > issue
> > >
> > > Yuwei:
> > > Please update commit message with reviewed-by info,
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#112216): https://edk2.groups.io/g/devel/message/112216
Mute This Topic: https://groups.io/mt/103051162/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe:
Hi Liming,
Is this feature been tested and reviewed these two weeks?
Thanks,
Christine
From: devel@edk2.groups.io On Behalf Of Yuwei Chen
Sent: Monday, November 13, 2023 8:32 AM
To: Gao, Liming ; 'Rebecca Cran' ;
Gao, Liming ; Zimmer, Vincent
; Kinney, Michael D ;
'Leif Lindholm' ; 'Andrew
d push
> label for this patch set.
>
> Thanks
> Liming
> > -----邮件原件-
> > 发件人: devel@edk2.groups.io 代表 Yuwei Chen
> > 发送时间: 2023年11月29日 16:26
> > 收件人: Gao, Liming ; Feng, Bob C
> >
> > 抄送: 'Rebecca Cran' ; devel@edk2.groups.io; Chen,
> > Christ
Hi Liming and Cran,
I have created the Edk2 PR for this one:
https://github.com/tianocore/edk2/pull/5009
As it has been reviewed, please help merge that. Thanks~
Thanks,
Yuwei (Christine)
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Yuwei
> Chen
>
Reviewed-by: Yuwei Chen
> -Original Message-
> From: mikub...@linux.microsoft.com
> Sent: Wednesday, November 29, 2023 3:49 AM
> To: devel@edk2.groups.io
> Cc: Feng, Bob C ; Gao, Liming
> ; Rebecca Cran ; Chen,
> Christine
> Subject: [PATCH v1 1/1] BaseTools/C
i
> Mujawar ; yeoreum@arm.com
> Subject: RE: [edk2-devel] [PATCH 1/1] BaseTools/Scripts/PatchCheck.py: Check
> for Change-id
>
> It's good. But I am curious why --ignore-change-id is needed?
>
> Thanks,
> Ray
> > -Original Message-
> > From: d
The patch is good for me.
Reviewed-by: Yuwei Chen
> -Original Message-
> From: Pierre Gondois
> Sent: Wednesday, November 22, 2023 9:15 PM
> To: devel@edk2.groups.io
> Cc: Rebecca Cran ; Gao, Liming
> ; Feng, Bob C ; Chen,
> Christine ; Sami Mujawar
> ; yeore
Hi Liming,
I know your point. Would you like to start reviewing it and give us more
feedbacks? We really hope it can be merged as soon as possible.
We can do the merging after the stable tag, but just like you said, maybe we
need to review it firstly.
Looking forward to your feedbacks, and I
Reviewed-by: Yuwei Chen
> -Original Message-
> From: mikub...@linux.microsoft.com
> Sent: Wednesday, October 18, 2023 9:05 AM
> To: devel@edk2.groups.io
> Cc: Feng, Bob C ; Gao, Liming
> ; Kinney, Michael D
> ; Rebecca Cran ; Sean
> Brogan ; Chen, Christine
>
As the error is changed to warning, Trim.py will skip the build
error when the source code have exactly issue.
This patch change warning to error to opens the checking.
Cc: Rebecca Cran
Cc: Liming Gao
Cc: Bob Feng
Signed-off-by: Yuwei Chen
---
BaseTools/Source/Python/Trim/Trim.py | 4 ++--
1
Reviewed-by: Yuwei Chen
> -Original Message-
> From: Srinivasan, ManickamX
> Sent: Wednesday, September 13, 2023 4:56 PM
> To: devel@edk2.groups.io
> Cc: Srinivasan, ManickamX ; Feng, Bob C
> ; Gao, Liming ; Chen,
> Christine ; T V, Krishnamoorthy
>
> Subj
n, Christine
> > Sent: Thursday, June 29, 2023 11:34 AM
> > To: devel@edk2.groups.io
> > Cc: Rebecca Cran ; Gao, Liming
> > ; Feng, Bob C
> > Subject: [Patch V2 1/4] BaseTools: fixing FMMT ShrinkFv issue
> >
> > 1. FvLength not change issue;
> > 2. FileS
Reviewed-by: Yuwei Chen
> -Original Message-
> From: Srinivasan, ManickamX
> Sent: Wednesday, August 23, 2023 3:29 PM
> To: devel@edk2.groups.io
> Cc: Srinivasan, ManickamX ; Feng, Bob C
> ; Gao, Liming ; Chen,
> Christine ; T V, Krishnamoorthy
>
> Subj
Cc: Rebecca Cran
Cc: Liming Gao
Cc: Bob Feng
Signed-off-by: Yuwei Chen
---
BaseTools/BinPipWrappers/PosixLike/FMMT | 12
BaseTools/BinPipWrappers/WindowsLike/FMMT.bat | 3 +++
2 files changed, 15 insertions(+)
create mode 100755 BaseTools/BinPipWrappers/PosixLike/FMMT
-devel] [Patch V3] [edk2-staging] BaseTools/FMMT: C
> FMMT match new version machine defines
>
> Christine:
> I just push this patch @ bab1724cdf725b7d22869c79fa2b86ed47e01110 in
> edk2-staging.
>
> Thanks
> Liming
> > -邮件原件-
> > 发件人: devel@edk2.gro
>
> Subject: 回复: [Patch V3] [edk2-staging] BaseTools/FMMT: C FMMT match
> new version machine defines
>
> Reviewed-by: Liming Gao
>
> > -邮件原件-
> > 发件人: Yuwei Chen
> > 发送时间: 2023年6月27日 10:54
> > 收件人: devel@edk2.groups.io
> > 抄送: Rebecca Cra
In FMMT replace function, when newffs size <= targetffs size,
the new free space is calculated wrong as loss the pad data delta size.
That will cause invalid binary generated.
This patch fixes this issue.
Cc: Rebecca Cran
Cc: Liming Gao
Cc: Bob Feng
Signed-off-by: Yuwei Chen
---
BaseTo
'''
Cc: Rebecca Cran
Cc: Bob Feng
Cc: Liming Gao
Signed-off-by: Yuwei Chen
---
BaseTools/Source/Python/FMMT/FMMT.py | 2 ++
BaseTools/Source/Python/FMMT/core/BinaryFactoryProduct.py | 36
+++-
BaseTools/Source/Python/FMMT/core/BiosTree.py
For replace function, when target Ffs and new ffs are with
same size, the output file can not be generated successfully.
This patch fixes this issue.
Cc: Rebecca Cran
Cc: Bob Feng
Cc: Liming Gao
Signed-off-by: Yuwei Chen
---
BaseTools/Source/Python/FMMT/core/BiosTree.py | 4 ++--
BaseTools
1. FvLength not change issue;
2. FileSystemGuid align with File Size;
Cc: Rebecca Cran
Cc: Liming Gao
Cc: Bob Feng
Signed-off-by: Yuwei Chen
---
BaseTools/Source/Python/FMMT/core/FMMTOperation.py | 2 +-
BaseTools/Source/Python/FMMT/core/FvHandler.py | 10 +++---
2 files changed, 8
BaseTools have switch from EFI_IMAGE_MACHINE_*
to IMAGE_FILE_MACHINE_*. Thus, match the FCE & FMMT
tool in edk2-staging repo with the new version define.
Cc: Rebecca Cran
Cc: Liming Gao
Cc: Bob Feng
Signed-off-by: Yuwei Chen
---
V3 modify the patch with the correct define
BaseTools/Sour
BaseTools have switch from EFI_IMAGE_MACHINE_*
to IMAGE_FILE_MACHINE_*. Thus, match the FCE & FMMT
tool in edk2-staging repo with the new version define.
Cc: Rebecca Cran
Cc: Liming Gao
Cc: Bob Feng
Signed-off-by: Yuwei Chen
---
BaseTools/Source/C/FMMT/Rebase.c | 12 ++--
1
ming ; Feng, Bob C
>
> Subject: Re: [edk2-devel] [PATCH 1/1] BaseTools: FMMT GuidTool Auto Select
> Config file
>
> That won't work on Unix, where the separator is ':', not ';'.
>
>
> --
>
> Rebecca Cran
>
>
> On 6/5/23 02:12, Yuwei Chen wrote:
> > Cu
BaseTools have switch from EFI_IMAGE_MACHINE_*
to IMAGE_FILE_MACHINE_*. Thus, match the FCE & FMMT
tool in edk2-staging repo with the new version define.
Cc: Rebecca Cran
Cc: Liming Gao
Cc: Bob Feng
Signed-off-by: Yuwei Chen
---
BaseTools/Source/C/FMMT/Rebase.c | 12 ++--
1
Currently, Python FMMT tool does not support automatically
select FMMTConf.ini file which saves GuidTool settings.
This patch support this features.
Cc: Rebecca Cran
Cc: Liming Gao
Cc: Bob Feng
Signed-off-by: Yuwei Chen
---
BaseTools/Source/Python/FMMT/core/GuidTools.py | 2 +-
1 file
For edk2-basetools repo, have made a PR for these three patches:
https://github.com/tianocore/edk2-basetools/pull/95
Thanks,
Christine (Yuwei)
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Yuwei
> Chen
> Sent: Tuesday, April 18, 2023 5:53 PM
> To: devel
'''
Cc: Rebecca Cran
Cc: Bob Feng
Cc: Liming Gao
Signed-off-by: Yuwei Chen
---
BaseTools/Source/Python/FMMT/FMMT.py | 2 ++
BaseTools/Source/Python/FMMT/core/BinaryFactoryProduct.py | 36
+++-
BaseTools/Source/Python/FMMT/core/BiosTree.py
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#103156): https://edk2.groups.io/g/devel/message/103156
Mute This Topic: https://groups.io/mt/98340352/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe:
For replace function, when target Ffs and new ffs are with
same size, the output file can not be generated successfully.
This patch fixes this issue.
Cc: Rebecca Cran
Cc: Bob Feng
Cc: Liming Gao
Signed-off-by: Yuwei Chen
---
BaseTools/Source/Python/FMMT/core/BiosTree.py | 4 ++--
BaseTools
1. FvLength not change issue;
2. FileSystemGuid align with File Size;
Cc: Rebecca Cran
Cc: Liming Gao
Cc: Bob Feng
Signed-off-by: Yuwei Chen
---
BaseTools/Source/Python/FMMT/core/FMMTOperation.py | 2 +-
BaseTools/Source/Python/FMMT/core/FvHandler.py | 10 +++---
2 files changed, 8
Add myself as maintainer for the BaseTools Pkg.
Cc: Michael D Kinney
Cc: Bob Feng
Cc: Liming Gao
Signed-off-by: Yuwei Chen
---
Maintainers.txt | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Maintainers.txt b/Maintainers.txt
index d4607a..463d9567e1 100644
een reviewed for edk2-basetools repo?
>
> Mike
>
> > -Original Message-
> > From: devel@edk2.groups.io On Behalf Of Yuwei
> > Chen
> > Sent: Tuesday, February 14, 2023 6:44 PM
> > To: Palomino Sosa, Guillermo A ;
> > devel@edk2.groups.io
> > C
Reviewed-by: Yuwei Chen
> -Original Message-
> From: Palomino Sosa, Guillermo A
> Sent: Tuesday, February 7, 2023 11:07 AM
> To: devel@edk2.groups.io
> Cc: Feng, Bob C ; Gao, Liming
> ; Chen, Christine
> Subject: [edk2-devel][PATCH V1 1/1] BaseTools: Generate
'''
Cc: Bob Feng
Cc: Liming Gao
Signed-off-by: Yuwei Chen
---
edk2basetools/FMMT/FMMT.py | 2 ++
edk2basetools/FMMT/core/BinaryFactoryProduct.py | 36
+++-
edk2basetools/FMMT/core/BiosTree.py | 49
For replace function, when target Ffs and new ffs are with
same size, the output file can not be generated successfully.
This patch fixes this issue.
Cc: Bob Feng
Cc: Liming Gao
Signed-off-by: Yuwei Chen
---
edk2basetools/FMMT/core/BiosTree.py | 4 ++--
edk2basetools/FMMT/core/FvHandler.py
Add new build option "--gen-default-variable-bin" for Variable
default value generation from Python VFR tool's extended json
output file.
Cc: Bob Feng
Cc: Liming Gao
Signed-off-by: Yuwei Chen
---
BaseTools/Source/Python/AutoGen/DataPipe.py | 2 ++
BaseTools/Source/Pyth
Add new build option "--vfr-yaml-enable" for Python VfrCompiler
extended output yaml file generation.
Cc: Bob Feng
Cc: Liming Gao
Signed-off-by: Yuwei Chen
---
BaseTools/Source/Python/AutoGen/DataPipe.py | 2 ++
BaseTools/Source/Python/AutoGen/ModuleAutoGen.py | 8
Add new build option "--gen-default-variable-bin" for Variable
default value generation from Python VFR tool's extended json
output file.
Cc: Bob Feng
Cc: Liming Gao
Signed-off-by: Yuwei Chen
---
edk2basetools/AutoGen/DataPipe.py | 2 ++
edk2basetools/AutoGen/GenDef
Add new build option "--vfr-yaml-enable" for Python VfrCompiler
extended output yaml file generation.
Cc: Bob Feng
Cc: Liming Gao
Signed-off-by: Yuwei Chen
---
edk2basetools/AutoGen/DataPipe.py | 2 ++
edk2basetools/AutoGen/ModuleAutoGen.py | 8
edk2baseto
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#99275): https://edk2.groups.io/g/devel/message/99275
Mute This Topic: https://groups.io/mt/96622973/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe:
Add new build option "--gen-default-variable-bin" for Variable
default value generation from Python VFR tool's extended json
output file.
Cc: Bob Feng
Cc: Liming Gao
Signed-off-by: Yuwei Chen
---
edk2basetools/AutoGen/DataPipe.py | 2 ++
edk2basetools/AutoGen/GenDef
Add new build option "--vfr-yaml-enable" for Python VfrCompiler
extended output yaml file generation.
Cc: Bob Feng
Cc: Liming Gao
Signed-off-by: Yuwei Chen
---
edk2basetools/AutoGen/DataPipe.py | 2 ++
edk2basetools/AutoGen/ModuleAutoGen.py | 8
edk2baseto
Add new build option "--gen-default-variable-bin" for Variable
default value generation from Python VFR tool's extended json
output file.
Cc: Bob Feng
Cc: Liming Gao
Signed-off-by: Yuwei Chen
---
BaseTools/Source/Python/AutoGen/DataPipe.py | 2 ++
BaseTools/Source/Pyth
Add new build option "--vfr-yaml-enable" for Python VfrCompiler
extended output yaml file generation.
Cc: Bob Feng
Cc: Liming Gao
Signed-off-by: Yuwei Chen
---
BaseTools/Source/Python/AutoGen/DataPipe.py | 2 ++
BaseTools/Source/Python/AutoGen/ModuleAutoGen.py | 8
Add new build option "--gen-default-variable-bin" for Variable
default value generation from Python VFR tool's extended json
output file.
Cc: Bob Feng
Cc: Liming Gao
Signed-off-by: Yuwei Chen
---
BaseTools/Source/Python/AutoGen/DataPipe.py | 2 ++
BaseTools/Source/Pyth
Add new build option "--vfr-yaml-enable" for Python VfrCompiler
extended output yaml file generation.
Cc: Bob Feng
Cc: Liming Gao
Signed-off-by: Yuwei Chen
---
BaseTools/Source/Python/AutoGen/DataPipe.py | 2 ++
BaseTools/Source/Python/AutoGen/ModuleAutoGen.py | 8
Cc Mike.
Thanks,
Christine
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Yuwei
> Chen
> Sent: Tuesday, October 25, 2022 4:51 PM
> To: devel@edk2.groups.io
> Cc: Feng, Bob C ; Gao, Liming
>
> Subject: [edk2-devel] [PATCH] BaseTools: Fix bu
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4081
INF [Sources] section Feature Flag Expressions do not use
override values from build --pcd option currently.
This patch fix this issue.
Cc: Bob Feng
Cc: Liming Gao
Signed-off-by: Yuwei Chen
---
edk2basetools/Workspace/InfBuildData.py
Reviewed-by: Yuwei Chen
> -Original Message-
> From: Feng, Bob C
> Sent: Sunday, October 16, 2022 8:11 PM
> To: devel@edk2.groups.io
> Cc: Feng, Bob C ; Gao, Liming
> ; Chen, Christine
> Subject: [PATCH 1/1] pip-requirement: Upgrade the edk2-basetools version
&g
For replace function, when target Ffs and new ffs are with
same size, the output file can not be generated successfully.
This patch fixes this issue.
Cc: Bob Feng
Cc: Liming Gao
Signed-off-by: Yuwei Chen
---
edk2basetools/FMMT/core/BiosTree.py | 4 ++--
edk2basetools/FMMT/core/FvHandler.py
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3938
This function is used to remove the useless FV free space.
Usage: FMMT -s Inputfile Outputfile
Cc: Bob Feng
Cc: Liming Gao
Signed-off-by: Yuwei Chen
---
BaseTools/Source/Python/FMMT/FMMT.py | 7 +
.../Source/Python/FMMT
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3938
With this patch "-e" parameter supports extract FV function.
Usage: FMMT -e Inputfile TargetFv Outputfile
Cc: Bob Feng
Cc: Liming Gao
Signed-off-by: Yuwei Chen
---
BaseTools/Source/Python/FMMT/FMMT.py | 3 +-
Reviewed-by: Yuwei Chen
> -Original Message-
> From: Feng, Bob C
> Sent: Friday, September 2, 2022 2:18 PM
> To: devel@edk2.groups.io
> Cc: Feng, Bob C ; Gao, Liming
> ; Chen, Christine ;
> Kinney, Michael D
> Subject: [PATCH 1/1] pip-requirement: Upgrade th
Hi Konstantin, this is really an issue need to be solved.
When GenSec tool uses the guidtools to encode the section, it differentiates
how GenCrc32 is used from other tools..
GenSec defines a CRC32_SECTION_HEADER structure for GenCrc32, and calculate the
DataOffset of the Section with this
Reviewed-by: Yuwei Chen
> -Original Message-
> From: Konstantin Aladyshev
> Sent: Monday, July 18, 2022 8:56 PM
> To: devel@edk2.groups.io
> Cc: Feng, Bob C ; Gao, Liming
> ; Chen, Christine ;
> Konstantin Aladyshev
> Subject: [PATCH] BaseTools/VolInfo: Inc
Reviewed-by: Yuwei Chen
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of
> Konstantin Aladyshev
> Sent: Wednesday, July 13, 2022 9:11 PM
> To: devel@edk2.groups.io
> Cc: Feng, Bob C ; Gao, Liming
> ; Chen, Christine ;
> Konstantin Aladyshev
> S
Hi Yi,
Could you describe the bug with an example? In which scenario the dsc defined
pcd will not override the dec definition?
Thanks,
Christine
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of yi1 li
> Sent: Monday, July 11, 2022 1:48 PM
> To: devel@edk2.groups.io
> Cc:
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4003
In some environment, the directly calling for gcc is not supported.
This patch fixes the issue.
Cc: Bob Feng
Cc: Liming Gao
Signed-off-by: Yuwei Chen
---
BaseTools/Source/C/DevicePath/GNUmakefile | 13 -
1 file changed, 8
In some environment, the directly calling for gcc is not supported.
This patch fixes the issue.
Cc: Bob Feng
Cc: Liming Gao
Signed-off-by: Yuwei Chen
---
BaseTools/Source/C/DevicePath/GNUmakefile | 13 -
1 file changed, 8 insertions(+), 5 deletions(-)
diff --git a/BaseTools
this issue.
Cc: Bob Feng
Cc: Liming Gao
Signed-off-by: Yuwei Chen
---
BaseTools/Source/Python/AutoGen/GenMake.py| 2 +-
BaseTools/Source/Python/Workspace/DscBuildData.py | 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/BaseTools/Source/Python/AutoGen/GenMake.py
b
In some environment, the directly calling for gcc is not supported.
Thus replace gcc to $(CC).
Cc: Bob Feng
Cc: Liming Gao
Signed-off-by: Yuwei Chen
---
BaseTools/Source/C/DevicePath/GNUmakefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/BaseTools/Source/C/DevicePath
Reviewed-by: Yuwei Chen
> -Original Message-
> From: Lin, Jason1
> Sent: Friday, July 1, 2022 11:10 PM
> To: devel@edk2.groups.io
> Cc: Lin, Jason1 ; Feng, Bob C ;
> Gao, Liming ; Chen, Christine
> ; Oram, Isaac W ;
> Chaganty, Rangasai V ; Chiang, Dakota
>
Reviewed-by: Yuwei Chen
> -Original Message-
> From: Lin, Jason1
> Sent: Friday, July 1, 2022 11:10 PM
> To: devel@edk2.groups.io
> Cc: Lin, Jason1 ; Feng, Bob C ;
> Gao, Liming ; Chen, Christine
> ; Oram, Isaac W ;
> Chaganty, Rangasai V ; Chiang, Dakota
>
Reviewed-by: Yuwei Chen
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Lin,
> Jason1
> Sent: Friday, July 1, 2022 11:10 PM
> To: devel@edk2.groups.io
> Cc: Lin, Jason1 ; Feng, Bob C ;
> Gao, Liming ; Chen, Christine
> ; Oram, Isaac W ;
> Ch
Reviewed-by: Yuwei Chen
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Bob
> Feng
> Sent: Thursday, June 30, 2022 12:11 PM
> To: devel@edk2.groups.io
> Cc: Kinney, Michael D ; Kubacki, Michael
>
> Subject: [edk2-devel] [Patch V2] pip-requiremen
RCH)] > [LibraryClasses.Common.$(MODULE_TYPE)]
This patch fixes the issue.
Cc: Bob Feng
Cc: Liming Gao
Cc: Long1 Huang
Cc: Ray Ni
Signed-off-by: Yuwei Chen
---
BaseTools/Source/Python/Workspace/DscBuildData.py | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/BaseTools/Source/Python/Wor
Reviewed-by: Yuwei Chen
> -Original Message-
> From: Feng, Bob C
> Sent: Saturday, June 25, 2022 1:12 PM
> To: devel@edk2.groups.io
> Cc: Feng, Bob C ; Gao, Liming
> ; Chen, Christine
> Subject: [Patch] BaseTools: Fix the GenMake bug for .cpp source file
&g
Hi Ayush,
The migration is still working in progress.
In order to ensure the normal use of users, the current bug fixes are still
based on BaseTools in edk2.
After all the migrations are completed, an official notification will be sent,
and the developments and bug fixing works will be
Reviewed-by: Yuwei Chen
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Rebecca
> Cran
> Sent: Monday, June 20, 2022 6:07 AM
> To: devel@edk2.groups.io; Feng, Bob C ; Gao, Liming
> ; Chen, Christine
> Cc: Rebecca Cran
> Subject: [edk2-devel] [
FMMT can be directly used as its compiled binary path saved in PATH,
the FMMT in BaseTools/BinWrappers/PosixLike is useless now.
This patch remove the useless file.
Cc: Bob Feng
Cc: Liming Gao
Signed-off-by: Yuwei Chen
---
BaseTools/BinWrappers/PosixLike/FMMT | 29
Currently the path of compiled FMMT binary is not saved in PATH,
this patch modified FMMT binary path for directly using.
Cc: Bob Feng
Cc: Liming Gao
Signed-off-by: Yuwei Chen
---
BaseTools/Source/C/FMMT/GNUmakefile | 2 +-
BaseTools/Source/C/FMMT/app.makefile | 25
FMMT can be directly used as its compiled binary path saved in PATH,
the FMMT in BaseTools/BinWrappers/PosixLike is useless now.
This patch remove the useless file.
Cc: Bob Feng
Cc: Liming Gao
Signed-off-by: Yuwei Chen
---
BaseTools/BinWrappers/PosixLike/FMMT | 29
Currently the path of compiled FMMT binary is not saved in PATH,
this patch modified FMMT binary path for directly using.
Cc: Bob Feng
Cc: Liming Gao
Signed-off-by: Yuwei Chen
---
BaseTools/Source/C/FMMT/GNUmakefile | 2 +-
BaseTools/Source/C/FMMT/app.makefile | 25
Hi all,
Currently python FMMT tool has finished final tests on several scenarios and
made some functions' optimization. All the changes have already been merged
into edk2-staging PyFMMT branch. Since it have been under review for a long
time Liming has ever given the agreement, I propose to
This patch looks good to me.
Reviewed-by: Yuwei Chen
> -Original Message-
> From: Feng, Bob C
> Sent: Monday, April 4, 2022 11:46 AM
> To: devel@edk2.groups.io
> Cc: Feng, Bob C ; Rebecca Cran
> ; Chen, Christine ; Gerd
> Hoffmann ; Gao, Liming
> Subject: [
hange from GCC5.4, I'd also
> > suggest
> we
> > could create a new TOOL CHAIN for gcc12.
> > The error reports I collected show in gcc5.4 ,
> "-Wno-error=stringop-overflow"
> > is an unrecognized command line option which is available in gcc12.
> >
> >
ine (Yuwei)
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Yuwei
> Chen
> Sent: Thursday, March 31, 2022 8:51 AM
> To: Gerd Hoffmann ; devel@edk2.groups.io
> Cc: Feng, Bob C ; Rebecca Cran
> ; Pawel Polawski ; Oliver
> Steffen ; Gao, Liming
> Su
Hi Hoffmann,
I received some reports that some platforms are using gcc5.4. With this patch,
these platform builds are still broken.
Would you like to revert the original commits?
Thanks,
Christine (Yuwei)
> -Original Message-
> From: Gerd Hoffmann
> Sent: Tuesday, March 29, 2022 4:38
This patch reduces compilation time , it looks good to me.
Reviewed-by: Yuwei Chen
> -Original Message-
> From: Feng, Bob C
> Sent: Tuesday, March 15, 2022 8:17 PM
> To: devel@edk2.groups.io
> Cc: Gao, Liming ; Chen, Christine
>
> Subject: [Patch] BaseTools:
-defined exception class should
be imported.
Signed-off-by: Mingyue Liang
Cc: Bob Feng
Cc: Liming Gao
Cc: Yuwei Chen
---
BaseTools/Source/Python/build/build.py | 2 ++
1 file changed, 2 insertions(+)
diff --git a/BaseTools/Source/Python/build/build.py
b/BaseTools/Source/Python/build/build.py
and Linux systems.
Signed-off-by: Mingyue Liang
Cc: Bob Feng
Cc: Liming Gao
Cc: Yuwei Chen
---
BaseTools/BuildEnv | 24 +---
BaseTools/toolsetup.bat | 6 ++
2 files changed, 27 insertions(+), 3 deletions(-)
diff --git a/BaseTools/BuildEnv b/BaseTools/BuildEnv
index
This patch looks good to me.
Reviewed-by: Yuwei Chen
> -Original Message-
> From: Lou, Yun
> Sent: Monday, January 10, 2022 11:13 PM
> To: devel@edk2.groups.io
> Cc: Lou, Yun ; Feng, Bob C ;
> Gao, Liming ; Chen, Christine
>
> Subject: [PATCH v2 6/6] BaseTo
This patch looks good to me.
Reviewed-by: Yuwei Chen
> -Original Message-
> From: Feng, Bob C
> Sent: Friday, December 24, 2021 10:50 PM
> To: devel@edk2.groups.io
> Cc: Feng, Bob C ; Gao, Liming
> ; Chen, Christine
> Subject: [Patch] BaseTools: Fix the bug of -
oups.io
> Cc: Feng, Bob C
> Subject: 回复: [PATCH 1/1] BaseTools: Fix StructurePcd offset error.
>
> Yuwei:
>
> > -邮件原件-
> > 发件人: Yuwei Chen
> > 发送时间: 2021年10月27日 18:00
> > 收件人: devel@edk2.groups.io
> > 抄送: Bob Feng ; Liming Gao
> >
>
Hi everyone,
I would like to propose the new FMMT Python tool, which is used to replace the
origin C version tool.
Currently the FMMT C tool is saved in edk2-staging repo, but its quality and
coding style can't meet the Edk2 quality, which is hard to maintain
(Hard/Duplicate Code; Regression
Currently when parse VFR files to get the struct info,
BOOLEAN type struct is ignored, which caused offset errors.
This patch fixed these bugs.
Cc: Bob Feng
Cc: Liming Gao
Signed-off-by: Yuwei Chen
---
BaseTools/Scripts/ConvertFceToStructurePcd.py | 4 ++--
1 file changed, 2 insertions(+), 2
1 - 100 of 159 matches
Mail list logo
