Add configuration ExceptionList and IgnoreFiles for package config
files. So users can rely on this to ignore some Ecc issues.
Cc: Jiewen Yao
Cc: Jian J Wang
Cc: Chao Zhang
Signed-off-by: Shenglei Zhang
---
SecurityPkg/SecurityPkg.ci.yaml | 11 +++
1 file changed, 11 insertions(+)
di
Add configuration ExceptionList and IgnoreFiles for package config
files. So users can rely on this to ignore some Ecc issues.
Cc: Eric Dong
Cc: Ray Ni
Cc: Laszlo Ersek
Signed-off-by: Shenglei Zhang
Acked-by: Laszlo Ersek
---
UefiCpuPkg/UefiCpuPkg.ci.yaml | 11 +++
1 file changed, 11
Add configuration ExceptionList and IgnoreFiles for package config
files. So users can rely on this to ignore some Ecc issues.
Cc: Jordan Justen
Cc: Andrew Fish
Cc: Ray Ni
Signed-off-by: Shenglei Zhang
---
EmulatorPkg/EmulatorPkg.ci.yaml | 11 +++
1 file changed, 11 insertions(+)
dif
Add configuration ExceptionList and IgnoreFiles for package config
files. So users can rely on this to ignore some Ecc issues.
Cc: Maciej Rabeda
Cc: Jiaxin Wu
Cc: Siyuan Fu
Signed-off-by: Shenglei Zhang
Reviewed-by: Maciej Rabeda
---
NetworkPkg/NetworkPkg.ci.yaml | 11 +++
1 file cha
Add configuration ExceptionList and IgnoreFiles for package config
files. So users can rely on this to ignore some Ecc issues.
Cc: Ray Ni
Cc: Zhichao Gao
Signed-off-by: Shenglei Zhang
Acked-by: Zhichao gao
---
ShellPkg/ShellPkg.ci.yaml | 11 +++
1 file changed, 11 insertions(+)
diff
Add configuration ExceptionList and IgnoreFiles for package config
files. So users can rely on this to ignore some Ecc issues.
Cc: Ray Ni
Signed-off-by: Shenglei Zhang
Reviewed-by: Guomin Jiang
---
FatPkg/FatPkg.ci.yaml | 11 +++
1 file changed, 11 insertions(+)
diff --git a/FatPkg/Fa
Add configuration ExceptionList and IgnoreFiles for package config
files. So users can rely on this to ignore some Ecc issues.
Cc: Jordan Justen
Cc: Laszlo Ersek
Cc: Ard Biesheuvel
Signed-off-by: Shenglei Zhang
Acked-by: Laszlo Ersek
---
OvmfPkg/OvmfPkg.ci.yaml | 11 +++
1 file chang
Add configuration ExceptionList and IgnoreFiles for package config
files. So users can rely on this to ignore some Ecc issues.
Cc: Michael D Kinney
Cc: Liming Gao
Signed-off-by: Shenglei Zhang
---
MdePkg/MdePkg.ci.yaml | 11 +++
1 file changed, 11 insertions(+)
diff --git a/MdePkg/Mde
Add configuration ExceptionList and IgnoreFiles for package config
files. So users can rely on this to ignore some Ecc issues.
Cc: Jian J Wang
Cc: Hao A Wu
Signed-off-by: Shenglei Zhang
---
MdeModulePkg/MdeModulePkg.ci.yaml | 11 +++
1 file changed, 11 insertions(+)
diff --git a/MdeMo
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2606
As planed we will enable Ecc check for edk2 on open ci. And they are
ready now. I appreciate receiving feedback and comments if someone
find errors or false positive issues.
I created a pipline of EccCheck for my forked edk2.
https://dev.azu
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2606
EccCheck is a plugin to report Ecc issues for code in pull request
, which will be run on open ci.
But note not each kind of issue could be reported out.
It can only handle the issues, whose line number in CSV report
accurately map with their
Add configuration ExceptionList and IgnoreFiles for package config
files. So users can rely on this to ignore some Ecc issues.
Cc: Jian J Wang
Cc: Xiaoyu Lu
Signed-off-by: Shenglei Zhang
Reviewed-by: Guomin Jiang
---
CryptoPkg/CryptoPkg.ci.yaml | 11 +++
1 file changed, 11 insertions(
Add configuration ExceptionList and IgnoreFiles for package config
files. So users can rely on this to ignore some Ecc issues.
Cc: Laszlo Ersek
Cc: Ard Biesheuvel
Cc: Leif Lindholm
Signed-off-by: Shenglei Zhang
Acked-by: Laszlo Ersek
---
ArmVirtPkg/ArmVirtPkg.ci.yaml | 11 +++
1 file
Add configuration ExceptionList and IgnoreFiles for package config
files. So users can rely on this to ignore some Ecc issues.
Cc: Jordan Justen
Cc: Andrew Fish
Cc: Ray Ni
Signed-off-by: Shenglei Zhang
---
EmulatorPkg/EmulatorPkg.ci.yaml | 10 ++
1 file changed, 10 insertions(+)
diff
Add configuration ExceptionList and IgnoreFiles for package config
files. So users can rely on this to ignore some Ecc issues.
Cc: Eric Dong
Cc: Ray Ni
Cc: Laszlo Ersek
Signed-off-by: Shenglei Zhang
Acked-by: Laszlo Ersek
---
UefiCpuPkg/UefiCpuPkg.ci.yaml | 10 ++
1 file changed, 10
Add configuration ExceptionList and IgnoreFiles for package config
files. So users can rely on this to ignore some Ecc issues.
Cc: Ray Ni
Signed-off-by: Shenglei Zhang
---
FatPkg/FatPkg.ci.yaml | 10 ++
1 file changed, 10 insertions(+)
diff --git a/FatPkg/FatPkg.ci.yaml b/FatPkg/FatPkg
Add configuration ExceptionList and IgnoreFiles for package config
files. So users can rely on this to ignore some Ecc issues.
Cc: Maciej Rabeda
Cc: Jiaxin Wu
Cc: Siyuan Fu
Signed-off-by: Shenglei Zhang
Reviewed-by: Maciej Rabeda
---
NetworkPkg/NetworkPkg.ci.yaml | 10 ++
1 file chan
Add configuration ExceptionList and IgnoreFiles for package config
files. So users can rely on this to ignore some Ecc issues.
Cc: Jordan Justen
Cc: Laszlo Ersek
Cc: Ard Biesheuvel
Signed-off-by: Shenglei Zhang
Acked-by: Laszlo Ersek
---
OvmfPkg/OvmfPkg.ci.yaml | 10 ++
1 file change
Add configuration ExceptionList and IgnoreFiles for package config
files. So users can rely on this to ignore some Ecc issues.
Cc: Jian J Wang
Cc: Hao A Wu
Signed-off-by: Shenglei Zhang
---
MdeModulePkg/MdeModulePkg.ci.yaml | 10 ++
1 file changed, 10 insertions(+)
diff --git a/MdeMod
Add configuration ExceptionList and IgnoreFiles for package config
files. So users can rely on this to ignore some Ecc issues.
Cc: Ray Ni
Cc: Zhichao Gao
Signed-off-by: Shenglei Zhang
---
ShellPkg/ShellPkg.ci.yaml | 10 ++
1 file changed, 10 insertions(+)
diff --git a/ShellPkg/ShellPk
Add configuration ExceptionList and IgnoreFiles for package config
files. So users can rely on this to ignore some Ecc issues.
Cc: Michael D Kinney
Cc: Liming Gao
Signed-off-by: Shenglei Zhang
---
MdePkg/MdePkg.ci.yaml | 10 ++
1 file changed, 10 insertions(+)
diff --git a/MdePkg/MdeP
Add configuration ExceptionList and IgnoreFiles for package config
files. So users can rely on this to ignore some Ecc issues.
Cc: Laszlo Ersek
Cc: Ard Biesheuvel
Cc: Leif Lindholm
Signed-off-by: Shenglei Zhang
Acked-by: Laszlo Ersek
---
ArmVirtPkg/ArmVirtPkg.ci.yaml | 10 ++
1 file
Add configuration ExceptionList and IgnoreFiles for package config
files. So users can rely on this to ignore some Ecc issues.
Cc: Jian J Wang
Cc: Xiaoyu Lu
Signed-off-by: Shenglei Zhang
---
CryptoPkg/CryptoPkg.ci.yaml | 10 ++
1 file changed, 10 insertions(+)
diff --git a/CryptoPkg/C
Add configuration ExceptionList and IgnoreFiles for package config
files. So users can rely on this to ignore some Ecc issues.
Cc: Liming Gao
Cc: Michael D Kinney
Signed-off-by: Shenglei Zhang
---
FmpDevicePkg/FmpDevicePkg.ci.yaml | 10 ++
1 file changed, 10 insertions(+)
diff --git a
Add configuration ExceptionList and IgnoreFiles for package config
files. So users can rely on this to ignore some Ecc issues.
Cc: Michael D Kinney
Cc: Sean Brogan
Cc: Bret Barkelew
Signed-off-by: Shenglei Zhang
---
UnitTestFrameworkPkg/UnitTestFrameworkPkg.ci.yaml | 10 ++
1 file cha
Add configuration ExceptionList and IgnoreFiles for package config
files. So users can rely on this to ignore some Ecc issues.
Cc: Jiewen Yao
Cc: Jian J Wang
Cc: Chao Zhang
Signed-off-by: Shenglei Zhang
---
SecurityPkg/SecurityPkg.ci.yaml | 10 ++
1 file changed, 10 insertions(+)
dif
antlr4-python3-runtime is a lib to support Ecc run with Py3.x.
Cc: Sean Brogan
Cc: Bret Barkelew
Cc: Michael D Kinney
Cc: Liming Gao
Signed-off-by: Shenglei Zhang
---
pip-requirements.txt | 1 +
1 file changed, 1 insertion(+)
diff --git a/pip-requirements.txt b/pip-requirements.txt
index 57
Add configuration ExceptionList and IgnoreFiles for package config
files. So users can rely on this to ignore some Ecc issues.
Cc: Ray Ni
Signed-off-by: Shenglei Zhang
---
PcAtChipsetPkg/PcAtChipsetPkg.ci.yaml | 10 ++
1 file changed, 10 insertions(+)
diff --git a/PcAtChipsetPkg/PcAtCh
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2606
Add a pipeline to run the ECC checks on Azure Pipelines agents
for edk2 open ci.
Cc: Sean Brogan
Cc: Bret Barkelew
Cc: Michael D Kinney
Cc: Liming Gao
Signed-off-by: Shenglei Zhang
---
.azurepipelines/Windows-EccCheck.yml | 38
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2606
As planed we will enable Ecc check for edk2 on open ci. And they are
ready now, but these are V3 series. So I expect that contributors in
edk2 community can try using this script when reviewing. And I appreciate
receiving feedback and comment
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2606
EccCheck.py is a tool to report Ecc issues for commits, which will
be run on open ci.
But note not each kind of issue could be reported out.
It can only handle the issues, whose line number in CSV report
accurately map with their code in sour
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2606
As planed we will enable Ecc check for edk2 on open ci. And they are
ready now, but these are V3 series. So I expect that contributors in
edk2 community can try using this script when reviewing. And I appreciate
receiving feedback and comment
Add configuration ExceptionList and IgnoreFiles for package config
files. So users can rely on this to ignore some Ecc issues.
Cc: Jordan Justen
Cc: Laszlo Ersek
Cc: Ard Biesheuvel
Signed-off-by: Shenglei Zhang
---
OvmfPkg/OvmfPkg.ci.yaml | 10 ++
1 file changed, 10 insertions(+)
dif
Add configuration ExceptionList and IgnoreFiles for package config
files. So users can rely on this to ignore some Ecc issues.
Cc: Jiewen Yao
Cc: Jian J Wang
Cc: Chao Zhang
Signed-off-by: Shenglei Zhang
---
SecurityPkg/SecurityPkg.ci.yaml | 10 ++
1 file changed, 10 insertions(+)
dif
Add configuration ExceptionList and IgnoreFiles for package config
files. So users can rely on this to ignore some Ecc issues.
Cc: Eric Dong
Cc: Ray Ni
Cc: Laszlo Ersek
Signed-off-by: Shenglei Zhang
---
UefiCpuPkg/UefiCpuPkg.ci.yaml | 10 ++
1 file changed, 10 insertions(+)
diff --gi
Add configuration ExceptionList and IgnoreFiles for package config
files. So users can rely on this to ignore some Ecc issues.
Cc: Jian J Wang
Cc: Xiaoyu Lu
Signed-off-by: Shenglei Zhang
---
CryptoPkg/CryptoPkg.ci.yaml | 10 ++
1 file changed, 10 insertions(+)
diff --git a/CryptoPkg/C
Add configuration ExceptionList and IgnoreFiles for package config
files. So users can rely on this to ignore some Ecc issues.
Cc: Jordan Justen
Cc: Andrew Fish
Cc: Ray Ni
Signed-off-by: Shenglei Zhang
---
EmulatorPkg/EmulatorPkg.ci.yaml | 10 ++
1 file changed, 10 insertions(+)
diff
Add configuration ExceptionList and IgnoreFiles for package config
files. So users can rely on this to ignore some Ecc issues.
Cc: Maciej Rabeda
Cc: Jiaxin Wu
Cc: Siyuan Fu
Signed-off-by: Shenglei Zhang
---
NetworkPkg/NetworkPkg.ci.yaml | 10 ++
1 file changed, 10 insertions(+)
diff
Add configuration ExceptionList and IgnoreFiles for package config
files. So users can rely on this to ignore some Ecc issues.
Cc: Michael D Kinney
Cc: Sean Brogan
Cc: Bret Barkelew
Signed-off-by: Shenglei Zhang
---
UnitTestFrameworkPkg/UnitTestFrameworkPkg.ci.yaml | 10 ++
1 file cha
Add configuration ExceptionList and IgnoreFiles for package config
files. So users can rely on this to ignore some Ecc issues.
Cc: Laszlo Ersek
Cc: Ard Biesheuvel
Cc: Leif Lindholm
Signed-off-by: Shenglei Zhang
---
ArmVirtPkg/ArmVirtPkg.ci.yaml | 10 ++
1 file changed, 10 insertions(+
Add configuration ExceptionList and IgnoreFiles for package config
files. So users can rely on this to ignore some Ecc issues.
Cc: Ray Ni
Signed-off-by: Shenglei Zhang
---
PcAtChipsetPkg/PcAtChipsetPkg.ci.yaml | 10 ++
1 file changed, 10 insertions(+)
diff --git a/PcAtChipsetPkg/PcAtCh
Add configuration ExceptionList and IgnoreFiles for package config
files. So users can rely on this to ignore some Ecc issues.
Cc: Ray Ni
Signed-off-by: Shenglei Zhang
---
FatPkg/FatPkg.ci.yaml | 10 ++
1 file changed, 10 insertions(+)
diff --git a/FatPkg/FatPkg.ci.yaml b/FatPkg/FatPkg
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2606
Add a pipeline to run the ECC checks on Azure Pipelines agents
for edk2 open ci.
Cc: Sean Brogan
Cc: Bret Barkelew
Cc: Michael D Kinney
Cc: Liming Gao
Signed-off-by: Shenglei Zhang
---
.azurepipelines/Windows-EccCheck.yml | 38
Add configuration ExceptionList and IgnoreFiles for package config
files. So users can rely on this to ignore some Ecc issues.
Cc: Liming Gao
Cc: Michael D Kinney
Signed-off-by: Shenglei Zhang
---
FmpDevicePkg/FmpDevicePkg.ci.yaml | 10 ++
1 file changed, 10 insertions(+)
diff --git a
Add configuration ExceptionList and IgnoreFiles for package config
files. So users can rely on this to ignore some Ecc issues.
Cc: Michael D Kinney
Cc: Liming Gao
Signed-off-by: Shenglei Zhang
---
MdePkg/MdePkg.ci.yaml | 10 ++
1 file changed, 10 insertions(+)
diff --git a/MdePkg/MdeP
Add configuration ExceptionList and IgnoreFiles for package config
files. So users can rely on this to ignore some Ecc issues.
Cc: Ray Ni
Cc: Zhichao Gao
Signed-off-by: Shenglei Zhang
---
ShellPkg/ShellPkg.ci.yaml | 10 ++
1 file changed, 10 insertions(+)
diff --git a/ShellPkg/ShellPk
Add configuration ExceptionList and IgnoreFiles for package config
files. So users can rely on this to ignore some Ecc issues.
Cc: Jian J Wang
Cc: Hao A Wu
Signed-off-by: Shenglei Zhang
---
MdeModulePkg/MdeModulePkg.ci.yaml | 10 ++
1 file changed, 10 insertions(+)
diff --git a/MdeMod
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2606
EccCheck.py is a tool to report Ecc issues for commits, which will
be run on open ci.
But note not each kind of issue could be reported out.
It can only handle the issues, whose line number in CSV report
accurately map with their code in sour
antlr4-python3-runtime is a lib to support Ecc run with Py3.x.
Cc: Sean Brogan
Cc: Bret Barkelew
Cc: Michael D Kinney
Cc: Liming Gao
Signed-off-by: Shenglei Zhang
---
pip-requirements.txt | 1 +
1 file changed, 1 insertion(+)
diff --git a/pip-requirements.txt b/pip-requirements.txt
index 57
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#61020): https://edk2.groups.io/g/devel/message/61020
Mute This Topic: https://groups.io/mt/74792208/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2691
For files to be added to the tree, this feature will check
whether it has BSD plus patent license. If not, licenses listed in
Readme are also accepted but warning will be reported.
Otherwise, it should be error.
Cc: Bob Feng
Cc: Liming Gao
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2691
For files to be added to the tree, this feature will check
whether it has BSD plus patent license. If not, licenses listed in
Readme are also accepted but warning will be reported.
Otherwise, it should be error.
Cc: Bob Feng
Cc: Liming Gao
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2777
Code wrapped by DISABLE_NEW_DEPRECATED_INTERFACES is deprecated.
So remove it.
Cc: Michael D Kinney
Cc: Liming Gao
Signed-off-by: Shenglei Zhang
---
MdePkg/Library/BaseLib/String.c| 626 -
MdePkg/Library/B
gt; From: Chen, Yuwei
> Sent: Friday, June 5, 2020 12:39 PM
> To: devel@edk2.groups.io; Zhang, Shenglei
> Cc: Fan, ZhijuX ; Feng, Bob C
> ; Gao, Liming
> Subject: RE: [edk2-devel] [PATCH v2 1/5] BaseTools:ECC needs to update the
> contents of CParser4
>
> Hi, Shenglei
Hi Laszlo,
> -Original Message-
> From: Laszlo Ersek [mailto:ler...@redhat.com]
> Sent: Wednesday, June 3, 2020 10:27 PM
> To: devel@edk2.groups.io; Zhang, Shenglei
> Cc: Feng, Bob C ; Bret Barkelew
> ; Kinney, Michael D
> ; Gao, Liming ; Sean
> Brogan
> Subje
antlr4-python3-runtime is a lib to support Ecc run with Py3.x.
Cc: Sean Brogan
Cc: Bret Barkelew
Cc: Michael D Kinney
Cc: Liming Gao
Signed-off-by: Shenglei Zhang
---
pip-requirements.txt | 1 +
1 file changed, 1 insertion(+)
diff --git a/pip-requirements.txt b/pip-requirements.txt
index 57
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2606
EccCheck.py is a tool to report Ecc issues for commits, which will
be run on open ci.
But note not each kind of issue could be reported out.
It can only handle the issues, whose line number in CSV report
accurately map with their code in sour
From: "Fan, Zhiju"
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2676
Because Ecc relies on the antlr extension package,
When the antlr version is updated, we need to change the code in it.
Currently, if you use the latest version antlr4.8, Ecc will fail
We will update the version to suppo
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2606
Add a pipeline to run the ECC checks on Azure Pipelines agents
for edk2 open ci.
Cc: Sean Brogan
Cc: Bret Barkelew
Cc: Michael D Kinney
Cc: Liming Gao
Signed-off-by: Shenglei Zhang
---
.azurepipelines/Windows-EccCheck.yml | 38
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2606
As planed we will enable Ecc check for edk2 on open ci. And they are
ready now, but these are V2 series. So I expect that contributors in
edk2 community can try using this script when reviewing. And I appreciate
receiving feedback and comment
This is a sample for users to add exceptions and ignored files for
their own use.
Cc: Jian J Wang
Cc: Hao A Wu
Signed-off-by: Shenglei Zhang
---
MdeModulePkg/MdeModulePkg.ci.yaml | 8
1 file changed, 8 insertions(+)
diff --git a/MdeModulePkg/MdeModulePkg.ci.yaml
b/MdeModulePkg/MdeMo
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2691
For files to be added to the tree, this feature will check
whether it has BSD plus patent license. If not, licenses listed in
Readme are also accepted but warning will be reported.
Otherwise, it should be error.
Cc: Bob Feng
Cc: Liming Gao
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2606
EccCheck.py is a tool to report Ecc issues for commits, which will
be run on open ci.
But note not each kind of issue could be reported out.
It can only handle the issues, whose line number in CSV report
accurately map with their code in sour
This is a sample for users to add exceptions and ignored files for
their own use.
Cc: Jian J Wang
Cc: Hao A Wu
Signed-off-by: Shenglei Zhang
---
MdeModulePkg/MdeModulePkg.ci.yaml | 8
1 file changed, 8 insertions(+)
diff --git a/MdeModulePkg/MdeModulePkg.ci.yaml
b/MdeModulePkg/MdeMo
antlr4-python3-runtime is a lib to support Ecc run with Py3.x.
Cc: Sean Brogan
Cc: Bret Barkelew
Cc: Michael D Kinney
Cc: Liming Gao
Signed-off-by: Shenglei Zhang
---
pip-requirements.txt | 1 +
1 file changed, 1 insertion(+)
diff --git a/pip-requirements.txt b/pip-requirements.txt
index 57
From: "Fan, Zhiju"
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2676
Because Ecc relies on the antlr extension package,
When the antlr version is updated, we need to change the code in it.
Currently, if you use the latest version antlr4.8, Ecc will fail
We will update the version to suppo
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2606
Add a pipeline to run the ECC checks on Azure Pipelines agents
for edk2 open ci.
Cc: Sean Brogan
Cc: Bret Barkelew
Cc: Michael D Kinney
Cc: Liming Gao
Signed-off-by: Shenglei Zhang
---
.azurepipelines/Windows-EccCheck.yml | 38
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2606
As planed we will enable Ecc check for edk2 on open ci. And they are
ready now, but these are V1 series. So I expect that contributors in
edk2 community can try using this script when reviewing. And I hope
receiving feedback and comments if s
Hi,
For this patch, I'd like to catch this stable tag.
Thanks,
Shenglei
> -Original Message-
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Zhang, Shenglei
> Sent: Wednesday, May 20, 2020 11:09 AM
> To: devel@edk2.groups.io
> Cc: Mac
The condition, NET_HEADSPACE(&(Nbuf->BlockOp[Index])) < Len, is
meaningless if Index = 0. So checking 'Index != 0' should be
performed first in the if statement.
Cc: Maciej Rabeda
Cc: Siyuan Fu
Cc: Jiaxin Wu
Signed-off-by: Shenglei Zhang
---
v2: Update 'Index > 0' to 'Index != 0'
NetworkPkg
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#59909): https://edk2.groups.io/g/devel/message/59909
Mute This Topic: https://groups.io/mt/74341614/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2691
For files to be added to the tree, this feature will check
whether it has BSD plus patent license. If not, licenses listed in
Readme are also accepted but warning will be reported out.
Otherwise, it should be error.
Cc: Bob Feng
Cc: Liming
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2712
OnigurumaIntrinsics.c is now not used improperly. So the implements
of function 'memcpy' and 'memset' are not linked for all tool chains,
which causes build failure with CLANG9 and XCODE. I remove
OnigurumaIntrinsics.c and move the necessary
OnigurumaIntrinsics.c is now not used. So the implement of function
'memcpy' is now not., which causes build failure with CLANG9 and
XCODE. I remove OnigurumaIntrinsics.c and move the necessary function
implement to OnigurumaUefiPort.c/h.
Cc: Jian J Wang
Cc: Hao A Wu
Signed-off-by: Shenglei Zhan
Reviewed-by: Shenglei Zhang
> -Original Message-
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Michael Kubacki
> Sent: Thursday, April 16, 2020 4:31 AM
> To: devel@edk2.groups.io
> Cc: Feng, Bob C ; Gao, Liming ;
> Bret Barkelew ; Kinney, Michael D
> ; Sean Bro
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2692
BrotliCompress submodule change for BaseTools causes untracked
files in BaseTools after building. This is regression for git.
Cc: Laszlo Ersek
Cc: Sean Brogan
Cc: Bob Feng
Cc: Liming Gao
Signed-off-by: Shenglei Zhang
---
.gitmodules |
Array 'TargetUrl' of size 255 may use index value(s) 255 and 256.
So enhance the boundary check to ensure the index is valid.
Cc: Maciej Rabeda
Cc: Jiaxin Wu
Cc: Siyuan Fu
Signed-off-by: Shenglei Zhang
---
NetworkPkg/IScsiDxe/IScsiDhcp.c | 2 +-
NetworkPkg/IScsiDxe/IScsiDhcp6.c | 2 +-
2 fil
For files to be added to the tree, this feature will check
whether it has BSD license.
Cc: Bob Feng
Cc: Liming Gao
Signed-off-by: Shenglei Zhang
---
BaseTools/Scripts/PatchCheck.py | 52 -
1 file changed, 51 insertions(+), 1 deletion(-)
diff --git a/BaseTools/S
> -Original Message-
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Ard Biesheuvel
> Sent: Thursday, April 16, 2020 5:37 PM
> To: devel@edk2.groups.io; Zhang, Shenglei
> Cc: Gao, Liming ; Wang, Jian J
> ; Wu, Hao A ; Feng, Bob C
>
&g
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1321
TpmCommLib is no longer used by TcgPei/TcgDxe/Tcg2ConfigPei modules.
So it can be removed from SecurityPkg.
Cc: Jiewen Yao
Cc: Jian J Wang
Cc: Chao Zhang
Signed-off-by: Shenglei Zhang
---
SecurityPkg/Library/TpmCommLib/TisPc.c|
Reviewed-by: Shenglei Zhang
> -Original Message-
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Michael Kubacki
> Sent: Thursday, April 9, 2020 2:13 AM
> To: devel@edk2.groups.io
> Cc: Andrew Fish ; Ard Biesheuvel
> ; Bret Barkelew
> ; Justen, Jordan L
> ; Laszl
hanks,
Shenglei
> -Original Message-
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Zhang, Shenglei
> Sent: Wednesday, April 1, 2020 4:32 PM
> To: devel@edk2.groups.io
> Cc: Gao, Liming ; Wang, Jian J
> ; Wu, Hao A ; Feng, Bob C
>
> Subject: [edk2-
glei
From: sean.brogan via [] [mailto:sean.brogan=microsoft.com@[]]
Sent: Wednesday, April 15, 2020 2:52 PM
To: Zhang; Zhang, Shenglei ; devel@edk2.groups.io
Subject: Re: [edk2-devel] [PATCH v1 0/6] Edk2 Platform and Core CI for
ArmVirtPkg, EmulatorPkg, and OvmfPkg
what do you mean "test for the a
Hi Sean/Michael,
Did you have test for the added piplines?
Thanks,
Shenglei
> -Original Message-
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Michael Kubacki
> Sent: Thursday, April 9, 2020 2:13 AM
> To: devel@edk2.groups.io
> Cc: Andrew Fish ; Ard Biesheuvel
Reviewed-by: Shenglei Zhang
> -Original Message-
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Michael Kubacki
> Sent: Friday, April 10, 2020 5:31 AM
> To: devel@edk2.groups.io
> Cc: Feng, Bob C ; Bret Barkelew
> ; Gao, Liming ;
> Kinney, Michael D ; Sean Broga
ginal Message-
> From: Gao, Liming
> Sent: Thursday, March 12, 2020 11:12 AM
> To: Zhang, Shenglei ; devel@edk2.groups.io
> Cc: Wang, Jian J ; Wu, Hao A
> Subject: RE: [PATCH v2] MdeModulePkg/RegularExpressionDxe: Make
> oniguruma a submodule in edk2.
>
> Reviewed-by: L
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2617
Update edk2 build and test ci to use Python 3.8.x
Cc: Sean Brogan
Cc: Bret Barkelew
Cc: Michael D Kinney
Cc: Liming Gao
Signed-off-by: Shenglei Zhang
---
.azurepipelines/templates/pr-gate-steps.yml | 2 +-
1 file changed, 1 insertion(+
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2616
Pytool extensions are locked on 0.12.x but extensions has
moved to 0.13.x. So update the pip-requirements.txt.
Cc: Sean Brogan
Cc: Bret Barkelew
Cc: Michael D Kinney
Cc: Liming Gao
Signed-off-by: Shenglei Zhang
---
pip-requirements.txt
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2659
Allow WindowsVsToolChain Plugin to add libraries and headers
of user defined ARCH for VS2017 and VS2019.
Cc: Bob Feng
Cc: Liming Gao
Signed-off-by: Shenglei Zhang
---
.../WindowsVsToolChain/WindowsVsToolChain.py | 73 ---
Use submodule way to access oniguruma. And upgrade oniguruma
version from v6.9.3 to v6.9.4_mark1.
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2073
Cc: Jian J Wang
Cc: Hao A Wu
Cc: Liming Gao
Signed-off-by: Shenglei Zhang
---
v2:1.Update the inf file to make VS2019 build pass.
2.Add
Hi All,
We have a build failure with
VS2012(https://bugzilla.tianocore.org/show_bug.cgi?id=2631).
If no body uses VS2012, I would like to ignore this issue. I send this mail to
collect information whether you are using VS2012.
Thanks,
Shenglei
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You recei
Currently brotli is used and customized by edk2 in BaseTools
and MdeModulePkg. These two patches make brotli a submodule in
edk2.
https://bugzilla.tianocore.org/show_bug.cgi?id=2558
https://bugzilla.tianocore.org/show_bug.cgi?id=2559
v2: Add submodule path in CISettings.py
Cc: Liming Gao
Cc: Jia
From: Sean Brogan
Update CI steps to build base tools after setup and update,
as basetools might have dependencies that need to be resolved.
Cc: Sean Brogan
Cc: Bret Barkelew
Cc: Michael D Kinney
Cc: Liming Gao
Signed-off-by: Shenglei Zhang
---
.azurepipelines/templates/pr-gate-steps.yml |
Hi Sean,
I am introducing third party project oniguruma as submodule into edk2, and want
to skip CharEncodingCheck for certain files in oniguruma.
I tried to add changes like below, but CI build failed.
"CharEncodingCheck": {
"IgnoreFiles":
[[(MdeModulePkg/Universal/RegularExpressionDxe/onigurum
Hi Mike,
> -Original Message-
> From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org]
> Sent: Thursday, March 26, 2020 4:43 PM
> To: edk2-devel-groups-io ; Zhang, Shenglei
> ; Laszlo Ersek
> Cc: Sean Brogan ; Bret Barkelew
> ; Kinney, Michael D
> ; Gao, Limi
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2570
OvmfPkg and EmulatorPkg are mostly used by the developers, so add
them to target list.
Cc: Sean Brogan
Cc: Bret Barkelew
Cc: Michael D Kinney
Cc: Liming Gao
Signed-off-by: Shenglei Zhang
---
.azurepipelines/templates/pr-gate-build-job.
In order to catch as many issues as possible in a single
pass (to allow devs to fix test failures in one commit rather than
several), recommend increasing the max failure count and max
duplicate count in SpellCheck plugin.
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2593
Cc: Sean Brogan
Reviewed-by: Shenglei Zhang
> -Original Message-
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> GuoMinJ
> Sent: Thursday, March 5, 2020 2:18 PM
> To: devel@edk2.groups.io
> Cc: GuoMinJ ; Kinney, Michael D
> ; Sean Brogan ;
> Bret Barkelew
> Subject: [edk2-devel
Reviewed-by: Shenglei Zhang
> -Original Message-
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> GuoMinJ
> Sent: Thursday, March 5, 2020 2:41 PM
> To: devel@edk2.groups.io
> Cc: GuoMinJ ; Wang, Jian J
> ; Lu, XiaoyuX
> Subject: [edk2-devel] [PATCH v2 1/2] Crypto
Reviewed-by: Shenglei Zhang
> -Original Message-
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> GuoMinJ
> Sent: Thursday, March 5, 2020 2:41 PM
> To: devel@edk2.groups.io
> Cc: GuoMinJ ; Wang, Jian J
> ; Lu, XiaoyuX
> Subject: [edk2-devel] [PATCH v2 2/2] Crypto
101 - 200 of 477 matches
Mail list logo
