Re: [edk2-devel] [edk2-platforms][PATCH V3] Silicon/Synopsys/DesignWare: DwEmacSnpDxe: Fix bug in EmacGetDmaStatus

2023-07-31 Thread wangy
Hi Pedro Falcato, At 2023-07-31 17:15:20, "Pedro Falcato" wrote: >On Mon, Jul 31, 2023 at 4:25 AM wangy wrote: >> >> From: Yang Wang >> >> The EFI spec (see UEFI 2.10, 24.1.12) requires >> EFI_SIMPLE_NETWORK.GetStatus() to handle NULL InterruptStatus

Re: [edk2-devel] [edk2-platforms][PATCH V1] Silicon/Synopsys/DesignWare: DwEmacSnpDxe: Fix bug in EmacGetDmaStatus

2023-07-30 Thread wangy
Hi Pedro Falcato, At 2023-07-29 03:40:15, "Pedro Falcato" wrote: >On Fri, Jul 28, 2023 at 5:00 AM wangy wrote: >> >> From: Yang Wang >> >> If IrqStat is NULL, the interrupt status will not be >> read from the device.When the interrupt status is

[edk2-devel] [edk2-platforms][PATCH V3] Silicon/Synopsys/DesignWare: DwEmacSnpDxe: Fix bug in EmacGetDmaStatus

2023-07-30 Thread wangy
From: Yang Wang The EFI spec (see UEFI 2.10, 24.1.12) requires EFI_SIMPLE_NETWORK.GetStatus() to handle NULL InterruptStatus pointers by not reading nor clearing the interrupt status from the device. However, EmacGetDmaStatus (part of the DwEmacSnpDxe GetStatus() implementation) did not correctl

[edk2-devel] [edk2-platforms][PATCH V1] Silicon/Synopsys/DesignWare: DwEmacSnpDxe: Fix bug in EmacGetDmaStatus

2023-07-27 Thread wangy
From: Yang Wang If IrqStat is NULL, the interrupt status will not be read from the device.When the interrupt status is read, it will also be cleared. Cc: Leif Lindholm Cc: Ard Biesheuvel Cc: Ran Wang Signed-off-by: Yang Wang --- .../Drivers/DwEmacSnpDxe/EmacDxeUtil.c| 22 ++

Re: [edk2-devel] [PATCH] Silicon/Synopsys/DesignWare: DwEmacSnpDxe: Fix bug in EmacGetDmaStatus

2023-07-27 Thread wangy
Hi Pedro Falcato, At 2023-07-27 21:45:46, "Pedro Falcato" wrote: >On Thu, Jul 27, 2023 at 8:12 AM wangy wrote: >> >> Hi Pedro Falcato, >> >> At 2023-07-27 08:26:44, "Pedro Falcato" wrote: >> >On Wed, Jul 26, 2023 at 4:07 AM wangy wro

Re: [edk2-devel] [PATCH] Silicon/Synopsys/DesignWare: DwEmacSnpDxe: Fix bug in EmacGetDmaStatus

2023-07-27 Thread wangy
Hi Pedro Falcato, At 2023-07-27 08:26:44, "Pedro Falcato" wrote: >On Wed, Jul 26, 2023 at 4:07 AM wangy wrote: >> >> Hi Pedro Falcato, >> >> At 2023-07-25 16:45:01, "Pedro Falcato" wrote: >> >> >On Tue, Jul 25, 2023 at

Re: [edk2-devel] [PATCH] Silicon/Synopsys/DesignWare: DwEmacSnpDxe: Fix bug in EmacGetDmaStatus

2023-07-25 Thread wangy
Hi Pedro Falcato, At 2023-07-25 16:45:01, "Pedro Falcato" wrote: >On Tue, Jul 25, 2023 at 2:10 AM wrote: >> >> From: Yang Wang >> >> Check EmacGetDmaStatus input parameters >> IrqStat may be a null pointer. >> >> Signed-off-by: Yang Wang >> --- >> .../Drivers/DwEmacSnpDxe/DwEmacSnpDxe.c