Re: [EXTERNAL] [edk2-devel] [edk2-rfc] GitHub Pull Request based Code Review Process

2020-05-28 Thread Bret Barkelew via groups.io
to:nathaniel.l.desim...@intel.com>; Kinney, Michael D<mailto:michael.d.kin...@intel.com>; Leif Lindholm (Nuvia address)<mailto:l...@nuviainc.com> Subject: Re: [EXTERNAL] [edk2-devel] [edk2-rfc] GitHub Pull Request based Code Review Process On 5/27/2020 6:12 AM, Laszlo Ersek wrote:

Re: [EXTERNAL] [edk2-devel] [edk2-rfc] GitHub Pull Request based Code Review Process

2020-05-27 Thread Laszlo Ersek
On 05/28/20 00:07, Rebecca Cran wrote: > I also tried using my openSUSE WSL installation, but it failed with: > > STARTTLS failed! SSL connect attempt failed error:1416F086:SSL > routines:tls_process_server_certificate:certificate verify failed at > /usr/lib/git/git-send-email line 1548. That's

Re: [EXTERNAL] [edk2-devel] [edk2-rfc] GitHub Pull Request based Code Review Process

2020-05-27 Thread Bret Barkelew via groups.io
intel.com>; Leif Lindholm (Nuvia address)<mailto:l...@nuviainc.com> Subject: Re: [EXTERNAL] [edk2-devel] [edk2-rfc] GitHub Pull Request based Code Review Process On 5/27/2020 6:12 AM, Laszlo Ersek wrote: > So, it could be a MINGW64 packaging bug, perhaps. I'm getting the same error, but with a

Re: [EXTERNAL] [edk2-devel] [edk2-rfc] GitHub Pull Request based Code Review Process

2020-05-27 Thread Andrew Fish via groups.io
Rebecca, I cheated and used smtpServer = relay.apple.com and smtpEncryption = tls. Seems relay.apple.com does not require authentication and it just worked. I used an internal git mailing list to figure all this out, but seems the easy button was an smtpServer setup to be easy to use with

Re: [EXTERNAL] [edk2-devel] [edk2-rfc] GitHub Pull Request based Code Review Process

2020-05-27 Thread Rebecca Cran
On 5/27/2020 6:12 AM, Laszlo Ersek wrote: So, it could be a MINGW64 packaging bug, perhaps. I'm getting the same error, but with a different packaging of Git: mine's in C:\Program Files\Git\cmd\git.exe . It's version "git version 2.26.2.windows.1". Of course it's possible it's just the

Re: [EXTERNAL] [edk2-devel] [edk2-rfc] GitHub Pull Request based Code Review Process

2020-05-27 Thread Laszlo Ersek
On 05/27/20 03:52, Bret Barkelew wrote: > So, today I followed the Wiki (that I had never seen) and now I’m staring > down the barrel of this fellow… > [cid:image002.png@01D6338E.D6C64920] > > [Not using SSL_VERIFY_PEER due to out-of-date IO::Socket::SSL. > To use SSL please install

Re: [EXTERNAL] [edk2-devel] [edk2-rfc] GitHub Pull Request based Code Review Process

2020-05-27 Thread Tomas Pilar (tpilar)
nt: 27 May 2020 02:53 To: Andrew Fish ; Laszlo Ersek Cc: devel@edk2.groups.io; spbro...@outlook.com; r...@edk2.groups.io; Desimone, Nathaniel L ; Kinney, Michael D ; Leif Lindholm (Nuvia address) Subject: Re: [EXTERNAL] [edk2-devel] [edk2-rfc] GitHub Pull Request based Code Review Process S

Re: [EXTERNAL] [edk2-devel] [edk2-rfc] GitHub Pull Request based Code Review Process

2020-05-26 Thread Bret Barkelew via groups.io
Fish Cc: Bret Barkelew ; devel@edk2.groups.io ; spbro...@outlook.com ; Desimone, Nathaniel L ; Kinney, Michael D ; Leif Lindholm (Nuvia address) ; Samer El-Haj-Mahmoud Subject: Re: [EXTERNAL] [edk2-devel] [edk2-rfc] GitHub Pull Request based Code Review Process I agree with Andrew. I also

Re: [EXTERNAL] [edk2-devel] [edk2-rfc] GitHub Pull Request based Code Review Process

2020-05-26 Thread Samer El-Haj-Mahmoud
ke Kinney > ; Leif Lindholm (Nuvia address) > > Subject: Re: [EXTERNAL] [edk2-devel] [edk2-rfc] GitHub Pull Request based > Code Review Process > > On 05/25/20 20:28, Andrew Fish wrote: > > > > > >> On May 25, 2020, at 11:10 AM, Laszlo Ersek wrote: > >>

Re: [EXTERNAL] [edk2-devel] [edk2-rfc] GitHub Pull Request based Code Review Process

2020-05-26 Thread Laszlo Ersek
On 05/25/20 20:28, Andrew Fish wrote: > > >> On May 25, 2020, at 11:10 AM, Laszlo Ersek wrote: >> >> Hi Andrew, >> >> On 05/25/20 06:09, Andrew Fish wrote: >> >>> I also found I had to Bing/Google to find the detailed instructions I >>> needed as a developer, as the Wiki seems to assume you

Re: [EXTERNAL] [edk2-devel] [edk2-rfc] GitHub Pull Request based Code Review Process

2020-05-25 Thread Andrew Fish via groups.io
> On May 25, 2020, at 11:10 AM, Laszlo Ersek wrote: > > Hi Andrew, > > On 05/25/20 06:09, Andrew Fish wrote: > >> I also found I had to Bing/Google to find the detailed instructions I >> needed as a developer, as the Wiki seems to assume you just know the >> Linux kernel patch process. That

Re: [EXTERNAL] [edk2-devel] [edk2-rfc] GitHub Pull Request based Code Review Process

2020-05-25 Thread Laszlo Ersek
Hi Andrew, On 05/25/20 06:09, Andrew Fish wrote: > I also found I had to Bing/Google to find the detailed instructions I > needed as a developer, as the Wiki seems to assume you just know the > Linux kernel patch process. That feels like an area we can improve. (apologies if I've lost context;