Add [edk2-test] in subject
Hi Tom,
Revisit the test, it gets the InformationType from GetSupportedTypes(), then
call SetInformation() with the supported InformationType. In this scenario,
the EFI_UNSUPPORTED doesn't make sense. If the adapter doesn't want to support
the function SetInformation at all, EFI_WRITE_PROTECTED may be better choice.
Copy the spec description as below.
EFI_WRITE_PROTECTED The InformationType cannot be modified using
EFI_ADAPTER_INFO_SET_INFO()
EFI_UNSUPPORTED The InformationType is not known.
Best Regards
Eric
-----Original Message-----
From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Eric Jin
Sent: Thursday, September 19, 2019 2:17 PM
To: Tom Zhao <tz...@solarflare.com>; devel@edk2.groups.io
Cc: Supreeth Venkatesh <supreeth.venkat...@arm.com>; Liu, XianhuiX
<xianhuix....@intel.com>
Subject: Re: [edk2-devel] [PATCH v2 1/1] uefi-sct/SctPkg AdapterInfo
SetInformation may return unsupported
EFI_UNSUPPORTED The InformationType is not known.
The description is described as above in UEFI Spec.
In this case, the test gets the InformationType from EFI_ADAPTER_GET_INFO(), so
the SetInformationfunction return EFI_UNSUPPORTED doesn't make sense. The
reason is not covered by spec at least.
How about to do some basic check in device or return EFI_DEVICE_ERROR.
And the test could add EFI_DEVICE_ERROR into acceptable return code.
-----Original Message-----
From: Tom Zhao <tz...@solarflare.com>
Sent: Wednesday, September 18, 2019 4:48 PM
To: devel@edk2.groups.io
Cc: Jin, Eric <eric....@intel.com>; Supreeth Venkatesh
<supreeth.venkat...@arm.com>
Subject: [PATCH v2 1/1] uefi-sct/SctPkg AdapterInfo SetInformation may return
unsupported
If AdapterInfo.SetInformation() is unsupported, it will return EFI_UNSUPPORTED.
Do not fail the test in this case.
Cc: Supreeth Venkatesh <supreeth.venkat...@arm.com>
Cc: Eric Jin <eric....@intel.com>
Signed-off-by: Tom Zhao <tz...@solarflare.com>
---
Notes:
v2:
- Change commit message to be closer to similar issues.
uefi-sct/SctPkg/TestCase/UEFI/IHV/Protocol/AdapterInfo/BlackBoxTest/AdapterInfoBBTestConformance.c
| 4 ++--
uefi-sct/SctPkg/TestCase/UEFI/IHV/Protocol/AdapterInfo/BlackBoxTest/AdapterInfoBBTestFunction.c
| 8 ++++----
2 files changed, 6 insertions(+), 6 deletions(-)
diff --git
a/uefi-sct/SctPkg/TestCase/UEFI/IHV/Protocol/AdapterInfo/BlackBoxTest/AdapterInfoBBTestConformance.c
b/uefi-sct/SctPkg/TestCase/UEFI/IHV/Protocol/AdapterInfo/BlackBoxTest/AdapterInfoBBTestConformance.c
index fb42398e4a97..3dc048db5333 100644
---
a/uefi-sct/SctPkg/TestCase/UEFI/IHV/Protocol/AdapterInfo/BlackBoxTest/AdapterInfoBBTestConformance.c
+++
b/uefi-sct/SctPkg/TestCase/UEFI/IHV/Protocol/AdapterInfo/BlackBoxTest/AdapterInfoBBTestConformance.c
@@ -556,8 +556,8 @@ BBTestSetInformationConformanceTestCheckpoint2 (
NULL,
InformationBlockSize
);
- - if ( Status != EFI_INVALID_PARAMETER && Status !=
EFI_WRITE_PROTECTED) {
+
+ if ( Status != EFI_INVALID_PARAMETER && Status !=
EFI_WRITE_PROTECTED && Status != EFI_UNSUPPORTED) {
AssertionType = EFI_TEST_ASSERTION_FAILED;
} else {
AssertionType = EFI_TEST_ASSERTION_PASSED; diff --git
a/uefi-sct/SctPkg/TestCase/UEFI/IHV/Protocol/AdapterInfo/BlackBoxTest/AdapterInfoBBTestFunction.c
b/uefi-sct/SctPkg/TestCase/UEFI/IHV/Protocol/AdapterInfo/BlackBoxTest/AdapterInfoBBTestFunction.c
index 334bb9edc493..4b054b0ef7d8 100644
---
a/uefi-sct/SctPkg/TestCase/UEFI/IHV/Protocol/AdapterInfo/BlackBoxTest/AdapterInfoBBTestFunction.c
+++
b/uefi-sct/SctPkg/TestCase/UEFI/IHV/Protocol/AdapterInfo/BlackBoxTest/AdapterInfoBBTestFunction.c
@@ -372,11 +372,11 @@ BBTestSetInformationFunctionTestCheckpoint1 (
InformationBlockSize1
);
- if (Status == EFI_SUCCESS || Status == EFI_WRITE_PROTECTED)
- AssertionType = EFI_TEST_ASSERTION_PASSED; + if (Status ==
EFI_SUCCESS || Status == EFI_WRITE_PROTECTED || Status == EFI_UNSUPPORTED)
+ AssertionType = EFI_TEST_ASSERTION_PASSED;
else
- AssertionType = EFI_TEST_ASSERTION_FAILED; - +
AssertionType = EFI_TEST_ASSERTION_FAILED;
+
StandardLib->RecordAssertion (
StandardLib,
AssertionType,
--
2.21.0
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#47685): https://edk2.groups.io/g/devel/message/47685
Mute This Topic: https://groups.io/mt/34206438/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
