Re: [edk2-devel] [[edk2-platforms]PATCH v4 1/1] Platform: Intel: Add Stratix 10 platform support

2019-05-31 Thread Leif Lindholm
On Thu, May 30, 2019 at 05:34:23AM +, Loh, Tien Hock wrote: > > Also, we should look into having the DT provided by the firmware > > instead of passed on the command line. > > > > And manually specifying console is very 2014 - use stdout-path in > > the DT. > > Yeah I'll be looking into it.

Re: [edk2-devel] [[edk2-platforms]PATCH v4 1/1] Platform: Intel: Add Stratix 10 platform support

2019-05-29 Thread Loh, Tien Hock
Leif, thanks for reviewing, a question inlined. > -Original Message- > From: Leif Lindholm > Sent: Wednesday, May 29, 2019 10:43 PM > To: Loh, Tien Hock > Cc: devel@edk2.groups.io; thlo...@gmail.com; Ard Biesheuvel > ; Kinney, Michael D > > Subject: Re: [[edk2-platforms]PATCH v4 1/1]

Re: [edk2-devel] [[edk2-platforms]PATCH v4 1/1] Platform: Intel: Add Stratix 10 platform support

2019-05-29 Thread Loh, Tien Hock
gmail.com > > Cc: Loh, Tien Hock; Ard Biesheuvel; Leif Lindholm; Kinney, Michael D > > Subject: [edk2-devel] [[edk2-platforms]PATCH v4 1/1] Platform: Intel: Add > > Stratix 10 platform support > > > > From: "Tien Hock, Loh" > > > > Adds support fo

Re: [edk2-devel] [[edk2-platforms]PATCH v4 1/1] Platform: Intel: Add Stratix 10 platform support

2019-05-29 Thread Wu, Hao A
Subject: [edk2-devel] [[edk2-platforms]PATCH v4 1/1] Platform: Intel: Add > Stratix 10 platform support > > From: "Tien Hock, Loh" > > Adds support for Intel Stratix 10 Platform. > > Signed-off-by: "Tien Hock, Loh" > Contributed-under: TianoCore Con

Re: [edk2-devel] [[edk2-platforms]PATCH v4 1/1] Platform: Intel: Add Stratix 10 platform support

2019-05-29 Thread Leif Lindholm
Urgh, sorry, saw this was still stuck in my review queue. Mike, one question for you inline below. Oh, and one here - what's your take on maintainership for ARM-based Intel platforms? Fall back to top-level maintainers and add Tien Hock as reviewer? On Thu, May 09, 2019 at 04:55:47PM +0800,

[edk2-devel] [[edk2-platforms]PATCH v4 1/1] Platform: Intel: Add Stratix 10 platform support

2019-05-09 Thread Loh, Tien Hock
From: "Tien Hock, Loh" Adds support for Intel Stratix 10 Platform. Signed-off-by: "Tien Hock, Loh" Contributed-under: TianoCore Contribution Agreement 1.1 Cc: Ard Biesheuvel Cc: Leif Lindholm Cc: Michael D Kinney -- v4 - Removed LibC - Added NOOPT to BUILD_TARGETS - Removed ARM from