Re: [edk2-devel] [PATCH] BaseTools/VolInfo: Correct buffer for GenCrc32 tool

2022-10-01 Thread Bob Feng
Sent: Friday, July 29, 2022 5:03 PM To: Chen, Christine Cc: devel@edk2.groups.io; Feng, Bob C ; Gao, Liming Subject: Re: [edk2-devel] [PATCH] BaseTools/VolInfo: Correct buffer for GenCrc32 tool Hi Christine! I think the GenCrc32 usage is different because it just prepends the data

Re: [edk2-devel] [PATCH] BaseTools/VolInfo: Correct buffer for GenCrc32 tool

2022-07-29 Thread Konstantin Aladyshev
Original Message- > > > From: devel@edk2.groups.io On Behalf Of > > > Konstantin Aladyshev > > > Sent: Tuesday, July 19, 2022 9:45 PM > > > To: devel@edk2.groups.io > > > Cc: Feng, Bob C ; Gao, Liming > > > ; Chen,

Re: [edk2-devel] [PATCH] BaseTools/VolInfo: Correct buffer for GenCrc32 tool

2022-07-28 Thread Yuwei Chen
s, Christine > -Original Message- > From: devel@edk2.groups.io On Behalf Of > Konstantin Aladyshev > Sent: Tuesday, July 19, 2022 9:45 PM > To: devel@edk2.groups.io > Cc: Feng, Bob C ; Gao, Liming > ; Chen, Christine ; > Konstantin Aladyshev > Subject

[edk2-devel] [PATCH] BaseTools/VolInfo: Correct buffer for GenCrc32 tool

2022-07-19 Thread Konstantin Aladyshev
If the guided section was encoded with GenCrc32 tool the resulting 'EFI_GUID_DEFINED_SECTION.DataOffset' field points to the start of the meaningfull data that follows the CRC32 value. But if we want to decode the section with GenCrc32 tool we need to provide a buffer that includes the CRC32 value