Push@39744883933eea9674ccaf243cbf565966b8fa74
From: Fan, ZhijuX
Sent: Friday, June 28, 2019 3:49 PM
To: devel@edk2.groups.io; rebe...@bluestop.org
Cc: Gao, Liming ; Feng, Bob C
Subject: RE: [edk2-devel] [PATCH] BaseTools:Linux changes the way the latest
version is judged
Hi:
You're right
ehalf Of
rebe...@bluestop.org
Sent: Wednesday, June 26, 2019 11:48 PM
To: devel@edk2.groups.io; Fan, ZhijuX
Cc: Gao, Liming ; Feng, Bob C
Subject: Re: FW: [edk2-devel] [PATCH] BaseTools:Linux changes the way the
latest version is judged
On 2019-06-25 22:46, Fan, ZhijuX wrote:
Hi:
Python3.6 and python3.7
On 2019-06-25 22:46, Fan, ZhijuX wrote:
>
>
>
> Hi:
>
> Python3.6 and python3.7
>
> After the code removes some common values “python”, we compare “3.6”
> and “3.7”
>
> origin_version = “3.6”, python_version=”3.7”
>
>
>
> I'm going to change it to
>
> if [[ "$origin_version" < "$p
w. Thanks.
Best Regards
Fan Zhiju
From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
rebe...@bluestop.org
Sent: Tuesday, June 25, 2019 10:34 AM
To: devel@edk2.groups.io; Fan, ZhijuX
Cc: Gao, Liming ; Feng, Bob C
Subject: Re: FW: [edk2-devel] [PATCH] BaseTools:Linux changes th
On 2019-06-24 20:18, Fan, ZhijuX wrote:
> Using "-lt" will report the following errors, but "\<" will not
> 3.6: integer expression expected
> 3.7: integer expression expected
>
> if [[ "$origin_version" < "$python_version" ]];then
> It is equivalent to
> if [ "$origin_version" \< "$python_version"
ps.io; Fan, ZhijuX
Cc: Gao, Liming ; Feng, Bob C
Subject: Re: [edk2-devel] [PATCH] BaseTools:Linux changes the way the latest
version is judged
On 2019-06-20 20:33, Fan, ZhijuX wrote:
> - ret=`echo "$origin_version < $python_version" |bc`
> - if [ "$ret" -e
On 2019-06-20 20:33, Fan, ZhijuX wrote:
> - ret=`echo "$origin_version < $python_version" |bc`
> - if [ "$ret" -eq 1 ]; then
> + if [ "$origin_version" \< "$python_version" ]; then
> origin_version=$python_version
> export PYTHON_COMMAND=$python
>fi
I thin
Zhiju:
The change is good. What test have you done?
Thanks
Liming
> -Original Message-
> From: Fan, ZhijuX
> Sent: Friday, June 21, 2019 10:33 AM
> To: devel@edk2.groups.io
> Cc: Gao, Liming ; Feng, Bob C
> Subject: [PATCH] BaseTools:Linux changes the way the latest version is judged
>
BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=1929
Some Linux servers do not have BC installed,so errors occur.
So the judgment was changed to avoid this error.
Cc: Bob Feng
Cc: Liming Gao
Signed-off-by: Zhiju.Fan
---
edksetup.sh | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
