Re: [edk2-devel] [PATCH] IntelFsp2Pkg: Add Fsp22SecCoreS.inf to Dsc.

2020-06-11 Thread Zeng, Star
Reviewed-by: Star Zeng with the copyright year correction. > -Original Message- > From: Desimone, Nathaniel L > Sent: Thursday, June 11, 2020 4:35 AM > To: Chiu, Chasel ; devel@edk2.groups.io > Cc: Ma, Maurice ; Zeng, Star > Subject: RE: [PATCH] IntelFsp2Pkg: Add Fsp22SecCoreS.inf to

Re: [edk2-devel] [PATCH] IntelFsp2Pkg: Add Fsp22SecCoreS.inf to Dsc.

2020-06-10 Thread Nate DeSimone
Please fix copyright year. With that change... Reviewed-by: Nate DeSimone -Original Message- From: Chiu, Chasel Sent: Tuesday, June 9, 2020 7:33 PM To: devel@edk2.groups.io Cc: Ma, Maurice ; Desimone, Nathaniel L ; Zeng, Star Subject: [PATCH] IntelFsp2Pkg: Add Fsp22SecCoreS.inf to

Re: [edk2-devel] [PATCH] IntelFsp2Pkg: Add Fsp22SecCoreS.inf to Dsc.

2020-06-10 Thread Chiu, Chasel
niel L > ; Zeng, Star > Subject: Re: [edk2-devel] [PATCH] IntelFsp2Pkg: Add Fsp22SecCoreS.inf to Dsc. > > I think your copyright year is off. 2022? > > After you fix that > > Reviewed-by: Sean Brogan > > Also since you are the package maintainer of this packa

Re: [edk2-devel] [PATCH] IntelFsp2Pkg: Add Fsp22SecCoreS.inf to Dsc.

2020-06-10 Thread Sean
I think your copyright year is off. 2022? After you fix that Reviewed-by: Sean Brogan Also since you are the package maintainer of this package what do you think about enabling Core CI? We do this already in Project Mu which is how this missing entry was identified.

[edk2-devel] [PATCH] IntelFsp2Pkg: Add Fsp22SecCoreS.inf to Dsc.

2020-06-09 Thread Chiu, Chasel
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2788 DSC is incomplete according to the established CI policies. Fsp22SecCoreS.inf needs to be added to the Components section for completeness. Cc: Maurice Ma Cc: Nate DeSimone Cc: Star Zeng Signed-off-by: Chasel Chiu ---