Re: [edk2-devel] [PATCH] IntelFsp2Pkg: Add FunctionParametePtr to FspGlobalData.

2020-05-20 Thread Chiu, Chasel
Zeng, Star > Subject: [edk2-devel] [PATCH] IntelFsp2Pkg: Add FunctionParametePtr to > FspGlobalData. > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2726 > > When FSP switching stack and calling bootloader functions, the function > parameter in stack may not be acce

Re: [edk2-devel] [PATCH] IntelFsp2Pkg: Add FunctionParametePtr to FspGlobalData.

2020-05-20 Thread Chiu, Chasel
Thanks! > -Original Message- > From: Zeng, Star > Sent: Wednesday, May 20, 2020 12:34 PM > To: Chiu, Chasel ; Desimone, Nathaniel L > ; devel@edk2.groups.io > Cc: Ma, Maurice ; Zeng, Star > Subject: RE: [PATCH] IntelFsp2Pkg: Add FunctionParametePtr to > FspGlobalData. > > No need to

Re: [edk2-devel] [PATCH] IntelFsp2Pkg: Add FunctionParametePtr to FspGlobalData.

2020-05-19 Thread Zeng, Star
No need to resend new patch, you can go ahead with Nate's review after the correction. > -Original Message- > From: Chiu, Chasel > Sent: Wednesday, May 20, 2020 12:25 PM > To: Zeng, Star ; Desimone, Nathaniel L > ; devel@edk2.groups.io > Cc: Ma, Maurice > Subject: RE: [PATCH]

Re: [edk2-devel] [PATCH] IntelFsp2Pkg: Add FunctionParametePtr to FspGlobalData.

2020-05-19 Thread Chiu, Chasel
Yes, thanks for good catch! I will correct it. > -Original Message- > From: Zeng, Star > Sent: Wednesday, May 20, 2020 12:21 PM > To: Desimone, Nathaniel L ; Chiu, Chasel > ; devel@edk2.groups.io > Cc: Ma, Maurice ; Zeng, Star > Subject: RE: [PATCH] IntelFsp2Pkg: Add

Re: [edk2-devel] [PATCH] IntelFsp2Pkg: Add FunctionParametePtr to FspGlobalData.

2020-05-19 Thread Zeng, Star
equilivant is a typo? > -Original Message- > From: Desimone, Nathaniel L > Sent: Wednesday, May 20, 2020 12:12 PM > To: Chiu, Chasel ; devel@edk2.groups.io > Cc: Ma, Maurice ; Zeng, Star > Subject: RE: [PATCH] IntelFsp2Pkg: Add FunctionParametePtr to > FspGlobalData. > > Reviewed-by:

Re: [edk2-devel] [PATCH] IntelFsp2Pkg: Add FunctionParametePtr to FspGlobalData.

2020-05-19 Thread Nate DeSimone
Reviewed-by: Nate DeSimone > -Original Message- > From: Chiu, Chasel > Sent: Tuesday, May 19, 2020 8:34 PM > To: devel@edk2.groups.io > Cc: Ma, Maurice ; Desimone, Nathaniel L > ; Zeng, Star > Subject: [PATCH] IntelFsp2Pkg: Add FunctionParametePtr to FspGlobalData. > > REF:

[edk2-devel] [PATCH] IntelFsp2Pkg: Add FunctionParametePtr to FspGlobalData.

2020-05-19 Thread Chiu, Chasel
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2726 When FSP switching stack and calling bootloader functions, the function parameter in stack may not be accessible easily. We can store the function parameter pointer to FspGlobalData and retrieve it after stack switched. Also need to add