Merged: https://github.com/tianocore/edk2/pull/5274
Mike
From: Ashish Singhal
Sent: Thursday, January 18, 2024 5:55 PM
To: Kinney, Michael D ; Kasbekar, Saloni
; devel@edk2.groups.io; Clark-williams, Zachary
; Jeff Brasen ; Gao,
Liming
Subject: Re: [PATCH] NetworkPkg/Ip4Dxe: Fix Reset To
Replied too soon. I saw you had already closed mine.
Thanks
Ashish
From: Ashish Singhal
Sent: Friday, January 19, 2024 7:23 AM
To: Kinney, Michael D ; Kasbekar, Saloni
; devel@edk2.groups.io ;
Clark-williams, Zachary ; Jeff Brasen
; Gao, Liming
Subject: Re:
Hi Michael,
If you are going to create a new PR yourself instead of using the one I already
created (https://github.com/tianocore/edk2/pull/5150), should I close this one?
Thanks
Ashish
From: Kinney, Michael D
Sent: Friday, January 19, 2024 4:57 AM
To:
Acked-by: Michael D Kinney
I will prepare PR for merge
From: Kasbekar, Saloni
Sent: Wednesday, January 17, 2024 9:27 AM
To: Ashish Singhal ; devel@edk2.groups.io;
Clark-williams, Zachary ; Jeff Brasen
; Kinney, Michael D ; Gao,
Liming
Subject: RE: [PATCH] NetworkPkg/Ip4Dxe: Fix Reset
Liming, Mike,
Could you please help merge this PR?
Thanks,
Saloni
From: Ashish Singhal
Sent: Wednesday, January 17, 2024 6:08 AM
To: Kasbekar, Saloni ; devel@edk2.groups.io;
Clark-williams, Zachary ; Jeff Brasen
Subject: Re: [PATCH] NetworkPkg/Ip4Dxe: Fix Reset To Default
Hello,
Checking
Hello,
Checking back for an update on when this PR can be merged or if there are any
other changes you recommend.
Thanks
Ashish
From: Ashish Singhal
Sent: Saturday, January 6, 2024 5:53 AM
To: Kasbekar, Saloni ; devel@edk2.groups.io
; Clark-williams, Zachary
Thanks Saloni. PR for getting this merged is available at
https://github.com/tianocore/edk2/pull/5150
Thanks
Ashish
From: Kasbekar, Saloni
Sent: Saturday, January 6, 2024 1:31 AM
To: Ashish Singhal ; devel@edk2.groups.io
; Clark-williams, Zachary
; Jeff
Yes, SetData does reset the previous configuration.
Reviewed-by: Saloni Kasbekar
Thanks,
Saloni
From: Ashish Singhal
Sent: Friday, January 5, 2024 2:34 AM
To: Kasbekar, Saloni ; devel@edk2.groups.io;
Clark-williams, Zachary ; Jeff Brasen
Subject: Re: [PATCH] NetworkPkg/Ip4Dxe: Fix Reset To
I do not recommend doing that. Setting policy via SetData does enough to wipe
out any previous manual configuration and that is the goal for reset to default.
From: Kasbekar, Saloni
Sent: Friday, January 5, 2024 2:30 AM
To: Ashish Singhal ; devel@edk2.groups.io
Makes sense. Should we also set IfrNvData->DhcpEnable = TRUE when updating the
Policy then?
From: Ashish Singhal
Sent: Wednesday, January 3, 2024 8:52 AM
To: Kasbekar, Saloni ; devel@edk2.groups.io;
Clark-williams, Zachary ; Jeff Brasen
Subject: Re: [PATCH] NetworkPkg/Ip4Dxe: Fix Reset To
Hello Saloni,
Thanks for the feedback. After the reset, or when we disable configure from
menu, GetData returns policy to static as the enum value is 0. However, setting
value as static does not have any benefit as it forces to reuse the old network
settings. Using DHCP really mimics the reset
Hi Ashish,
+Ip4NvData->Policy = Ip4Config2PolicyDhcp;
+Status= Ip4Cfg2->SetData (
+ Ip4Cfg2,
+ Ip4Config2DataTypePolicy,
+ sizeof (EFI_IP4_CONFIG2_POLICY),
+
Hello,
Checking again for some feedback on this.
Thanks
Ashish
From: Ashish Singhal
Sent: Thursday, December 14, 2023 4:42 PM
To: devel@edk2.groups.io ; saloni.kasbe...@intel.com
; zachary.clark-willi...@intel.com
; Jeff Brasen
Cc: Ashish Singhal
Subject:
Exercising reset to default does not reset the settings.
Add handler code for the case where configuration is
disabled.
Signed-off-by: Ashish Singhal
---
NetworkPkg/Ip4Dxe/Ip4Config2Nv.c | 25 +
1 file changed, 25 insertions(+)
diff --git
14 matches
Mail list logo
