Re: [edk2-devel] [PATCH] NetworkPkg/TlsAuthConfigDxe: Use HiiPopUp() instead of CreatePopUp()

2020-04-19 Thread Keysound Chang
: Wu, Jiaxin Subject: Re: [edk2-devel] [PATCH] NetworkPkg/TlsAuthConfigDxe: Use HiiPopUp() instead of CreatePopUp() Hi Chang, For any and all of your future patches, "Signed-off" should contain your name + email and maintainer should be in Cc :) Reviewed-by: Maciej Rabeda Thanks, Mac

Re: [edk2-devel] [PATCH] NetworkPkg/TlsAuthConfigDxe: Use HiiPopUp() instead of CreatePopUp()

2020-04-17 Thread Maciej Rabeda
Hi Chang, For any and all of your future patches, "Signed-off" should contain your name + email and maintainer should be in Cc :) Reviewed-by: Maciej Rabeda Thanks, Maciej On 17-Apr-20 04:38, Siyuan, Fu wrote: Reviewed-by: Siyuan Fu -Original Message- From: Keysound Chang

Re: [edk2-devel] [PATCH] NetworkPkg/TlsAuthConfigDxe: Use HiiPopUp() instead of CreatePopUp()

2020-04-16 Thread Siyuan, Fu
Reviewed-by: Siyuan Fu > -Original Message- > From: Keysound Chang > Sent: 2020年4月9日 14:57 > To: devel@edk2.groups.io > Cc: Keysound Chang ; Wu, Jiaxin > ; Fu, Siyuan ; Maciej Rabeda > > Subject: [PATCH] NetworkPkg/TlsAuthConfigDxe: Use HiiPopUp() instead of > CreatePopUp() > > From:

Re: [edk2-devel] [PATCH] NetworkPkg/TlsAuthConfigDxe: Use HiiPopUp() instead of CreatePopUp()

2020-04-09 Thread 張金松
Hi Siyuan, Sorry for making you confused. Actually all of 4 are the same just because I thought blocked by mail list and sent many times. Please use last one. Thanks. Keysound Siyuan, Fu 於 2020年4月9日 週四 下午4:28寫道: > Hi, Chang > > I received 4 patch mails with the same title "[PATCH] >

[edk2-devel] [PATCH] NetworkPkg/TlsAuthConfigDxe: Use HiiPopUp() instead of CreatePopUp()

2020-04-09 Thread Keysound Chang
From: Keysound Chang REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2635 According to EDK2 Driver Writer's Guide For UEFI 2.3.1, 4.2.18 Offer alternatives to function keys. Configuration of drivers should be accomplished via HII and via OS-present interfaces. Cc: Jiaxin Wu Cc: Siyuan Fu

Re: [edk2-devel] [PATCH] NetworkPkg/TlsAuthConfigDxe: Use HiiPopUp() instead of CreatePopUp()

2020-04-09 Thread Siyuan, Fu
Hi, Chang I received 4 patch mails with the same title "[PATCH] NetworkPkg/TlsAuthConfigDxe: Use HiiPopUp() instead of CreatePopUp()". Did you sent them by mistake or they are different patches? Please update the title with [PATCH v*] prefix if the patch content is changed so we could know