Re: [edk2-devel] [PATCH] RedfishPkg/RedfishPlatformConfigDxe: fix can not set one-of option issue.

2023-09-12 Thread Nickle Wang via groups.io
Hi Igor, Version 2 is here: https://edk2.groups.io/g/devel/message/108516 Please help me to review this while you have chance. Thanks, Nickle > -Original Message- > From: Igor Kulchytskyy > Sent: Thursday, August 3, 2023 9:27 PM > To: Nickle Wang ; devel@edk2.groups.io > Cc: Abner Chan

Re: [edk2-devel] [PATCH] RedfishPkg/RedfishPlatformConfigDxe: fix can not set one-of option issue.

2023-08-03 Thread Igor Kulchytskyy via groups.io
Thank you, Nickle. -Original Message- From: Nickle Wang Sent: Thursday, August 03, 2023 2:00 AM To: Igor Kulchytskyy ; devel@edk2.groups.io Cc: Abner Chang ; Nick Ramirez Subject: RE: [EXTERNAL] [PATCH] RedfishPkg/RedfishPlatformConfigDxe: fix can not set one-of option issue. Hi Igor,

Re: [edk2-devel] [PATCH] RedfishPkg/RedfishPlatformConfigDxe: fix can not set one-of option issue.

2023-08-02 Thread Nickle Wang via groups.io
Hi Igor, Thanks for your review. I think this is feasible. Let me try it and provide version 2 patch. Thanks, Nickle > -Original Message- > From: Igor Kulchytskyy > Sent: Monday, July 24, 2023 9:49 AM > To: Nickle Wang ; devel@edk2.groups.io > Cc: Abner Chang ; Nick Ramirez > > Subjec

Re: [edk2-devel] [PATCH] RedfishPkg/RedfishPlatformConfigDxe: fix can not set one-of option issue.

2023-07-23 Thread Igor Kulchytskyy via groups.io
Hi Nickle, May I ask you a question. What is the point to allocate and copy buffer. Then delete the original buffer. Could we just assign StatementValue->Buffer to TempBuffer and then assign NULL to StatementValue->Buffer? TempBuffer = StatementValue->Buffer; StatementValue->Buffer = NULL; Resu

[edk2-devel] [PATCH] RedfishPkg/RedfishPlatformConfigDxe: fix can not set one-of option issue.

2023-07-22 Thread Nickle Wang via groups.io
StatementValue->Buffer is converted from ASCII to Unicode by caller already so we don't have to convert it again. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy Cc: Nick Ramirez --- .../RedfishPlatformConfigDxe/RedfishPlatformConfigDxe.c | 6 +- 1 file changed, 5 inse