Re: [edk2-devel] [PATCH] UefiCpuPkg/MpInitLib: Skip reading PlatformId on AMD processors.

2020-04-22 Thread Duran, Leo
> -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Monday, April 20, 2020 5:41 AM > To: Gary Lin ; devel@edk2.groups.io; Duran, Leo > > Cc: Eric Dong ; Ray Ni > Subject: Re: [edk2-devel] [PATCH] UefiCpuPkg/MpInitLib: Skip readin

Re: [edk2-devel] [PATCH] UefiCpuPkg/MpInitLib: Skip reading PlatformId on AMD processors.

2020-04-20 Thread Laszlo Ersek
On 04/17/20 10:14, Gary Lin wrote: > On Sat, Feb 29, 2020 at 09:05:45AM -0600, Leo Duran wrote: >> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2556 >> >> This patch uses CPUID signature check to skip reading the PlatformId MSR, >> which is not implemented on AMD processors. >> >> The

Re: [edk2-devel] [PATCH] UefiCpuPkg/MpInitLib: Skip reading PlatformId on AMD processors.

2020-04-17 Thread Gary Lin
On Sat, Feb 29, 2020 at 09:05:45AM -0600, Leo Duran wrote: > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2556 > > This patch uses CPUID signature check to skip reading the PlatformId MSR, > which is not implemented on AMD processors. > > The PlatformId is used for loading microcode

Re: [edk2-devel] [PATCH] UefiCpuPkg/MpInitLib: Skip reading PlatformId on AMD processors.

2020-03-01 Thread Ni, Ray
k2-devel] [PATCH] UefiCpuPkg/MpInitLib: Skip reading > PlatformId on AMD processors. > > Leo, > The function name is the same as another local function defined in > LocalApicLib. > You may need to add a STATIC keyword for this local function, or change it to > a > different n

Re: [edk2-devel] [PATCH] UefiCpuPkg/MpInitLib: Skip reading PlatformId on AMD processors.

2020-03-01 Thread Ni, Ray
Leo, The function name is the same as another local function defined in LocalApicLib. You may need to add a STATIC keyword for this local function, or change it to a different name. Thanks, Ray > -Original Message- > From: Leo Duran > Sent: Saturday, February 29, 2020 11:06 PM > To:

[edk2-devel] [PATCH] UefiCpuPkg/MpInitLib: Skip reading PlatformId on AMD processors.

2020-02-29 Thread Leo Duran
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2556 This patch uses CPUID signature check to skip reading the PlatformId MSR, which is not implemented on AMD processors. The PlatformId is used for loading microcode patches, which is also not supported and AMD-based platforms. To mitigate

Re: [edk2-devel] [PATCH] UefiCpuPkg/MpInitLib: Skip reading PlatformId on AMD processors.

2020-02-29 Thread Laszlo Ersek
On 02/29/20 16:05, Leo Duran wrote: > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2556 > > This patch uses CPUID signature check to skip reading the PlatformId MSR, > which is not implemented on AMD processors. > > The PlatformId is used for loading microcode patches, which is also not >

Re: [edk2-devel] [PATCH] UefiCpuPkg/MpInitLib: Skip reading PlatformId on AMD processors.

2020-02-29 Thread Ni, Ray
Did you try the build? I saw "error C2065: CPUID_SIGNATURE_AUTHENTIC_AMD_EBX: undeclared identifier" in my internal build report with this patch. Thanks, Ray > -Original Message- > From: Laszlo Ersek > Sent: Saturday, February 29, 2020 3:33 PM > To: Leo Duran ; devel@edk2.groups.io >

Re: [edk2-devel] [PATCH] UefiCpuPkg/MpInitLib: Skip reading PlatformId on AMD processors.

2020-02-28 Thread Laszlo Ersek
On 02/28/20 19:58, Leo Duran wrote: > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2556 > > This patch uses CPUID signature check to skip reading the PlatformId MSR, > which is not implemented on AMD processors. > > The PlatformId is used for loading microcode patches, which is also not >

[edk2-devel] [PATCH] UefiCpuPkg/MpInitLib: Skip reading PlatformId on AMD processors.

2020-02-28 Thread Leo Duran
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2556 This patch uses CPUID signature check to skip reading the PlatformId MSR, which is not implemented on AMD processors. The PlatformId is used for loading microcode patches, which is also not supported and AMD-based platforms. To mitigate

[edk2-devel] [PATCH] UefiCpuPkg/MpInitLib: Skip reading PlatformId on AMD processors.

2020-02-28 Thread Leo Duran
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2556 This patch uses CPUID signature check to skip reading the PlatformId MSR, which is not implemented on AMD processors. The PlatformId is used for loading microcode patches, which is also not supported and AMD-based platforms. To mitigate