Re: [edk2-devel] [PATCH] UefiCpuPkg: Calculate DisplayFamily correctly

2023-03-06 Thread Zhiguang Liu
> > From: Mike Maslenkin > > Sent: Monday, March 6, 2023 9:37 PM > > To: devel@edk2.groups.io; Ni, Ray > > Subject: Re: [edk2-devel] [PATCH] UefiCpuPkg: Calculate DisplayFamily > > correctly > > > > There is no problem with curren

Re: [edk2-devel] [PATCH] UefiCpuPkg: Calculate DisplayFamily correctly

2023-03-06 Thread Ni, Ray
t 2:52 PM Ni, Ray wrote: > > > > ExtendedModelId field should use shift. So I believe nothing wrong there. > > > > > -Original Message- > > > From: Mike Maslenkin > > > Sent: Monday, March 6, 2023 7:14 PM > > > To: devel@edk2.groups.io; Zen

Re: [edk2-devel] [PATCH] UefiCpuPkg: Calculate DisplayFamily correctly

2023-03-06 Thread Zhiguang Liu
; Zeng, Star ; Liu, Zhiguang > > Cc: Dong, Eric ; Ni, Ray ; Kumar, > Rahul R ; Gerd Hoffmann ; > Zeng, Star > Subject: RE: [edk2-devel] [PATCH] UefiCpuPkg: Calculate DisplayFamily > correctly > > BTW, look like wrong Bugzilla ID is used in commit message, please

Re: [edk2-devel] [PATCH] UefiCpuPkg: Calculate DisplayFamily correctly

2023-03-06 Thread Chang, Abner via groups.io
.groups.io; ray...@intel.com > Subject: Re: [edk2-devel] [PATCH] UefiCpuPkg: Calculate DisplayFamily > correctly > > Caution: This message originated from an External Source. Use proper > caution when opening attachments, clicking links, or responding. > > > There is no pr

Re: [edk2-devel] [PATCH] UefiCpuPkg: Calculate DisplayFamily correctly

2023-03-06 Thread Mike Maslenkin
4 PM > > To: devel@edk2.groups.io; Zeng, Star > > Cc: Liu, Zhiguang ; Dong, Eric > > ; Ni, Ray ; Kumar, Rahul R > > ; Gerd Hoffmann > > Subject: Re: [edk2-devel] [PATCH] UefiCpuPkg: Calculate DisplayFamily > > correctly > > > > Handling of Extende

Re: [edk2-devel] [PATCH] UefiCpuPkg: Calculate DisplayFamily correctly

2023-03-06 Thread Ni, Ray
d Hoffmann > Subject: Re: [edk2-devel] [PATCH] UefiCpuPkg: Calculate DisplayFamily > correctly > > Handling of ExtendedModelId field has the same problem. > This patch could be improved to fix that too. > > On Mon, Mar 6, 2023 at 1:37 PM Zeng, Star wrote: > > > &

Re: [edk2-devel] [PATCH] UefiCpuPkg: Calculate DisplayFamily correctly

2023-03-06 Thread Mike Maslenkin
riginal Message- > From: devel@edk2.groups.io On Behalf Of Zeng, Star > Sent: Monday, March 6, 2023 6:35 PM > To: devel@edk2.groups.io; Liu, Zhiguang > Cc: Dong, Eric ; Ni, Ray ; Kumar, > Rahul R ; Gerd Hoffmann ; Zeng, > Star > Subject: Re: [edk2-devel] [PATCH] UefiCpuPkg:

Re: [edk2-devel] [PATCH] UefiCpuPkg: Calculate DisplayFamily correctly

2023-03-06 Thread Zeng, Star
, Rahul R ; Gerd Hoffmann ; Zeng, Star Subject: Re: [edk2-devel] [PATCH] UefiCpuPkg: Calculate DisplayFamily correctly Reviewed-by: Star Zeng -Original Message- From: devel@edk2.groups.io On Behalf Of Zhiguang Liu Sent: Thursday, March 2, 2023 9:27 AM To: devel@edk2.groups.io Cc: Liu

Re: [edk2-devel] [PATCH] UefiCpuPkg: Calculate DisplayFamily correctly

2023-03-06 Thread Zeng, Star
Reviewed-by: Star Zeng -Original Message- From: devel@edk2.groups.io On Behalf Of Zhiguang Liu Sent: Thursday, March 2, 2023 9:27 AM To: devel@edk2.groups.io Cc: Liu, Zhiguang ; Dong, Eric ; Ni, Ray ; Kumar, Rahul R ; Gerd Hoffmann Subject: [edk2-devel] [PATCH] UefiCpuPkg: Calculate

Re: [edk2-devel] [PATCH] UefiCpuPkg: Calculate DisplayFamily correctly

2023-03-01 Thread Gerd Hoffmann
On Thu, Mar 02, 2023 at 09:26:49AM +0800, Zhiguang Liu wrote: > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4238 > > Per SDM, DisplayFamily = Extended_Family_ID + Family_ID. > Correct the related code. Acked-by: Gerd Hoffmann take care, Gerd -=-=-=-=-=-=-=-=-=-=-=- Groups.io

Re: [edk2-devel] [PATCH] UefiCpuPkg: Calculate DisplayFamily correctly

2023-03-01 Thread Ni, Ray
Reviewed-by: Ray Ni > -Original Message- > From: Liu, Zhiguang > Sent: Thursday, March 2, 2023 9:27 AM > To: devel@edk2.groups.io > Cc: Liu, Zhiguang ; Dong, Eric > ; Ni, Ray ; Kumar, Rahul R > ; Gerd Hoffmann > Subject: [PATCH] UefiCpuPkg: Calculate DisplayFamily correctly > > REF:

[edk2-devel] [PATCH] UefiCpuPkg: Calculate DisplayFamily correctly

2023-03-01 Thread Zhiguang Liu
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4238 Per SDM, DisplayFamily = Extended_Family_ID + Family_ID. Correct the related code. Cc: Eric Dong Cc: Ray Ni Cc: Rahul Kumar Cc: Gerd Hoffmann Signed-off-by: Zhiguang Liu --- UefiCpuPkg/Application/Cpuid/Cpuid.c