I see what's going wrong.
First, PatchCheck.py isn't ignoring tabs in files named "*.makefile" or
"makefile".
Michael Kubacki has a patch to fix that (I also submitted a patch, but
I'll let him commit his changes).
Secondly, edk2basetools has a copy of Workspace/DscBuildData.py which is
Rebecca:
I create PR https://github.com/tianocore/edk2/pull/4162 . But PR shows some
failure. Can you help fix them?
Thanks
Liming
> -邮件原件-
> 发件人: devel@edk2.groups.io 代表 gaoliming via
> groups.io
> 发送时间: 2023年3月23日 9:10
> 收件人: devel@edk2.groups.io; rebe...@bsdio.com; 'Andrew Fish'
>
Rebecca:
This patch looks good to me. Reviewed-by: Liming Gao
I will help to merge this patch set.
Thanks
Liming
> -邮件原件-
> 发件人: Rebecca Cran
> 发送时间: 2023年3月15日 0:17
> 收件人: devel@edk2.groups.io; Andrew Fish ; Leif
> Lindholm ; Michael D Kinney
> ; Bob Feng ; Liming
> Gao ; Yuwei
This is a patch series that I'd really like to get committed.
It'll allow us to drop the dependency on gcc for building edk2 on FreeBSD.
The Github branch is https://github.com/bcran/edk2/tree/mdepkg-c11 and
there's a PR at https://github.com/tianocore/edk2/pull/4142.
--
Rebecca Cran
On
Could I get some reviews on this please?
Thanks.
Rebecca Cran
On 2/16/23 8:50 PM, Rebecca Cran wrote:
Currently, the BaseTools Makefiles use BUILD_CC and BUILD_CXX, which
doesn't allow users to override the compiler to use in the expected way
by running e.g. "make CC=clang-17
Currently, the BaseTools Makefiles use BUILD_CC and BUILD_CXX, which
doesn't allow users to override the compiler to use in the expected way
by running e.g. "make CC=clang-17 CXX=clang++-17". clang/llvm support
was added in https://bugzilla.tianocore.org/show_bug.cgi?id=2842 in a
way that required
