Re: [edk2-devel] [PATCH 0/4] Auto configure Fsp*BaseAddress PCD

2019-07-29 Thread Chiu, Chasel
Yes, we will remove them later after confirming no impact to all platforms. Regards, Chasel > -Original Message- > From: Gao, Liming > Sent: Tuesday, July 30, 2019 11:46 AM > To: Chiu, Chasel ; devel@edk2.groups.io > Cc: Kubacki, Michael A ; Sinha, Ankit > ; Desimone, Nathaniel L > >

Re: [edk2-devel] [PATCH 0/4] Auto configure Fsp*BaseAddress PCD

2019-07-29 Thread Liming Gao
Chasel: This is a good enhancement. With this change, can RebaseAndPatchFspBinBaseAddress.py and PatchFspBinFvsBaseAddress.py be removed? Thanks Liming > -Original Message- > From: Chiu, Chasel > Sent: Monday, July 29, 2019 7:07 PM > To: devel@edk2.groups.io > Cc: Kubacki, Michael A ;

Re: [edk2-devel] [PATCH 0/4] Auto configure Fsp*BaseAddress PCD

2019-07-29 Thread Chiu, Chasel
chael A ; Sinha, Ankit > ; Desimone, Nathaniel L > ; Gao, Liming > Subject: Re: [edk2-devel] [PATCH 0/4] Auto configure Fsp*BaseAddress PCD > > On 07/29/19 13:07, Chiu, Chasel wrote: > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1863 > > > > PcdFsp*BaseAd

Re: [edk2-devel] [PATCH 0/4] Auto configure Fsp*BaseAddress PCD

2019-07-29 Thread Laszlo Ersek
On 07/29/19 13:07, Chiu, Chasel wrote: > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1863 > > PcdFsp*BaseAddress now will be updated in FDF basing > on flash map. > DSC will only define types of those PCDs and always > having 0 as default. > New script added to only rebase FSP binary

[edk2-devel] [PATCH 0/4] Auto configure Fsp*BaseAddress PCD

2019-07-29 Thread Chiu, Chasel
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1863 PcdFsp*BaseAddress now will be updated in FDF basing on flash map. DSC will only define types of those PCDs and always having 0 as default. New script added to only rebase FSP binary without patching DSC file. Test: interanl platform