Thanks Nate for detail reviewing and all the good feedbacks!
I have applied all of them and sent a V2 patch series, please help to review
again.
From: Desimone, Nathaniel L
Sent: Thursday, August 4, 2022 5:51 PM
To: Chiu, Chasel ; devel@edk2.groups.io
Cc: Zeng, Star
Subject: RE: [PATCH 0/4]
Hi Chasel,
I have a few comments for you.
First, we should have a platform provided LibraryClass for running code in
between multi-phase actions. Right now you just have this comment in
IntelFsp2WrapperPkg/Library/FspWrapperMultiPhaseProcessLib/PeiFspWrapperMultiPhaseProcessLib.c:
//
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3916
Add FSP 2.4 MultiPhase interfaces and implementation.
Cc: Nate DeSimone
Cc: Star Zeng
Signed-off-by: Chasel Chiu
Chasel Chiu (4):
IntelFsp2Pkg: Add FSP 2.4 MultiPhase interface.
IntelFsp2WrapperPkg: Add FSP 2.4 MultiPhase
