; Lu, XiaoyuX
; Ard Biesheuvel ; Leif Lindholm
Subject: Re: [edk2-devel] [PATCH 00/15] Add a plugin LicenseCheck in open ci
Rebecca:
I see Shenglei patch. I plan to finish review early of this week, then merge
this patch set, and revert the original change in PatchCheck.py.
Thanks
Liming
Subject: Re: [edk2-devel] [PATCH 00/15] Add a plugin LicenseCheck in open ci
Rebecca:
I see Shenglei patch. I plan to finish review early of this week, then merge
this patch set, and revert the original change in PatchCheck.py.
Thanks
Liming
-Original Message-
From: Rebecca Cran
Sent
; Chao Zhang ; Justen, Jordan L
; Maciej Rabeda ; Wu,
Jiaxin ; Fu, Siyuan ; Wang, Jian J
; Wu, Hao A ; Ni, Ray
; Lu, XiaoyuX ; Ard Biesheuvel
; Leif Lindholm
Subject: Re: [edk2-devel] [PATCH 00/15] Add a plugin LicenseCheck in open ci
> On Jul 29, 2020, at 2:21 AM, Laszlo Ersek wr
> On Jul 29, 2020, at 2:21 AM, Laszlo Ersek wrote:
>
> On 07/29/20 03:32, Kinney, Michael D wrote:
>> Hi Liming,
>>
>> There are exception to PatchCheck as well for line endings and tabs.
>>
>> Seems like a similar problem, and a single CI plugin could
>> support all these cases.
>
> The
On Wed, Jul 29, 2020 at 11:12:02 +0200, Laszlo Ersek wrote:
> On 07/29/20 01:33, Kinney, Michael D wrote:
> > CI already runs PatchCheck. If we ported PatchCheck to
> > a CI plugin, then the plugin could perform both the
> > current PatchCheck features and the license check.
> >
> > What this
On 07/29/20 03:32, Kinney, Michael D wrote:
> Hi Liming,
>
> There are exception to PatchCheck as well for line endings and tabs.
>
> Seems like a similar problem, and a single CI plugin could
> support all these cases.
The exceptions for LicenseCheck are individual files that package
On 07/29/20 01:33, Kinney, Michael D wrote:
> CI already runs PatchCheck. If we ported PatchCheck to
> a CI plugin, then the plugin could perform both the
> current PatchCheck features and the license check.
>
> What this option evaluated?
>
> If we did provide PatchCheck as a CI plugin,
Mike:
I think this is a separate request. I submit BZ
https://bugzilla.tianocore.org/show_bug.cgi?id=2868 for it.
Thanks
Liming
-Original Message-
From: Kinney, Michael D
Sent: 2020年7月29日 9:33
To: Gao, Liming ; Zhang, Shenglei
; devel@edk2.groups.io; Kinney, Michael D
Cc: Sean
Hi Liming,
There are exception to PatchCheck as well for line endings and tabs.
Seems like a similar problem, and a single CI plugin could
support all these cases.
Mike
> -Original Message-
> From: Gao, Liming
> Sent: Tuesday, July 28, 2020 6:12 PM
> To: Kinney, Michael D ;
> Zhang,
Mike:
Previous discussion (https://edk2.groups.io/g/devel/message/62494) is to
revert the license check change in PatchCheck, and enable license check as
plugin. If so, the package maintainers can configure the package level
exception list to allow some special cases, such as autogen file.
CI already runs PatchCheck. If we ported PatchCheck to
a CI plugin, then the plugin could perform both the
current PatchCheck features and the license check.
What this option evaluated?
If we did provide PatchCheck as a CI plugin, developers
I believe developers could run a stuart command
Shenglei:
I have one comment. Seemly, LicenseCheck_plug_in.yaml copyright may be Intel
one.
Reviewed-by: Liming Gao for this patch set.
Thanks
Liming
-Original Message-
From: Zhang, Shenglei
Sent: 2020年7月20日 16:37
To: devel@edk2.groups.io
Cc: Kinney, Michael D ; Sean Brogan
;
: Re: [edk2-devel] [PATCH 00/15] Add a plugin LicenseCheck in open ci
On 7/20/20 2:36 AM, Zhang, Shenglei wrote:
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2691
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2833
> LicenseCheck is now enabled in PatchCheck.py. But there'
On 7/20/20 2:36 AM, Zhang, Shenglei wrote:
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2691
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2833
LicenseCheck is now enabled in PatchCheck.py. But there's
a patch "Revert 'BaseTools/PatchCheck.py: Add LicenseCheck'"
to suggest revert
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2691
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2833
LicenseCheck is now enabled in PatchCheck.py. But there's
a patch "Revert 'BaseTools/PatchCheck.py: Add LicenseCheck'"
to suggest revert the change.These patch series introduce
a
15 matches
Mail list logo
