Good suggestions, Jiaxin!
Thanks,
Ray
From: Tan, Dun
Sent: Monday, May 13, 2024 11:37
To: Wu, Jiaxin ; devel@edk2.groups.io
; Ni, Ray
Subject: RE: [edk2-devel] [PATCH 00/19] Remove some S3 related code in CpuS3.c
of smm cpu driver
Thanks for the comments
: [edk2-devel] [PATCH 00/19] Remove some S3 related code in CpuS3.c
of smm cpu driver
My comments as below:
1. I stronger recommend re-ordering the patches as below so as to combine all
related sub-patches together, then we can more easy understand what we are
target to resolving: 1) S3 MTRRs
copyright year.
3. Add all reviewer in the 00 patch.
4. Add PR in the 00 patch (if have).
Thanks,
Jiaxin
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of duntan
> Sent: Friday, May 10, 2024 6:08 PM
> To: devel@edk2.groups.io
> Subject: [edk2-devel] [PA
This patch set is to remove some S3 related code in CpuS3.c of smm cpu driver.
It contain commits to:
1.Save MTRR setting by lockbox in PEI phase
2.Load MTRR in S3Resume.c before transferring to CpuS3.c in smm cpu driver.
3.Add callback of gEdkiiEndOfS3ResumeGuid in PeiMpLib to relocate Ap to