Re: [edk2-devel] [PATCH 02/10] MdePkg/PiFirmwareFile: fix undefined behavior in SECTION_SIZE

2019-04-18 Thread Liming Gao
> -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Thursday, April 18, 2019 5:39 PM > To: devel@edk2.groups.io; Justen, Jordan L ; > Andrew Fish > Cc: Kinney, Michael D ; Gao, Liming > > Subject: Re: [edk2-devel] [PATCH 02/10] Md

Re: [edk2-devel] [PATCH 02/10] MdePkg/PiFirmwareFile: fix undefined behavior in SECTION_SIZE

2019-04-18 Thread Laszlo Ersek
On 04/17/19 21:35, Jordan Justen wrote: > On 2019-04-17 07:59:41, Laszlo Ersek wrote: >> On 04/17/19 13:44, Andrew Fish wrote: >> >>> Sorry I digressed into the C specification discussion, and did not >>> deal with the patch in general. My point is the original code is legal >>> C code. If you look

Re: [edk2-devel] [PATCH 02/10] MdePkg/PiFirmwareFile: fix undefined behavior in SECTION_SIZE

2019-04-17 Thread Jordan Justen
On 2019-04-17 07:59:41, Laszlo Ersek wrote: > On 04/17/19 13:44, Andrew Fish wrote: > > > Sorry I digressed into the C specification discussion, and did not > > deal with the patch in general. My point is the original code is legal > > C code. If you lookup CWE-119 it is written as a restriction o

Re: [edk2-devel] [PATCH 02/10] MdePkg/PiFirmwareFile: fix undefined behavior in SECTION_SIZE

2019-04-17 Thread Laszlo Ersek
On 04/17/19 13:44, Andrew Fish wrote: > Sorry I digressed into the C specification discussion, and did not > deal with the patch in general. My point is the original code is legal > C code. If you lookup CWE-119 it is written as a restriction on what > the C language allows. > > As I mentioned cas

Re: [edk2-devel] [PATCH 02/10] MdePkg/PiFirmwareFile: fix undefined behavior in SECTION_SIZE

2019-04-17 Thread Andrew Fish via Groups.Io
> On Apr 17, 2019, at 3:29 AM, Laszlo Ersek wrote: > > Hi Andrew, > > On 04/17/19 01:25, Andrew Fish wrote: >> >> >>> On Apr 16, 2019, at 11:48 AM, Jordan Justen >>> wrote: >>> >>> On 2019-04-16 03:59:48, Laszlo Ersek wrote: On 04/16/19 11:04, Jordan Justen wrote: > On 2019-04-15

Re: [edk2-devel] [PATCH 02/10] MdePkg/PiFirmwareFile: fix undefined behavior in SECTION_SIZE

2019-04-17 Thread Laszlo Ersek
Hi Andrew, On 04/17/19 01:25, Andrew Fish wrote: > > >> On Apr 16, 2019, at 11:48 AM, Jordan Justen >> wrote: >> >> On 2019-04-16 03:59:48, Laszlo Ersek wrote: >>> On 04/16/19 11:04, Jordan Justen wrote: On 2019-04-15 09:15:31, Laszlo Ersek wrote: > On 04/14/19 09:19, Jordan Justen wr

Re: [edk2-devel] [PATCH 02/10] MdePkg/PiFirmwareFile: fix undefined behavior in SECTION_SIZE

2019-04-17 Thread Laszlo Ersek
On 04/16/19 18:50, Philippe Mathieu-Daudé wrote: > Hi Laszlo, > > On 4/16/19 12:59 PM, Laszlo Ersek wrote: >> On 04/16/19 11:04, Jordan Justen wrote: >>> On 2019-04-15 09:15:31, Laszlo Ersek wrote: On 04/14/19 09:19, Jordan Justen wrote: > On 2019-04-12 16:31:20, Laszlo Ersek wrote: >

Re: [edk2-devel] [PATCH 02/10] MdePkg/PiFirmwareFile: fix undefined behavior in SECTION_SIZE

2019-04-17 Thread Laszlo Ersek
On 04/16/19 20:48, Jordan Justen wrote: > On 2019-04-16 03:59:48, Laszlo Ersek wrote: >> On 04/16/19 11:04, Jordan Justen wrote: >>> On 2019-04-15 09:15:31, Laszlo Ersek wrote: On 04/14/19 09:19, Jordan Justen wrote: > On 2019-04-12 16:31:20, Laszlo Ersek wrote: >> RH covscan justified

Re: [edk2-devel] [PATCH 02/10] MdePkg/PiFirmwareFile: fix undefined behavior in SECTION_SIZE

2019-04-16 Thread Andrew Fish via Groups.Io
> On Apr 16, 2019, at 11:48 AM, Jordan Justen wrote: > > On 2019-04-16 03:59:48, Laszlo Ersek wrote: >> On 04/16/19 11:04, Jordan Justen wrote: >>> On 2019-04-15 09:15:31, Laszlo Ersek wrote: On 04/14/19 09:19, Jordan Justen wrote: > On 2019-04-12 16:31:20, Laszlo Ersek wrote: >> R

Re: [edk2-devel] [PATCH 02/10] MdePkg/PiFirmwareFile: fix undefined behavior in SECTION_SIZE

2019-04-16 Thread Jordan Justen
On 2019-04-16 03:59:48, Laszlo Ersek wrote: > On 04/16/19 11:04, Jordan Justen wrote: > > On 2019-04-15 09:15:31, Laszlo Ersek wrote: > >> On 04/14/19 09:19, Jordan Justen wrote: > >>> On 2019-04-12 16:31:20, Laszlo Ersek wrote: > RH covscan justifiedly reports that accessing > "EFI_COMMO

Re: [edk2-devel] [PATCH 02/10] MdePkg/PiFirmwareFile: fix undefined behavior in SECTION_SIZE

2019-04-16 Thread Philippe Mathieu-Daudé
Hi Laszlo, On 4/16/19 12:59 PM, Laszlo Ersek wrote: > On 04/16/19 11:04, Jordan Justen wrote: >> On 2019-04-15 09:15:31, Laszlo Ersek wrote: >>> On 04/14/19 09:19, Jordan Justen wrote: On 2019-04-12 16:31:20, Laszlo Ersek wrote: > RH covscan justifiedly reports that accessing > "EFI_C

Re: [edk2-devel] [PATCH 02/10] MdePkg/PiFirmwareFile: fix undefined behavior in SECTION_SIZE

2019-04-16 Thread Laszlo Ersek
On 04/16/19 11:04, Jordan Justen wrote: > On 2019-04-15 09:15:31, Laszlo Ersek wrote: >> On 04/14/19 09:19, Jordan Justen wrote: >>> On 2019-04-12 16:31:20, Laszlo Ersek wrote: RH covscan justifiedly reports that accessing "EFI_COMMON_SECTION_HEADER.Size", which is of type UINT8[3], throu

Re: [edk2-devel] [PATCH 02/10] MdePkg/PiFirmwareFile: fix undefined behavior in SECTION_SIZE

2019-04-16 Thread Jordan Justen
On 2019-04-15 09:15:31, Laszlo Ersek wrote: > On 04/14/19 09:19, Jordan Justen wrote: > > On 2019-04-12 16:31:20, Laszlo Ersek wrote: > >> RH covscan justifiedly reports that accessing > >> "EFI_COMMON_SECTION_HEADER.Size", which is of type UINT8[3], through a > >> (UINT32*), is undefined behavior:

Re: [edk2-devel] [PATCH 02/10] MdePkg/PiFirmwareFile: fix undefined behavior in SECTION_SIZE

2019-04-16 Thread Liming Gao
ups.io] On Behalf Of >Laszlo Ersek >Sent: Tuesday, April 16, 2019 12:16 AM >To: Justen, Jordan L ; edk2-devel-groups-io >; Kinney, Michael D >Cc: Gao, Liming >Subject: Re: [edk2-devel] [PATCH 02/10] MdePkg/PiFirmwareFile: fix >undefined behavior in SECTION_SIZE > >On 04

Re: [edk2-devel] [PATCH 02/10] MdePkg/PiFirmwareFile: fix undefined behavior in SECTION_SIZE

2019-04-15 Thread Laszlo Ersek
On 04/14/19 09:19, Jordan Justen wrote: > On 2019-04-12 16:31:20, Laszlo Ersek wrote: >> RH covscan justifiedly reports that accessing >> "EFI_COMMON_SECTION_HEADER.Size", which is of type UINT8[3], through a >> (UINT32*), is undefined behavior: >> >>> Error: OVERRUN (CWE-119): >>> edk2-89910a39dcf

Re: [edk2-devel] [PATCH 02/10] MdePkg/PiFirmwareFile: fix undefined behavior in SECTION_SIZE

2019-04-14 Thread Jordan Justen
On 2019-04-12 16:31:20, Laszlo Ersek wrote: > RH covscan justifiedly reports that accessing > "EFI_COMMON_SECTION_HEADER.Size", which is of type UINT8[3], through a > (UINT32*), is undefined behavior: > > > Error: OVERRUN (CWE-119): > > edk2-89910a39dcfd/OvmfPkg/Sec/SecMain.c:178: overrun-local: O

[edk2-devel] [PATCH 02/10] MdePkg/PiFirmwareFile: fix undefined behavior in SECTION_SIZE

2019-04-12 Thread Laszlo Ersek
RH covscan justifiedly reports that accessing "EFI_COMMON_SECTION_HEADER.Size", which is of type UINT8[3], through a (UINT32*), is undefined behavior: > Error: OVERRUN (CWE-119): > edk2-89910a39dcfd/OvmfPkg/Sec/SecMain.c:178: overrun-local: Overrunning > array of 3 bytes at byte offset 3 by derefe