Re: [edk2-devel] [PATCH 1/1] BaseTools: Fix check for ${PYTHON_COMMAND} in Tests/GNUmakefile

2022-10-01 Thread Bob Feng
Reviewed-by: Bob Feng -Original Message- From: Rebecca Cran Sent: Tuesday, September 20, 2022 5:39 AM To: devel@edk2.groups.io; Feng, Bob C ; Gao, Liming ; Chen, Christine Cc: Rebecca Cran Subject: [PATCH 1/1] BaseTools: Fix check for ${PYTHON_COMMAND} in Tests/GNUmakefile When che

[edk2-devel] [PATCH 1/1] BaseTools: Fix check for ${PYTHON_COMMAND} in Tests/GNUmakefile

2022-09-19 Thread Rebecca Cran
When checking if $PYTHON_COMMAND exists, curly braces should be used instead of parentheses. Also, "1" causes an error on FreeBSD: it's likely supposed to be 2>&1 like other scripts. Signed-off-by: Rebecca Cran --- BaseTools/Tests/GNUmakefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-