I will update and resubmit for item a (add NULL) and item b (remove duplicate
EVP_PKEY_CTX_free) but the changing the code as suggested looks more complex to
me. I think the user of the label follows the pattern of other EDK2 code. A
single if with multiple function calls and relying on short
Gary,
See my comment below.
> -Original Message-
> From: West, Gary
> Sent: Tuesday, July 23, 2019 8:04 PM
> To: devel@edk2.groups.io
> Cc: West, Gary ; West, Gary ;
> Wang, Jian J ; Ye, Ting
> Subject: [PATCH 1/1] CryptoPkg/BaseCryptLib: Wrap OpenSSL HKDF
> algorithm
>
> REF:
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1928
1. Implement OpenSSL HKDF wrapped function in CryptHkdf.c file.
2. Implement stub implementation function in CryptHkdfNull.c file.
3. Add wrapped HKDF function declaration to BaseCryptLib.h file.
4. Add CryptHkdf.c to module information
Gary,
Mailing list edk2-de...@lists.01.org is not used any more. Please subscribe and
send review emails to devel@edk2.groups.io
Regards,
Jian
> -Original Message-
> From: Wang, Jian J
> Sent: Tuesday, July 23, 2019 12:53 PM
> To: West, Gary ; edk2-de...@lists.01.org
> Cc: Ye, Ting
