Re: [edk2-devel] [PATCH 1/1] IntelFsp2Pkg/Library/BaseFspCommonLib: Fix OVERRUN Coverity issue

2023-05-30 Thread Ranbir Singh
-Original Message- > > From: devel@edk2.groups.io On Behalf Of Pedro > > Falcato > > Sent: Friday, May 19, 2023 5:29 AM > > To: devel@edk2.groups.io; rsi...@ventanamicro.com > > Cc: Chiu, Chasel ; Desimone, Nathaniel L > > ; Zeng, Star ; > Ranbir > >

Re: [edk2-devel] [PATCH 1/1] IntelFsp2Pkg/Library/BaseFspCommonLib: Fix OVERRUN Coverity issue

2023-05-29 Thread Chiu, Chasel
Patch merged: https://github.com/tianocore/edk2/commit/48c53994e649d51a388dc414944c9a9b717a1c3c Thanks, Chasel > -Original Message- > From: Ranbir Singh > Sent: Wednesday, May 17, 2023 11:29 PM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Desimone, Nathaniel L > ; Zeng, Star ; Ran

Re: [edk2-devel] [PATCH 1/1] IntelFsp2Pkg/Library/BaseFspCommonLib: Fix OVERRUN Coverity issue

2023-05-29 Thread Chiu, Chasel
devel@edk2.groups.io; rsi...@ventanamicro.com > Cc: Chiu, Chasel ; Desimone, Nathaniel L > ; Zeng, Star ; Ranbir > Singh > Subject: Re: [edk2-devel] [PATCH 1/1] IntelFsp2Pkg/Library/BaseFspCommonLib: > Fix OVERRUN Coverity issue > > On Thu, May 18, 2023 at 4:16 PM Ranbir Singh > wrote:

Re: [edk2-devel] [PATCH 1/1] IntelFsp2Pkg/Library/BaseFspCommonLib: Fix OVERRUN Coverity issue

2023-05-19 Thread Pedro Falcato
On Thu, May 18, 2023 at 4:16 PM Ranbir Singh wrote: > > FspData->PerfIdx is getting increased for every call unconditionally > in the function SetFspMeasurePoint and hence memory access can happen > for out of bound FspData->PerfData[] array entries also. > > Example - >FspData->PerfData is an

Re: [edk2-devel] [PATCH 1/1] IntelFsp2Pkg/Library/BaseFspCommonLib: Fix OVERRUN Coverity issue

2023-05-18 Thread Chiu, Chasel
This fix looks good to me! Thanks Ranbir! Reviewed-by: Chasel Chiu > -Original Message- > From: Ranbir Singh > Sent: Wednesday, May 17, 2023 11:29 PM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Desimone, Nathaniel L > ; Zeng, Star ; Ranbir > Singh > Subject: [PATCH 1/1] IntelFsp2

[edk2-devel] [PATCH 1/1] IntelFsp2Pkg/Library/BaseFspCommonLib: Fix OVERRUN Coverity issue

2023-05-18 Thread Ranbir Singh
FspData->PerfIdx is getting increased for every call unconditionally in the function SetFspMeasurePoint and hence memory access can happen for out of bound FspData->PerfData[] array entries also. Example - FspData->PerfData is an array of 32 UINT64 entries. Assume a call is made to SetFspMea