Hi Nicholas,
Instead of adding gBS->SignalEvent() lines, please utilize
RECYCLE_RXDATA goto label. You can find the same gBS->SignalEvent()
being done there.
Additionally, please apply goto change in place pointed by Siyuan.
Thanks,
Maciej
On 17-Feb-20 06:15, Fu, Siyuan wrote:
Hi, Nicholas
On 02/13/20 00:53, Armour, Nicholas wrote:
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2031
>
> This patch triggers the RecycleEvent for invalid ARP packets.
> Prior to this, we would just ignore invalid ARP packets,
> and never free them.
>
> Cc: Jiaxin Wu
> Cc: Maciej Rabeda
> Cc:
Hi, Nicholas
Should the signal recycle event also be added to below if condition?
if (RxData->DataLength < sizeof (ARP_HEAD)) {
//
// Restart the receiving if packet size is not correct.
//
goto RESTART_RECEIVE;
}
Best Regards
Siyuan
> -Original Message-
> From:
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2031
This patch triggers the RecycleEvent for invalid ARP packets.
Prior to this, we would just ignore invalid ARP packets,
and never free them.
Cc: Jiaxin Wu
Cc: Maciej Rabeda
Cc: Siyuan Fu
Signed-off-by: Nicholas Armour
---
