Re: [edk2-devel] [PATCH 1/1] StandaloneMmPkg/Core: Remove optimization for depex evaluation

2024-01-22 Thread Michael D Kinney
Hi Ray, +Andrew Fish That optimization was imported into git history 17 years ago, so it has effectively always been there. I do not recall the performance improvement at the time the optimization was originally implemented. The difference in behavior is that caching the result may miss an

Re: [edk2-devel] [PATCH 1/1] StandaloneMmPkg/Core: Remove optimization for depex evaluation

2024-01-21 Thread Ni, Ray
Reviewed-by: Ray Ni PI spec does not define the REPLACE_TRUE op-code. Existing dispatchers (DXE, SMM and Standalone MM) use REPLACE_TRUE to optimize the protocol evaluation. PEI dispatcher does not use this optimization as the Depex binary might be in flash. Now this patch only modifies

Re: [edk2-devel] [PATCH 1/1] StandaloneMmPkg/Core: Remove optimization for depex evaluation

2024-01-21 Thread Nhi Pham via groups.io
On 1/19/2024 6:51 PM, levi.yun wrote: Except, 8bit transfer encoding. Tested-by: levi.yun Reviewed-by: levi.yun Thanks Levi Yun for testing. -Nhi -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#114131):

Re: [edk2-devel] [PATCH 1/1] StandaloneMmPkg/Core: Remove optimization for depex evaluation

2024-01-21 Thread Nhi Pham via groups.io
On 1/19/2024 5:39 PM, Ard Biesheuvel wrote: Thanks for the patch. This looks good to me in principle, only the patch got mangled by your MTA Please resend using 8bit transfer encoding. (You can use BaseTools/Scripts/SetupGit.py to configure Git for you) Thanks Ard, I will resend the patch

Re: [edk2-devel] [PATCH 1/1] StandaloneMmPkg/Core: Remove optimization for depex evaluation

2024-01-19 Thread Laszlo Ersek
On 1/19/24 05:56, Nhi Pham wrote: > From: Laszlo Ersek > > The current dependency evaluator violates the memory access permission > when patching depex grammar directly in the read-only depex memory area. > > Laszlo pointed out the optimization issue in the thread (1) "Memory > Attribute for

Re: [edk2-devel] [PATCH 1/1] StandaloneMmPkg/Core: Remove optimization for depex evaluation

2024-01-19 Thread levi.yun
Except, 8bit transfer encoding. Tested-by: levi.yun Reviewed-by: levi.yun On 19/01/2024 10:39, Ard Biesheuvel via groups.io wrote: On Fri, 19 Jan 2024 at 05:58, Nhi Pham via groups.io wrote: From: Laszlo Ersek The current dependency evaluator violates the memory access permission when

Re: [edk2-devel] [PATCH 1/1] StandaloneMmPkg/Core: Remove optimization for depex evaluation

2024-01-19 Thread Ard Biesheuvel
On Fri, 19 Jan 2024 at 05:58, Nhi Pham via groups.io wrote: > > From: Laszlo Ersek > > The current dependency evaluator violates the memory access permission > when patching depex grammar directly in the read-only depex memory area. > > Laszlo pointed out the optimization issue in the thread (1)

[edk2-devel] [PATCH 1/1] StandaloneMmPkg/Core: Remove optimization for depex evaluation

2024-01-18 Thread Nhi Pham via groups.io
From: Laszlo Ersek The current dependency evaluator violates the memory access permission when patching depex grammar directly in the read-only depex memory area. Laszlo pointed out the optimization issue in the thread (1) "Memory Attribute for depex section" and provided suggested patch to