Re: [edk2-devel] [PATCH 1/2] Add VS2019 Toolchain def

2019-09-16 Thread Pete Batard
o:devel@edk2.groups.io] On Behalf Of Pete Batard Sent: Wednesday, September 11, 2019 11:43 PM To: devel@edk2.groups.io; Cheng, Ching JenX Cc: Chan, Amy ; Feng, Bob C ; Gao, Liming Subject: Re: [edk2-devel] [PATCH 1/2] Add VS2019 Toolchain def Hi Ching JenX, Please see two comments inline.

Re: [edk2-devel] [PATCH 1/2] Add VS2019 Toolchain def

2019-09-11 Thread Pete Batard
Hi Ching JenX, Please see two comments inline. On 2019.09.11 07:08, Cheng, Ching JenX wrote: REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2182 In order to support VS2019, the first thing need to do is add 2019 toolchain on tools_def.template Change-Id:

[edk2-devel] [PATCH 1/2] Add VS2019 Toolchain def

2019-09-11 Thread Cheng, Ching JenX
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2182 In order to support VS2019, the first thing need to do is add 2019 toolchain on tools_def.template Change-Id: Id52abdc9762cf06bb9a38bbfd1153608c878d839 Cc: Amy Chan Cc: Bob Feng Cc: Liming Gao Signed-off-by: Ching JenX Cheng ---