Re: [edk2-devel] [PATCH 1/2] UefiCpuPkg/CpuDxe: Rename variables to follow EDKII coding standard

2021-03-16 Thread Ni, Ray
> (1) I think "mGdtTemplate" would be a better name than "gGdtTemplate". I > think the "g" prefix is used when an object is identical for all > firmware modules (such as named GUIDs, for example). Agree! I will change in v2. > > (2) I think the last hunk does not belong in this patch -- more >

Re: [edk2-devel] [PATCH 1/2] UefiCpuPkg/CpuDxe: Rename variables to follow EDKII coding standard

2021-03-16 Thread Laszlo Ersek
On 03/16/21 04:33, Ray Ni wrote: > The change doesn't impact any functionality. > > Signed-off-by: Ray Ni > Cc: Eric Dong > Cc: Laszlo Ersek > Cc: Rahul Kumar > --- > UefiCpuPkg/CpuDxe/CpuGdt.c | 27 +-- > 1 file changed, 13 insertions(+), 14 deletions(-) > > diff

Re: [edk2-devel] [PATCH 1/2] UefiCpuPkg/CpuDxe: Rename variables to follow EDKII coding standard

2021-03-16 Thread Dong, Eric
Reviewed-by: Eric Dong -Original Message- From: Ni, Ray Sent: Tuesday, March 16, 2021 11:34 AM To: devel@edk2.groups.io Cc: Dong, Eric ; Laszlo Ersek ; Kumar, Rahul1 Subject: [PATCH 1/2] UefiCpuPkg/CpuDxe: Rename variables to follow EDKII coding standard The change doesn't impact

[edk2-devel] [PATCH 1/2] UefiCpuPkg/CpuDxe: Rename variables to follow EDKII coding standard

2021-03-15 Thread Ni, Ray
The change doesn't impact any functionality. Signed-off-by: Ray Ni Cc: Eric Dong Cc: Laszlo Ersek Cc: Rahul Kumar --- UefiCpuPkg/CpuDxe/CpuGdt.c | 27 +-- 1 file changed, 13 insertions(+), 14 deletions(-) diff --git a/UefiCpuPkg/CpuDxe/CpuGdt.c