Re: [edk2-devel] [PATCH 1/3] BaseTools: Allow users to specify compiler to use with make CC= CXX=

2023-03-20 Thread Rebecca Cran
Sorry, I don't think I saw a suggestion from you to not set CC - though I may have missed emails since this patch series was sent from the email of my former employer. Marvin did suggest that though, so I can certainly add another patch to the series to do that. -- Rebecca Cran On

Re: [edk2-devel] [PATCH 1/3] BaseTools: Allow users to specify compiler to use with make CC= CXX=

2023-03-20 Thread Gerd Hoffmann
On Fri, Mar 17, 2023 at 04:43:24AM -0600, Rebecca Cran wrote: > On 3/15/23 4:07 AM, Gerd Hoffmann wrote: > > > Rework the BaseTools Makefiles removing the 'BUILD_' prefix (BUILD_CC > > > and BUILD_CXX) and using the standard name 'LDFLAGS' instead of > > > 'LFLAGS'. This allows clang to be used by

Re: [edk2-devel] [PATCH 1/3] BaseTools: Allow users to specify compiler to use with make CC= CXX=

2023-03-17 Thread Rebecca Cran
On 3/15/23 4:07 AM, Gerd Hoffmann wrote: Rework the BaseTools Makefiles removing the 'BUILD_' prefix (BUILD_CC and BUILD_CXX) and using the standard name 'LDFLAGS' instead of 'LFLAGS'. This allows clang to be used by running 'make -C BaseTools CC=clang CXX=clang++'. Hmm, not sure this is a good

Re: [edk2-devel] [PATCH 1/3] BaseTools: Allow users to specify compiler to use with make CC= CXX=

2023-03-15 Thread Gerd Hoffmann
Hi, > Rework the BaseTools Makefiles removing the 'BUILD_' prefix (BUILD_CC > and BUILD_CXX) and using the standard name 'LDFLAGS' instead of > 'LFLAGS'. This allows clang to be used by running > 'make -C BaseTools CC=clang CXX=clang++'. Hmm, not sure this is a good idea. I suspect there was

[edk2-devel] [PATCH 1/3] BaseTools: Allow users to specify compiler to use with make CC= CXX=

2023-02-16 Thread Rebecca Cran
In https://bugzilla.tianocore.org/show_bug.cgi?id=2842 clang support was added by having users specify "make CXX=llvm" when building BaseTools. The Makefile then sees that and sets CC=$(CLANG_BIN)clang and CXX=$(CLANG_BIN)clang++. That requires that the executables 'clang' and 'clang++' exist and