Re: [edk2-devel] [PATCH 1/3] MdeModulePkg/SdMmcPciHcDxe: Refactor command error detection

2020-01-13 Thread Wu, Hao A
> -Original Message- > From: Albecki, Mateusz > Sent: Monday, January 13, 2020 9:49 PM > To: Wu, Hao A; devel@edk2.groups.io > Cc: Marcin Wojtas; Gao, Zhichao; Gao, Liming > Subject: RE: [PATCH 1/3] MdeModulePkg/SdMmcPciHcDxe: Refactor > command error detection > > Hi, > > I will fix the

Re: [edk2-devel] [PATCH 1/3] MdeModulePkg/SdMmcPciHcDxe: Refactor command error detection

2020-01-13 Thread Albecki, Mateusz
Hi, I will fix the 2 issues in separate patch probably before doing the refactor to avoid reverting it if the refactor introduces some unexpected issues. Please also see inline. Thanks, Mateusz > -Original Message- > From: Wu, Hao A > Sent: Friday, January 10, 2020 6:38 AM > To:

Re: [edk2-devel] [PATCH 1/3] MdeModulePkg/SdMmcPciHcDxe: Refactor command error detection

2020-01-09 Thread Wu, Hao A
Hello Mateusz, Some inline comments below: > -Original Message- > From: Albecki, Mateusz > Sent: Tuesday, January 07, 2020 7:06 PM > To: devel@edk2.groups.io > Cc: Albecki, Mateusz; Wu, Hao A; Marcin Wojtas; Gao, Zhichao; Gao, Liming > Subject: [PATCH 1/3] MdeModulePkg/SdMmcPciHcDxe:

[edk2-devel] [PATCH 1/3] MdeModulePkg/SdMmcPciHcDxe: Refactor command error detection

2020-01-07 Thread Albecki, Mateusz
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1140 Error detection function will now check if the command failure has been caused by one of the errors that can appear randomly on link(CRC error + end bit error). If such an error has been a cause of failure function will return EFI_CRC_ERROR