Re: [edk2-devel] [PATCH 1/3] Platform/Intel: Add all pathes of feature domains to package path

2020-03-30 Thread Liming Gao
EDKII DEC spec https://github.com/tianocore-docs/edk2-DecSpecification/tree/release/1.27/2_dec_file_overview DEC File Overview An EDK II Package (directory) is a directory that contains an EDK II package declaration (DEC) file. Only one DEC file is permitted per directory. EDK II Packages

Re: [edk2-devel] [PATCH 1/3] Platform/Intel: Add all pathes of feature domains to package path

2020-03-30 Thread Ni, Ray
Liming, Where can I find the rule? Thanks, Ray > -Original Message- > From: Gao, Liming > Sent: Tuesday, March 31, 2020 10:52 AM > To: Luo, Heng ; Ni, Ray ; > devel@edk2.groups.io > Cc: Bi, Dandan ; Dong, Eric > Subject: RE: [PATCH 1/3] Platform/Intel: Add all pathes of feature

Re: [edk2-devel] [PATCH 1/3] Platform/Intel: Add all pathes of feature domains to package path

2020-03-30 Thread Heng Luo
OK, it means we just need to check dec file Best Regards Heng > -Original Message- > From: Gao, Liming > Sent: Tuesday, March 31, 2020 10:52 AM > To: Luo, Heng ; Ni, Ray ; > devel@edk2.groups.io > Cc: Bi, Dandan ; Dong, Eric > Subject: RE: [PATCH 1/3] Platform/Intel: Add all pathes of

Re: [edk2-devel] [PATCH 1/3] Platform/Intel: Add all pathes of feature domains to package path

2020-03-30 Thread Liming Gao
Ray: Package has dec file in its root directory. Package DSC file is optional. Thanks Liming -Original Message- From: Luo, Heng Sent: 2020年3月31日 9:25 To: Ni, Ray ; devel@edk2.groups.io Cc: Bi, Dandan ; Gao, Liming ; Dong, Eric Subject: RE: [PATCH 1/3] Platform/Intel: Add all pathes

Re: [edk2-devel] [PATCH 1/3] Platform/Intel: Add all pathes of feature domains to package path

2020-03-30 Thread Dong, Eric
Liming, Please help to provide comments for this mail. It break the open board now Thanks, Eric From: Luo, Heng Sent: Tuesday, March 31, 2020 9:25 AM To: Ni, Ray ; devel@edk2.groups.io Cc: Bi, Dandan ; Gao, Liming ; Dong, Eric Subject: RE: [PATCH 1/3] Platform/Intel: Add all pathes of feature

Re: [edk2-devel] [PATCH 1/3] Platform/Intel: Add all pathes of feature domains to package path

2020-03-30 Thread Heng Luo
Hi Liming, I will apply the change below if you agree to we treat a folder that contains ".dec" and "dsc" files as a package directory: diff --git a/Platform/Intel/build_bios.py b/Platform/Intel/build_bios.py index b9ad980510..bb25699ed8 100644 --- a/Platform/Intel/build_bios.py +++

Re: [edk2-devel] [PATCH 1/3] Platform/Intel: Add all pathes of feature domains to package path

2020-03-30 Thread Ni, Ray
> +# add all feature domains in WORKSPACE_FEATURES to package path > +for filename in os.listdir(config["WORKSPACE_FEATURES"]): > +filepath = os.path.join(config["WORKSPACE_FEATURES"], filename) > +if os.path.isdir(filepath): > +config["PACKAGES_PATH"] +=

[edk2-devel] [PATCH 1/3] Platform/Intel: Add all pathes of feature domains to package path

2020-03-30 Thread Heng Luo
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2644 Add all pathes of feature domains to package path in build_bios.py. Cc: Dandan Bi Cc: Liming Gao Cc: Eric Dong Cc: Ray Ni Signed-off-by: Heng Luo --- Platform/Intel/build_bios.py | 7 ++- 1 file changed, 6 insertions(+), 1