Re: [edk2-devel] [PATCH 1/3 v6] Drivers/OpTeeRpmb: Add an OP-TEE backed RPMB driver

2021-03-12 Thread PierreGondois
Hi Ilias and Achin, Thank you for the details. I don't have any more comments on the patches, Regards, Pierre -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#72717): https://edk2.groups.io/g/devel/message/72717 Mute This Topic:

Re: [edk2-devel] [PATCH 1/3 v6] Drivers/OpTeeRpmb: Add an OP-TEE backed RPMB driver

2021-03-11 Thread Achin Gupta
Hi, CIL... On Thu, Mar 11, 2021 at 06:37:30PM +0200, Ilias Apalodimas wrote: > (+cc Achin) > > On Wed, 10 Mar 2021 at 14:45, Ilias Apalodimas via groups.io > linaro@groups.io> wrote: > > Hi Pierre, > > On Wed, Mar 10, 2021 at 09:58:19AM +, Pierre wrote: > > Hi Ilias, >

Re: [edk2-devel] [PATCH 1/3 v6] Drivers/OpTeeRpmb: Add an OP-TEE backed RPMB driver

2021-03-11 Thread Ilias Apalodimas
(+cc Achin) On Wed, 10 Mar 2021 at 14:45, Ilias Apalodimas via groups.io wrote: > Hi Pierre, > > On Wed, Mar 10, 2021 at 09:58:19AM +, Pierre wrote: > > Hi Ilias, > > Just minor coding style nit picking: > > > > * Drivers/OpTee/OpteeRpmbPkg/FixupPcd.c:FixPcdMemory() I think the > >

Re: [edk2-devel] [PATCH 1/3 v6] Drivers/OpTeeRpmb: Add an OP-TEE backed RPMB driver

2021-03-10 Thread Ilias Apalodimas
Hi Pierre, On Wed, Mar 10, 2021 at 09:58:19AM +, Pierre wrote: > Hi Ilias, > Just minor coding style nit picking: > > * Drivers/OpTee/OpteeRpmbPkg/FixupPcd.c:FixPcdMemory() I think the >error codes are missing in the function header Ah you mean the return values of locate protocol? >

Re: [edk2-devel] [PATCH 1/3 v6] Drivers/OpTeeRpmb: Add an OP-TEE backed RPMB driver

2021-03-10 Thread PierreGondois
Hi Ilias, Just minor coding style nit picking: * Drivers/OpTee/OpteeRpmbPkg/FixupPcd.c:FixPcdMemory() I think the error codes are missing in the function header * Thanks for adding the IN/OUT function parameter descriptors. Is it possible to also add them in the function headers [1] ?

[edk2-devel] [PATCH 1/3 v6] Drivers/OpTeeRpmb: Add an OP-TEE backed RPMB driver

2021-03-09 Thread Ilias Apalodimas
A following patch is adding support for building StMM in order to run it from OP-TEE. OP-TEE in combination with a NS-world supplicant can use the RPMB partition of an eMMC to store EFI variables. The supplicant functionality is currently available in U-Boot only but can be ported into EDK2.