Re: [edk2-devel] [PATCH 1/8] AlderlakeSiliconPkg: Add package and library instances

2023-07-22 Thread Chaganty, Rangasai V
Looks good. One feedback though, in PeiDxeSmmReserveMmioSizeLib.inf. The file comments states that the functions in the library are available for PEI, DXE and SMM only. Yet, MODULE_TYPE is set to BASE, which contradicts the above the line. >From the .inf specification, we have the following

[edk2-devel] [PATCH 1/8] AlderlakeSiliconPkg: Add package and library instances

2023-06-15 Thread Saloni Kasbekar
Create the AlderlakeSiliconPkg to provide an initial package for silicon initialization code for Alder Lake (ADL) products. Add the following libraries - - BasePciSegmentMultiSegLibPci - BaseSiConfigBlockLib - PeiDxeSmmReserveMmio64SizeLib - PeiPostMemSiliconPolicyInitLib Cc: Sai Chaganty Cc: